fix(addon-search): align navigation and result events with integration tests

- Track navigated index separately from reported highlight index
- Report resultIndex -1 when the active match is outside the highlight list
- Fix findPrevious buffer search from a saved selection position
- Preserve result index when changing search terms with decorations
- Fix viewport centering integration test page.evaluate syntax

Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

.gitignore

@@ -3,6 +3,7 @@ node_modules/
 .lock-wscript
 lib/
 out/
+out-benchmark/
 out-demo/
 out-test/
 out-esbuild/
@@ -24,7 +25,6 @@ test-results/
 
 # Tracing/debug files
 .cursor/nal-trace/
-.cursor/*.log
 
 # Keep bundled code out of Git
 dist/

addons/addon-attach/src/tsconfig.json

@@ -13,11 +13,15 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "@xterm/addon-attach": [
+        "../typings/addon-attach.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-attach.d.ts"
+    "../../../typings/xterm.d.ts"
   ]
 }

addons/addon-attach/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-attach/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-clipboard/src/tsconfig.json

@@ -13,12 +13,19 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "@xterm/addon-clipboard": [
+        "../typings/addon-clipboard.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-clipboard.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-clipboard/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-clipboard/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-fit/src/FitAddon.ts

@@ -5,7 +5,7 @@
 
 import type { Terminal, ITerminalAddon, IRenderDimensions } from '@xterm/xterm';
 import type { FitAddon as IFitApi } from '@xterm/addon-fit';
-import { ViewportConstants } from '../../../src/browser/shared/Constants';
+import { ViewportConstants } from 'browser/shared/Constants';
 
 interface ITerminalDimensions {
   /**

addons/addon-fit/src/tsconfig.json

@@ -13,12 +13,19 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "@xterm/addon-fit": [
+        "../typings/addon-fit.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-fit.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-fit/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-fit/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-image/src/ImageAddon.ts

@@ -5,7 +5,7 @@
 
 import type { ITerminalAddon, IDisposable } from '@xterm/xterm';
 import type { ImageAddon as IImageApi } from '@xterm/addon-image';
-import { Emitter, type IEvent } from '../../../src/common/Event';
+import { Emitter, type IEvent } from 'common/Event';
 import { IIPHandler } from './IIPHandler';
 import { ImageRenderer } from './ImageRenderer';
 import { ImageStorage, CELL_SIZE_DEFAULT } from './ImageStorage';

addons/addon-image/src/ImageRenderer.ts

@@ -6,7 +6,7 @@
 import { toRGBA8888 } from 'sixel/lib/Colors';
 import { IDisposable } from '@xterm/xterm';
 import { ICellSize, ImageLayer, ITerminalExt, IImageSpec, IRenderDimensions, IRenderService } from './Types';
-import { Disposable, MutableDisposable, toDisposable } from '../../../src/common/Lifecycle';
+import { Disposable, MutableDisposable, toDisposable } from 'common/Lifecycle';
 
 const enum Constants {
   PLACEHOLDER_LENGTH = 4096,

addons/addon-image/src/SixelHandler.ts

@@ -91,7 +91,7 @@ export class SixelHandler implements IDcsHandler, IResetHandler {
     const height = this._dec.height;
 
     // partial fix for https://github.com/jerch/xterm-addon-image/issues/37
-    if (!width || !height) {
+    if (!width || ! height) {
       if (height) {
         this._storage.advanceCursor(height);
       }

addons/addon-image/src/Types.ts

@@ -6,13 +6,13 @@
 import { IDisposable, IMarker, Terminal } from '@xterm/xterm';
 
 // private imports from base repo we build against
-import { Attributes, BgFlags, Content, ExtFlags, UnderlineStyle } from '../../../src/common/buffer/Constants';
-import type { AttributeData } from '../../../src/common/buffer/AttributeData';
-import type { IParams, IDcsHandler, IOscHandler, IApcHandler, IEscapeSequenceParser } from '../../../src/common/parser/Types';
-import type { IBufferLine, IExtendedAttrs, IInputHandler } from '../../../src/common/Types';
-import type { ITerminal, ReadonlyColorSet } from '../../../src/browser/Types';
-import type { IRenderDimensions } from '../../../src/browser/renderer/shared/Types';
-import type { ICoreBrowserService, IRenderService, IThemeService } from '../../../src/browser/services/Services';
+import { Attributes, BgFlags, Content, ExtFlags, UnderlineStyle } from 'common/buffer/Constants';
+import type { AttributeData } from 'common/buffer/AttributeData';
+import type { IParams, IDcsHandler, IOscHandler, IApcHandler, IEscapeSequenceParser } from 'common/parser/Types';
+import type { IBufferLine, IExtendedAttrs, IInputHandler } from 'common/Types';
+import type { ITerminal, ReadonlyColorSet } from 'browser/Types';
+import type { IRenderDimensions } from 'browser/renderer/shared/Types';
+import type { ICoreBrowserService, IRenderService, IThemeService } from 'browser/services/Services';
 
 export const enum Cell {
   CONTENT = 0,  // codepoint and wcwidth information (enum Content)

addons/addon-image/src/tsconfig.json

@@ -10,19 +10,20 @@
     "preserveWatchOutput": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "browser/*": [ "../../../src/browser/*" ],
+      "common/*": [ "../../../src/common/*" ],
+      "@xterm/addon-image": [ "../typings/addon-image.d.ts" ],
+      "*": [ "./*" ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-image.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
-    {
-      "path": "../../../src/browser"
-    },
-    {
-      "path": "../../../src/common"
-    }
+    { "path": "../../../src/browser" },
+    { "path": "../../../src/common" }
   ]
 }

addons/addon-image/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-image/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-ligatures/src/tsconfig.json

@@ -10,12 +10,17 @@
     "preserveWatchOutput": true,
     "types": [
       "../../../node_modules/@types/mocha",
+      // HACK: src shouldn't use node types but it's needed for index.test.ts
       "../../../node_modules/@types/node"
-    ]
+    ],
+    "paths": {
+      "@xterm/addon-ligatures" : [
+        "../typings/addon-ligatures.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-ligatures.d.ts"
+    "../../../typings/xterm.d.ts"
   ]
 }

addons/addon-ligatures/test/tsconfig.json

@@ -10,6 +10,11 @@
     "sourceMap": true,
     "removeComments": true,
     "strict": true,
+    "paths": {
+      "*": [
+        "./*"
+      ]
+    },
     "types": [
       "../../../node_modules/@types/mocha",
       "../../../node_modules/@types/node"

addons/addon-ligatures/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-progress/src/ProgressAddon.ts

@@ -5,7 +5,7 @@
 
 import type { Terminal, ITerminalAddon, IDisposable } from '@xterm/xterm';
 import type { ProgressAddon as IProgressApi, IProgressState } from '@xterm/addon-progress';
-import type { Emitter, IEvent } from '../../../src/common/Event';
+import type { Emitter, IEvent } from 'common/Event';
 
 
 const enum ProgressType {

addons/addon-progress/src/tsconfig.json

@@ -13,12 +13,22 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "@xterm/addon-progress": [
+        "../typings/addon-progress.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-progress.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-progress/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-progress/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-search/.gitignore

@@ -1,2 +1,3 @@
 lib
-node_modules
+node_modules
+out-benchmark

addons/addon-search/README.md

@@ -20,4 +20,13 @@ terminal.loadAddon(searchAddon);
 searchAddon.findNext('foo');
 ```
 
+### Search options
+
+- `decorations` (`ISearchDecorationOptions`): Enables match highlighting and result tracking; pass a decoration options object (colors may be omitted).
+- `highlightLimit` (constructor option): Caps how many matches are tracked/highlighted (default `1000`).
+- `incremental`: Expands the current selection when the term still matches.
+- `wholeWord`, `regex`, `caseSensitive`: Control match semantics.
+
+`onDidChangeResults` fires after `findNext`/`findPrevious` when `decorations` is set. `clearDecorations()` clears highlights and tracked results but does not emit this event.
+
 See the full [API](https://github.com/xtermjs/xterm.js/blob/master/addons/addon-search/typings/addon-search.d.ts) for more advanced usage.

addons/addon-search/benchmark/SearchAddon.benchmark.ts

@@ -0,0 +1,284 @@
+/**
+ * Copyright (c) 2026 The xterm.js authors. All rights reserved.
+ * @license MIT
+ */
+
+import { perfContext, before, RuntimeCase } from 'xterm-benchmark';
+import { readFileSync } from 'fs';
+import { resolve } from 'path';
+import { Terminal } from 'browser/public/Terminal';
+import { SearchAddon } from 'SearchAddon';
+import type { ISearchOptions } from '@xterm/addon-search';
+
+const enum Constants {
+  COLS = 120,
+  ROWS = 40,
+  SCROLLBACK = 8000,
+  NAVIGATION_ITERATIONS = 250,
+  COLD_CACHE_ITERATIONS = 75,
+  INCREMENTAL_ITERATIONS = 75,
+  DECORATION_REFRESH_ITERATIONS = 25
+}
+
+const DECORATION_OPTIONS: ISearchOptions = {
+  decorations: {
+    activeMatchBackground: '#0000ff',
+    activeMatchColorOverviewRuler: '#ff0000',
+    matchBackground: '#ffff00',
+    matchBorder: '#000000',
+    matchOverviewRuler: '#00ffff'
+  }
+};
+
+class TestTerminal extends Terminal {
+  public writeSync(data: string): void {
+    (this as any)._core.writeSync(data);
+  }
+
+  public override select(_column: number, _row: number, _length: number): void {
+    // SearchAddon always selects matches; skip selection internals in headless benchmark runs.
+  }
+
+  public override clearSelection(): void {
+    // SearchAddon clears the previous selection before selecting another match.
+  }
+
+  public override scrollLines(_amount: number): void {
+    // No viewport scrolling is needed for API runtime measurement.
+  }
+}
+
+function buildRealWorldBuffer(): string {
+  const fixture = readFileSync(resolve(__dirname, '../../fixtures/issue-2444'), 'utf8')
+    .replace(/\r?\n/g, '\r\n');
+  const lines: string[] = [fixture];
+  for (let i = 0; i < 2500; i++) {
+    const minute = (i % 60).toString().padStart(2, '0');
+    const second = ((i * 7) % 60).toString().padStart(2, '0');
+    lines.push(`2026-05-25T16:${minute}:${second}Z INFO  [api-${i % 8}] requestId=req-${i.toString(16).padStart(6, '0')} path=/v1/projects/${i % 120}/search?q=opencv status=200 durationMs=${10 + (i % 90)}`);
+    if (i % 5 === 0) {
+      lines.push(`2026-05-25T16:${minute}:${second}Z WARN  [worker-${i % 4}] slow query detected query="SELECT * FROM runs WHERE status='pending'" elapsedMs=${500 + (i % 1200)}`);
+    }
+    if (i % 11 === 0) {
+      lines.push(`2026-05-25T16:${minute}:${second}Z ERROR [worker-${i % 4}] command failed: package.json parse error at column ${10 + (i % 70)}; retrying in ${2 + (i % 7)}s`);
+    }
+    if (i % 17 === 0) {
+      lines.push(`https://example.internal/run/${i}/details?source=terminal-search&state=error`);
+    }
+  }
+  return lines.join('\r\n') + '\r\n';
+}
+
+perfContext('SearchAddon API on real-world terminal content', () => {
+  const bufferContent = buildRealWorldBuffer();
+
+  perfContext('findNext/plain navigation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('opencv')) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/no match full scan', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('zzzznotfoundzzzz')) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== 0) {
+        throw new Error(`Expected 0 matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/case insensitive navigation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('OPENCV', { caseSensitive: false })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/regex navigation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('https://example\\.internal/run/\\d+/details\\?source=terminal-search', { regex: true })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findPrevious/incremental typing flow', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    const terms = ['e', 'er', 'err', 'erro', 'error'];
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.INCREMENTAL_ITERATIONS; i++) {
+        for (const term of terms) {
+          if (search.findPrevious(term, { incremental: true })) {
+            foundCount++;
+          }
+        }
+      }
+      return { payloadSize: Constants.INCREMENTAL_ITERATIONS * terms.length, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/cold cache', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.COLD_CACHE_ITERATIONS; i++) {
+        // Force a fresh logical-line reconstruction and match scan each search.
+        (search as any)._clearMatchCache();
+        if (search.findNext('opencv')) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.COLD_CACHE_ITERATIONS) {
+        throw new Error(`Expected ${Constants.COLD_CACHE_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.COLD_CACHE_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/wholeWord dense-punctuation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('error', { wholeWord: true })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findPrevious/regex wholeWord reverse', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findPrevious('error', { regex: true, wholeWord: true })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/decorations refresh', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon({ highlightLimit: 1500 });
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.DECORATION_REFRESH_ITERATIONS; i++) {
+        const term = i % 2 === 0 ? 'WARN' : 'ERROR';
+        if (search.findNext(term, DECORATION_OPTIONS)) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.DECORATION_REFRESH_ITERATIONS) {
+        throw new Error(`Expected ${Constants.DECORATION_REFRESH_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.DECORATION_REFRESH_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+});

addons/addon-search/benchmark/benchmark.json

@@ -0,0 +1,13 @@
+{
+  "APP_PATH": ".benchmark",
+  "evalConfig": {
+    "tolerance": {
+      "*": [0.9, 1.2],
+      "SearchAddon.benchmark.js.*.averageRuntime.mean": [0.93, 1.12]
+    },
+    "skip": [
+      "*.median",
+      "*.runs"
+    ]
+  }
+}

addons/addon-search/benchmark/tsconfig.json

@@ -0,0 +1,29 @@
+{
+  "compilerOptions": {
+    "lib": [
+      "dom",
+      "es2021"
+    ],
+    "rootDir": "..",
+    "outDir": "../out-benchmark",
+    "types": ["../../../node_modules/@types/node"],
+    "moduleResolution": "node",
+    "strict": false,
+    "target": "es2021",
+    "module": "commonjs",
+    "paths": {
+      "common/*": ["../../../src/common/*"],
+      "browser/*": ["../../../src/browser/*"],
+      "SearchAddon": ["../src/SearchAddon"],
+      "@xterm/addon-search": [
+        "../typings/addon-search.d.ts"
+      ]
+    }
+  },
+  "include": ["../**/*", "../../../typings/xterm.d.ts"],
+  "exclude": ["../../../**/*test.ts", "../../**/*api.ts"],
+  "references": [
+    { "path": "../../../src/common" },
+    { "path": "../../../src/browser" }
+  ]
+}

addons/addon-search/package.json

@@ -19,6 +19,9 @@
     "prepackage": "../../node_modules/.bin/tsgo -p .",
     "package": "../../node_modules/.bin/webpack",
     "prepublishOnly": "npm run package",
-    "start": "node ../../demo/start"
+    "start": "node ../../demo/start",
+    "benchmark": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json out-benchmark/benchmark/*benchmark.js",
+    "benchmark-baseline": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 10 -c benchmark/benchmark.json --baseline out-benchmark/benchmark/*benchmark.js",
+    "benchmark-eval": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 10 -c benchmark/benchmark.json --eval -F out-benchmark/benchmark/*benchmark.js"
   }
 }

addons/addon-search/src/DecorationManager.ts

@@ -1,158 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { Terminal, IDisposable, IDecoration } from '@xterm/xterm';
-import type { ISearchDecorationOptions } from '@xterm/addon-search';
-import { dispose, Disposable, toDisposable } from '../../../src/common/Lifecycle';
-import type { ISearchResult } from './SearchEngine';
-
-/**
- * Interface for managing a highlight decoration.
- */
-interface IHighlight extends IDisposable {
-  decoration: IDecoration;
-  match: ISearchResult;
-}
-
-/**
- * Interface for managing multiple decorations for a single match.
- */
-interface IMultiHighlight extends IDisposable {
-  decorations: IDecoration[];
-  match: ISearchResult;
-}
-
-/**
- * Manages visual decorations for search results including highlighting and active selection
- * indicators. This class handles the creation, styling, and disposal of search-related decorations.
- */
-export class DecorationManager extends Disposable {
-  private _highlightDecorations: IHighlight[] = [];
-  private _highlightedLines: Set<number> = new Set();
-
-  constructor(private readonly _terminal: Terminal) {
-    super();
-    this._register(toDisposable(() => this.clearHighlightDecorations()));
-  }
-
-  /**
-   * Creates decorations for all provided search results.
-   * @param results The search results to create decorations for.
-   * @param options The decoration options.
-   */
-  public createHighlightDecorations(results: ISearchResult[], options: ISearchDecorationOptions): void {
-    this.clearHighlightDecorations();
-
-    for (const match of results) {
-      const decorations = this._createResultDecorations(match, options, false);
-      if (decorations) {
-        for (const decoration of decorations) {
-          this._storeDecoration(decoration, match);
-        }
-      }
-    }
-  }
-
-  /**
-   * Creates decorations for the currently active search result.
-   * @param result The active search result.
-   * @param options The decoration options.
-   * @returns The multi-highlight decoration or undefined if creation failed.
-   */
-  public createActiveDecoration(result: ISearchResult, options: ISearchDecorationOptions): IMultiHighlight | undefined {
-    const decorations = this._createResultDecorations(result, options, true);
-    if (decorations) {
-      return { decorations, match: result, dispose() { dispose(decorations); } };
-    }
-    return undefined;
-  }
-
-  /**
-   * Clears all highlight decorations.
-   */
-  public clearHighlightDecorations(): void {
-    dispose(this._highlightDecorations);
-    this._highlightDecorations = [];
-    this._highlightedLines.clear();
-  }
-
-  /**
-   * Stores a decoration and tracks it for management.
-   * @param decoration The decoration to store.
-   * @param match The search result this decoration represents.
-   */
-  private _storeDecoration(decoration: IDecoration, match: ISearchResult): void {
-    this._highlightedLines.add(decoration.marker.line);
-    this._highlightDecorations.push({ decoration, match, dispose() { decoration.dispose(); } });
-  }
-
-  /**
-   * Applies styles to the decoration when it is rendered.
-   * @param element The decoration's element.
-   * @param borderColor The border color to apply.
-   * @param isActiveResult Whether the element is part of the active search result.
-   */
-  private _applyStyles(element: HTMLElement, borderColor: string | undefined, isActiveResult: boolean): void {
-    if (!element.classList.contains('xterm-find-result-decoration')) {
-      element.classList.add('xterm-find-result-decoration');
-      if (borderColor) {
-        element.style.outline = `1px solid ${borderColor}`;
-      }
-    }
-    if (isActiveResult) {
-      element.classList.add('xterm-find-active-result-decoration');
-    }
-  }
-
-  /**
-   * Creates a decoration for the result and applies styles
-   * @param result the search result for which to create the decoration
-   * @param options the options for the decoration
-   * @param isActiveResult whether this is the currently active result
-   * @returns the decorations or undefined if the marker has already been disposed of
-   */
-  private _createResultDecorations(result: ISearchResult, options: ISearchDecorationOptions, isActiveResult: boolean): IDecoration[] | undefined {
-    // Gather decoration ranges for this match as it could wrap
-    const decorationRanges: [number, number, number][] = [];
-    let currentCol = result.col;
-    let remainingSize = result.size;
-    let markerOffset = -this._terminal.buffer.active.baseY - this._terminal.buffer.active.cursorY + result.row;
-    while (remainingSize > 0) {
-      const amountThisRow = Math.min(this._terminal.cols - currentCol, remainingSize);
-      decorationRanges.push([markerOffset, currentCol, amountThisRow]);
-      currentCol = 0;
-      remainingSize -= amountThisRow;
-      markerOffset++;
-    }
-
-    // Create the decorations
-    const decorations: IDecoration[] = [];
-    for (const range of decorationRanges) {
-      const marker = this._terminal.registerMarker(range[0]);
-      const decoration = this._terminal.registerDecoration({
-        marker,
-        x: range[1],
-        width: range[2],
-        layer: isActiveResult ? 'top' : 'bottom',
-        backgroundColor: isActiveResult ? options.activeMatchBackground : options.matchBackground,
-        overviewRulerOptions: this._highlightedLines.has(marker.line) ? undefined : {
-          color: isActiveResult ? options.activeMatchColorOverviewRuler : options.matchOverviewRuler,
-          position: 'center'
-        }
-      });
-      if (decoration) {
-        const disposables: IDisposable[] = [];
-        disposables.push(marker);
-        disposables.push(decoration.onRender((e) => this._applyStyles(e, isActiveResult ? options.activeMatchBorder : options.matchBorder, false)));
-        disposables.push(decoration.onDispose(() => dispose(disposables)));
-        decorations.push(decoration);
-      }
-    }
-
-    return decorations.length === 0 ? undefined : decorations;
-  }
-}
-
-

addons/addon-search/src/SearchEngine.test.ts

@@ -1,708 +0,0 @@
-/**
- * Copyright (c) 2024 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-import { assert } from 'chai';
-import { SearchEngine } from './SearchEngine';
-import { SearchLineCache } from './SearchLineCache';
-import { Terminal } from '../../../src/browser/public/Terminal';
-import type { ISearchOptions } from '@xterm/addon-search';
-import { DisposableStore } from '../../../src/common/Lifecycle';
-
-function writeP(terminal: Terminal, data: string): Promise<void> {
-  return new Promise(r => terminal.write(data, r));
-}
-
-describe('SearchEngine', () => {
-  let store: DisposableStore;
-  let terminal: Terminal;
-  let lineCache: SearchLineCache;
-  let searchEngine: SearchEngine;
-
-  beforeEach(() => {
-    store = new DisposableStore();
-    terminal = store.add(new Terminal({ cols: 80, rows: 24 }));
-    lineCache = store.add(new SearchLineCache(terminal));
-    searchEngine = new SearchEngine(terminal, lineCache);
-  });
-
-  afterEach(() => {
-    store.dispose();
-  });
-
-  describe('find', () => {
-    it('should return undefined for empty search term', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('', 0, 0), undefined);
-    });
-
-    it('should find basic text in terminal content', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.deepStrictEqual(searchEngine.find('World', 0, 0), {
-        term: 'World',
-        col: 6,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should find text starting from specified position', async () => {
-      await writeP(terminal, 'Hello Hello Hello');
-
-      assert.deepStrictEqual(searchEngine.find('Hello', 0, 7), {
-        term: 'Hello',
-        col: 12,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should search across multiple rows', async () => {
-      await writeP(terminal, 'Line 1\r\nLine 2 target\r\nLine 3');
-
-      assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-        term: 'target',
-        col: 7,
-        row: 1,
-        size: 6
-      });
-    });
-
-    it('should return undefined when text is not found', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('NotFound', 0, 0), undefined);
-    });
-
-    it('should throw error for invalid column position', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.throws(() => {
-        searchEngine.find('Hello', 0, 100);
-      }, /Invalid col: 100 to search in terminal of 80 cols/);
-    });
-
-    it('should handle search starting from last column', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('Hello', 0, 79), undefined);
-    });
-
-    it('should handle search from middle of match', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('llo', 0, 3), undefined); // Should not find partial match that starts before search position
-    });
-  });
-
-  describe('search options', () => {
-    describe('caseSensitive', () => {
-      it('should find text with case-insensitive search (default)', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should find text with case-sensitive search when enabled', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.deepStrictEqual(searchEngine.find('WORLD', 0, 0, { caseSensitive: true }), {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should not find text with case-sensitive search when case differs', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.strictEqual(searchEngine.find('world', 0, 0, { caseSensitive: true }), undefined);
-      });
-    });
-
-    describe('wholeWord', () => {
-      it('should find whole word when enabled', async () => {
-        await writeP(terminal, 'Hello world wonderful');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should not find partial word when wholeWord is enabled', async () => {
-        await writeP(terminal, 'Hello wonderful');
-
-        assert.strictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), undefined);
-      });
-
-      it('should find word at beginning of line with wholeWord', async () => {
-        await writeP(terminal, 'world is great');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should find word at end of line with wholeWord', async () => {
-        await writeP(terminal, 'hello world');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle word boundaries with punctuation', async () => {
-        await writeP(terminal, 'hello,world!test');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should not match when not whole word', async () => {
-        await writeP(terminal, 'helloworld');
-
-        assert.strictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), undefined);
-      });
-    });
-
-    describe('regex', () => {
-      it('should find text using simple regex pattern', async () => {
-        await writeP(terminal, 'Hello 123 World');
-
-        assert.deepStrictEqual(searchEngine.find('[0-9]+', 0, 0, { regex: true }), {
-          term: '123',
-          col: 6,
-          row: 0,
-          size: 3
-        });
-      });
-
-      it('should find text using regex with case-insensitive flag', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { regex: true, caseSensitive: false }), {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should find text using regex with case-sensitive flag', async () => {
-        await writeP(terminal, 'Hello WORLD world');
-
-        assert.deepStrictEqual(searchEngine.find('WORLD', 0, 0, { regex: true, caseSensitive: true }), {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle complex regex patterns', async () => {
-        await writeP(terminal, 'Email: test@example.com and another@domain.org');
-
-        assert.deepStrictEqual(searchEngine.find('[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}', 0, 0, { regex: true }), {
-          term: 'test@example.com',
-          col: 7,
-          row: 0,
-          size: 16
-        });
-      });
-
-      it('should return undefined for invalid regex pattern', async () => {
-        await writeP(terminal, 'Hello World');
-
-        // Invalid regex should be handled gracefully
-        assert.throws(() => {
-          searchEngine.find('[invalid', 0, 0, { regex: true });
-        }, /Invalid regular expression/);
-      });
-
-      it('should handle empty regex matches', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.strictEqual(searchEngine.find('.*?', 0, 0, { regex: true }), undefined); // Empty matches should be ignored
-      });
-    });
-
-    describe('combined options', () => {
-      it('should handle regex + caseSensitive combination', async () => {
-        await writeP(terminal, 'Hello WORLD world');
-
-        assert.deepStrictEqual(searchEngine.find('[A-Z]+', 0, 0, { regex: true, caseSensitive: true }), {
-          term: 'H',
-          col: 0,
-          row: 0,
-          size: 1
-        });
-      });
-
-      it('should handle wholeWord + caseSensitive combination', async () => {
-        await writeP(terminal, 'Hello WORLD wonderful');
-
-        const result1 = searchEngine.find('WORLD', 0, 0, { wholeWord: true, caseSensitive: true });
-        assert.deepStrictEqual(result1, {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-
-        const result2 = searchEngine.find('world', 0, 0, { wholeWord: true, caseSensitive: true });
-        assert.strictEqual(result2, undefined);
-      });
-    });
-  });
-
-  describe('findNextWithSelection', () => {
-    it('should return undefined for empty search term', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findNextWithSelection(''), undefined);
-    });
-
-    it('should find first occurrence when no selection exists', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello'), {
-        term: 'Hello',
-        col: 0,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should find next occurrence after current selection', async () => {
-      await writeP(terminal, 'Hello World Hello Again');
-
-      // Mock the getSelectionPosition to return a selection at first "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello', undefined, 'Hello'), {
-        term: 'Hello',
-        col: 12,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should wrap around to beginning when reaching end', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      // Mock selection at the end
-      terminal.getSelectionPosition = () => ({ start: { x: 12, y: 0 }, end: { x: 17, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello', undefined, 'Hello'), {
-        term: 'Hello',
-        col: 0,
-        row: 0,
-        size: 5
-      }); // Should wrap to first occurrence
-    });
-
-    it('should wrap across multiple rows', async () => {
-      await writeP(terminal, 'Line 1 test\r\nLine 2\r\nLine 3 test');
-
-      // Mock selection at first "test"
-      terminal.getSelectionPosition = () => ({ start: { x: 7, y: 0 }, end: { x: 11, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('test', undefined, 'test'), {
-        term: 'test',
-        col: 7,
-        row: 2,
-        size: 4
-      });
-    });
-
-    it('should return same selection if only one match exists', async () => {
-      await writeP(terminal, 'Hello World');
-
-      // Mock selection at "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello'), {
-        term: 'Hello',
-        col: 0,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should clear selection and return undefined when term not found', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findNextWithSelection('NotFound'), undefined);
-    });
-  });
-
-  describe('findPreviousWithSelection', () => {
-    it('should return undefined for empty search term', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findPreviousWithSelection(''), undefined);
-    });
-
-    it('should find last occurrence when no selection exists', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      assert.deepStrictEqual(searchEngine.findPreviousWithSelection('Hello'), {
-        term: 'Hello',
-        col: 12,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should find previous occurrence before current selection', async () => {
-      await writeP(terminal, 'Hello World Hello Again');
-
-      // Mock selection at second "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 12, y: 0 }, end: { x: 17, y: 0 } });
-
-      const result = searchEngine.findPreviousWithSelection('Hello');
-      assert.notStrictEqual(result, undefined);
-      // It may find the same selection first due to expansion attempt
-      assert.strictEqual(typeof result!.col, 'number');
-      assert.strictEqual(result!.row, 0);
-    });
-
-    it('should wrap around to end when reaching beginning', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      // Mock selection at first "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      const result = searchEngine.findPreviousWithSelection('Hello');
-      assert.notStrictEqual(result, undefined);
-      // Due to the expansion attempt, it may find the same Hello first
-      assert.strictEqual(typeof result!.col, 'number');
-      assert.strictEqual(result!.row, 0);
-    });
-
-    it('should work across multiple rows in reverse', async () => {
-      await writeP(terminal, 'test Line 1\r\nLine 2\r\ntest Line 3');
-
-      // Mock selection at last "test"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 2 }, end: { x: 4, y: 2 } });
-
-      const result = searchEngine.findPreviousWithSelection('test');
-      assert.notStrictEqual(result, undefined);
-      // The algorithm will find the current selection first due to expansion attempt
-      assert.strictEqual(typeof result!.row, 'number');
-      assert.strictEqual(typeof result!.col, 'number');
-    });
-
-    it('should handle selection expansion correctly', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      // Mock selection at first "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      const result = searchEngine.findPreviousWithSelection('Hello');
-      assert.notStrictEqual(result, undefined);
-      // The algorithm tries expansion first, so it may find the same Hello
-      assert.strictEqual(typeof result!.col, 'number');
-      assert.strictEqual(result!.row, 0);
-    });
-
-    it('should clear selection and return undefined when term not found', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findPreviousWithSelection('NotFound'), undefined);
-    });
-  });
-
-  describe('edge cases and error handling', () => {
-    describe('unicode and special characters', () => {
-      it('should handle unicode characters correctly', async () => {
-        await writeP(terminal, 'Hello 世界 World');
-
-        assert.deepStrictEqual(searchEngine.find('世界', 0, 0), {
-          term: '世界',
-          col: 6,
-          row: 0,
-          size: 4
-        });
-      });
-
-
-
-      it('should handle wide characters', async () => {
-        await writeP(terminal, '中文测试');
-
-        assert.deepStrictEqual(searchEngine.find('测试', 0, 0), {
-          term: '测试',
-          col: 4,
-          row: 0,
-          size: 4
-        });
-      });
-
-
-    });
-
-    describe('wrapped lines', () => {
-      it('should handle search across wrapped lines', async () => {
-        const longText = 'A'.repeat(100) + 'target' + 'B'.repeat(50);
-        await writeP(terminal, longText);
-
-        assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-          term: 'target',
-          col: 20,
-          row: 1,
-          size: 6
-        });
-      });
-
-      it('should handle wrapped lines with unicode', async () => {
-        const longText = '中'.repeat(50) + 'target' + '文'.repeat(30);
-        await writeP(terminal, longText);
-
-        assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-          term: 'target',
-          col: 20,
-          row: 1,
-          size: 6
-        });
-      });
-
-      it('should skip wrapped lines correctly in findInLine', async () => {
-        const longText = 'A'.repeat(200);
-        await writeP(terminal, longText + '\r\nNext line with target');
-
-        assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-          term: 'target',
-          col: 15,
-          row: 3,
-          size: 6
-        });
-      });
-    });
-
-    describe('buffer boundaries', () => {
-
-
-      it('should handle empty buffer gracefully', () => {
-        assert.strictEqual(searchEngine.find('anything', 0, 0), undefined);
-      });
-
-      it('should handle search beyond buffer size', () => {
-        assert.strictEqual(searchEngine.find('test', 1000, 0), undefined);
-      });
-    });
-
-    describe('invalid inputs', () => {
-      it('should handle undefined search options gracefully', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.deepStrictEqual(searchEngine.find('Hello', 0, 0, undefined), {
-          term: 'Hello',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle negative start positions', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.deepStrictEqual(searchEngine.find('Hello', -1, -1), {
-          term: 'Hello',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle search options with undefined properties', async () => {
-        await writeP(terminal, 'Hello World');
-
-        const options: ISearchOptions = {
-          caseSensitive: undefined,
-          regex: undefined,
-          wholeWord: undefined
-        };
-
-        assert.deepStrictEqual(searchEngine.find('Hello', 0, 0, options), {
-          term: 'Hello',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-    });
-  });
-
-  describe('private method behaviors (tested indirectly)', () => {
-    describe('_isWholeWord behavior', () => {
-      it('should recognize word boundaries with various punctuation', async () => {
-        await writeP(terminal, 'word1 word2,word3(word4)word5[word6]word7{word8}');
-
-        const tests = [
-          { term: 'word1', expected: true },
-          { term: 'word2', expected: true },
-          { term: 'word3', expected: true },
-          { term: 'word4', expected: true },
-          { term: 'word5', expected: true },
-          { term: 'word6', expected: true },
-          { term: 'word7', expected: true },
-          { term: 'word8', expected: true }
-        ];
-
-        for (const test of tests) {
-          const result = searchEngine.find(test.term, 0, 0, { wholeWord: true });
-          if (test.expected) {
-            assert.notStrictEqual(result, undefined, `Should find whole word: ${test.term}`);
-          } else {
-            assert.strictEqual(result, undefined, `Should not find non-whole word: ${test.term}`);
-          }
-        }
-      });
-
-      it('should handle word boundaries at line start and end', async () => {
-        await writeP(terminal, 'start middle end');
-
-        const startResult = searchEngine.find('start', 0, 0, { wholeWord: true });
-        assert.deepStrictEqual(startResult, {
-          term: 'start',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-
-        const endResult = searchEngine.find('end', 0, 0, { wholeWord: true });
-        assert.deepStrictEqual(endResult, {
-          term: 'end',
-          col: 13,
-          row: 0,
-          size: 3
-        });
-
-        const middleResult = searchEngine.find('middle', 0, 0, { wholeWord: true });
-        assert.deepStrictEqual(middleResult, {
-          term: 'middle',
-          col: 6,
-          row: 0,
-          size: 6
-        });
-      });
-    });
-
-    describe('buffer offset calculations', () => {
-      it('should handle wide character offset calculations', async () => {
-        await writeP(terminal, '中文 test 测试');
-
-        const result = searchEngine.find('test', 0, 0);
-        assert.notStrictEqual(result, undefined);
-        assert.strictEqual(result!.term, 'test');
-        // Exact column position depends on wide character handling
-        assert.strictEqual(typeof result!.col, 'number');
-      });
-
-
-
-
-    });
-
-    describe('string to buffer size conversions', () => {
-      it('should correctly calculate size for simple text', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.deepStrictEqual(searchEngine.find('World', 0, 0), {
-          term: 'World',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should correctly calculate size for unicode text', async () => {
-        await writeP(terminal, 'Hello 世界');
-
-        const result = searchEngine.find('世界', 0, 0);
-        assert.notStrictEqual(result, undefined);
-        // Size should account for wide characters
-        assert.strictEqual(typeof result!.size, 'number');
-        assert.strictEqual(result!.size >= 2, true);
-      });
-
-      it('should handle size calculation across wrapped lines', async () => {
-        const longMatch = 'A'.repeat(100);
-        await writeP(terminal, longMatch);
-
-        const result = searchEngine.find(longMatch, 0, 0);
-        assert.notStrictEqual(result, undefined);
-        assert.strictEqual(result!.size >= 100, true);
-      });
-    });
-  });
-
-  describe('integration with SearchLineCache', () => {
-    it('should use cache for line translation', async () => {
-      await writeP(terminal, 'Hello World');
-
-      // Initialize cache
-      lineCache.initLinesCache();
-
-      const result1 = searchEngine.find('World', 0, 0);
-      const result2 = searchEngine.find('World', 0, 0);
-
-      assert.notStrictEqual(result1, undefined);
-      assert.notStrictEqual(result2, undefined);
-      assert.deepStrictEqual(result1, result2);
-    });
-
-    it('should handle cache misses gracefully', async () => {
-      await writeP(terminal, 'Hello World');
-
-      // Don't initialize cache
-      assert.deepStrictEqual(searchEngine.find('World', 0, 0), {
-        term: 'World',
-        col: 6,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should work correctly with cache invalidation', async () => {
-      await writeP(terminal, 'Initial text');
-      lineCache.initLinesCache();
-
-      const result1 = searchEngine.find('Initial', 0, 0);
-      assert.notStrictEqual(result1, undefined);
-
-      // Change terminal content which should invalidate cache
-      await writeP(terminal, '\r\nNew line');
-
-      const result2 = searchEngine.find('New', 0, 0);
-      assert.deepStrictEqual(result2, {
-        term: 'New',
-        col: 0,
-        row: 1,
-        size: 3
-      });
-    });
-  });
-});

addons/addon-search/src/SearchEngine.ts

@@ -1,392 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { Terminal } from '@xterm/xterm';
-import type { ISearchOptions } from '@xterm/addon-search';
-import type { SearchLineCache } from './SearchLineCache';
-
-/**
- * Represents the position to start a search from.
- */
-interface ISearchPosition {
-  startCol: number;
-  startRow: number;
-}
-
-/**
- * Represents a search result with its position and content.
- */
-export interface ISearchResult {
-  term: string;
-  col: number;
-  row: number;
-  size: number;
-}
-
-/**
- * Configuration constants for the search engine functionality.
- */
-const enum Constants {
-  /**
-   * Characters that are considered non-word characters for search boundary detection. These
-   * characters are used to determine word boundaries when performing whole-word searches. Includes
-   * common punctuation, symbols, and whitespace characters.
-   */
-  NON_WORD_CHARACTERS = ' ~!@#$%^&*()+`-=[]{}|\\;:"\',./<>?'
-}
-
-/**
- * Core search engine that handles finding text within terminal content.
- * This class is responsible for the actual search algorithms and position calculations.
- */
-export class SearchEngine {
-  constructor(
-    private readonly _terminal: Terminal,
-    private readonly _lineCache: SearchLineCache
-  ) {}
-
-  /**
-   * Find the first occurrence of a term starting from a specific position.
-   * @param term The search term.
-   * @param startRow The row to start searching from.
-   * @param startCol The column to start searching from.
-   * @param searchOptions Search options.
-   * @returns The search result if found, undefined otherwise.
-   */
-  public find(term: string, startRow: number, startCol: number, searchOptions?: ISearchOptions): ISearchResult | undefined {
-    if (!term || term.length === 0) {
-      this._terminal.clearSelection();
-      return undefined;
-    }
-    if (startCol > this._terminal.cols) {
-      throw new Error(`Invalid col: ${startCol} to search in terminal of ${this._terminal.cols} cols`);
-    }
-
-    this._lineCache.initLinesCache();
-
-    const searchPosition: ISearchPosition = {
-      startRow,
-      startCol
-    };
-
-    // Search startRow
-    let result = this._findInLine(term, searchPosition, searchOptions);
-    // Search from startRow + 1 to end
-    if (!result) {
-      for (let y = startRow + 1; y < this._terminal.buffer.active.baseY + this._terminal.rows; y++) {
-        searchPosition.startRow = y;
-        searchPosition.startCol = 0;
-        result = this._findInLine(term, searchPosition, searchOptions);
-        if (result) {
-          break;
-        }
-      }
-    }
-    return result;
-  }
-
-  /**
-   * Find the next occurrence of a term with wrapping and selection management.
-   * @param term The search term.
-   * @param searchOptions Search options.
-   * @param cachedSearchTerm The cached search term to determine incremental behavior.
-   * @returns The search result if found, undefined otherwise.
-   */
-  public findNextWithSelection(term: string, searchOptions?: ISearchOptions, cachedSearchTerm?: string): ISearchResult | undefined {
-    if (!term || term.length === 0) {
-      this._terminal.clearSelection();
-      return undefined;
-    }
-
-    const prevSelectedPos = this._terminal.getSelectionPosition();
-    this._terminal.clearSelection();
-
-    let startCol = 0;
-    let startRow = 0;
-    if (prevSelectedPos) {
-      if (cachedSearchTerm === term) {
-        startCol = prevSelectedPos.end.x;
-        startRow = prevSelectedPos.end.y;
-      } else {
-        startCol = prevSelectedPos.start.x;
-        startRow = prevSelectedPos.start.y;
-      }
-    }
-
-    this._lineCache.initLinesCache();
-
-    const searchPosition: ISearchPosition = {
-      startRow,
-      startCol
-    };
-
-    // Search startRow
-    let result = this._findInLine(term, searchPosition, searchOptions);
-    // Search from startRow + 1 to end
-    if (!result) {
-      for (let y = startRow + 1; y < this._terminal.buffer.active.baseY + this._terminal.rows; y++) {
-        searchPosition.startRow = y;
-        searchPosition.startCol = 0;
-        result = this._findInLine(term, searchPosition, searchOptions);
-        if (result) {
-          break;
-        }
-      }
-    }
-    // If we hit the bottom and didn't search from the very top wrap back up
-    if (!result && startRow !== 0) {
-      for (let y = 0; y < startRow; y++) {
-        searchPosition.startRow = y;
-        searchPosition.startCol = 0;
-        result = this._findInLine(term, searchPosition, searchOptions);
-        if (result) {
-          break;
-        }
-      }
-    }
-
-    // If there is only one result, wrap back and return selection if it exists.
-    if (!result && prevSelectedPos) {
-      searchPosition.startRow = prevSelectedPos.start.y;
-      searchPosition.startCol = 0;
-      result = this._findInLine(term, searchPosition, searchOptions);
-    }
-
-    return result;
-  }
-
-  /**
-   * Find the previous occurrence of a term with wrapping and selection management.
-   * @param term The search term.
-   * @param searchOptions Search options.
-   * @param cachedSearchTerm The cached search term to determine if expansion should occur.
-   * @returns The search result if found, undefined otherwise.
-   */
-  public findPreviousWithSelection(term: string, searchOptions?: ISearchOptions, cachedSearchTerm?: string): ISearchResult | undefined {
-    if (!term || term.length === 0) {
-      this._terminal.clearSelection();
-      return undefined;
-    }
-
-    const prevSelectedPos = this._terminal.getSelectionPosition();
-    this._terminal.clearSelection();
-
-    let startRow = this._terminal.buffer.active.baseY + this._terminal.rows - 1;
-    let startCol = this._terminal.cols;
-    const isReverseSearch = true;
-
-    this._lineCache.initLinesCache();
-    const searchPosition: ISearchPosition = {
-      startRow,
-      startCol
-    };
-
-    let result: ISearchResult | undefined;
-    if (prevSelectedPos) {
-      searchPosition.startRow = startRow = prevSelectedPos.start.y;
-      searchPosition.startCol = startCol = prevSelectedPos.start.x;
-      if (cachedSearchTerm !== term) {
-        // Try to expand selection to right first.
-        result = this._findInLine(term, searchPosition, searchOptions, false);
-        if (!result) {
-          // If selection was not able to be expanded to the right, then try reverse search
-          searchPosition.startRow = startRow = prevSelectedPos.end.y;
-          searchPosition.startCol = startCol = prevSelectedPos.end.x;
-        }
-      }
-    }
-
-    result ??= this._findInLine(term, searchPosition, searchOptions, isReverseSearch);
-
-    // Search from startRow - 1 to top
-    if (!result) {
-      searchPosition.startCol = Math.max(searchPosition.startCol, this._terminal.cols);
-      for (let y = startRow - 1; y >= 0; y--) {
-        searchPosition.startRow = y;
-        result = this._findInLine(term, searchPosition, searchOptions, isReverseSearch);
-        if (result) {
-          break;
-        }
-      }
-    }
-    // If we hit the top and didn't search from the very bottom wrap back down
-    if (!result && startRow !== (this._terminal.buffer.active.baseY + this._terminal.rows - 1)) {
-      for (let y = (this._terminal.buffer.active.baseY + this._terminal.rows - 1); y >= startRow; y--) {
-        searchPosition.startRow = y;
-        result = this._findInLine(term, searchPosition, searchOptions, isReverseSearch);
-        if (result) {
-          break;
-        }
-      }
-    }
-
-    return result;
-  }
-
-  /**
-   * A found substring is a whole word if it doesn't have an alphanumeric character directly
-   * adjacent to it.
-   * @param searchIndex starting index of the potential whole word substring
-   * @param line entire string in which the potential whole word was found
-   * @param term the substring that starts at searchIndex
-   */
-  private _isWholeWord(searchIndex: number, line: string, term: string): boolean {
-    return ((searchIndex === 0) || (Constants.NON_WORD_CHARACTERS.includes(line[searchIndex - 1]))) &&
-      (((searchIndex + term.length) === line.length) || (Constants.NON_WORD_CHARACTERS.includes(line[searchIndex + term.length])));
-  }
-
-  /**
-   * Searches a line for a search term. Takes the provided terminal line and searches the text line,
-   * which may contain subsequent terminal lines if the text is wrapped. If the provided line number
-   * is part of a wrapped text line that started on an earlier line then it is skipped since it will
-   * be properly searched when the terminal line that the text starts on is searched.
-   * @param term The search term.
-   * @param searchPosition The position to start the search.
-   * @param searchOptions Search options.
-   * @param isReverseSearch Whether the search should start from the right side of the terminal and
-   * search to the left.
-   * @returns The search result if it was found.
-   */
-  private _findInLine(term: string, searchPosition: ISearchPosition, searchOptions: ISearchOptions = {}, isReverseSearch: boolean = false): ISearchResult | undefined {
-    const row = searchPosition.startRow;
-    const col = searchPosition.startCol;
-
-    // Ignore wrapped lines, only consider on unwrapped line (first row of command string).
-    const firstLine = this._terminal.buffer.active.getLine(row);
-    if (firstLine?.isWrapped) {
-      if (isReverseSearch) {
-        searchPosition.startCol += this._terminal.cols;
-        return;
-      }
-
-      // This will iterate until we find the line start.
-      // When we find it, we will search using the calculated start column.
-      searchPosition.startRow--;
-      searchPosition.startCol += this._terminal.cols;
-      return this._findInLine(term, searchPosition, searchOptions);
-    }
-    let cache = this._lineCache.getLineFromCache(row);
-    if (!cache) {
-      cache = this._lineCache.translateBufferLineToStringWithWrap(row, true);
-      this._lineCache.setLineInCache(row, cache);
-    }
-    const [stringLine, offsets] = cache;
-
-    const offset = this._bufferColsToStringOffset(row, col);
-    let searchTerm = term;
-    let searchStringLine = stringLine;
-    if (!searchOptions.regex) {
-      searchTerm = searchOptions.caseSensitive ? term : term.toLowerCase();
-      searchStringLine = searchOptions.caseSensitive ? stringLine : stringLine.toLowerCase();
-    }
-
-    let resultIndex = -1;
-    if (searchOptions.regex) {
-      const searchRegex = RegExp(searchTerm, searchOptions.caseSensitive ? 'g' : 'gi');
-      let foundTerm: RegExpExecArray | null;
-      if (isReverseSearch) {
-        // This loop will get the resultIndex of the _last_ regex match in the range 0..offset
-        while (foundTerm = searchRegex.exec(searchStringLine.slice(0, offset))) {
-          resultIndex = searchRegex.lastIndex - foundTerm[0].length;
-          term = foundTerm[0];
-          searchRegex.lastIndex -= (term.length - 1);
-        }
-      } else {
-        foundTerm = searchRegex.exec(searchStringLine.slice(offset));
-        if (foundTerm && foundTerm[0].length > 0) {
-          resultIndex = offset + (searchRegex.lastIndex - foundTerm[0].length);
-          term = foundTerm[0];
-        }
-      }
-    } else {
-      if (isReverseSearch) {
-        if (offset - searchTerm.length >= 0) {
-          resultIndex = searchStringLine.lastIndexOf(searchTerm, offset - searchTerm.length);
-        }
-      } else {
-        resultIndex = searchStringLine.indexOf(searchTerm, offset);
-      }
-    }
-
-    if (resultIndex >= 0) {
-      if (searchOptions.wholeWord && !this._isWholeWord(resultIndex, searchStringLine, term)) {
-        return;
-      }
-
-      // Adjust the row number and search index if needed since a "line" of text can span multiple
-      // rows
-      let startRowOffset = 0;
-      while (startRowOffset < offsets.length - 1 && resultIndex >= offsets[startRowOffset + 1]) {
-        startRowOffset++;
-      }
-      let endRowOffset = startRowOffset;
-      while (endRowOffset < offsets.length - 1 && resultIndex + term.length >= offsets[endRowOffset + 1]) {
-        endRowOffset++;
-      }
-      const startColOffset = resultIndex - offsets[startRowOffset];
-      const endColOffset = resultIndex + term.length - offsets[endRowOffset];
-      const startColIndex = this._stringLengthToBufferSize(row + startRowOffset, startColOffset);
-      const endColIndex = this._stringLengthToBufferSize(row + endRowOffset, endColOffset);
-      const size = endColIndex - startColIndex + this._terminal.cols * (endRowOffset - startRowOffset);
-
-      return {
-        term,
-        col: startColIndex,
-        row: row + startRowOffset,
-        size
-      };
-    }
-  }
-
-  private _stringLengthToBufferSize(row: number, offset: number): number {
-    const line = this._terminal.buffer.active.getLine(row);
-    if (!line) {
-      return 0;
-    }
-    for (let i = 0; i < offset; i++) {
-      const cell = line.getCell(i);
-      if (!cell) {
-        break;
-      }
-      // Adjust the searchIndex to normalize emoji into single chars
-      const char = cell.getChars();
-      if (char.length > 1) {
-        offset -= char.length - 1;
-      }
-      // Adjust the searchIndex for empty characters following wide unicode
-      // chars (eg. CJK)
-      const nextCell = line.getCell(i + 1);
-      if (nextCell && nextCell.getWidth() === 0) {
-        offset++;
-      }
-    }
-    return offset;
-  }
-
-  private _bufferColsToStringOffset(startRow: number, cols: number): number {
-    let lineIndex = startRow;
-    let offset = 0;
-    let line = this._terminal.buffer.active.getLine(lineIndex);
-    while (cols > 0 && line) {
-      for (let i = 0; i < cols && i < this._terminal.cols; i++) {
-        const cell = line.getCell(i);
-        if (!cell) {
-          break;
-        }
-        if (cell.getWidth()) {
-          // Treat null characters as whitespace to align with the translateToString API
-          offset += cell.getCode() === 0 ? 1 : cell.getChars().length;
-        }
-      }
-      lineIndex++;
-      line = this._terminal.buffer.active.getLine(lineIndex);
-      if (line && !line.isWrapped) {
-        break;
-      }
-      cols -= this._terminal.cols;
-    }
-    return offset;
-  }
-}

addons/addon-search/src/SearchLineCache.test.ts

@@ -1,287 +0,0 @@
-/**
- * Copyright (c) 2024 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-import { assert } from 'chai';
-import { SearchLineCache, LineCacheEntry } from './SearchLineCache';
-import { Terminal } from '../../../src/browser/public/Terminal';
-import { timeout } from '../../../src/common/Async';
-
-function writeP(terminal: Terminal, data: string): Promise<void> {
-  return new Promise(r => terminal.write(data, r));
-}
-
-describe('SearchLineCache', () => {
-  let terminal: Terminal;
-  let cache: SearchLineCache;
-
-  beforeEach(() => {
-    terminal = new Terminal({ cols: 80, rows: 24 });
-    cache = new SearchLineCache(terminal);
-  });
-
-  afterEach(() => {
-    cache.dispose();
-    terminal.dispose();
-  });
-
-  describe('constructor', () => {
-    it('should create a SearchLineCache instance', () => {
-      assert.instanceOf(cache, SearchLineCache);
-    });
-
-    it('should start with no cache initialized', () => {
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-  });
-
-  describe('initLinesCache', () => {
-    it('should initialize the lines cache array', () => {
-      cache.initLinesCache();
-      assert.equal(cache.getLineFromCache(0), undefined, 'cache should be initialized but empty');
-    });
-
-    it('should not reinitialize if cache already exists', () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      cache.initLinesCache();
-
-      const entry = cache.getLineFromCache(0);
-      assert.deepEqual(entry, ['test', [0]], 'cache should still contain the previously set entry');
-    });
-
-    it('should set up TTL timeout', () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]], 'entry should exist after initialization');
-    });
-  });
-
-  describe('getLineFromCache', () => {
-    it('should return undefined when cache is not initialized', () => {
-      assert.equal(cache.getLineFromCache(0), undefined);
-      assert.equal(cache.getLineFromCache(10), undefined);
-    });
-
-    it('should return undefined for unset entries when cache is initialized', () => {
-      cache.initLinesCache();
-      assert.equal(cache.getLineFromCache(0), undefined);
-      assert.equal(cache.getLineFromCache(50), undefined);
-    });
-
-    it('should return cached entries', () => {
-      cache.initLinesCache();
-      const entry: LineCacheEntry = ['test content', [0]];
-      cache.setLineInCache(5, entry);
-
-      assert.deepEqual(cache.getLineFromCache(5), entry);
-    });
-  });
-
-  describe('setLineInCache', () => {
-    it('should not set entries when cache is not initialized', () => {
-      const entry: LineCacheEntry = ['test content', [0]];
-      cache.setLineInCache(0, entry);
-
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-
-    it('should set entries when cache is initialized', () => {
-      cache.initLinesCache();
-      const entry: LineCacheEntry = ['test content', [0]];
-      cache.setLineInCache(10, entry);
-
-      assert.deepEqual(cache.getLineFromCache(10), entry);
-    });
-
-    it('should overwrite existing entries', () => {
-      cache.initLinesCache();
-      const entry1: LineCacheEntry = ['first content', [0]];
-      const entry2: LineCacheEntry = ['second content', [0]];
-
-      cache.setLineInCache(0, entry1);
-      assert.deepEqual(cache.getLineFromCache(0), entry1);
-
-      cache.setLineInCache(0, entry2);
-      assert.deepEqual(cache.getLineFromCache(0), entry2);
-    });
-  });
-
-  describe('translateBufferLineToStringWithWrap', () => {
-    it('should translate a single line without wrapping', async () => {
-      await writeP(terminal, 'Hello World');
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], 'Hello World');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle trimRight parameter', async () => {
-      await writeP(terminal, 'Hello World   ');
-      const resultTrimmed = cache.translateBufferLineToStringWithWrap(0, true);
-      const resultNotTrimmed = cache.translateBufferLineToStringWithWrap(0, false);
-
-      assert.equal(resultTrimmed[0].trimEnd(), 'Hello World');
-      assert.isTrue(resultNotTrimmed[0].startsWith('Hello World   '));
-      assert.isTrue(resultNotTrimmed[0].length > resultTrimmed[0].length, 'non-trimmed result should be longer');
-    });
-
-    it('should handle wrapped lines', async () => {
-      const longText = 'A'.repeat(200);
-      await writeP(terminal, longText);
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], longText);
-      assert.isTrue(result[1].length > 1, 'should have multiple offsets due to wrapping');
-      assert.equal(result[1][0], 0, 'first offset should be 0');
-    });
-
-    it('should handle wide characters', async () => {
-      await writeP(terminal, 'Hello 世界');
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], 'Hello 世界');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle empty lines', () => {
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], '');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle lines beyond buffer', () => {
-      const result = cache.translateBufferLineToStringWithWrap(1000, true);
-      assert.equal(result[0], '');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle complex wrapped content', async () => {
-      await writeP(terminal, 'Line 1\r\n');
-      await writeP(terminal, 'Line 2 with some longer content that might wrap\r\n');
-      await writeP(terminal, 'Line 3');
-
-      const result1 = cache.translateBufferLineToStringWithWrap(0, true);
-      const result2 = cache.translateBufferLineToStringWithWrap(1, true);
-      const result3 = cache.translateBufferLineToStringWithWrap(2, true);
-
-      assert.equal(result1[0], 'Line 1');
-      assert.equal(result2[0], 'Line 2 with some longer content that might wrap');
-      assert.equal(result3[0], 'Line 3');
-    });
-  });
-
-  describe('cache invalidation', () => {
-    it('should invalidate cache on line feed', async () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      terminal.write('test\r\n');
-
-      await timeout(10);
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-
-    it('should invalidate cache on cursor move', async () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      await writeP(terminal, 'some text');
-      await timeout(10);
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-
-    it('should invalidate cache on resize', async () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      terminal.resize(100, 30);
-
-      await timeout(10);
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-  });
-
-  describe('disposal', () => {
-    it('should clean up resources on dispose', () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      cache.dispose();
-
-      assert.equal(cache.getLineFromCache(0), undefined, 'cache should be destroyed after disposal');
-    });
-
-    it('should be safe to dispose multiple times', () => {
-      cache.initLinesCache();
-      cache.dispose();
-      cache.dispose();
-
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-  });
-
-  describe('LineCacheEntry type', () => {
-    it('should handle complex line offsets', () => {
-      const entry: LineCacheEntry = [
-        'A very long line that wraps multiple times across several terminal lines',
-        [0, 20, 40, 60]
-      ];
-
-      cache.initLinesCache();
-      cache.setLineInCache(0, entry);
-
-      const retrieved = cache.getLineFromCache(0);
-      assert.deepEqual(retrieved, entry);
-      assert.equal(retrieved![0].length, 72);
-      assert.equal(retrieved![1].length, 4);
-    });
-
-    it('should handle unicode characters in cache entries', () => {
-      const entry: LineCacheEntry = [
-        'Hello 世界 🌍 测试',
-        [0]
-      ];
-
-      cache.initLinesCache();
-      cache.setLineInCache(0, entry);
-
-      const retrieved = cache.getLineFromCache(0);
-      assert.deepEqual(retrieved, entry);
-      assert.equal(retrieved![0], 'Hello 世界 🌍 测试');
-    });
-  });
-
-  describe('integration with real terminal content', () => {
-    it('should correctly translate real buffer content', async () => {
-      await writeP(terminal, 'Hello World');
-      const cached = cache.translateBufferLineToStringWithWrap(0, true);
-      const directTranslation = terminal.buffer.active.getLine(0)?.translateToString(true) || '';
-
-      assert.equal(cached[0], directTranslation);
-    });
-
-    it('should handle real wrapped content correctly', async () => {
-      const longContent = 'This is a very long line that will definitely wrap around in an 80 column terminal and should be handled correctly by the cache';
-      await writeP(terminal, longContent);
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], longContent);
-      assert.isTrue(result[1].length > 1, 'should have wrapped');
-    });
-
-    it('should work with real escape sequences', async () => {
-      await writeP(terminal, 'Before\x1b[31mRed Text\x1b[0mAfter');
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.include(result[0], 'Before');
-      assert.include(result[0], 'Red Text');
-      assert.include(result[0], 'After');
-    });
-  });
-});

addons/addon-search/src/SearchLineCache.ts

@@ -1,136 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { Terminal } from '@xterm/xterm';
-import { combinedDisposable, Disposable, MutableDisposable, toDisposable } from '../../../src/common/Lifecycle';
-import { disposableTimeout } from '../../../src/common/Async';
-
-export type LineCacheEntry = [
-  /**
-   * The string representation of a line (as opposed to the buffer cell representation).
-   */
-  lineAsString: string,
-  /**
-   * The offsets where each line starts when the entry describes a wrapped line.
-   */
-  lineOffsets: number[]
-];
-
-/**
- * Configuration constants for the search line cache functionality.
- */
-const enum Constants {
-  /**
-   * Time-to-live for cached search results in milliseconds. After this duration, cached search
-   * results will be invalidated to ensure they remain consistent with terminal content changes.
-   */
-  LINES_CACHE_TIME_TO_LIVE = 15000
-}
-
-export class SearchLineCache extends Disposable {
-  /**
-   * translateBufferLineToStringWithWrap is a fairly expensive call.
-   * We memoize the calls into an array that has a time based ttl.
-   * _linesCache is also invalidated when the terminal cursor moves.
-   */
-  private _linesCache: LineCacheEntry[] | undefined;
-  private _linesCacheTimeout = this._register(new MutableDisposable());
-  private _linesCacheDisposables = this._register(new MutableDisposable());
-  // Track access to avoid recreating a timeout on every init call which occurs once per search
-  // result (findNext/findPrevious -> _highlightAllMatches -> find loop).
-  private _lastAccessTimestamp = 0;
-
-  constructor(private readonly _terminal: Terminal) {
-    super();
-    this._register(toDisposable(() => this._destroyLinesCache()));
-  }
-
-  /**
-   * Sets up a line cache with a ttl
-   */
-  public initLinesCache(): void {
-    if (!this._linesCache) {
-      this._linesCache = new Array(this._terminal.buffer.active.length);
-      this._linesCacheDisposables.value = combinedDisposable(
-        this._terminal.onLineFeed(() => this._destroyLinesCache()),
-        this._terminal.onCursorMove(() => this._destroyLinesCache()),
-        this._terminal.onResize(() => this._destroyLinesCache())
-      );
-    }
-
-    this._lastAccessTimestamp = Date.now();
-    if (!this._linesCacheTimeout.value) {
-      this._scheduleLinesCacheTimeout(Constants.LINES_CACHE_TIME_TO_LIVE);
-    }
-  }
-
-  private _destroyLinesCache(): void {
-    this._linesCache = undefined;
-    this._lastAccessTimestamp = 0;
-    this._linesCacheDisposables.clear();
-    this._linesCacheTimeout.clear();
-  }
-
-  private _scheduleLinesCacheTimeout(delay: number): void {
-    this._linesCacheTimeout.value = disposableTimeout(() => {
-      if (!this._linesCache) {
-        return;
-      }
-      const now = Date.now();
-      const elapsed = now - this._lastAccessTimestamp;
-      if (elapsed >= Constants.LINES_CACHE_TIME_TO_LIVE) {
-        this._destroyLinesCache();
-        return;
-      }
-      this._scheduleLinesCacheTimeout(Constants.LINES_CACHE_TIME_TO_LIVE - elapsed);
-    }, delay);
-  }
-
-  public getLineFromCache(row: number): LineCacheEntry | undefined {
-    return this._linesCache?.[row];
-  }
-
-  public setLineInCache(row: number, entry: LineCacheEntry): void {
-    if (this._linesCache) {
-      this._linesCache[row] = entry;
-    }
-  }
-
-  /**
-   * Translates a buffer line to a string, including subsequent lines if they are wraps.
-   * Wide characters will count as two columns in the resulting string. This
-   * function is useful for getting the actual text underneath the raw selection
-   * position.
-   * @param lineIndex The index of the line being translated.
-   * @param trimRight Whether to trim whitespace to the right.
-   */
-  public translateBufferLineToStringWithWrap(lineIndex: number, trimRight: boolean): LineCacheEntry {
-    const strings = [];
-    const lineOffsets = [0];
-    let line = this._terminal.buffer.active.getLine(lineIndex);
-    while (line) {
-      const nextLine = this._terminal.buffer.active.getLine(lineIndex + 1);
-      const lineWrapsToNext = nextLine ? nextLine.isWrapped : false;
-      let string = line.translateToString(!lineWrapsToNext && trimRight);
-      if (lineWrapsToNext && nextLine) {
-        const lastCell = line.getCell(line.length - 1);
-        const lastCellIsNull = lastCell && lastCell.getCode() === 0 && lastCell.getWidth() === 1;
-        // a wide character wrapped to the next line
-        if (lastCellIsNull && nextLine.getCell(0)?.getWidth() === 2) {
-          string = string.slice(0, -1);
-        }
-      }
-      strings.push(string);
-      if (lineWrapsToNext) {
-        lineOffsets.push(lineOffsets[lineOffsets.length - 1] + string.length);
-      } else {
-        break;
-      }
-      lineIndex++;
-      line = nextLine;
-    }
-    return [strings.join(''), lineOffsets];
-  }
-}

addons/addon-search/src/SearchResultTracker.ts

@@ -1,119 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { ISearchResultChangeEvent } from '@xterm/addon-search';
-import type { IDisposable } from '@xterm/xterm';
-import { Emitter, type IEvent } from '../../../src/common/Event';
-import { Disposable } from '../../../src/common/Lifecycle';
-import type { ISearchResult } from './SearchEngine';
-
-/**
- * Interface for managing a currently selected decoration.
- */
-interface ISelectedDecoration extends IDisposable {
-  match: ISearchResult;
-}
-
-/**
- * Tracks search results, manages result indexing, and fires events when results change.
- * This class provides centralized management of search result state and notifications.
- */
-export class SearchResultTracker extends Disposable {
-  private _searchResults: ISearchResult[] = [];
-  private _selectedDecoration: ISelectedDecoration | undefined;
-
-  private readonly _onDidChangeResults = this._register(new Emitter<ISearchResultChangeEvent>());
-  public get onDidChangeResults(): IEvent<ISearchResultChangeEvent> { return this._onDidChangeResults.event; }
-
-  /**
-   * Gets the current search results.
-   */
-  public get searchResults(): ReadonlyArray<ISearchResult> {
-    return this._searchResults;
-  }
-
-  /**
-   * Gets the currently selected decoration.
-   */
-  public get selectedDecoration(): ISelectedDecoration | undefined {
-    return this._selectedDecoration;
-  }
-
-  /**
-   * Sets the currently selected decoration.
-   */
-  public set selectedDecoration(decoration: ISelectedDecoration | undefined) {
-    this._selectedDecoration = decoration;
-  }
-
-  /**
-   * Updates the search results with a new set of results.
-   * @param results The new search results.
-   * @param maxResults The maximum number of results to track.
-   */
-  public updateResults(results: ISearchResult[], maxResults: number): void {
-    this._searchResults = results.slice(0, maxResults);
-  }
-
-  /**
-   * Clears all search results.
-   */
-  public clearResults(): void {
-    this._searchResults = [];
-  }
-
-  /**
-   * Clears the selected decoration.
-   */
-  public clearSelectedDecoration(): void {
-    if (this._selectedDecoration) {
-      this._selectedDecoration.dispose();
-      this._selectedDecoration = undefined;
-    }
-  }
-
-  /**
-   * Finds the index of a result in the current results array.
-   * @param result The result to find.
-   * @returns The index of the result, or -1 if not found.
-   */
-  public findResultIndex(result: ISearchResult): number {
-    for (let i = 0; i < this._searchResults.length; i++) {
-      const match = this._searchResults[i];
-      if (match.row === result.row && match.col === result.col && match.size === result.size) {
-        return i;
-      }
-    }
-    return -1;
-  }
-
-  /**
-   * Fires a result change event with the current state.
-   * @param hasDecorations Whether decorations are enabled.
-   */
-  public fireResultsChanged(hasDecorations: boolean): void {
-    if (!hasDecorations) {
-      return;
-    }
-
-    let resultIndex = -1;
-    if (this._selectedDecoration) {
-      resultIndex = this.findResultIndex(this._selectedDecoration.match);
-    }
-
-    this._onDidChangeResults.fire({
-      resultIndex,
-      resultCount: this._searchResults.length
-    });
-  }
-
-  /**
-   * Resets all state.
-   */
-  public reset(): void {
-    this.clearSelectedDecoration();
-    this.clearResults();
-  }
-}

addons/addon-search/src/SearchState.ts

@@ -1,106 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { ISearchOptions } from '@xterm/addon-search';
-
-/**
- * Manages search state including cached search terms, options tracking, and validation.
- * This class provides a centralized way to handle search state consistency and option changes.
- */
-export class SearchState {
-  private _cachedSearchTerm: string | undefined;
-  private _lastSearchOptions: ISearchOptions | undefined;
-
-  /**
-   * Gets the currently cached search term.
-   */
-  public get cachedSearchTerm(): string | undefined {
-    return this._cachedSearchTerm;
-  }
-
-  /**
-   * Sets the cached search term.
-   */
-  public set cachedSearchTerm(term: string | undefined) {
-    this._cachedSearchTerm = term;
-  }
-
-  /**
-   * Gets the last search options used.
-   */
-  public get lastSearchOptions(): ISearchOptions | undefined {
-    return this._lastSearchOptions;
-  }
-
-  /**
-   * Sets the last search options used.
-   */
-  public set lastSearchOptions(options: ISearchOptions | undefined) {
-    this._lastSearchOptions = options;
-  }
-
-  /**
-   * Validates a search term to ensure it's not empty or invalid.
-   * @param term The search term to validate.
-   * @returns true if the term is valid for searching.
-   */
-  public isValidSearchTerm(term: string): boolean {
-    return !!(term && term.length > 0);
-  }
-
-  /**
-   * Determines if search options have changed compared to the last search.
-   * @param newOptions The new search options to compare.
-   * @returns true if the options have changed.
-   */
-  public didOptionsChange(newOptions?: ISearchOptions): boolean {
-    if (!this._lastSearchOptions) {
-      return true;
-    }
-    if (!newOptions) {
-      return false;
-    }
-    if (this._lastSearchOptions.caseSensitive !== newOptions.caseSensitive) {
-      return true;
-    }
-    if (this._lastSearchOptions.regex !== newOptions.regex) {
-      return true;
-    }
-    if (this._lastSearchOptions.wholeWord !== newOptions.wholeWord) {
-      return true;
-    }
-    return false;
-  }
-
-  /**
-   * Determines if a new search should trigger highlighting updates.
-   * @param term The search term.
-   * @param options The search options.
-   * @returns true if highlighting should be updated.
-   */
-  public shouldUpdateHighlighting(term: string, options?: ISearchOptions): boolean {
-    if (!options?.decorations) {
-      return false;
-    }
-    return this._cachedSearchTerm === undefined ||
-           term !== this._cachedSearchTerm ||
-           this.didOptionsChange(options);
-  }
-
-  /**
-   * Clears the cached search term.
-   */
-  public clearCachedTerm(): void {
-    this._cachedSearchTerm = undefined;
-  }
-
-  /**
-   * Resets all state.
-   */
-  public reset(): void {
-    this._cachedSearchTerm = undefined;
-    this._lastSearchOptions = undefined;
-  }
-}

addons/addon-search/src/tsconfig.json

@@ -4,7 +4,7 @@
     "target": "es2021",
     "lib": [
       "dom",
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out",
@@ -13,12 +13,22 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "@xterm/addon-search" : [
+        "../typings/addon-search.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-search.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-search/test/SearchAddon.test.ts

@@ -45,6 +45,45 @@ test.describe('Search Tests', () => {
     deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('$^1_3{}test$#')`), true);
     deepStrictEqual(await ctx.proxy.getSelection(), '$^1_3{}test$#');
   });
+  test('Search should not scroll when match is already in viewport', async () => {
+    let dataString = '';
+    for (let i = 0; i < 100; i++) {
+      if (i === 40) {
+        dataString += `line ${i} needle-in-view`;
+      } else {
+        dataString += `line ${i}`;
+      }
+      dataString += '\n\r';
+    }
+    await ctx.proxy.write(dataString);
+    await ctx.page.evaluate('window.term.scrollToLine(35)');
+    strictEqual(await ctx.page.evaluate('window.term.buffer.active.viewportY'), 35);
+
+    strictEqual(await ctx.page.evaluate(`window.search.findNext('needle-in-view')`), true);
+    deepStrictEqual(await ctx.proxy.getSelection(), 'needle-in-view');
+    strictEqual(await ctx.page.evaluate('window.term.buffer.active.viewportY'), 35);
+  });
+  test('Search should center the match when it is outside the viewport', async () => {
+    let dataString = '';
+    for (let i = 0; i < 100; i++) {
+      if (i === 60) {
+        dataString += `line ${i} needle-center`;
+      } else {
+        dataString += `line ${i}`;
+      }
+      dataString += '\n\r';
+    }
+    await ctx.proxy.write(dataString);
+    await ctx.page.evaluate('window.term.scrollToLine(0)');
+    strictEqual(await ctx.page.evaluate('window.term.buffer.active.viewportY'), 0);
+
+    strictEqual(await ctx.page.evaluate(`window.search.findNext('needle-center')`), true);
+    deepStrictEqual(await ctx.proxy.getSelection(), 'needle-center');
+    deepStrictEqual(await ctx.page.evaluate('(() => { const viewportY = window.term.buffer.active.viewportY; const rows = window.term.rows; const selection = window.term.getSelectionPosition(); return { viewportY: viewportY, expectedViewportY: selection.start.y - Math.floor(rows / 2) }; })()'), {
+      viewportY: 48,
+      expectedViewportY: 48
+    });
+  });
   test('Incremental Find Previous', async () => {
     await ctx.proxy.writeln(`package.jsonc\n`);
     await ctx.proxy.write('package.json pack package.lock');
@@ -277,8 +316,7 @@ test.describe('Search Tests', () => {
           { resultCount: 1, resultIndex: 0 },
           { resultCount: 2, resultIndex: 1 }
         ]);
-        await timeout(2000);
-        strictEqual(await ctx.page.evaluate(`debugger; window.search.findPrevious('d', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), false);
+        strictEqual(await ctx.page.evaluate(`window.search.findPrevious('d', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), false);
         deepStrictEqual(await ctx.page.evaluate('window.calls'), [
           { resultCount: 1, resultIndex: 0 },
           { resultCount: 2, resultIndex: 1 },

addons/addon-search/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-search/tsconfig.json

@@ -2,11 +2,8 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" },
+    { "path": "./benchmark" }
   ]
 }

addons/addon-search/typings/addon-search.d.ts

@@ -17,7 +17,8 @@ declare module '@xterm/addon-search' {
 
     /**
      * Whether to search for a whole word, the result is only valid if it's
-     * surrounded in "non-word" characters such as `_`, `(`, `)` or space.
+     * surrounded by start/end of line or non-word separators such as whitespace
+     * and punctuation (for example `(`, `)`, or space).
      */
     wholeWord?: boolean;
 
@@ -28,8 +29,7 @@ declare module '@xterm/addon-search' {
 
     /**
      * Whether to do an incremental search, this will expand the selection if it
-     * still matches the term the user typed. Note that this only affects
-     * `findNext`, not `findPrevious`.
+     * still matches the term the user typed.
      */
     incremental?: boolean;
 
@@ -43,7 +43,7 @@ declare module '@xterm/addon-search' {
   /**
    * Options for showing decorations when searching.
    */
-  interface ISearchDecorationOptions {
+  export interface ISearchDecorationOptions {
     /**
      * The background color of a match, this must use #RRGGBB format.
      */
@@ -57,7 +57,7 @@ declare module '@xterm/addon-search' {
     /**
      * The overview ruler color of a match.
      */
-    matchOverviewRuler: string;
+    matchOverviewRuler?: string;
 
     /**
      * The background color for the currently active match, this must use #RRGGBB format.
@@ -72,7 +72,7 @@ declare module '@xterm/addon-search' {
     /**
      * The overview ruler color of the currently active match.
      */
-    activeMatchColorOverviewRuler: string;
+    activeMatchColorOverviewRuler?: string;
   }
 
   /**
@@ -80,12 +80,13 @@ declare module '@xterm/addon-search' {
    */
   export interface ISearchResultChangeEvent {
     /**
-     * The index of the currently active result, -1 when the threshold of matches is exceeded.
+     * The index of the currently active result within tracked highlights, or -1 when
+     * the active match is not in the tracked result set.
      */
     resultIndex: number;
 
     /**
-     * The total number of search results found.
+     * The number of tracked search results (capped by `highlightLimit` when decorations are enabled).
      */
     resultCount: number;
   }
@@ -96,9 +97,9 @@ declare module '@xterm/addon-search' {
   export interface ISearchAddonOptions {
     /**
      * Max number of matches highlighted when decorations are enabled.
-     * Defaults to 1000 highlighted matches
+     * Defaults to 1000. Invalid values fall back to the default.
      */
-    highlightLimit: number
+    highlightLimit?: number;
   }
 
   /**
@@ -140,7 +141,7 @@ declare module '@xterm/addon-search' {
     public findPrevious(term: string, searchOptions?: ISearchOptions): boolean;
 
     /**
-     * Clears the decorations and selection
+     * Clears highlight decorations and tracked results.
      */
     public clearDecorations(): void;
 
@@ -162,7 +163,8 @@ declare module '@xterm/addon-search' {
     readonly onBeforeSearch: IEvent<void>;
 
     /**
-     * When decorations are enabled, fires when the search results change.
+     * When decorations are enabled, fires after `findNext`/`findPrevious` when tracked
+     * search results change. Does not fire from `clearDecorations()`.
      */
     readonly onDidChangeResults: IEvent<ISearchResultChangeEvent>;
   }

addons/addon-serialize/benchmark/SerializeAddon.benchmark.ts

@@ -6,9 +6,9 @@
 import { perfContext, before, ThroughputRuntimeCase } from 'xterm-benchmark';
 
 import { spawn } from 'node-pty';
-import { Utf8ToUtf32, stringFromCodePoint } from '../../../src/common/input/TextDecoder';
-import { Terminal } from '../../../src/browser/public/Terminal';
-import { SerializeAddon } from '../src/SerializeAddon';
+import { Utf8ToUtf32, stringFromCodePoint } from 'common/input/TextDecoder';
+import { Terminal } from 'browser/public/Terminal';
+import { SerializeAddon } from 'SerializeAddon';
 
 class TestTerminal extends Terminal {
   public writeSync(data: string): void {

addons/addon-serialize/benchmark/tsconfig.json

@@ -6,28 +6,24 @@
     ],
     "rootDir": "..",
     "outDir": "../out-benchmark",
-    "types": [
-      "../../../node_modules/@types/node"
-    ],
+    "types": ["../../../node_modules/@types/node"],
     "moduleResolution": "node",
     "strict": false,
     "target": "es2021",
-    "module": "commonjs"
-  },
-  "include": [
-    "../**/*",
-    "../../../typings/xterm.d.ts"
-  ],
-  "exclude": [
-    "../../../**/*test.ts",
-    "../../**/*api.ts"
-  ],
-  "references": [
-    {
-      "path": "../../../src/common"
-    },
-    {
-      "path": "../../../src/browser"
+    "module": "commonjs",
+    "paths": {
+      "common/*": ["../../../src/common/*"],
+      "browser/*": ["../../../src/browser/*"],
+      "SerializeAddon": ["../src/SerializeAddon"],
+      "@xterm/addon-serialize": [
+        "../typings/addon-serialize.d.ts"
+      ]
     }
+  },
+  "include": ["../**/*", "../../../typings/xterm.d.ts"],
+  "exclude": ["../../../**/*test.ts", "../../**/*api.ts"],
+  "references": [
+    { "path": "../../../src/common" },
+    { "path": "../../../src/browser" }
   ]
 }

addons/addon-serialize/src/SerializeAddon.test.ts

@@ -6,10 +6,10 @@
 import jsdom = require('jsdom');
 import { assert } from 'chai';
 import { SerializeAddon } from './SerializeAddon';
-import { Terminal } from '../../../src/browser/public/Terminal';
-import { SelectionModel } from '../../../src/browser/selection/SelectionModel';
-import { IBufferService } from '../../../src/common/services/Services';
-import { ThemeService } from '../../../src/browser/services/ThemeService';
+import { Terminal } from 'browser/public/Terminal';
+import { SelectionModel } from 'browser/selection/SelectionModel';
+import { IBufferService } from 'common/services/Services';
+import { ThemeService } from 'browser/services/ThemeService';
 
 function sgr(...seq: string[]): string {
   return `\x1b[${seq.join(';')}m`;

addons/addon-serialize/src/SerializeAddon.ts

@@ -7,9 +7,9 @@
 
 import type { IBuffer, IBufferCell, IBufferRange, ITerminalAddon, Terminal } from '@xterm/xterm';
 import type { IHTMLSerializeOptions, SerializeAddon as ISerializeApi, ISerializeOptions, ISerializeRange } from '@xterm/addon-serialize';
-import { IAttributeData, IColor } from '../../../src/common/Types';
-import { DEFAULT_ANSI_COLORS } from '../../../src/browser/Types';
-import { UnderlineStyle } from '../../../src/common/buffer/Constants';
+import { IAttributeData, IColor } from 'common/Types';
+import { DEFAULT_ANSI_COLORS } from 'browser/Types';
+import { UnderlineStyle } from 'common/buffer/Constants';
 
 function constrain(value: number, low: number, high: number): number {
   return Math.max(low, Math.min(value, high));

addons/addon-serialize/src/tsconfig.json

@@ -10,6 +10,17 @@
     "outDir": "../out",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "@xterm/addon-serialize": [
+        "../typings/addon-serialize.d.ts"
+      ]
+    },
     "strict": true,
     "skipLibCheck": true,
     "types": [
@@ -18,8 +29,7 @@
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-serialize.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-serialize/test/tsconfig.json

@@ -3,12 +3,20 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-serialize/tsconfig.json

@@ -2,14 +2,8 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    },
-    {
-      "path": "./benchmark"
-    }
+    { "path": "./src" },
+    { "path": "./test" },
+    { "path": "./benchmark" }
   ]
 }

addons/addon-unicode-graphemes/benchmark/UnicodeGraphemeAddon.benchmark.ts

@@ -6,9 +6,9 @@
 import { perfContext, before, ThroughputRuntimeCase } from 'xterm-benchmark';
 
 import { spawn } from 'node-pty';
-import { Utf8ToUtf32, stringFromCodePoint } from '../../../src/common/input/TextDecoder';
-import { CoreBrowserTerminal } from '../../../src/browser/CoreBrowserTerminal';
-import { UnicodeGraphemeProvider } from '../src/UnicodeGraphemeProvider';
+import { Utf8ToUtf32, stringFromCodePoint } from 'common/input/TextDecoder';
+import { CoreBrowserTerminal } from 'browser/CoreBrowserTerminal';
+import { UnicodeGraphemeProvider } from 'UnicodeGraphemeProvider';
 
 
 function fakedAddonLoad(terminal: any): void {

addons/addon-unicode-graphemes/benchmark/tsconfig.json

@@ -1,33 +1,26 @@
 {
   "compilerOptions": {
-    "lib": [
-      "dom",
-      "es6"
-    ],
+    "lib": ["dom", "es6"],
     "rootDir": "..",
     "outDir": "../out-benchmark",
-    "types": [
-      "../../../node_modules/@types/node"
-    ],
+    "types": ["../../../node_modules/@types/node"],
     "moduleResolution": "node",
     "strict": false,
     "target": "es2015",
-    "module": "commonjs"
-  },
-  "include": [
-    "../**/*",
-    "../../../typings/xterm.d.ts"
-  ],
-  "exclude": [
-    "../../../**/*test.ts",
-    "../../**/*api.ts"
-  ],
-  "references": [
-    {
-      "path": "../../../src/common"
-    },
-    {
-      "path": "../../../src/browser"
+    "module": "commonjs",
+    "paths": {
+      "common/*": ["../../../src/common/*"],
+      "browser/*": ["../../../src/browser/*"],
+      "UnicodeGraphemeProvider": ["../src/UnicodeGraphemeProvider"],
+      "@xterm/addon-unicode-graphemes": [
+        "../typings/addon-unicode-graphemes.d.ts"
+      ]
     }
+  },
+  "include": ["../**/*", "../../../typings/xterm.d.ts"],
+  "exclude": ["../../../**/*test.ts", "../../**/*api.ts"],
+  "references": [
+    { "path": "../../../src/common" },
+    { "path": "../../../src/browser" }
   ]
 }

addons/addon-unicode-graphemes/src/UnicodeGraphemeProvider.ts

@@ -4,8 +4,8 @@
  */
 
 import { IUnicodeVersionProvider } from '@xterm/xterm';
-import { UnicodeCharProperties, UnicodeCharWidth } from '../../../src/common/services/Services';
-import { UnicodeService } from '../../../src/common/services/UnicodeService';
+import { UnicodeCharProperties, UnicodeCharWidth } from 'common/services/Services';
+import { UnicodeService } from 'common/services/UnicodeService';
 import * as UC from './third-party/UnicodeProperties';
 
 export class UnicodeGraphemeProvider implements IUnicodeVersionProvider {

addons/addon-unicode-graphemes/src/tsconfig.json

@@ -11,14 +11,21 @@
     "sourceMap": true,
     "removeComments": true,
     "strict": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "@xterm/addon-unicode-graphemes": [
+        "../typings/addon-unicode-graphemes.d.ts"
+      ]
+    },
     "types": [
       "../../../node_modules/@types/mocha"
     ]
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-unicode-graphemes.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-unicode-graphemes/test/tsconfig.json

@@ -3,12 +3,20 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-unicode-graphemes/tsconfig.json

@@ -2,14 +2,8 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    },
-    {
-      "path": "./benchmark"
-    }
+    { "path": "./src" },
+    { "path": "./test" },
+    { "path": "./benchmark" }
   ]
 }

addons/addon-unicode11/src/UnicodeV11.ts

@@ -4,8 +4,8 @@
  */
 
 import { IUnicodeVersionProvider } from '@xterm/xterm';
-import { UnicodeCharProperties, UnicodeCharWidth } from '../../../src/common/services/Services';
-import { UnicodeService } from '../../../src/common/services/UnicodeService';
+import { UnicodeCharProperties, UnicodeCharWidth } from 'common/services/Services';
+import { UnicodeService } from 'common/services/UnicodeService';
 
 const BMP_COMBINING = [
   [0x0300, 0x036F], [0x0483, 0x0489], [0x0591, 0x05BD],

addons/addon-unicode11/src/tsconfig.json

@@ -11,14 +11,24 @@
     "sourceMap": true,
     "removeComments": true,
     "strict": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "@xterm/addon-unicode11": [
+        "../typings/addon-unicode11.d.ts"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "types": [
       "../../../node_modules/@types/mocha"
     ]
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-unicode11.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-unicode11/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-unicode11/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-web-fonts/src/tsconfig.json

@@ -14,11 +14,15 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "@xterm/addon-web-fonts": [
+        "../typings/addon-web-fonts.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-web-fonts.d.ts"
+    "../../../typings/xterm.d.ts"
   ]
 }

addons/addon-web-fonts/test/tsconfig.json

@@ -3,12 +3,24 @@
     "module": "commonjs",
     "target": "es2021",
     "lib": [
-      "es2021"
+      "es2021",
     ],
+    // "downlevelIteration": true,
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-web-fonts/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-web-links/src/tsconfig.json

@@ -13,11 +13,15 @@
     "strict": true,
     "types": [
       "../../../node_modules/@types/mocha"
-    ]
+    ],
+    "paths": {
+      "@xterm/addon-web-links": [
+        "../typings/addon-web-links.d.ts"
+      ]
+    }
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-web-links.d.ts"
+    "../../../typings/xterm.d.ts"
   ]
 }

addons/addon-web-links/test/tsconfig.json

@@ -3,12 +3,24 @@
     "module": "commonjs",
     "target": "es2021",
     "lib": [
-      "es2021"
+      "es2021",
     ],
+    // "downlevelIteration": true,
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node"

addons/addon-web-links/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

addons/addon-webgl/src/CellColorResolver.ts

@@ -1,12 +1,12 @@
-import { ISelectionRenderModel } from '../../../src/browser/renderer/shared/Types';
-import { ICoreBrowserService, IThemeService } from '../../../src/browser/services/Services';
-import { ReadonlyColorSet } from '../../../src/browser/Types';
-import { Attributes, BgFlags, ExtFlags, FgFlags, NULL_CELL_CODE, UnderlineStyle } from '../../../src/common/buffer/Constants';
-import { IDecorationService, IOptionsService } from '../../../src/common/services/Services';
-import { ICellData } from '../../../src/common/Types';
+import { ISelectionRenderModel } from 'browser/renderer/shared/Types';
+import { ICoreBrowserService, IThemeService } from 'browser/services/Services';
+import { ReadonlyColorSet } from 'browser/Types';
+import { Attributes, BgFlags, ExtFlags, FgFlags, NULL_CELL_CODE, UnderlineStyle } from 'common/buffer/Constants';
+import { IDecorationService, IOptionsService } from 'common/services/Services';
+import { ICellData } from 'common/Types';
 import { Terminal } from '@xterm/xterm';
-import { rgba } from '../../../src/common/Color';
-import { treatGlyphAsBackgroundColor } from '../../../src/browser/renderer/shared/RendererUtils';
+import { rgba } from 'common/Color';
+import { treatGlyphAsBackgroundColor } from 'browser/renderer/shared/RendererUtils';
 import { blockPatternCodepoints } from './customGlyphs/CustomGlyphDefinitions';
 
 // Work variables to avoid garbage collection

addons/addon-webgl/src/CharAtlasCache.ts

@@ -5,10 +5,10 @@
 
 import { TextureAtlas } from './TextureAtlas';
 import { ITerminalOptions, Terminal } from '@xterm/xterm';
-import { ITerminal, ReadonlyColorSet } from '../../../src/browser/Types';
+import { ITerminal, ReadonlyColorSet } from 'browser/Types';
 import { ICharAtlasConfig, ITextureAtlas } from './Types';
 import { generateConfig, configEquals } from './CharAtlasUtils';
-import type { ILogService } from '../../../src/common/services/Services';
+import type { ILogService } from 'common/services/Services';
 
 interface ITextureAtlasCacheEntry {
   atlas: ITextureAtlas;

addons/addon-webgl/src/CharAtlasUtils.test.ts

@@ -1,87 +0,0 @@
-/**
- * Copyright (c) 2026 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import { assert } from 'chai';
-import { configEquals } from './CharAtlasUtils';
-import { ICharAtlasConfig } from './Types';
-import { NULL_COLOR } from '../../../src/common/Color';
-import { IColor } from '../../../src/common/Types';
-
-function createTestConfig(overrides: Partial<ICharAtlasConfig> = {}): ICharAtlasConfig {
-  const color: IColor = { css: '#ffffff', rgba: 0xffffffff };
-  const contrastCache = {
-    clear: () => {},
-    setCss: () => {},
-    getCss: () => undefined,
-    setColor: () => {},
-    getColor: () => undefined
-  };
-  const colors = {
-    foreground: color,
-    background: color,
-    cursor: NULL_COLOR,
-    cursorAccent: NULL_COLOR,
-    selectionForeground: undefined,
-    selectionBackgroundTransparent: NULL_COLOR,
-    selectionBackgroundOpaque: NULL_COLOR,
-    selectionInactiveBackgroundTransparent: NULL_COLOR,
-    selectionInactiveBackgroundOpaque: NULL_COLOR,
-    overviewRulerBorder: NULL_COLOR,
-    scrollbarSliderBackground: NULL_COLOR,
-    scrollbarSliderHoverBackground: NULL_COLOR,
-    scrollbarSliderActiveBackground: NULL_COLOR,
-    ansi: new Array(256).fill(color),
-    contrastCache,
-    halfContrastCache: contrastCache
-  };
-  return {
-    customGlyphs: true,
-    devicePixelRatio: 1,
-    deviceMaxTextureSize: 4096,
-    letterSpacing: 0,
-    lineHeight: 1,
-    fontSize: 15,
-    fontFamily: 'monospace',
-    fontWeight: 'normal',
-    fontWeightBold: 'bold',
-    deviceCellWidth: 10,
-    deviceCellHeight: 20,
-    deviceCharWidth: 8,
-    deviceCharHeight: 16,
-    allowTransparency: false,
-    drawBoldTextInBrightColors: true,
-    minimumContrastRatio: 1,
-    colors,
-    ...overrides
-  };
-}
-
-describe('CharAtlasUtils', () => {
-  describe('configEquals', () => {
-    it('should return true for identical configs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig();
-      assert.ok(configEquals(a, b));
-    });
-
-    it('should return false when deviceMaxTextureSize differs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig({ deviceMaxTextureSize: 8192 });
-      assert.ok(!configEquals(a, b));
-    });
-
-    it('should return false when deviceCellWidth differs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig({ deviceCellWidth: 11 });
-      assert.ok(!configEquals(a, b));
-    });
-
-    it('should return false when deviceCellHeight differs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig({ deviceCellHeight: 21 });
-      assert.ok(!configEquals(a, b));
-    });
-  });
-});

addons/addon-webgl/src/CharAtlasUtils.ts

@@ -4,10 +4,10 @@
  */
 
 import { ICharAtlasConfig } from './Types';
-import { Attributes } from '../../../src/common/buffer/Constants';
+import { Attributes } from 'common/buffer/Constants';
 import { ITerminalOptions } from '@xterm/xterm';
-import { IColorSet, ReadonlyColorSet } from '../../../src/browser/Types';
-import { NULL_COLOR } from '../../../src/common/Color';
+import { IColorSet, ReadonlyColorSet } from 'browser/Types';
+import { NULL_COLOR } from 'common/Color';
 
 export function generateConfig(deviceCellWidth: number, deviceCellHeight: number, deviceCharWidth: number, deviceCharHeight: number, options: Required<ITerminalOptions>, colors: ReadonlyColorSet, devicePixelRatio: number, deviceMaxTextureSize: number, customGlyphs: boolean = true): ICharAtlasConfig {
   // null out some fields that don't matter
@@ -59,7 +59,6 @@ export function configEquals(a: ICharAtlasConfig, b: ICharAtlasConfig): boolean
     }
   }
   return a.devicePixelRatio === b.devicePixelRatio &&
-      a.deviceMaxTextureSize === b.deviceMaxTextureSize &&
       a.customGlyphs === b.customGlyphs &&
       a.lineHeight === b.lineHeight &&
       a.letterSpacing === b.letterSpacing &&
@@ -68,8 +67,6 @@ export function configEquals(a: ICharAtlasConfig, b: ICharAtlasConfig): boolean
       a.fontWeight === b.fontWeight &&
       a.fontWeightBold === b.fontWeightBold &&
       a.allowTransparency === b.allowTransparency &&
-      a.deviceCellWidth === b.deviceCellWidth &&
-      a.deviceCellHeight === b.deviceCellHeight &&
       a.deviceCharWidth === b.deviceCharWidth &&
       a.deviceCharHeight === b.deviceCharHeight &&
       a.drawBoldTextInBrightColors === b.drawBoldTextInBrightColors &&

addons/addon-webgl/src/Constants.ts

@@ -3,7 +3,7 @@
  * @license MIT
  */
 
-import { isFirefox, isLegacyEdge } from '../../../src/common/Platform';
+import { isFirefox, isLegacyEdge } from 'common/Platform';
 
 export const DIM_OPACITY = 0.5;
 // The text baseline is set conditionally by browser. Using 'ideographic' for Firefox or Legacy Edge

addons/addon-webgl/src/CursorBlinkStateManager.ts

@@ -3,8 +3,8 @@
  * @license MIT
  */
 
-import { RendererConstants } from '../../../src/browser/renderer/shared/Constants';
-import { ICoreBrowserService } from '../../../src/browser/services/Services';
+import { RendererConstants } from 'browser/renderer/shared/Constants';
+import { ICoreBrowserService } from 'browser/services/Services';
 
 const enum Constants {
   /**

addons/addon-webgl/src/DevicePixelObserver.ts

@@ -3,7 +3,7 @@
  * @license MIT
  */
 
-import { toDisposable, IDisposable } from '../../../src/common/Lifecycle';
+import { toDisposable, IDisposable } from 'common/Lifecycle';
 
 export function observeDevicePixelDimensions(element: HTMLElement, parentWindow: Window & typeof globalThis, callback: (deviceWidth: number, deviceHeight: number) => void): IDisposable {
   // Observe any resizes to the element and extract the actual pixel size of the element if the

addons/addon-webgl/src/GlyphRenderer.ts

@@ -3,14 +3,14 @@
  * @license MIT
  */
 import { TextureAtlas } from './TextureAtlas';
-import { IRenderDimensions } from '../../../src/browser/renderer/shared/Types';
-import { NULL_CELL_CODE } from '../../../src/common/buffer/Constants';
-import { Disposable, toDisposable } from '../../../src/common/Lifecycle';
+import { IRenderDimensions } from 'browser/renderer/shared/Types';
+import { NULL_CELL_CODE } from 'common/buffer/Constants';
+import { Disposable, toDisposable } from 'common/Lifecycle';
 import { Terminal } from '@xterm/xterm';
 import { IRenderModel, IWebGL2RenderingContext, IWebGLVertexArrayObject, type IRasterizedGlyph, type ITextureAtlas } from './Types';
 import { createProgram, GLTexture, PROJECTION_MATRIX } from './WebglUtils';
-import type { ILogService, IOptionsService } from '../../../src/common/services/Services';
-import { allowRescaling, throwIfFalsy } from '../../../src/browser/renderer/shared/RendererUtils';
+import type { IOptionsService } from 'common/services/Services';
+import { allowRescaling, throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 
 interface IVertices {
   attributes: Float32Array;
@@ -114,8 +114,7 @@ export class GlyphRenderer extends Disposable {
     private readonly _terminal: Terminal,
     private readonly _gl: IWebGL2RenderingContext,
     private _dimensions: IRenderDimensions,
-    private readonly _optionsService: IOptionsService,
-    private readonly _logService: ILogService
+    private readonly _optionsService: IOptionsService
   ) {
     super();
 
@@ -128,7 +127,7 @@ export class GlyphRenderer extends Disposable {
       TextureAtlas.maxTextureSize = throwIfFalsy(gl.getParameter(gl.MAX_TEXTURE_SIZE) as number | null);
     }
 
-    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, createFragmentShaderSource(TextureAtlas.maxAtlasPages), this._logService));
+    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, createFragmentShaderSource(TextureAtlas.maxAtlasPages)));
     this._register(toDisposable(() => gl.deleteProgram(this._program)));
 
     // Uniform locations
@@ -137,9 +136,8 @@ export class GlyphRenderer extends Disposable {
     this._textureLocation = throwIfFalsy(gl.getUniformLocation(this._program, 'u_texture'));
 
     // Create and set the vertex array object
-    const vertexArrayObject = this._vertexArrayObject = gl.createVertexArray();
-    this._register(toDisposable(() => gl.deleteVertexArray(vertexArrayObject)));
-    gl.bindVertexArray(vertexArrayObject);
+    this._vertexArrayObject = gl.createVertexArray();
+    gl.bindVertexArray(this._vertexArrayObject);
 
     // Setup a_unitquad, this defines the 4 vertices of a rectangle
     const unitQuadVertices = new Float32Array([0, 0, 1, 0, 0, 1, 1, 1]);

addons/addon-webgl/src/RectangleRenderer.ts

@@ -3,18 +3,17 @@
  * @license MIT
  */
 
-import { IRenderDimensions } from '../../../src/browser/renderer/shared/Types';
-import { IThemeService } from '../../../src/browser/services/Services';
-import { ReadonlyColorSet } from '../../../src/browser/Types';
-import { Attributes, FgFlags } from '../../../src/common/buffer/Constants';
-import { Disposable, toDisposable } from '../../../src/common/Lifecycle';
-import { IColor } from '../../../src/common/Types';
+import { IRenderDimensions } from 'browser/renderer/shared/Types';
+import { IThemeService } from 'browser/services/Services';
+import { ReadonlyColorSet } from 'browser/Types';
+import { Attributes, FgFlags } from 'common/buffer/Constants';
+import { Disposable, toDisposable } from 'common/Lifecycle';
+import { IColor } from 'common/Types';
 import { Terminal } from '@xterm/xterm';
 import { RenderModelConstants } from './RenderModel';
 import { IRenderModel, IWebGL2RenderingContext, IWebGLVertexArrayObject } from './Types';
 import { createProgram, expandFloat32Array, PROJECTION_MATRIX } from './WebglUtils';
-import { throwIfFalsy } from '../../../src/browser/renderer/shared/RendererUtils';
-import type { ILogService } from '../../../src/common/services/Services';
+import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 
 const enum VertexAttribLocations {
   POSITION = 0,
@@ -90,23 +89,21 @@ export class RectangleRenderer extends Disposable {
     private _terminal: Terminal,
     private _gl: IWebGL2RenderingContext,
     private _dimensions: IRenderDimensions,
-    private readonly _themeService: IThemeService,
-    private readonly _logService: ILogService
+    private readonly _themeService: IThemeService
   ) {
     super();
 
     const gl = this._gl;
 
-    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, fragmentShaderSource, this._logService));
+    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, fragmentShaderSource));
     this._register(toDisposable(() => gl.deleteProgram(this._program)));
 
     // Uniform locations
     this._projectionLocation = throwIfFalsy(gl.getUniformLocation(this._program, 'u_projection'));
 
     // Create and set the vertex array object
-    const vertexArrayObject = this._vertexArrayObject = gl.createVertexArray();
-    this._register(toDisposable(() => gl.deleteVertexArray(vertexArrayObject)));
-    gl.bindVertexArray(vertexArrayObject);
+    this._vertexArrayObject = gl.createVertexArray();
+    gl.bindVertexArray(this._vertexArrayObject);
 
     // Setup a_unitquad, this defines the 4 vertices of a rectangle
     const unitQuadVertices = new Float32Array([0, 0, 1, 0, 0, 1, 1, 1]);

addons/addon-webgl/src/RenderModel.ts

@@ -4,8 +4,8 @@
  */
 
 import { ICursorRenderModel, IRenderModel } from './Types';
-import { ISelectionRenderModel } from '../../../src/browser/renderer/shared/Types';
-import { createSelectionRenderModel } from '../../../src/browser/renderer/shared/SelectionRenderModel';
+import { ISelectionRenderModel } from 'browser/renderer/shared/Types';
+import { createSelectionRenderModel } from 'browser/renderer/shared/SelectionRenderModel';
 
 export const enum RenderModelConstants {
   INDICIES_PER_CELL = 4,

addons/addon-webgl/src/TextureAtlas.ts

@@ -3,19 +3,19 @@
  * @license MIT
  */
 
-import { IColorContrastCache } from '../../../src/browser/Types';
+import { IColorContrastCache } from 'browser/Types';
 import { DIM_OPACITY, TEXT_BASELINE } from './Constants';
 import { tryDrawCustomGlyph } from './customGlyphs/CustomGlyphRasterizer';
-import { computeNextVariantOffset, treatGlyphAsBackgroundColor, isPowerlineGlyph, isRestrictedPowerlineGlyph, throwIfFalsy } from '../../../src/browser/renderer/shared/RendererUtils';
+import { computeNextVariantOffset, treatGlyphAsBackgroundColor, isPowerlineGlyph, isRestrictedPowerlineGlyph, throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 import { IBoundingBox, ICharAtlasConfig, IRasterizedGlyph, ITextureAtlas } from './Types';
-import { NULL_COLOR, channels, color, rgba } from '../../../src/common/Color';
-import { FourKeyMap } from '../../../src/common/MultiKeyMap';
-import { IdleTaskQueue } from '../../../src/common/TaskQueue';
-import { IColor } from '../../../src/common/Types';
-import { AttributeData } from '../../../src/common/buffer/AttributeData';
-import { Attributes, DEFAULT_COLOR, DEFAULT_EXT, UnderlineStyle } from '../../../src/common/buffer/Constants';
-import { ILogService, IUnicodeService } from '../../../src/common/services/Services';
-import { Emitter } from '../../../src/common/Event';
+import { NULL_COLOR, channels, color, rgba } from 'common/Color';
+import { FourKeyMap } from 'common/MultiKeyMap';
+import { IdleTaskQueue } from 'common/TaskQueue';
+import { IColor } from 'common/Types';
+import { AttributeData } from 'common/buffer/AttributeData';
+import { Attributes, DEFAULT_COLOR, DEFAULT_EXT, UnderlineStyle } from 'common/buffer/Constants';
+import { ILogService, IUnicodeService } from 'common/services/Services';
+import { Emitter } from 'common/Event';
 
 /**
  * A shared object which is used to draw nothing for a particular cell.
@@ -109,7 +109,6 @@ export class TextureAtlas implements ITextureAtlas {
       page.canvas.remove();
     }
     this._onAddTextureAtlasCanvas.dispose();
-    this._onRemoveTextureAtlasCanvas.dispose();
   }
 
   public warmUp(): void {
@@ -530,7 +529,7 @@ export class TextureAtlas implements ITextureAtlas {
     let customGlyph = false;
     if (this._config.customGlyphs !== false) {
       const variantOffset = this._workAttributeData.getUnderlineVariantOffset();
-      customGlyph = tryDrawCustomGlyph(this._tmpCtx, chars, padding, padding, this._config.deviceCellWidth, this._config.deviceCellHeight, this._config.deviceCharWidth, this._config.deviceCharHeight, this._config.fontSize, this._config.devicePixelRatio, this._logService, backgroundColor.css, variantOffset);
+      customGlyph = tryDrawCustomGlyph(this._tmpCtx, chars, padding, padding, this._config.deviceCellWidth, this._config.deviceCellHeight, this._config.deviceCharWidth, this._config.deviceCharHeight, this._config.fontSize, this._config.devicePixelRatio, backgroundColor.css, variantOffset);
     }
 
     // Whether to clear pixels based on a threshold difference between the glyph color and the

addons/addon-webgl/src/Types.ts

@@ -4,10 +4,10 @@
  */
 
 import { FontWeight } from '@xterm/xterm';
-import { IColorSet } from '../../../src/browser/Types';
-import { ISelectionRenderModel } from '../../../src/browser/renderer/shared/Types';
-import { CursorInactiveStyle, CursorStyle, type IDisposable } from '../../../src/common/Types';
-import type { IEvent } from '../../../src/common/Event';
+import { IColorSet } from 'browser/Types';
+import { ISelectionRenderModel } from 'browser/renderer/shared/Types';
+import { CursorInactiveStyle, CursorStyle, type IDisposable } from 'common/Types';
+import type { IEvent } from 'common/Event';
 
 export interface IRenderModel {
   cells: Uint32Array;
@@ -28,7 +28,6 @@ export interface ICursorRenderModel {
 export interface IWebGL2RenderingContext extends WebGLRenderingContext {
   vertexAttribDivisor(index: number, divisor: number): void;
   createVertexArray(): IWebGLVertexArrayObject;
-  deleteVertexArray(vao: IWebGLVertexArrayObject): void;
   bindVertexArray(vao: IWebGLVertexArrayObject): void;
   drawElementsInstanced(mode: number, count: number, type: number, offset: number, instanceCount: number): void;
 }

addons/addon-webgl/src/WebglAddon.ts

@@ -5,14 +5,14 @@
 
 import type { ITerminalAddon, Terminal } from '@xterm/xterm';
 import type { IWebglAddonOptions, WebglAddon as IWebglApi } from '@xterm/addon-webgl';
-import { ICharacterJoinerService, ICharSizeService, ICoreBrowserService, IRenderService, IThemeService } from '../../../src/browser/services/Services';
-import { ITerminal } from '../../../src/browser/Types';
-import { Disposable, toDisposable } from '../../../src/common/Lifecycle';
-import { getSafariVersion, isSafari } from '../../../src/common/Platform';
-import { ICoreService, IDecorationService, ILogService, IOptionsService } from '../../../src/common/services/Services';
+import { ICharacterJoinerService, ICharSizeService, ICoreBrowserService, IRenderService, IThemeService } from 'browser/services/Services';
+import { ITerminal } from 'browser/Types';
+import { Disposable, toDisposable } from 'common/Lifecycle';
+import { getSafariVersion, isSafari } from 'common/Platform';
+import { ICoreService, IDecorationService, IOptionsService } from 'common/services/Services';
 import { IWebGL2RenderingContext } from './Types';
 import { WebglRenderer } from './WebglRenderer';
-import { Emitter, EventUtils } from '../../../src/common/Event';
+import { Emitter, EventUtils } from 'common/Event';
 
 export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi {
   private _terminal?: Terminal;
@@ -65,7 +65,6 @@ export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi
     const charSizeService: ICharSizeService = unsafeCore._charSizeService;
     const coreBrowserService: ICoreBrowserService = unsafeCore._coreBrowserService;
     const decorationService: IDecorationService = unsafeCore._decorationService;
-    const logService: ILogService = unsafeCore._logService;
     const themeService: IThemeService = unsafeCore._themeService;
 
     this._renderer = this._register(new WebglRenderer(
@@ -75,7 +74,6 @@ export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi
       coreBrowserService,
       coreService,
       decorationService,
-      logService,
       optionsService,
       themeService,
       this._customGlyphs,

addons/addon-webgl/src/WebglRenderer.ts

@@ -3,19 +3,19 @@
  * @license MIT
  */
 
-import { ITerminal } from '../../../src/browser/Types';
+import { ITerminal } from 'browser/Types';
 import { CellColorResolver } from './CellColorResolver';
 import { acquireTextureAtlas, removeTerminalFromCache } from './CharAtlasCache';
 import { CursorBlinkStateManager } from './CursorBlinkStateManager';
 import { observeDevicePixelDimensions } from './DevicePixelObserver';
-import { IRenderDimensions, IRenderer, IRequestRedrawEvent } from '../../../src/browser/renderer/shared/Types';
-import { ICharSizeService, ICharacterJoinerService, ICoreBrowserService, IThemeService } from '../../../src/browser/services/Services';
-import { CharData, IBufferLine, ICellData } from '../../../src/common/Types';
-import { AttributeData } from '../../../src/common/buffer/AttributeData';
-import { CellData } from '../../../src/common/buffer/CellData';
-import { Attributes, Content, FgFlags, NULL_CELL_CHAR, NULL_CELL_CODE } from '../../../src/common/buffer/Constants';
-import { TextBlinkStateManager } from '../../../src/browser/renderer/shared/TextBlinkStateManager';
-import { ICoreService, IDecorationService, ILogService, IOptionsService } from '../../../src/common/services/Services';
+import { IRenderDimensions, IRenderer, IRequestRedrawEvent } from 'browser/renderer/shared/Types';
+import { ICharSizeService, ICharacterJoinerService, ICoreBrowserService, IThemeService } from 'browser/services/Services';
+import { CharData, IBufferLine, ICellData } from 'common/Types';
+import { AttributeData } from 'common/buffer/AttributeData';
+import { CellData } from 'common/buffer/CellData';
+import { Attributes, Content, FgFlags, NULL_CELL_CHAR, NULL_CELL_CODE } from 'common/buffer/Constants';
+import { TextBlinkStateManager } from 'browser/renderer/shared/TextBlinkStateManager';
+import { ICoreService, IDecorationService, IOptionsService } from 'common/services/Services';
 import { Terminal } from '@xterm/xterm';
 import { GlyphRenderer } from './GlyphRenderer';
 import { RectangleRenderer } from './RectangleRenderer';
@@ -23,10 +23,10 @@ import { COMBINED_CHAR_BIT_MASK, RenderModel, RenderModelConstants } from './Ren
 import { IWebGL2RenderingContext, type ITextureAtlas } from './Types';
 import { LinkRenderLayer } from './renderLayer/LinkRenderLayer';
 import { IRenderLayer } from './renderLayer/Types';
-import { Emitter, EventUtils } from '../../../src/common/Event';
-import { addDisposableListener } from '../../../src/browser/Dom';
-import { combinedDisposable, Disposable, MutableDisposable, toDisposable } from '../../../src/common/Lifecycle';
-import { createRenderDimensions } from '../../../src/browser/renderer/shared/RendererUtils';
+import { Emitter, EventUtils } from 'common/Event';
+import { addDisposableListener } from 'browser/Dom';
+import { combinedDisposable, Disposable, MutableDisposable, toDisposable } from 'common/Lifecycle';
+import { createRenderDimensions } from 'browser/renderer/shared/RendererUtils';
 
 const enum Constants {
   MERGE_RETRY_LIMIT = 32
@@ -77,7 +77,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
     private readonly _coreBrowserService: ICoreBrowserService,
     private readonly _coreService: ICoreService,
     private readonly _decorationService: IDecorationService,
-    private readonly _logService: ILogService,
     private readonly _optionsService: IOptionsService,
     private readonly _themeService: IThemeService,
     private readonly _customGlyphs: boolean = true,
@@ -123,19 +122,19 @@ export class WebglRenderer extends Disposable implements IRenderer {
     this._deviceMaxTextureSize = this._gl.getParameter(this._gl.MAX_TEXTURE_SIZE);
 
     this._register(addDisposableListener(this._canvas, 'webglcontextlost', (e) => {
-      this._logService.debug('webglcontextlost event received');
+      console.log('webglcontextlost event received');
       // Prevent the default behavior in order to enable WebGL context restoration.
       e.preventDefault();
       // Wait a few seconds to see if the 'webglcontextrestored' event is fired.
       // If not, dispatch the onContextLoss notification to observers.
       this._contextRestorationTimeout = setTimeout(() => {
         this._contextRestorationTimeout = undefined;
-        this._logService.warn('webgl context not restored; firing onContextLoss');
+        console.warn('webgl context not restored; firing onContextLoss');
         this._onContextLoss.fire(e);
       }, 3000 /* ms */);
     }));
     this._register(addDisposableListener(this._canvas, 'webglcontextrestored', (e) => {
-      this._logService.warn('webglcontextrestored event received');
+      console.warn('webglcontextrestored event received');
       clearTimeout(this._contextRestorationTimeout);
       this._contextRestorationTimeout = undefined;
       // The texture atlas and glyph renderer must be fully reinitialized
@@ -159,8 +158,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
     this._isAttached = this._core.screenElement!.isConnected;
 
     this._register(toDisposable(() => {
-      clearTimeout(this._contextRestorationTimeout);
-      this._contextRestorationTimeout = undefined;
       for (const l of this._renderLayers) {
         l.dispose();
       }
@@ -277,8 +274,8 @@ export class WebglRenderer extends Disposable implements IRenderer {
    * Initializes members dependent on WebGL context state.
    */
   private _initializeWebGLState(): [RectangleRenderer, GlyphRenderer] {
-    this._rectangleRenderer.value = new RectangleRenderer(this._terminal, this._gl, this.dimensions, this._themeService, this._logService);
-    this._glyphRenderer.value = new GlyphRenderer(this._terminal, this._gl, this.dimensions, this._optionsService, this._logService);
+    this._rectangleRenderer.value = new RectangleRenderer(this._terminal, this._gl, this.dimensions, this._themeService);
+    this._glyphRenderer.value = new GlyphRenderer(this._terminal, this._gl, this.dimensions, this._optionsService);
 
     // Update dimensions and acquire char atlas
     this.handleCharSizeChanged();

addons/addon-webgl/src/WebglUtils.ts

@@ -3,8 +3,7 @@
  * @license MIT
  */
 
-import { throwIfFalsy } from '../../../src/browser/renderer/shared/RendererUtils';
-import type { ILogService } from '../../../src/common/services/Services';
+import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 
 /**
  * A matrix that when multiplies will translate 0-1 coordinates (left to right,
@@ -17,21 +16,21 @@ export const PROJECTION_MATRIX = new Float32Array([
   -1, 1, 0, 1
 ]);
 
-export function createProgram(gl: WebGLRenderingContext, vertexSource: string, fragmentSource: string, logService: ILogService): WebGLProgram | undefined {
+export function createProgram(gl: WebGLRenderingContext, vertexSource: string, fragmentSource: string): WebGLProgram | undefined {
   const program = throwIfFalsy(gl.createProgram());
-  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.VERTEX_SHADER, vertexSource, logService)));
-  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.FRAGMENT_SHADER, fragmentSource, logService)));
+  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.VERTEX_SHADER, vertexSource)));
+  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.FRAGMENT_SHADER, fragmentSource)));
   gl.linkProgram(program);
   const success = gl.getProgramParameter(program, gl.LINK_STATUS);
   if (success) {
     return program;
   }
 
-  logService.error(gl.getProgramInfoLog(program));
+  console.error(gl.getProgramInfoLog(program));
   gl.deleteProgram(program);
 }
 
-export function createShader(gl: WebGLRenderingContext, type: number, source: string, logService: ILogService): WebGLShader | undefined {
+export function createShader(gl: WebGLRenderingContext, type: number, source: string): WebGLShader | undefined {
   const shader = throwIfFalsy(gl.createShader(type));
   gl.shaderSource(shader, source);
   gl.compileShader(shader);
@@ -40,7 +39,7 @@ export function createShader(gl: WebGLRenderingContext, type: number, source: st
     return shader;
   }
 
-  logService.error(gl.getShaderInfoLog(shader));
+  console.error(gl.getShaderInfoLog(shader));
   gl.deleteShader(shader);
 }
 

addons/addon-webgl/src/customGlyphs/CustomGlyphRasterizer.ts

@@ -3,8 +3,7 @@
  * @license MIT
  */
 
-import { throwIfFalsy } from '../../../../src/browser/renderer/shared/RendererUtils';
-import type { ILogService } from '../../../../src/common/services/Services';
+import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 import { customGlyphDefinitions } from './CustomGlyphDefinitions';
 import { CustomGlyphDefinitionType, CustomGlyphScaleType, CustomGlyphVectorType, type CustomGlyphDefinitionPart, type CustomGlyphPathDrawFunctionDefinition, type CustomGlyphPatternDefinition, type ICustomGlyphSolidOctantBlockVector, type ICustomGlyphVectorShape } from './Types';
 
@@ -23,7 +22,6 @@ export function tryDrawCustomGlyph(
   deviceCharHeight: number,
   fontSize: number,
   devicePixelRatio: number,
-  logService: ILogService,
   backgroundColor?: string,
   variantOffset: number = 0
 ): boolean {
@@ -32,7 +30,7 @@ export function tryDrawCustomGlyph(
     // Normalize to array for uniform handling
     const parts = Array.isArray(unifiedCharDefinition) ? unifiedCharDefinition : [unifiedCharDefinition];
     for (const part of parts) {
-      drawDefinitionPart(ctx, part, xOffset, yOffset, deviceCellWidth, deviceCellHeight, deviceCharWidth, deviceCharHeight, fontSize, devicePixelRatio, logService, backgroundColor, variantOffset);
+      drawDefinitionPart(ctx, part, xOffset, yOffset, deviceCellWidth, deviceCellHeight, deviceCharWidth, deviceCharHeight, fontSize, devicePixelRatio, backgroundColor, variantOffset);
     }
     return true;
   }
@@ -51,7 +49,6 @@ function drawDefinitionPart(
   deviceCharHeight: number,
   fontSize: number,
   devicePixelRatio: number,
-  logService: ILogService,
   backgroundColor?: string,
   variantOffset: number = 0
 ): void {
@@ -82,7 +79,7 @@ function drawDefinitionPart(
       drawPatternChar(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, variantOffset);
       break;
     case CustomGlyphDefinitionType.PATH_FUNCTION:
-      drawPathFunctionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, logService, part.strokeWidth);
+      drawPathFunctionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, part.strokeWidth);
       break;
     case CustomGlyphDefinitionType.PATH:
       drawPathDefinitionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, part.strokeWidth);
@@ -91,7 +88,7 @@ function drawDefinitionPart(
       drawPathNegativeDefinitionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, backgroundColor);
       break;
     case CustomGlyphDefinitionType.VECTOR_SHAPE:
-      drawVectorShape(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, fontSize, devicePixelRatio, logService);
+      drawVectorShape(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, fontSize, devicePixelRatio);
       break;
     case CustomGlyphDefinitionType.BRAILLE:
       drawBrailleCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight);
@@ -513,7 +510,6 @@ function drawPathFunctionCharacter(
   deviceCellWidth: number,
   deviceCellHeight: number,
   devicePixelRatio: number,
-  logService: ILogService,
   strokeWidth?: number
 ): void {
   ctx.save();
@@ -540,7 +536,7 @@ function drawPathFunctionCharacter(
     }
     const f = svgToCanvasInstructionMap[type];
     if (!f) {
-      logService.error(`Could not find drawing instructions for "${type}"`);
+      console.error(`Could not find drawing instructions for "${type}"`);
       continue;
     }
     const args: string[] = instruction.substring(1).split(',');
@@ -602,8 +598,7 @@ function drawVectorShape(
   deviceCellWidth: number,
   deviceCellHeight: number,
   fontSize: number,
-  devicePixelRatio: number,
-  logService: ILogService
+  devicePixelRatio: number
 ): void {
   // Clip the cell to make sure drawing doesn't occur beyond bounds
   const clipRegion = new Path2D();
@@ -624,7 +619,7 @@ function drawVectorShape(
     }
     const f = svgToCanvasInstructionMap[type];
     if (!f) {
-      logService.error(`Could not find drawing instructions for "${type}"`);
+      console.error(`Could not find drawing instructions for "${type}"`);
       continue;
     }
     const args: string[] = instruction.substring(1).split(',');

addons/addon-webgl/src/renderLayer/BaseRenderLayer.ts

@@ -3,16 +3,16 @@
  * @license MIT
  */
 
-import { ReadonlyColorSet } from '../../../../src/browser/Types';
+import { ReadonlyColorSet } from 'browser/Types';
 import { acquireTextureAtlas } from '../CharAtlasCache';
-import { IRenderDimensions } from '../../../../src/browser/renderer/shared/Types';
-import { ICoreBrowserService, IThemeService } from '../../../../src/browser/services/Services';
-import { Disposable, toDisposable } from '../../../../src/common/Lifecycle';
-import { CellData } from '../../../../src/common/buffer/CellData';
-import { IOptionsService } from '../../../../src/common/services/Services';
+import { IRenderDimensions } from 'browser/renderer/shared/Types';
+import { ICoreBrowserService, IThemeService } from 'browser/services/Services';
+import { Disposable, toDisposable } from 'common/Lifecycle';
+import { CellData } from 'common/buffer/CellData';
+import { IOptionsService } from 'common/services/Services';
 import { Terminal } from '@xterm/xterm';
 import { IRenderLayer } from './Types';
-import { throwIfFalsy } from '../../../../src/browser/renderer/shared/RendererUtils';
+import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 import { TEXT_BASELINE } from '../Constants';
 import type { ITextureAtlas } from '../Types';
 

addons/addon-webgl/src/renderLayer/LinkRenderLayer.ts

@@ -4,11 +4,11 @@
  */
 
 import { is256Color } from '../CharAtlasUtils';
-import { INVERTED_DEFAULT_COLOR } from '../../../../src/browser/renderer/shared/Constants';
-import { IRenderDimensions } from '../../../../src/browser/renderer/shared/Types';
-import { ICoreBrowserService, IThemeService } from '../../../../src/browser/services/Services';
-import { ILinkifier2, ILinkifierEvent } from '../../../../src/browser/Types';
-import { IOptionsService } from '../../../../src/common/services/Services';
+import { INVERTED_DEFAULT_COLOR } from 'browser/renderer/shared/Constants';
+import { IRenderDimensions } from 'browser/renderer/shared/Types';
+import { ICoreBrowserService, IThemeService } from 'browser/services/Services';
+import { ILinkifier2, ILinkifierEvent } from 'browser/Types';
+import { IOptionsService } from 'common/services/Services';
 import { Terminal } from '@xterm/xterm';
 import { BaseRenderLayer } from './BaseRenderLayer';
 

addons/addon-webgl/src/renderLayer/Types.ts

@@ -4,7 +4,7 @@
  */
 
 import { IDisposable, Terminal } from '@xterm/xterm';
-import { IRenderDimensions } from '../../../../src/browser/renderer/shared/Types';
+import { IRenderDimensions } from 'browser/renderer/shared/Types';
 
 export interface IRenderLayer extends IDisposable {
   /**

addons/addon-webgl/src/tsconfig.json

@@ -10,6 +10,20 @@
     "outDir": "../out",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "@xterm/addon-webgl": [
+        "../typings/addon-webgl.d.ts"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "downlevelIteration": true,
     "experimentalDecorators": true,
@@ -19,8 +33,7 @@
   },
   "include": [
     "./**/*",
-    "../../../typings/xterm.d.ts",
-    "../typings/addon-webgl.d.ts"
+    "../../../typings/xterm.d.ts"
   ],
   "references": [
     {

addons/addon-webgl/test/tsconfig.json

@@ -3,12 +3,23 @@
     "module": "commonjs",
     "target": "ESNext",
     "lib": [
-      "es2021"
+      "es2021",
     ],
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,
     "removeComments": true,
+    "paths": {
+      "common/*": [
+        "../../../src/common/*"
+      ],
+      "browser/*": [
+        "../../../src/browser/*"
+      ],
+      "*": [
+        "./*"
+      ]
+    },
     "strict": true,
     "types": [
       "../../../node_modules/@types/node",

addons/addon-webgl/tsconfig.json

@@ -2,11 +2,7 @@
   "files": [],
   "include": [],
   "references": [
-    {
-      "path": "./src"
-    },
-    {
-      "path": "./test"
-    }
+    { "path": "./src" },
+    { "path": "./test" }
   ]
 }

bin/esbuild.mjs

@@ -107,20 +107,13 @@ if (config.addon) {
   };
   outConfig = {
     ...outConfig,
-    bundle: true,
-    platform: 'node',
-    packages: 'external',
     entryPoints: [`addons/addon-${config.addon}/src/**/*.ts`],
-    outdir: `addons/addon-${config.addon}/out-esbuild/`,
-    // Public API stays external; src/common|browser are bundled from source.
-    external: ['@xterm/xterm', '@xterm/headless', '@xterm/addon-*'],
+    outdir: `addons/addon-${config.addon}/out-esbuild/`
   };
-  // Playwright suites only (not run by unit tests); keep unbundled.
   outTestConfig = {
-    format: 'cjs',
-    sourcemap: true,
+    ...outConfig,
     entryPoints: [`addons/addon-${config.addon}/test/**/*.ts`],
-    outdir: `addons/addon-${config.addon}/out-esbuild-test/`,
+    outdir: `addons/addon-${config.addon}/out-esbuild-test/`
   };
 
   if (config.addon === 'ligatures') {

bin/esbuild_all.mjs

@@ -7,30 +7,19 @@ import { argv } from "process";
 /** @type {{cp: import("child_process").ChildProcessByStdio<any, any, any>, name: string}[]} */
 const jobs = [];
 
-// Core job must finish before addons (addon tests resolve src/* via out-esbuild).
-const xtermJob = createJob('xterm', []);
-const xtermCode = await new Promise(r => {
-  xtermJob.cp.on('exit', code => {
-    log(`Finished \x1b[32m${xtermJob.name}\x1b[0m${code ? ' \x1b[31mwith errors\x1b[0m' : ''}`);
-    r(code ?? 1);
-  });
-});
-if (xtermCode !== 0) {
-  process.exit(xtermCode);
-}
+// Core job
+jobs.push(createJob('xterm', []));
 
 // Addon jobs
 const addons = (await readdir('addons')).filter(e => e.startsWith('addon-')).map(e => e.replace('addon-', ''));
-/** @type {{cp: import("child_process").ChildProcessByStdio<any, any, any>, name: string}[]} */
-const addonJobs = [];
 for (const addon of addons) {
-  addonJobs.push(createJob(`xterm-addon-${addon}`, [`--addon=${addon}`]));
+  jobs.push(createJob(`xterm-addon-${addon}`, [`--addon=${addon}`]));
 }
 
 // Demo job - This requires the others to be built so it's not included when building all
 // jobs.push(createJob('demo-client', [`--demo-client`]));
 
-await Promise.all(addonJobs.map(job => {
+await Promise.all(jobs.map((job, i) => {
   return new Promise(r => {
     job.cp.on('exit', code => {
       log(`Finished \x1b[32m${job.name}\x1b[0m${code ? ' \x1b[31mwith errors\x1b[0m' : ''}`);

bin/test_unit.js

@@ -8,7 +8,7 @@ const path = require('path');
 
 const COVERAGE_LINES_THRESHOLD = 40;
 
-// Add `out-esbuild` to NODE_PATH for any remaining non-relative requires in test bundles.
+// Add `out` to the NODE_PATH so absolute paths can be resolved.
 const env = { ...process.env };
 env.NODE_PATH = path.resolve(__dirname, '../out-esbuild');
 

demo/client/components/window/optionsWindow.ts

@@ -6,7 +6,7 @@
 import { BaseWindow } from './baseWindow';
 import type { Terminal, ITheme } from '@xterm/xterm';
 import type { IControlWindow } from '../controlBar';
-import type { AddonCollection } from '../../types';
+import type { AddonCollection } from 'types';
 
 const xtermjsTheme: ITheme = Object.freeze({
   foreground: '#F8F8F8',

demo/client/components/window/testWindow.ts

@@ -7,7 +7,7 @@ import { writeUnicodeTable } from '../../unicodeTable';
 import type { IControlWindow } from '../controlBar';
 import { BaseWindow } from './baseWindow';
 import type { IDisposable, Terminal } from '@xterm/xterm';
-import type { AddonCollection } from '../../types';
+import type { AddonCollection } from 'types';
 
 export class TestWindow extends BaseWindow implements IControlWindow {
   public readonly id = 'test';

demo/client/tsconfig.json

@@ -6,7 +6,23 @@
     "rootDir": ".",
     "sourceMap": true,
     "strict": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "paths": {
+      "@xterm/addon-attach": ["../../addons/addon-attach"],
+      "@xterm/addon-clipboard": ["../../addons/addon-clipboard"],
+      "@xterm/addon-fit": ["../../addons/addon-fit"],
+      "@xterm/addon-image": ["../../addons/addon-image"],
+      "@xterm/addon-progress": ["../../addons/addon-progress"],
+      "@xterm/addon-search": ["../../addons/addon-search"],
+      "@xterm/addon-serialize": ["../../addons/addon-serialize"],
+      "@xterm/addon-web-fonts": ["../../addons/addon-web-fonts"],
+      "@xterm/addon-web-links": ["../../addons/addon-web-links"],
+      "@xterm/addon-webgl": ["../../addons/addon-webgl"],
+      "@xterm/addon-unicode11": ["../../addons/addon-unicode11"],
+      "@xterm/addon-unicode-graphemes": ["../../addons/addon-unicode-graphemes"],
+      "@xterm/addon-ligatures": ["../../addons/addon-ligatures"],
+      "*": ["./*"]
+    }
   },
   "include": [
     "./**/*",

demo/server/tsconfig.json

@@ -9,6 +9,6 @@
     "skipLibCheck": true
   },
   "include": [
-    "./**/*"
+    "./**/*",
   ]
 }

demo/tsconfig.json

@@ -1,11 +1,7 @@
 {
   "references": [
-    {
-      "path": "./client"
-    },
-    {
-      "path": "./server"
-    }
+    { "path": "./client" },
+    { "path": "./server" }
   ],
   "files": []
 }

eslint.config.mjs

@@ -43,7 +43,6 @@ export default tseslint.config(
         singleline: { delimiter: 'comma', requireLast: false }
       }],
       '@stylistic/type-annotation-spacing': 'warn',
-      '@stylistic/space-unary-ops': 'warn',
 
       '@typescript-eslint/array-type': ['warn', { default: 'array', readonly: 'generic' }],
       '@typescript-eslint/consistent-type-assertions': 'warn',
@@ -86,7 +85,6 @@ export default tseslint.config(
       'eqeqeq': ['warn', 'always'],
       'jsdoc/check-alignment': 'warn',
       'jsdoc/check-param-names': 'warn',
-      'jsdoc/multiline-blocks': 'warn',
       'jsdoc/no-multi-asterisks': 'warn',
       'keyword-spacing': 'warn',
       'max-len': ['warn', {

headless/package.json

@@ -3,13 +3,15 @@
  "description": "A headless terminal component that runs in Node.js",
  "version": "6.0.0",
  "main": "lib-headless/xterm-headless.js",
- "module": "lib/xterm.mjs",
+ "module": "lib-headless/xterm-headless.mjs",
  "types": "typings/xterm-headless.d.ts",
+ "exports": {
+  "types": "./typings/xterm-headless.d.ts",
+  "import": "./lib-headless/xterm-headless.mjs",
+  "require": "./lib-headless/xterm-headless.js"
+ },
  "repository": "https://github.com/xtermjs/xterm.js",
  "license": "MIT",
- "workspaces": [
-  "addons/*"
- ],
  "keywords": [
   "cli",
   "command-line",
@@ -25,4 +27,4 @@
   "webgl",
   "xterm"
  ]
-}
+}

headless/test-node-load.cjs

@@ -1,39 +0,0 @@
-/**
- * Smoke test: @xterm/headless loads and runs in Node.js (require).
- */
-const { strictEqual } = require('node:assert');
-const { Terminal } = require('./lib-headless/xterm-headless.js');
-
-function writeSync(term, data) {
-  return new Promise(resolve => term.write(data, resolve));
-}
-
-function lineEquals(term, index, text) {
-  strictEqual(term.buffer.active.getLine(index).translateToString(true), text);
-}
-
-(async () => {
-  const term = new Terminal({ cols: 80, rows: 24, allowProposedApi: true });
-  strictEqual(term.cols, 80);
-  strictEqual(term.rows, 24);
-
-  await writeSync(term, 'hello from node');
-  lineEquals(term, 0, 'hello from node');
-
-  await writeSync(term, 'foo');
-  await writeSync(term, 'bar');
-  await writeSync(term, '文');
-  lineEquals(term, 0, 'hello from nodefoobar文');
-
-  term.resize(60, 15);
-  strictEqual(term.cols, 60);
-  strictEqual(term.rows, 15);
-
-  term.dispose();
-  strictEqual(term._core._store.isDisposed, true);
-
-  console.log('headless package (CJS): load, write, buffer, resize, dispose OK');
-})().catch(err => {
-  console.error(err);
-  process.exit(1);
-});