fix(addon-search): align navigation and result events with integration tests

- Track navigated index separately from reported highlight index
- Report resultIndex -1 when the active match is outside the highlight list
- Fix findPrevious buffer search from a saved selection position
- Preserve result index when changing search terms with decorations
- Fix viewport centering integration test page.evaluate syntax

Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

.github/workflows/ci.yml

@@ -11,9 +11,9 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js 22.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: 22.x
         cache: 'npm'
@@ -69,7 +69,7 @@ jobs:
           ./addons/addon-webgl/out/* \
           ./addons/addon-webgl/out-*st/*
     - name: Upload artifacts
-      uses: actions/upload-artifact@v6
+      uses: actions/upload-artifact@v4
       with:
         name: build-artifacts
         path: compressed-build.zip
@@ -79,9 +79,9 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js 22.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: 22.x
         cache: 'npm'
@@ -100,16 +100,16 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js 22.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: 22.x
         cache: 'npm'
     - name: Install dependencies
       run: |
         npm ci
-    - uses: actions/download-artifact@v7
+    - uses: actions/download-artifact@v4
       with:
         name: build-artifacts
     - name: Unzip artifacts
@@ -129,7 +129,6 @@ jobs:
         exit $EXIT_CODE
 
   test-unit:
-    needs: build
     timeout-minutes: 20
     strategy:
       matrix:
@@ -137,16 +136,21 @@ jobs:
         runs-on: [ubuntu, macos, windows]
     runs-on: ${{ matrix.runs-on }}-latest
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js ${{ matrix.node-version }}.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node-version }}.x
         cache: 'npm'
     - name: Install dependencies
       run: |
         npm ci
-    - uses: actions/download-artifact@v7
+    - name: Wait for build job
+      uses: NathanFirmo/wait-for-other-job@v1.1.1
+      with:
+        token: ${{ secrets.GITHUB_TOKEN }}
+        job: build
+    - uses: actions/download-artifact@v4
       with:
         name: build-artifacts
     - name: Unzip artifacts
@@ -162,7 +166,6 @@ jobs:
       run: npm run test-unit --forbid-only
 
   test-integration:
-    needs: build
     timeout-minutes: 20
     strategy:
       matrix:
@@ -171,9 +174,9 @@ jobs:
         browser: [chromium, firefox, webkit]
     runs-on: ${{ matrix.runs-on }}
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js ${{ matrix.node-version }}.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node-version }}.x
         cache: 'npm'
@@ -182,7 +185,12 @@ jobs:
         npm ci
     - name: Install playwright
       run: npx playwright install --with-deps ${{ matrix.browser }}
-    - uses: actions/download-artifact@v7
+    - name: Wait for build job
+      uses: NathanFirmo/wait-for-other-job@v1.1.1
+      with:
+        token: ${{ secrets.GITHUB_TOKEN }}
+        job: build
+    - uses: actions/download-artifact@v4
       with:
         name: build-artifacts
     - name: Unzip artifacts
@@ -232,9 +240,9 @@ jobs:
       matrix:
         node-version: [22]
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js ${{ matrix.node-version }}.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node-version }}.x
         cache: 'npm'
@@ -243,7 +251,7 @@ jobs:
         npm ci
     - name: Install playwright
       run: npx playwright install
-    - uses: actions/download-artifact@v7
+    - uses: actions/download-artifact@v4
       with:
         name: build-artifacts
     - name: Unzip artifacts

.github/workflows/codeql-analysis.yml

@@ -24,12 +24,12 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v5
+      uses: actions/checkout@v3
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v4
+      uses: github/codeql-action/init@v2
       with:
         languages: ${{ matrix.language }}
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v4
+      uses: github/codeql-action/autobuild@v2
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v4
+      uses: github/codeql-action/analyze@v2

.github/workflows/copilot-setup-steps.yml

@@ -18,9 +18,9 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v4
       - name: Use Node.js 22.x
-        uses: actions/setup-node@v5
+        uses: actions/setup-node@v3
         with:
           node-version: 22.x
           cache: 'npm'

.github/workflows/release.yml

@@ -10,9 +10,9 @@ jobs:
   release:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@v3
     - name: Use Node.js 22.x
-      uses: actions/setup-node@v5
+      uses: actions/setup-node@v3
       with:
         node-version: 22.x
         cache: 'npm'

.gitignore

@@ -3,6 +3,7 @@ node_modules/
 .lock-wscript
 lib/
 out/
+out-benchmark/
 out-demo/
 out-test/
 out-esbuild/
@@ -17,7 +18,6 @@ docs/
 npm-debug.log
 /.idea/
 .env
-mise.toml
 build/
 .DS_Store
 yarn.lock
@@ -25,7 +25,6 @@ test-results/
 
 # Tracing/debug files
 .cursor/nal-trace/
-.cursor/*.log
 
 # Keep bundled code out of Git
 dist/

.oxlintrc.json

@@ -1,374 +0,0 @@
-{
-  "$schema": "./node_modules/oxlint/configuration_schema.json",
-  "plugins": [
-    "import",
-    "typescript"
-  ],
-  "categories": {
-    "correctness": "off"
-  },
-  "options": {
-    "typeAware": true,
-    "maxWarnings": 0
-  },
-  "env": {
-    "builtin": true
-  },
-  "ignorePatterns": [
-    "addons/*/src/third-party/*.ts",
-    "**/out/*",
-    "**/out-test/*",
-    "**/out-esbuild/*",
-    "**/out-esbuild-test/*",
-    "**/inwasm-sdks/*",
-    "**/typings/*.d.ts",
-    "**/node_modules",
-    "**/*.js",
-    "**/*.mjs"
-  ],
-  "rules": {
-    "constructor-super": "error",
-    "for-direction": "error",
-    "getter-return": "error",
-    "no-async-promise-executor": "error",
-    "no-case-declarations": "error",
-    "no-class-assign": "error",
-    "no-compare-neg-zero": "error",
-    "no-cond-assign": "error",
-    "no-const-assign": "error",
-    "no-constant-binary-expression": "error",
-    "no-constant-condition": "error",
-    "no-control-regex": "error",
-    "no-debugger": "error",
-    "no-delete-var": "error",
-    "no-dupe-class-members": "error",
-    "no-dupe-else-if": "error",
-    "no-dupe-keys": "error",
-    "no-duplicate-case": "error",
-    "no-empty": "error",
-    "no-empty-character-class": "error",
-    "no-empty-pattern": "error",
-    "no-empty-static-block": "error",
-    "no-ex-assign": "error",
-    "no-extra-boolean-cast": "error",
-    "no-fallthrough": "error",
-    "no-func-assign": "error",
-    "no-global-assign": "error",
-    "no-import-assign": "error",
-    "no-invalid-regexp": "error",
-    "no-irregular-whitespace": "error",
-    "no-loss-of-precision": "error",
-    "no-misleading-character-class": "error",
-    "no-new-native-nonconstructor": "error",
-    "no-nonoctal-decimal-escape": "error",
-    "no-obj-calls": "error",
-    "no-prototype-builtins": "error",
-    "no-redeclare": "error",
-    "no-regex-spaces": "error",
-    "no-self-assign": "error",
-    "no-setter-return": "error",
-    "no-shadow-restricted-names": "error",
-    "no-sparse-arrays": "error",
-    "no-this-before-super": "error",
-    "no-unassigned-vars": "error",
-    "no-unexpected-multiline": "error",
-    "no-unreachable": "error",
-    "no-unsafe-finally": "error",
-    "no-unsafe-negation": "error",
-    "no-unsafe-optional-chaining": "error",
-    "no-unused-labels": "error",
-    "no-unused-private-class-members": "error",
-    "no-unused-vars": "error",
-    "no-useless-backreference": "error",
-    "no-useless-catch": "error",
-    "no-useless-escape": "error",
-    "no-with": "error",
-    "preserve-caught-error": "error",
-    "require-yield": "error",
-    "use-isnan": "error",
-    "valid-typeof": "error",
-    "no-array-constructor": "error",
-    "no-unused-expressions": "error",
-    "typescript/ban-ts-comment": "error",
-    "typescript/no-duplicate-enum-values": "error",
-    "typescript/no-empty-object-type": "error",
-    "typescript/no-explicit-any": "error",
-    "typescript/no-extra-non-null-assertion": "error",
-    "typescript/no-misused-new": "error",
-    "typescript/no-namespace": "error",
-    "typescript/no-non-null-asserted-optional-chain": "error",
-    "typescript/no-require-imports": "error",
-    "typescript/no-this-alias": "error",
-    "typescript/no-unnecessary-type-constraint": "error",
-    "typescript/no-unsafe-declaration-merging": "error",
-    "typescript/no-unsafe-function-type": "error",
-    "typescript/no-wrapper-object-types": "error",
-    "typescript/prefer-as-const": "error",
-    "typescript/prefer-namespace-keyword": "error",
-    "typescript/triple-slash-reference": "error",
-    "import/no-cycle": "error"
-  },
-  "overrides": [
-    {
-      "files": [
-        "**/*.ts",
-        "**/*.tsx",
-        "**/*.mts",
-        "**/*.cts"
-      ],
-      "rules": {
-        "constructor-super": "off",
-        "getter-return": "off",
-        "no-class-assign": "off",
-        "no-const-assign": "off",
-        "no-dupe-class-members": "off",
-        "no-dupe-keys": "off",
-        "no-func-assign": "off",
-        "no-import-assign": "off",
-        "no-new-native-nonconstructor": "off",
-        "no-obj-calls": "off",
-        "no-redeclare": "off",
-        "no-setter-return": "off",
-        "no-this-before-super": "off",
-        "no-unreachable": "off",
-        "no-unsafe-negation": "off",
-        "no-var": "error",
-        "no-with": "off",
-        "prefer-const": "error",
-        "prefer-rest-params": "error",
-        "prefer-spread": "error"
-      }
-    },
-    {
-      "files": [
-        "**/*.ts"
-      ],
-      "jsPlugins": [
-        "@stylistic/eslint-plugin",
-        {
-          "name": "jsdoc-js",
-          "specifier": "eslint-plugin-jsdoc"
-        },
-        "oxlint-plugin-eslint"
-      ],
-      "rules": {
-        "@stylistic/comma-spacing": [
-          "warn",
-          {
-            "before": false,
-            "after": true
-          }
-        ],
-        "@stylistic/indent": [
-          "warn",
-          2
-        ],
-        "@stylistic/semi": [
-          "warn",
-          "always"
-        ],
-        "@stylistic/quotes": [
-          "warn",
-          "single",
-          {
-            "allowTemplateLiterals": "always"
-          }
-        ],
-        "@stylistic/member-delimiter-style": [
-          "warn",
-          {
-            "multiline": {
-              "delimiter": "semi",
-              "requireLast": true
-            },
-            "singleline": {
-              "delimiter": "comma",
-              "requireLast": false
-            }
-          }
-        ],
-        "@stylistic/type-annotation-spacing": "warn",
-        "@stylistic/space-unary-ops": "warn",
-        "@stylistic/keyword-spacing": "warn",
-        "@stylistic/max-len": [
-          "warn",
-          {
-            "code": 1000,
-            "comments": 100,
-            "ignoreTrailingComments": true,
-            "ignoreUrls": true,
-            "ignorePattern": "^ *((?<vt_comment>(//|\\*) @vt)|(?<table_comment>\\* \\| )|(?<commented_code>//  ))"
-          }
-        ],
-        "@stylistic/new-parens": "warn",
-        "@stylistic/no-extra-semi": "error",
-        "@stylistic/no-trailing-spaces": "warn",
-        "eslint-js/object-curly-spacing": [
-          "warn",
-          "always"
-        ],
-        "@stylistic/spaced-comment": [
-          "warn",
-          "always",
-          {
-            "markers": [
-              "/"
-            ],
-            "exceptions": [
-              "-"
-            ]
-          }
-        ],
-        "jsdoc-js/check-alignment": "warn",
-        "jsdoc-js/check-param-names": "warn",
-        "jsdoc-js/multiline-blocks": "warn",
-        "jsdoc-js/no-multi-asterisks": "warn",
-        "eslint-js/one-var": [
-          "warn",
-          "never"
-        ],
-        "eslint-js/no-restricted-syntax": [
-          "warn",
-          {
-            "selector": "CallExpression[callee.name='requestAnimationFrame']",
-            "message": "The global requestAnimationFrame() should be avoided, call it on the parent window from ICoreBrowserService."
-          },
-          {
-            "selector": "CallExpression[callee.name='cancelAnimationFrame']",
-            "message": "The global cancelAnimationFrame() should be avoided, call it on the parent window from ICoreBrowserService."
-          },
-          {
-            "selector": "CallExpression > MemberExpression[object.name='window'][property.name='requestAnimationFrame']",
-            "message": "window.requestAnimationFrame() should be avoided, call it on the parent window from ICoreBrowserService."
-          },
-          {
-            "selector": "CallExpression > MemberExpression[object.name='window'][property.name='cancelAnimationFrame']",
-            "message": "window.cancelAnimationFrame() should be avoided, call it on the parent window from ICoreBrowserService."
-          },
-          {
-            "selector": "MemberExpression[object.name='window'][property.name='devicePixelRatio']",
-            "message": "window.devicePixelRatio should be avoided, get it from ICoreBrowserService."
-          }
-        ],
-        "curly": [
-          "warn",
-          "multi-line"
-        ],
-        "eqeqeq": [
-          "warn",
-          "always"
-        ],
-        "no-duplicate-imports": "warn",
-        "no-else-return": [
-          "warn",
-          {
-            "allowElseIf": false
-          }
-        ],
-        "no-eval": "warn",
-        "no-irregular-whitespace": "warn",
-        "no-restricted-imports": [
-          "warn",
-          {
-            "patterns": [
-              ".*\\/out\\/.*"
-            ]
-          }
-        ],
-        "no-unsafe-finally": "warn",
-        "no-unused-vars": "off",
-        "no-var": "warn",
-        "no-empty": "off",
-        "no-empty-pattern": "off",
-        "no-cond-assign": "off",
-        "no-case-declarations": "off",
-        "for-direction": "off",
-        "no-prototype-builtins": "off",
-        "no-useless-escape": "off",
-        "no-self-assign": "off",
-        "no-async-promise-executor": "off",
-        "prefer-rest-params": "off",
-        "no-control-regex": "off",
-        "no-fallthrough": "off",
-        "prefer-spread": "off",
-        "prefer-const": "warn",
-        "no-unused-expressions": "off",
-        "typescript/array-type": [
-          "warn",
-          {
-            "default": "array",
-            "readonly": "generic"
-          }
-        ],
-        "typescript/consistent-type-assertions": "warn",
-        "typescript/consistent-type-definitions": "warn",
-        "typescript/explicit-function-return-type": [
-          "warn",
-          {
-            "allowExpressions": true
-          }
-        ],
-        "typescript/explicit-member-accessibility": [
-          "warn",
-          {
-            "accessibility": "explicit",
-            "overrides": {
-              "constructors": "off"
-            }
-          }
-        ],
-        "typescript/no-confusing-void-expression": [
-          "warn",
-          {
-            "ignoreArrowShorthand": true
-          }
-        ],
-        "typescript/no-useless-constructor": "warn",
-        "typescript/prefer-nullish-coalescing": [
-          "warn",
-          {
-            "ignorePrimitives": true
-          }
-        ],
-        "typescript/prefer-namespace-keyword": "warn",
-        "typescript/no-unused-vars": [
-          "warn",
-          {
-            "vars": "all",
-            "args": "none"
-          }
-        ],
-        "typescript/no-require-imports": "off",
-        "typescript/no-explicit-any": "off",
-        "typescript/no-wrapper-object-types": "off",
-        "typescript/no-empty-object-type": "off",
-        "typescript/no-unsafe-function-type": "off",
-        "typescript/no-this-alias": "off",
-        "typescript/no-namespace": "off",
-        "typescript/no-duplicate-enum-values": "off"
-      }
-    },
-    {
-      "files": [
-        "**/*.api.ts",
-        "**/*.test.ts"
-      ],
-      "rules": {
-        "eslint-js/object-curly-spacing": "off",
-        "@stylistic/max-len": "off",
-        "typescript/no-unused-vars": "off",
-        "typescript/explicit-function-return-type": "off",
-        "typescript/explicit-member-accessibility": "off"
-      }
-    },
-    {
-      "files": [
-        "demo/**/*.ts",
-        "**/*.benchmark.ts"
-      ],
-      "rules": {
-        "typescript/prefer-nullish-coalescing": "off"
-      }
-    }
-  ]
-}

.oxlintrc.typings.json

@@ -1,120 +0,0 @@
-{
-  "$schema": "./node_modules/oxlint/configuration_schema.json",
-  "options": {
-    "maxWarnings": 0
-  },
-  "env": {
-    "builtin": true
-  },
-  "overrides": [
-    {
-      "files": [
-        "typings/**/*.d.ts"
-      ],
-      "plugins": [
-        "typescript"
-      ],
-      "jsPlugins": [
-        "@stylistic/eslint-plugin",
-        {
-          "name": "jsdoc-js",
-          "specifier": "eslint-plugin-jsdoc"
-        },
-        "oxlint-plugin-eslint"
-      ],
-      "rules": {
-        "@stylistic/indent": [
-          "warn",
-          2
-        ],
-        "@stylistic/semi": [
-          "warn",
-          "always"
-        ],
-        "@stylistic/quotes": [
-          "warn",
-          "single",
-          {
-            "allowTemplateLiterals": "always"
-          }
-        ],
-        "@stylistic/member-delimiter-style": [
-          "warn",
-          {
-            "multiline": {
-              "delimiter": "semi",
-              "requireLast": true
-            },
-            "singleline": {
-              "delimiter": "comma",
-              "requireLast": false
-            }
-          }
-        ],
-        "@stylistic/type-annotation-spacing": "warn",
-        "@stylistic/keyword-spacing": "warn",
-        "@stylistic/max-len": [
-          "warn",
-          {
-            "code": 1000,
-            "comments": 80,
-            "ignoreUrls": true,
-            "ignorePattern": "^ *(?<ps_description>\\* Ps=)"
-          }
-        ],
-        "@stylistic/no-extra-semi": "error",
-        "@stylistic/no-trailing-spaces": "warn",
-        "eslint-js/object-curly-spacing": [
-          "warn",
-          "always"
-        ],
-        "@stylistic/spaced-comment": [
-          "warn",
-          "always",
-          {
-            "markers": [
-              "/"
-            ],
-            "exceptions": [
-              "-"
-            ]
-          }
-        ],
-        "@stylistic/comma-dangle": [
-          "warn",
-          {
-            "objects": "never",
-            "arrays": "never",
-            "functions": "never"
-          }
-        ],
-        "@stylistic/eol-last": "warn",
-        "curly": [
-          "warn",
-          "multi-line"
-        ],
-        "eqeqeq": [
-          "warn",
-          "always"
-        ],
-        "jsdoc-js/check-alignment": "warn",
-        "jsdoc-js/check-param-names": "warn",
-        "no-irregular-whitespace": "warn",
-        "typescript/array-type": [
-          "warn",
-          {
-            "default": "array",
-            "readonly": "generic"
-          }
-        ],
-        "typescript/explicit-function-return-type": [
-          "warn",
-          {
-            "allowExpressions": true
-          }
-        ],
-        "typescript/prefer-namespace-keyword": "warn"
-      }
-    }
-  ]
-}

.vscode/launch.json

@@ -15,6 +15,9 @@
         "--recursive",
         "${workspaceRoot}/out/**/*.test.js"
       ],
+      "env": {
+        "NODE_PATH": "${workspaceRoot}/out"
+      },
       "sourceMaps": true,
       "outFiles": [ "${workspaceRoot}/out/**/*.js" ],
       "internalConsoleOptions": "openOnSessionStart"

AGENTS.md

@@ -26,7 +26,6 @@ npm run build && npm run esbuild # Build all TypeScript and bundle
 - Integration tests: `npm run test-integration` (Playwright across Chrome/Firefox/WebKit)
 - Integration tests by file: `npm run test-integration -- test/playwright/InputHandler.test.ts`. Never use grep to filter tests, it doesn't work
 - Integration tests by addon: `npm run test-integration -- --suite=addon-search`. Suites always follow the format `addon-<something>`
-- Lint: `npm run lint` (oxlint with type-aware rules, then ESLint for `naming-convention` only), `npm run lint-api` for `typings/`, `npm run lint-fix` for oxlint auto-fix
 - Lint changes: `npm run lint-changes` to lint only changed files, `npm run lint-changes-fix` to fix them
 
 ## Addon Development Pattern
@@ -99,15 +98,3 @@ const cell = line?.getCell(0);
 ## Writing unit tests
 
 - Unit tests live alongside the source code file of the thing it's testing with a .test.ts suffix.
-
-## Cursor Cloud specific instructions
-
-**Demo server**: Start with `npm start` (port 3000). The demo server uses node-pty to spawn real shell sessions over WebSocket. Integration tests auto-start it via Playwright's `webServer` config, so you don't need to start it manually for `npm run test-integration`.
-
-**Build before testing**: Always run `npm run build && npm run esbuild` before `npm run test-unit`. Integration tests also need `npm run esbuild-demo-client` and `npm run esbuild-demo-server`. The update script handles this automatically on session start.
-
-**No external services**: This project has zero external dependencies (no databases, Docker, or APIs). Everything runs locally with Node.js.
-
-**TypeScript compiler**: The project uses `tsgo` (native TypeScript compiler preview) rather than standard `tsc`. It's installed via the `@typescript/native-preview` package.
-
-**Lint only changed files**: Prefer `npm run lint-changes` over `npm run lint` when iterating on code changes — it's significantly faster.

CONTRIBUTING.md

@@ -39,7 +39,7 @@ The preferred way to report bugs or request features is to use
 
 It's pretty common for maintainers of large open source projects to suffer from burnout, especially when needing to triage a large number of incoming issues instead of actually building things. Here are some of the steps we take to try mitigate this:
 
-- Support questions live in [GH discussions](https://github.com/xtermjs/xterm.js/discussions), issues may be transferred there without further comment and core maintainers may or may not participate in discussions.
+- Support questions live in [GH discussions](https://github.com/xtermjs/xterm.js/discussions), issues may be transfered there without further comment and core maintainers may or may not participate in discussions.
 - Issues are strictly for well defined features or bugs that are _actionable_.
 - Sometimes features are out of scope. A common example of this is a niche feature that the pricipal implementation ([VS Code](https://code.visualstudio.com/)) won't leverage and therefore would be difficult to maintain and likely suffer from bitrot. The reporter may not agree with this, but you could always create an addon if that works or maintain your own fork if it comes to that.
 - If a feature does not have a clear way forward or needs more discussion it may be closed ro moved to a discussion.

addons/addon-attach/test/AttachAddon.test.ts

@@ -15,7 +15,7 @@ test.beforeAll(async ({ browser }) => {
 });
 test.afterAll(async () => await ctx.page.close());
 
-test.describe('AttachAddon', () => {
+test.describe('Search Tests', () => {
 
   test.beforeEach(async () => {
     await ctx.proxy.reset();

addons/addon-clipboard/src/ClipboardAddon.ts

@@ -78,43 +78,13 @@ export class BrowserClipboardProvider implements IClipboardProvider {
   }
 }
 
-/**
- * TODO: Once the base64 handling on Uint8Arrays is more common,
- * remove the btoa/atob fallbacks below.
- */
-interface IUint8ArrayB64 extends Uint8Array {
-  toBase64(): string;
-}
-interface IUint8ArrayB64Ctor extends Uint8ArrayConstructor {
-  fromBase64(s: string): IUint8ArrayB64;
-}
-
 export class Base64 implements IBase64 {
   public encodeText(data: string): string {
-    const bytes = new TextEncoder().encode(data) as IUint8ArrayB64;
-    if (bytes.toBase64 !== undefined) {
-      return bytes.toBase64();
-    }
-    let bin = '';
-    for (let i = 0; i < bytes.length; i++) {
-      bin += String.fromCharCode(bytes[i]);
-    }
-    return btoa(bin);
+    return btoa(data);
   }
   public decodeText(data: string): string {
-    if ((Uint8Array as IUint8ArrayB64Ctor).fromBase64 !== undefined) {
-      try {
-        return new TextDecoder().decode((Uint8Array as IUint8ArrayB64Ctor).fromBase64(data));
-      } catch {}
-      return '';
-    }
     try {
-      const bin = atob(data);
-      const bytes = new Uint8Array(bin.length);
-      for (let i = 0; i < bin.length; ++i) {
-        bytes[i] = bin.charCodeAt(i);
-      }
-      return new TextDecoder().decode(bytes);
+      return atob(data);
     } catch {}
     return '';
   }

addons/addon-clipboard/test/ClipboardAddon.test.ts

@@ -29,7 +29,7 @@ test.describe('ClipboardAddon', () => {
       await ctx.page.context().grantPermissions(['clipboard-read', 'clipboard-write']);
     }
     await ctx.page.evaluate(`
-      window.term.reset();
+      window.term.reset()
       window.clipboard?.dispose();
       window.clipboard = new ClipboardAddon();
       window.term.loadAddon(window.clipboard);
@@ -92,22 +92,4 @@ test.describe('ClipboardAddon', () => {
       deepEqual(await ctx.page.evaluate(() => window.navigator.clipboard.readText()), '');
     });
   });
-
-  test.describe('non-ASCII', () => {
-    const testDataEncoded = '4oKsbWzDpMO8dMOf';
-    const testDataDecoded = '€mläütß';
-    test('write simple string', async () => {
-      await ctx.proxy.write(`\x1b]52;c;${testDataEncoded}\x07`);
-      deepEqual(await ctx.page.evaluate(() => window.navigator.clipboard.readText()), testDataDecoded);
-    });
-    test('read simple string', async () => {
-      await ctx.page.evaluate(`
-        window.data2 = [];
-        window.term.onData(e => data2.push(e));
-      `);
-      await ctx.page.evaluate((d) => window.navigator.clipboard.writeText(d), testDataDecoded);
-      await ctx.proxy.write(`\x1b]52;c;?\x07`);
-      deepEqual(await ctx.page.evaluate('window.data2'), [`\x1b]52;c;${testDataEncoded}\x07`]);
-    });
-  });
 });

addons/addon-clipboard/typings/addon-clipboard.d.ts

@@ -82,7 +82,7 @@ declare module '@xterm/addon-clipboard' {
   /**
    * The clipboard provider interface that enables xterm.js to access the browser clipboard.
    *
-   * Note that this clipboard provider does not implement own cut buffers as xterm does,
+   * Note this this clipboard provider does not implement own cut buffers as xterm does,
    * but redirect the selection parameter always to navigator.clipboard.
    */
   export class BrowserClipboardProvider implements IClipboardProvider{

addons/addon-fit/src/FitAddon.ts

@@ -74,14 +74,14 @@ export class FitAddon implements ITerminalAddon, IFitApi {
       : (this._terminal.options.scrollbar?.width ?? ViewportConstants.DEFAULT_SCROLL_BAR_WIDTH));
 
     const parentElementStyle = _getComputedStyle(this._terminal.element.parentElement);
-    const parentElementHeight = Math.max(0, parseInt(parentElementStyle.getPropertyValue('height'), 10) || 0);
-    const parentElementWidth = Math.max(0, parseInt(parentElementStyle.getPropertyValue('width'), 10) || 0);
+    const parentElementHeight = parseInt(parentElementStyle.getPropertyValue('height'));
+    const parentElementWidth = Math.max(0, parseInt(parentElementStyle.getPropertyValue('width')));
     const elementStyle = _getComputedStyle(this._terminal.element);
     const elementPadding = {
-      top: parseInt(elementStyle.getPropertyValue('padding-top'), 10) || 0,
-      bottom: parseInt(elementStyle.getPropertyValue('padding-bottom'), 10) || 0,
-      right: parseInt(elementStyle.getPropertyValue('padding-right'), 10) || 0,
-      left: parseInt(elementStyle.getPropertyValue('padding-left'), 10) || 0
+      top: parseInt(elementStyle.getPropertyValue('padding-top')),
+      bottom: parseInt(elementStyle.getPropertyValue('padding-bottom')),
+      right: parseInt(elementStyle.getPropertyValue('padding-right')),
+      left: parseInt(elementStyle.getPropertyValue('padding-left'))
     };
     const elementPaddingVer = elementPadding.top + elementPadding.bottom;
     const elementPaddingHor = elementPadding.right + elementPadding.left;

addons/addon-image/README.md

@@ -1,7 +1,6 @@
 ## @xterm/addon-image
 
-Inline image output in xterm.js. Supports SIXEL, iTerm's inline image protocol (IIP)
-and partially Kitty's terminal graphics prtocol (TGP).
+Inline image output in xterm.js. Supports SIXEL and iTerm's inline image protocol (IIP).
 
 
 ![](fixture/example.png)
@@ -44,6 +43,9 @@ terminal.loadAddon(imageAddon);
 
 ### General Notes
 
+- *IMPORTANT:* The worker approach as done in previous releases got removed.
+  The addon contructor no longer expects a worker path as first argument.
+
 - By default the addon will activate these `windowOptions` reports on the terminal:
   - getWinSizePixels (CSI 14 t)
   - getCellSizePixels (CSI 16 t)
@@ -71,7 +73,7 @@ terminal.loadAddon(imageAddon);
 
 - **Cursor Positioning**  
   If scrolling is set, the cursor will be placed at the first image column of the last image row (VT340 mode).
-  Other cursor positioning modes as used by xterm or mintty are not supported for sixel.
+  Other cursor positioning modes as used by xterm or mintty are not supported.
 
 - **SIXEL Palette Handling**  
   By default the addon limits the palette size to 256 registers (as demanded by the DEC specification).
@@ -90,7 +92,7 @@ terminal.loadAddon(imageAddon);
   therefore palette animations cannot be used.
 
 - **SIXEL Raster Attributes Handling**  
-  If raster attributes were found in the SIXEL data (level 2), the image will always be truncated to the given height/width extent. We deviate here from the specification on purpose, as it allows several processing optimizations. For level 1 SIXEL data without any raster attributes the image can freely grow in width and height up to the last data byte, which has a much higher processing penalty. In general encoding libraries should not create level 1 data anymore and should not produce pixel information beyond the announced height/width extent. Both is discouraged by the >30 years old specification.
+  If raster attributes were found in the SIXEL data (level 2), the image will always be truncated to the given height/width extend. We deviate here from the specification on purpose, as it allows several processing optimizations. For level 1 SIXEL data without any raster attributes the image can freely grow in width and height up to the last data byte, which has a much higher processing penalty. In general encoding libraries should not create level 1 data anymore and should not produce pixel information beyond the announced height/width extend. Both is discouraged by the >30 years old specification.
 
   Currently the SIXEL implementation of the addon does not take custom pixel sizes into account, a SIXEL pixel will map 1:1 to a screen pixel.
 
@@ -98,24 +100,17 @@ terminal.loadAddon(imageAddon);
   Set by default, change it with `{iipSupport: true}`.
 
   The IIP implementation has the following features / restrictions (sequence will silently fail for unmet conditions):
-  - Supported formats: PNG, JPEG, GIF and QOI
+  - Supported formats: PNG, JPEG and GIF
   - No animation support.
   - Image type hinting is not supported (always deducted from data header).
   - File download is not supported.
   - Filename gets parsed but not used.
   - Strict base64 handling as of RFC4648 §4 (standard alphabet, optional padding, no separator bytes allowed).
+  - Payload size may not exceed CEIL(sizeParameter * 4 / 3).
   - Image scaling beyond terminal viewport size is allowed (e.g. `width=200%`).
   - Image pixel size is restricted by `pixelLimit` (pre- and post resizing).
-  - Playload size is restricted by `iipSizeLimit`.
-  - size parameter is not mandatory anymore.
-  - Cursor gets positioned at the next cell of the last image line.
-  - ReportCellSize sequence is supported.
-  - Hi-res display support is currently limited (image gets blurred).
-
-- **Kitty Graphics Support (TGP)**  
-  Set by default, change it with `{kittySupport: true}`.
-
-  Note that the kitty graphics support is still WIP.
+  - Size parameter is restricted by `iipSizeLimit`.
+  - Cursor positioning behaves the same as for sixel (see above).
 
 
 ### Storage and Drawing Settings
@@ -132,7 +127,6 @@ The addon exposes two properties to interact with the storage limits at runtime:
 By default the addon will show a placeholder pattern for evicted images that are still part
 of the terminal (e.g. in the scrollback). The pattern can be deactivated by toggling `showPlaceholder`.
 
-
 ### Image Data Retrieval
 
 The addon provides the following API endpoints to retrieve raw image data as canvas:
@@ -146,12 +140,11 @@ The addon provides the following API endpoints to retrieve raw image data as can
   The buffer position is the 0-based absolute index (including scrollback at top).
   Note that the canvas gets created and data copied over for every call, thus it is not suitable for performance critical actions.
 
-
 ### Memory Usage
 
-The addon does most image processing in JavaScript and therefore can occupy a rather big amount of memory. To get an idea where the memory gets eaten, let's look at the data flow and processing steps:
-- Incoming image data chunk at `term.write` (terminal)  
-  `term.write` might stack up incoming chunks. To circumvent this, you will need proper flow control (see xterm.js docs). Note that with image output it is more likely to run into this issue, as it can create lots of MBs in very short time.
+The addon does most image processing in Javascript and therefore can occupy a rather big amount of memory. To get an idea where the memory gets eaten, lets look at the data flow and processing steps:
+- Incomming image data chunk at `term.write` (terminal)  
+  `term.write` might stock up incoming chunks. To circumvent this, you will need proper flow control (see xterm.js docs). Note that with image output it is more likely to run into this issue, as it can create lots of MBs in very short time.
 - Sequence Parser (terminal)  
   The parser operates on a buffer containing up to 2^17 codepoints (~0.5 MB).
 - Sequence Handler - Chunk Decoding (addon)  
@@ -177,18 +170,18 @@ const totalActive = storageBytes + decodingBytes;
 ```
 
 Note that browsers have offloading tricks for rarely touched memory segments, esp. `storageBytes` might not directly translate into real memory usage. Usage peaks will happen during active decoding of multiple big images due to the need of 2 full pixel buffers at the same time, which cannot be offloaded. Thus you may want to keep an eye on `pixelLimit` under limited memory conditions.  
-Further note that the formulas above do not respect the JavaScript object's overhead. Compared to the raw buffer needs the bookkeeping by these objects is rather small (<<5%).
+Further note that the formulas above do not respect the Javascript object's overhead. Compared to the raw buffer needs the book keeping by these objects is rather small (<<5%).
 
 _Why should I care about memory usage at all?_  
-Well you don't have to, and it probably will just work fine with the addon defaults. But for bigger integrations, where much more data is held in the JavaScript context (like multiple terminals on one page), it is likely to hit the engine's memory limit sooner or later under decoding and/or storage pressure.
+Well you don't have to, and it probably will just work fine with the addon defaults. But for bigger integrations, where much more data is held in the Javascript context (like multiple terminals on one page), it is likely to hit the engine's memory limit sooner or later under decoding and/or storage pressure.
 
 _How can I adjust the memory usage?_  
 - `pixelLimit`  
-  A constructor setting, thus you would have to anticipate, whether (multiple) terminals in your page gonna do lots of concurrent decoding. Since this is normally not the case and the memory usage only peaks temporarily, a rather high value should work even with multiple terminals in one page.
+  A constructor setting, thus you would have to anticipate, whether (multiple) terminals in your page gonna do lots of concurrent decoding. Since this is normally not the case and the memory usage is only temporarily peaking, a rather high value should work even with multiple terminals in one page.
 - `storageLimit`  
-  A constructor and a runtime setting. In conjunction with `storageUsage` you can do runtime checks and adjust the limit to your needs. If you have to lower the limit below the current usage, images will be removed in FIFO order and may turn into a placeholder in the terminal's scrollback (if `showPlaceholder` is set). When adjusting keep in mind to leave enough room for peak memory use during decoding.
-- `sixelSizeLimit | iipSizeLimit | kittySizeLimit`  
-  Constructor settings. This has only a small impact on peak memory during decoding. It is meant to avoid processing of overly big or broken image sequences at an earlier phase, thus may stop the invoked decoders from entering memory intensive tasks for potentially invalid data.
+  A constructor and a runtime setting. In conjunction with `storageUsage` you can do runtime checks and adjust the limit to your needs. If you have to lower the limit below the current usage, images will be removed in FIFO order and may turn into a placeholder in the terminal's scrollback (if `showPlaceholder` is set). When adjusting keep in mind to leave enough room for memory peaking for decoding.
+- `sixelSizeLimit`  
+  A constructor setting. This has only a small impact on peaking memory during decoding. It is meant to avoid processing of overly big or broken SIXEL sequences at an earlier phase, thus may stop the decoder from entering its memory intensive task for potentially invalid data.
 
 
 ### Terminal Interaction
@@ -218,5 +211,23 @@ _How can I adjust the memory usage?_
 
 ### Status
 
-- Sixel and IIP support and image handling in xterm.js is considered beta quality.
-- Kitty support is in alpha stage. Please file a bug for any awkwardities or missing features.
+- Sixel support and image handling in xterm.js is considered beta quality.
+- IIP support is in alpha stage. Please file a bug for any awkwardities.
+
+
+### Changelog
+
+- 0.5.0 integrate with xtermjs base repo (at v0.4.3)
+- 0.4.3 defer canvas creation
+- 0.4.2 fix image canvas resize
+- 0.4.1 compat release for xterm.js 5.2.0
+- 0.4.0 IIP support
+- 0.3.1 compat release for xterm.js 5.1.0
+- 0.3.0 important change: worker removed from addon
+- 0.2.0 compat release for xterm.js 5.0.0
+- 0.1.3 bugfix: avoid striping
+- 0.1.2 bugfix: reset clear flag
+- 0.1.1 bugfixes:
+  - clear sticky image tiles on render
+  - create folder from bootstrap.sh
+  - fix peer dependency in package.json

addons/addon-image/src/IIPHandler.ts

@@ -8,7 +8,7 @@ import { IIPImageStorage } from './IIPImageStorage';
 import { CELL_SIZE_DEFAULT } from './ImageStorage';
 import Base64Decoder from 'xterm-wasm-parts/lib/base64/Base64Decoder.wasm';
 import QoiDecoder from 'xterm-wasm-parts/lib/qoi/QoiDecoder.wasm';
-import { HeaderParser, IHeaderFields, HeaderState, SequenceType } from './IIPHeaderParser';
+import { HeaderParser, IHeaderFields, HeaderState } from './IIPHeaderParser';
 import { imageType, UNSUPPORTED_TYPE } from './IIPMetrics';
 
 // Local const enum mirror - esbuild can't inline const enums from external packages
@@ -23,7 +23,6 @@ const enum DecoderConst {
 
 // default IIP header values
 const DEFAULT_HEADER: IHeaderFields = {
-  type: SequenceType.INVALID,
   name: 'Unnamed file',
   size: 0,
   width: 'auto',
@@ -40,8 +39,6 @@ export class IIPHandler implements IOscHandler, IResetHandler {
   private _dec: Base64Decoder;
   private _qoiDec: QoiDecoder;
   private _metrics = UNSUPPORTED_TYPE;
-  private _isMultipart = false;
-  private _abortMulti = false;
 
   constructor(
     private readonly _opts: IImageAddonOptions,
@@ -55,14 +52,11 @@ export class IIPHandler implements IOscHandler, IResetHandler {
     this._qoiDec = new QoiDecoder(DecoderConst.KEEP_DATA);
   }
 
-  public reset(): void {
-    this._hp.reset();
-    this._dec.release();
-    this._qoiDec.release();
-  }
+  public reset(): void {}
 
   public start(): void {
     this._aborted = false;
+    this._header = DEFAULT_HEADER;
     this._metrics  = UNSUPPORTED_TYPE;
     this._hp.reset();
   }
@@ -82,27 +76,15 @@ export class IIPHandler implements IOscHandler, IResetHandler {
         return;
       }
       if (dataPos > 0) {
-        const seqType = this._hp.fields.type;
-        if (seqType === SequenceType.FILE) {
-          if (this._isMultipart) {
-            this._isMultipart = false;
-            this._abortMulti = false;
-            this._dec.release();
-          }
-          this._header = Object.assign({}, DEFAULT_HEADER, this._hp.fields);
-          if (!this._header.inline) {
-            this._aborted = true;
-            return;
-          }
-          this._dec.init();
-        } else if (this._abortMulti) {
+        this._header = Object.assign({}, DEFAULT_HEADER, this._hp.fields);
+        if (!this._header.inline || !this._header.size || this._header.size > this._opts.iipSizeLimit) {
           this._aborted = true;
           return;
         }
+        this._dec.init();
         if ((this._dec.put(data.subarray(dataPos, end)) as number) !== DecoderConst.OK) {
           this._dec.release();
           this._aborted = true;
-          if (this._isMultipart) this._abortMulti = true;
         }
       }
     }
@@ -111,58 +93,22 @@ export class IIPHandler implements IOscHandler, IResetHandler {
   public end(success: boolean): boolean | Promise<boolean> {
     if (this._aborted) return true;
 
-    if (this._hp.state !== HeaderState.END) {
-      if (this._hp.end()) return true;
-    }
-    const seqType = this._hp.fields.type;
-
-    if (seqType === SequenceType.FILEPART) return true;
-
-    if (seqType === SequenceType.REPORTCELLSIZE) {
-      // OSC 1337 ; ReportCellSize=[height];[width];[scale] ST
-      let width = CELL_SIZE_DEFAULT.width;
-      let height = CELL_SIZE_DEFAULT.height;
-      if (this._renderer.dimensions) {
-        width = this._renderer.dimensions.css.canvas.width / this._coreTerminal.cols;
-        height = this._renderer.dimensions.css.canvas.height / this._coreTerminal.rows;
-      }
-      const scale = this._coreTerminal._core._coreBrowserService?.dpr ?? 1;
-      const report = `\x1b]1337;ReportCellSize=${height.toFixed(3)};${width.toFixed(3)};${scale.toFixed(3)}\x1b\\`;
-      this._coreTerminal.input(report, false);
-      return true;
-    }
-
-    if (seqType === SequenceType.MULTIPARTFILE) {
-      this._header = Object.assign({}, DEFAULT_HEADER, this._hp.fields);
-      this._isMultipart = true;
-      this._abortMulti = false;
-      this._dec.release();
-      this._dec.init();
-      return true;
-    }
-
-    if (seqType === SequenceType.FILEEND) {
-      if (!this._isMultipart) return true;
-      this._isMultipart = false;
-      if (this._abortMulti || this._header.type !== SequenceType.MULTIPARTFILE) return true;
-    }
-
-    // fallthrough for SequenceType.FILE & SequenceType.FILEEND
-
     let w = 0;
     let h = 0;
 
     // early exit condition chain
-    let cond: number | boolean;
+    let cond: number | boolean = true;
     if (cond = success) {
       if (cond = !this._dec.end()) {
-        this._metrics = imageType(this._dec.data8);
-        if (cond = this._metrics.mime !== 'unsupported') {
-          w = this._metrics.width;
-          h = this._metrics.height;
-          if (cond = w && h && w * h < this._opts.pixelLimit) {
-            [w, h] = this._resize(w, h).map(Math.floor);
-            cond = w && h && w * h < this._opts.pixelLimit;
+        if (cond = this._dec.data8.length === this._header.size) {
+          this._metrics = imageType(this._dec.data8);
+          if (cond = this._metrics.mime !== 'unsupported') {
+            w = this._metrics.width;
+            h = this._metrics.height;
+            if (cond = w && h && w * h < this._opts.pixelLimit) {
+              [w, h] = this._resize(w, h).map(Math.floor);
+              cond = w && h && w * h < this._opts.pixelLimit;
+            }
           }
         }
       }
@@ -222,8 +168,8 @@ export class IIPHandler implements IOscHandler, IResetHandler {
 
   private _dim(s: string, total: number, cdim: number): number {
     if (s === 'auto') return 0;
-    if (s.endsWith('%')) return parseInt(s.slice(0, -1), 10) * total / 100;
-    if (s.endsWith('px')) return parseInt(s.slice(0, -2), 10);
-    return parseInt(s, 10) * cdim;
+    if (s.endsWith('%')) return parseInt(s.slice(0, -1)) * total / 100;
+    if (s.endsWith('px')) return parseInt(s.slice(0, -2));
+    return parseInt(s) * cdim;
   }
 }

addons/addon-image/src/IIPHeaderParser.test.ts

@@ -4,20 +4,19 @@
  */
 
 import { assert } from 'chai';
-import { HeaderParser, HeaderState, IHeaderFields, SequenceType } from './IIPHeaderParser';
+import { HeaderParser, HeaderState, IHeaderFields } from './IIPHeaderParser';
 
 
 const CASES: [string, IHeaderFields][] = [
-  ['File=size=123456;name=dGVzdA==:', {type: SequenceType.FILE, name: 'test', size: 123456}],
-  ['File=size=123456;name=dGVzdA:', {type: SequenceType.FILE, name: 'test', size: 123456}],
+  ['File=size=123456;name=dGVzdA==:', {name: 'test', size: 123456}],
+  ['File=size=123456;name=dGVzdA:', {name: 'test', size: 123456}],
   // utf-8 encoding in name
-  ['File=size=123456;name=w7xtbMOkdXTDnw==:', {type: SequenceType.FILE, name: 'ümläutß', size: 123456}],
-  ['File=size=123456;name=w7xtbMOkdXTDnw:', {type: SequenceType.FILE, name: 'ümläutß', size: 123456}],
+  ['File=size=123456;name=w7xtbMOkdXTDnw==:', {name: 'ümläutß', size: 123456}],
+  ['File=size=123456;name=w7xtbMOkdXTDnw:', {name: 'ümläutß', size: 123456}],
   // full header spec
   [
     'File=inline=1;width=10px;height=20%;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw:',
     {
-      type: SequenceType.FILE,
       inline: 1,
       width: '10px',
       height: '20%',
@@ -29,7 +28,6 @@ const CASES: [string, IHeaderFields][] = [
   [
     'File=inline=1;width=auto;height=20;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw:',
     {
-      type: SequenceType.FILE,
       inline: 1,
       width: 'auto',
       height: '20',
@@ -103,7 +101,7 @@ describe('IIPHeaderParser', () => {
     let res = hp.parse(inp, 0, inp.length);
     assert.strictEqual(res, inp.length);
     assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, {type: SequenceType.FILE, name: 'test', size: 0});
+    assert.deepEqual(hp.fields, {name: 'test', size: 0});
     hp.reset();
     inp = fromBs(CASES[0][0]);
     res = hp.parse(inp, 0, inp.length);
@@ -117,7 +115,7 @@ describe('IIPHeaderParser', () => {
     let res = hp.parse(inp, 0, inp.length);
     assert.strictEqual(res, inp.length);
     assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, {type: SequenceType.FILE, name: '', size: 123456});
+    assert.deepEqual(hp.fields, {name: '', size: 123456});
     hp.reset();
     inp = fromBs(CASES[0][0]);
     res = hp.parse(inp, 0, inp.length);
@@ -137,124 +135,4 @@ describe('IIPHeaderParser', () => {
     assert.strictEqual(hp.state, HeaderState.END);
     assert.deepEqual(hp.fields, CASES[0][1]);
   });
-  it('FilePart sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FilePart=w7xtbMOkdXTDnw');
-    const res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, 9);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEPART);
-  });
-  it('FilePart sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FilePart=w7xtbMOkdXTDnw');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, 1);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEPART);
-  });
-  it('MultipartFile sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('MultipartFile=inline=1;width=10px;height=20%;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw');
-    let res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.VALUE);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(
-      hp.fields,
-      {
-        type: SequenceType.MULTIPARTFILE,
-        inline: 1,
-        width: '10px',
-        height: '20%',
-        preserveAspectRatio: 1,
-        size: 123456,
-        name: 'ümläutß'
-      }
-    );
-  });
-  it('MultipartFile sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('MultipartFile=inline=1;width=10px;height=20%;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.VALUE);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(
-      hp.fields,
-      {
-        type: SequenceType.MULTIPARTFILE,
-        inline: 1,
-        width: '10px',
-        height: '20%',
-        preserveAspectRatio: 1,
-        size: 123456,
-        name: 'ümläutß'
-      }
-    );
-  });
-  it('FileEnd sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FileEnd');
-    let res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEEND);
-  });
-  it('FileEnd sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FileEnd');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEEND);
-  });
-  it('ReportCellSize sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('ReportCellSize');
-    let res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, { type: SequenceType.REPORTCELLSIZE });
-  });
-  it('ReportCellSize sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('ReportCellSize');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, { type: SequenceType.REPORTCELLSIZE });
-  });
 });

addons/addon-image/src/IIPHeaderParser.ts

@@ -6,27 +6,9 @@
 // eslint-disable-next-line
 declare const Buffer: any;
 
-export const enum HeaderState {
-  START = 0,
-  ABORT = 1,
-  KEY = 2,
-  VALUE = 3,
-  END = 4
-}
-
-export const enum SequenceType {
-  INVALID = 0,
-  FILE = 1,
-  MULTIPARTFILE = 2,
-  FILEPART = 3,
-  FILEEND = 4,
-  REPORTCELLSIZE = 5
-}
 
 export interface IHeaderFields {
   [key: string]: number | string | Uint32Array | null | undefined;
-  // sequence type
-  type: SequenceType;
   // base-64 encoded filename. Defaults to "Unnamed file".
   name: string;
   // File size in bytes. The file transfer will be canceled if this size is exceeded.
@@ -47,6 +29,14 @@ export interface IHeaderFields {
   inline?: number;
 }
 
+export const enum HeaderState {
+  START = 0,
+  ABORT = 1,
+  KEY = 2,
+  VALUE = 3,
+  END = 4
+}
+
 // field value decoders
 
 // ASCII bytes to string
@@ -102,19 +92,7 @@ const DECODERS: {[key: string]: (v: Uint32Array) => number | string} = {
 };
 
 
-// sequence type markers
-// File
 const FILE_MARKER = [70, 105, 108, 101];
-// MultipartFile
-const MULTIPARTFILE_MARKER = [77, 117, 108, 116, 105, 112, 97, 114, 116, 70, 105, 108, 101];
-// FilePart
-const FILEPART_MARKER = [70, 105, 108, 101, 80, 97, 114, 116];
-// FileEnd
-const FILEEND_MARKER = [70, 105, 108, 101, 69, 110, 100];
-// ReportCellSize
-const REPORTCELLSIZE_MARKER = [82, 101, 112, 111, 114, 116, 67, 101, 108, 108, 83, 105, 122, 101];
-
-// max allowed chars for sequence header
 const MAX_FIELDCHARS = 1024;
 
 
@@ -133,43 +111,12 @@ export class HeaderParser {
     this._key = '';
   }
 
-  public end(): number {
-    if (this.state === HeaderState.START) {
-      if (this._position === FILEEND_MARKER.length) {
-        for (let k = 0; k < FILEEND_MARKER.length; ++k) {
-          if (this._buffer[k] !== FILEEND_MARKER[k]) return this._a();
-        }
-        this.fields['type'] = SequenceType.FILEEND;
-        this.state = HeaderState.END;
-        return 0;
-      }
-      if (this._position === REPORTCELLSIZE_MARKER.length) {
-        for (let k = 0; k < REPORTCELLSIZE_MARKER.length; ++k) {
-          if (this._buffer[k] !== REPORTCELLSIZE_MARKER[k]) return this._a();
-        }
-        this.fields['type'] = SequenceType.REPORTCELLSIZE;
-        this.state = HeaderState.END;
-        return 0;
-      }
-      return this._a();
-    }
-    if (this.state === HeaderState.END) return 0;
-    if (this.state === HeaderState.VALUE
-      && this.fields.type === SequenceType.MULTIPARTFILE
-    ) {
-      if (!this._storeValue(this._position)) return this._a();
-      this.state = HeaderState.END;
-      return 0;
-    }
-    return this._a();
-  }
-
   public parse(data: Uint32Array, start: number, end: number): number {
     let state = this.state;
     let pos = this._position;
     const buffer = this._buffer;
     if (state === HeaderState.ABORT || state === HeaderState.END) return -1;
-    if (state === HeaderState.START && pos > 14) return -1;
+    if (state === HeaderState.START && pos > 6) return -1;
     for (let i = start; i < end; ++i) {
       const c = data[i];
       switch (c) {
@@ -180,29 +127,8 @@ export class HeaderParser {
           break;
         case 61: // =
           if (state === HeaderState.START) {
-            if (buffer[0] === 70) {
-              // 'File' or 'FilePart'
-              let k = 0;
-              for (; k < FILE_MARKER.length; ++k) {
-                if (buffer[k] !== FILE_MARKER[k]) return this._a();
-              }
-              this.fields['type'] = SequenceType.FILE;
-              if (pos === FILEPART_MARKER.length) {
-                for (; k < FILEPART_MARKER.length; ++k) {
-                  if (buffer[k] !== FILEPART_MARKER[k]) return this._a();
-                }
-                this.fields['type'] = SequenceType.FILEPART;
-                this.state = HeaderState.END;
-                return i + 1;
-              }
-            } else if (buffer[0] === 77) {
-              // 'MultipartFile'
-              for (let k = 0; k < MULTIPARTFILE_MARKER.length; ++k) {
-                if (buffer[k] !== MULTIPARTFILE_MARKER[k]) return this._a();
-              }
-              this.fields['type'] = SequenceType.MULTIPARTFILE;
-            } else {
-              return this._a();
+            for (let k = 0; k < FILE_MARKER.length; ++k) {
+              if (buffer[k] !== FILE_MARKER[k]) return this._a();
             }
             state = HeaderState.KEY;
             pos = 0;
@@ -232,7 +158,6 @@ export class HeaderParser {
   }
 
   private _a(): number {
-    this.fields.type = SequenceType.INVALID;
     this.state = HeaderState.ABORT;
     return -1;
   }

addons/addon-image/src/IIPImageStorage.ts

@@ -3,7 +3,6 @@
  * @license MIT
  */
 
-import { IAddImageOpts } from './Types';
 import { ImageStorage } from './ImageStorage';
 
 /**
@@ -13,7 +12,6 @@ import { ImageStorage } from './ImageStorage';
  * - Always uses scrolling mode (cursor advances with image)
  */
 export class IIPImageStorage {
-  private _addImageOpts: IAddImageOpts = { scrolling: true, layer: 'top', zIndex: 0, cursorPos: 'iip' };
   constructor(
     private readonly _storage: ImageStorage
   ) {}
@@ -23,6 +21,6 @@ export class IIPImageStorage {
    * Always uses scrolling mode — cursor advances past the image.
    */
   public addImage(img: HTMLCanvasElement | ImageBitmap): void {
-    this._storage.addImage(img, this._addImageOpts);
+    this._storage.addImage(img, true);
   }
 }

addons/addon-image/src/IIPMetrics.test.ts

@@ -30,8 +30,7 @@ const TEST_IMAGES: [string, IMetrics][] = [
   ['iphone_hdr_YES.jpg', { mime: 'image/jpeg', width: 3264, height: 2448 }],
   ['nikon-e950.jpg', { mime: 'image/jpeg', width: 800, height: 600 }],
   ['agfa-makernotes.jpg', { mime: 'image/jpeg', width: 8, height: 8 }],
-  ['sony-alpha-6000.jpg', { mime: 'image/jpeg', width: 6000, height: 4000 }],
-  ['dice.qoi', { mime: 'image/qoi', width: 800, height: 600 }],
+  ['sony-alpha-6000.jpg', { mime: 'image/jpeg', width: 6000, height: 4000 }]
 ];
 
 

addons/addon-image/src/ImageAddon.ts

@@ -137,6 +137,11 @@ export class ImageAddon implements ITerminalAddon, IImageApi {
 
     // enable size reports
     if (this._opts.enableSizeReports) {
+      // const windowOptions = terminal.getOption('windowOptions');
+      // windowOptions.getWinSizePixels = true;
+      // windowOptions.getCellSizePixels = true;
+      // windowOptions.getWinSizeChars = true;
+      // terminal.setOption('windowOptions', windowOptions);
       const windowOps = terminal.options.windowOptions ?? {};
       windowOps.getWinSizePixels = true;
       windowOps.getCellSizePixels = true;
@@ -255,7 +260,7 @@ export class ImageAddon implements ITerminalAddon, IImageApi {
   }
 
   private _report(s: string): void {
-    this._terminal?._core.input(s, false);
+    this._terminal?._core.coreService.triggerDataEvent(s);
   }
 
   private _decset(params: (number | number[])[]): boolean {

addons/addon-image/src/ImageRenderer.ts

@@ -146,7 +146,7 @@ export class ImageRenderer extends Disposable implements IDisposable {
   public clearLines(start: number, end: number, layer?: ImageLayer): void {
     const y = start * (this.dimensions?.css.cell.height || 0);
     const w = this.dimensions?.css.canvas.width || 0;
-    const h = (end + 1 - start) * (this.dimensions?.css.cell.height || 0);
+    const h = (++end - start) * (this.dimensions?.css.cell.height || 0);
     if (!layer || layer === 'top') {
       this._layers.get('top')?.clearRect(0, y, w, h);
     }

addons/addon-image/src/ImageStorage.ts

@@ -5,11 +5,7 @@
 
 import { IDisposable } from '@xterm/xterm';
 import { ImageRenderer } from './ImageRenderer';
-import {
-  ITerminalExt, IExtendedAttrsImage, IImageAddonOptions, IImageSpec,
-  IBufferLineExt, BgFlags, Cell, Content, ICellSize, ExtFlags, Attributes,
-  UnderlineStyle, IAddImageOpts
-} from './Types';
+import { ITerminalExt, IExtendedAttrsImage, IImageAddonOptions, IImageSpec, IBufferLineExt, BgFlags, Cell, Content, ICellSize, ExtFlags, Attributes, UnderlineStyle, ImageLayer } from './Types';
 
 
 // fallback default cell size
@@ -239,15 +235,13 @@ export class ImageStorage implements IDisposable {
   /**
    * Method to add an image to the storage.
    * @param img - The image to add (canvas or bitmap).
-   * @param opts - Options for addImage:
-   *   - scrolling:  When true, cursor advances with the image.
-   *                 When false, image is placed at ORIGIN and cursor does not move.
-   *   - layer:      Which canvas layer to render on ('top' or 'bottom').
-   *   - zIndex:     Z-index for image layering within the same layer.
-   *   - cursorPos:  'vt340' for bottom-left, 'iip' for bottom.right.
+   * @param scrolling - When true, cursor advances with the image (lineFeed per row).
+   *   When false, image is placed at (0,0) and cursor is restored (DECSET 80 / sixel origin mode).
+   * @param layer - Which canvas layer to render on ('top' or 'bottom').
+   * @param zIndex - Z-index for image layering within the same layer.
    * @returns The internal image ID assigned to the stored image.
    */
-  public addImage(img: HTMLCanvasElement | ImageBitmap, opts: IAddImageOpts): number {
+  public addImage(img: HTMLCanvasElement | ImageBitmap, scrolling: boolean, layer: ImageLayer = 'top', zIndex: number = 0): number {
     // never allow storage to exceed memory limit
     this._evictOldest(img.width * img.height);
 
@@ -269,7 +263,7 @@ export class ImageStorage implements IDisposable {
     let offset = originX;
     let tileCount = 0;
 
-    if (!opts.scrolling) {
+    if (!scrolling) {
       buffer.x = 0;
       buffer.y = 0;
       offset = 0;
@@ -283,7 +277,7 @@ export class ImageStorage implements IDisposable {
         this._writeToCell(line as IBufferLineExt, offset + col, imageId, row * cols + col);
         tileCount++;
       }
-      if (opts.scrolling) {
+      if (scrolling) {
         if (row < rows - 1) this._terminal._core._inputHandler.lineFeed();
       } else {
         if (++buffer.y >= termRows) break;
@@ -293,12 +287,8 @@ export class ImageStorage implements IDisposable {
     this._terminal._core._inputHandler._dirtyRowTracker.markDirty(buffer.y);
 
     // cursor positioning modes
-    if (opts.scrolling) {
-      if (opts.cursorPos === 'iip') {
-        buffer.x = Math.min(offset + cols, termCols);
-      } else {
-        buffer.x = offset;
-      }
+    if (scrolling) {
+      buffer.x = offset;
     } else {
       buffer.x = originX;
       buffer.y = originY;
@@ -341,8 +331,8 @@ export class ImageStorage implements IDisposable {
       marker: endMarker || undefined,
       tileCount,
       bufferType: this._terminal.buffer.active.type,
-      layer: opts.layer,
-      zIndex: opts.zIndex
+      layer,
+      zIndex
     };
 
     // finally add the image
@@ -436,9 +426,9 @@ export class ImageStorage implements IDisposable {
       for (let col = 0; col < cols; ++col) {
         let e: IExtendedAttrsImage;
         if (line.getBg(col) & BgFlags.HAS_EXTENDED) {
-          e = line._extendedAttrs?.[col] ?? EMPTY_ATTRS;
+          e = line._extendedAttrs[col] ?? EMPTY_ATTRS;
         } else {
-          const maybeImg = line._extendedAttrs?.[col] as IExtendedAttrsImage | undefined;
+          const maybeImg = line._extendedAttrs[col] as IExtendedAttrsImage | undefined;
           if (!maybeImg || maybeImg.imageId === undefined || maybeImg.imageId === -1) {
             continue;
           }
@@ -461,10 +451,11 @@ export class ImageStorage implements IDisposable {
            * Also check _extendedAttrs directly for cells where text cleared HAS_EXTENDED.
            */
           while (++col < cols) {
-            const nextE = line._extendedAttrs?.[col] as IExtendedAttrsImage | undefined;
+            const nextE = line._extendedAttrs[col] as IExtendedAttrsImage | undefined;
             if (!nextE || nextE.imageId !== imageId || nextE.tileId !== startTile + count) {
               break;
             }
+            e = nextE;
             count++;
           }
           col--;
@@ -515,7 +506,7 @@ export class ImageStorage implements IDisposable {
     for (let row = 0; row < rows; ++row) {
       const line = buffer.lines.get(row) as IBufferLineExt;
       if (line.getBg(oldCol) & BgFlags.HAS_EXTENDED) {
-        const e: IExtendedAttrsImage = line._extendedAttrs?.[oldCol] ?? EMPTY_ATTRS;
+        const e: IExtendedAttrsImage = line._extendedAttrs[oldCol] ?? EMPTY_ATTRS;
         const imageId = e.imageId;
         if (imageId === undefined || imageId === -1) {
           continue;
@@ -560,7 +551,7 @@ export class ImageStorage implements IDisposable {
     const buffer = this._terminal._core.buffer;
     const line = buffer.lines.get(y) as IBufferLineExt;
     if (line && line.getBg(x) & BgFlags.HAS_EXTENDED) {
-      const e: IExtendedAttrsImage = line._extendedAttrs?.[x] ?? EMPTY_ATTRS;
+      const e: IExtendedAttrsImage = line._extendedAttrs[x] ?? EMPTY_ATTRS;
       if (e.imageId && e.imageId !== -1) {
         const orig = this._images.get(e.imageId)?.orig;
         if (window.ImageBitmap && orig instanceof ImageBitmap) {
@@ -580,7 +571,7 @@ export class ImageStorage implements IDisposable {
     const buffer = this._terminal._core.buffer;
     const line = buffer.lines.get(y) as IBufferLineExt;
     if (line && line.getBg(x) & BgFlags.HAS_EXTENDED) {
-      const e: IExtendedAttrsImage = line._extendedAttrs?.[x] ?? EMPTY_ATTRS;
+      const e: IExtendedAttrsImage = line._extendedAttrs[x] ?? EMPTY_ATTRS;
       if (e.imageId && e.imageId !== -1 && e.tileId !== -1) {
         const spec = this._images.get(e.imageId);
         if (spec) {
@@ -611,7 +602,7 @@ export class ImageStorage implements IDisposable {
 
   private _writeToCell(line: IBufferLineExt, x: number, imageId: number, tileId: number): void {
     if (line._data[x * Cell.SIZE + Cell.BG] & BgFlags.HAS_EXTENDED) {
-      const old = line._extendedAttrs?.[x];
+      const old = line._extendedAttrs[x];
       if (old) {
         if (old.imageId !== undefined) {
           // found an old ExtendedAttrsImage, since we know that
@@ -627,13 +618,13 @@ export class ImageStorage implements IDisposable {
           return;
         }
         // found a plain ExtendedAttrs instance, clone it to new entry
-        (line._extendedAttrs ??= {})[x] = new ExtendedAttrsImage(old.ext, old.urlId, imageId, tileId);
+        line._extendedAttrs[x] = new ExtendedAttrsImage(old.ext, old.urlId, imageId, tileId);
         return;
       }
     }
     // fall-through: always create new ExtendedAttrsImage entry
     line._data[x * Cell.SIZE + Cell.BG] |= BgFlags.HAS_EXTENDED;
-    (line._extendedAttrs ??= {})[x] = new ExtendedAttrsImage(0, 0, imageId, tileId);
+    line._extendedAttrs[x] = new ExtendedAttrsImage(0, 0, imageId, tileId);
   }
 
   private _evictOnAlternate(): void {
@@ -652,7 +643,7 @@ export class ImageStorage implements IDisposable {
       }
       for (let x = 0; x < this._terminal.cols; ++x) {
         if (line._data[x * Cell.SIZE + Cell.BG] & BgFlags.HAS_EXTENDED) {
-          const imgId = line._extendedAttrs?.[x]?.imageId;
+          const imgId = line._extendedAttrs[x]?.imageId;
           if (imgId) {
             const spec = this._images.get(imgId);
             if (spec) {

addons/addon-image/src/SixelHandler.ts

@@ -91,7 +91,7 @@ export class SixelHandler implements IDcsHandler, IResetHandler {
     const height = this._dec.height;
 
     // partial fix for https://github.com/jerch/xterm-addon-image/issues/37
-    if (!width || !height) {
+    if (!width || ! height) {
       if (height) {
         this._storage.advanceCursor(height);
       }

addons/addon-image/src/SixelImageStorage.ts

@@ -4,7 +4,7 @@
  */
 
 import { ImageStorage, CELL_SIZE_DEFAULT } from './ImageStorage';
-import { IImageAddonOptions, ITerminalExt, IAddImageOpts } from './Types';
+import { IImageAddonOptions, ITerminalExt } from './Types';
 import { ImageRenderer } from './ImageRenderer';
 
 /**
@@ -15,7 +15,6 @@ import { ImageRenderer } from './ImageRenderer';
  * - advanceCursor for empty sixels carrying only height
  */
 export class SixelImageStorage {
-  private _addImageOpts: IAddImageOpts = { scrolling: true, layer: 'top', zIndex: 0, cursorPos: 'vt340' };
   constructor(
     private readonly _storage: ImageStorage,
     private readonly _opts: IImageAddonOptions,
@@ -28,8 +27,7 @@ export class SixelImageStorage {
    * Cursor behavior depends on the sixelScrolling option (DECSET 80).
    */
   public addImage(img: HTMLCanvasElement | ImageBitmap): void {
-    this._addImageOpts.scrolling = this._opts.sixelScrolling;
-    this._storage.addImage(img, this._addImageOpts);
+    this._storage.addImage(img, this._opts.sixelScrolling);
   }
 
   /**

addons/addon-image/src/Types.ts

@@ -9,8 +9,7 @@ import { IDisposable, IMarker, Terminal } from '@xterm/xterm';
 import { Attributes, BgFlags, Content, ExtFlags, UnderlineStyle } from 'common/buffer/Constants';
 import type { AttributeData } from 'common/buffer/AttributeData';
 import type { IParams, IDcsHandler, IOscHandler, IApcHandler, IEscapeSequenceParser } from 'common/parser/Types';
-import type { IInputHandler } from 'common/Types';
-import type { IBufferLine, IExtendedAttrs } from 'common/buffer/Types';
+import type { IBufferLine, IExtendedAttrs, IInputHandler } from 'common/Types';
 import type { ITerminal, ReadonlyColorSet } from 'browser/Types';
 import type { IRenderDimensions } from 'browser/renderer/shared/Types';
 import type { ICoreBrowserService, IRenderService, IThemeService } from 'browser/services/Services';
@@ -64,7 +63,7 @@ export interface IExtendedAttrsImage extends IExtendedAttrs {
 
 /* eslint-disable */
 export interface IBufferLineExt extends IBufferLine {
-  _extendedAttrs: {[index: number]: IExtendedAttrsImage | undefined} | undefined;
+  _extendedAttrs: {[index: number]: IExtendedAttrsImage | undefined};
   _data: Uint32Array;
 }
 
@@ -101,14 +100,6 @@ export interface ICellSize {
 }
 
 export type ImageLayer = 'top' | 'bottom';
-export type CursorPos = 'vt340' | 'iip';
-
-export interface IAddImageOpts {
-  scrolling: boolean;
-  layer: ImageLayer;
-  zIndex: number;
-  cursorPos: CursorPos;
-}
 
 export interface IImageSpec {
   orig: HTMLCanvasElement | ImageBitmap | undefined;

addons/addon-image/src/kitty/KittyGraphicsTypes.ts

@@ -168,7 +168,7 @@ export function parseKittyCommand(data: string): IKittyCommand {
       cmd.deleteSelector = value;
       continue;
     }
-    const numValue = parseInt(value, 10);
+    const numValue = parseInt(value);
     switch (key) {
       case KittyKey.FORMAT: cmd.format = numValue; break;
       case KittyKey.ID: cmd.id = numValue; break;

addons/addon-image/src/kitty/KittyImageStorage.ts

@@ -5,7 +5,7 @@
 
 import { IDisposable } from '@xterm/xterm';
 import { ImageStorage } from '../ImageStorage';
-import { ImageLayer, IAddImageOpts } from '../Types';
+import { ImageLayer } from '../Types';
 import { IKittyImageData } from './KittyGraphicsTypes';
 
 // Kitty-specific image storage controller.
@@ -42,7 +42,6 @@ export class KittyImageStorage implements IDisposable {
       this._images.delete(kittyId);
     }
   };
-  private _addImageOpts: IAddImageOpts = { scrolling: true, layer: 'top', zIndex: 0, cursorPos: 'iip' };
 
   constructor(
     private readonly _storage: ImageStorage
@@ -99,10 +98,7 @@ export class KittyImageStorage implements IDisposable {
     if (oldStorageId !== undefined) {
       this._storageIdToKittyId.delete(oldStorageId);
     }
-    this._addImageOpts.scrolling = scrolling;
-    this._addImageOpts.layer = layer;
-    this._addImageOpts.zIndex = zIndex;
-    const storageId = this._storage.addImage(image, this._addImageOpts);
+    const storageId = this._storage.addImage(image, scrolling, layer, zIndex);
     this._kittyIdToStorageId.set(kittyId, storageId);
     this._storageIdToKittyId.set(storageId, kittyId);
   }

addons/addon-image/test/ImageAddon.test.ts

@@ -118,10 +118,7 @@ test.describe('ImageAddon', () => {
     }
     // bufferline privates
     strictEqual(await ctx.page.evaluate('window.term._core.buffer.lines.get(0)._data instanceof Uint32Array'), true);
-    strictEqual(await ctx.page.evaluate(`(() => {
-      const ea = window.term._core.buffer.lines.get(0)._extendedAttrs;
-      return ea === undefined || (typeof ea === 'object' && ea !== null);
-    })()`), true);
+    strictEqual(await ctx.page.evaluate('window.term._core.buffer.lines.get(0)._extendedAttrs instanceof Object'), true);
     // inputhandler privates
     strictEqual(await ctx.page.evaluate('window.term._core._inputHandler._curAttrData.constructor.name'), '_AttributeData');
     strictEqual(await ctx.page.evaluate('window.term._core._inputHandler._parser.constructor.name'), 'EscapeSequenceParser');
@@ -293,67 +290,6 @@ test.describe('ImageAddon', () => {
     });
   });
 
-  test.describe('IIP support', () => {
-    test('size params is optional/informative', async () => {
-      // too small size param
-      await ctx.proxy.write(`\x1b]1337;File=inline=1;size=5:${PALETTE_PNG_BASE64}\x07`);
-      deepStrictEqual(await getOrigSize(1), [640, 80]);
-      // no size aparm at all
-      await ctx.proxy.write(`\x1b[10H\x1b]1337;File=inline=1:${PALETTE_QOI_BASE64}\x07`);
-      deepStrictEqual(await getOrigSize(2), [640, 80]);
-    });
-    test.skip('FilePart support - bytewise', async () => {
-      // opener
-      await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      // byte-wise
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; ++i) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64[i]}\x07`);
-      }
-      // finalizer
-      await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      deepStrictEqual(await getOrigSize(1), [640, 80]);
-    });
-    test('FilePart support - chunks', async () => {
-      // opener
-      await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      // chunks
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; i += 256) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64.slice(i, i + 256)}\x07`);
-      }
-      // finalizer
-      await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      deepStrictEqual(await getOrigSize(1), [640, 80]);
-    });
-    test('FilePart support - edgecases', async () => {
-      // multiple opener do not harm
-      for (let i = 0; i < 10; ++i) {
-        await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      }
-      // multiple finalizer do not harm
-      for (let i = 0; i < 5; ++i) {
-        await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      }
-      // chunks w'o opener are ignored
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; i += 256) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64.slice(i, i + 256)}\x07`);
-      }
-      await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      pollFor(ctx.page, 'window.imageAddon._storage._images.size', 0);
-    });
-    test('FilePart support - other IIP sequence cancels chunked image', async () => {
-      // opener
-      await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      // chunks
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; i += 256) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64.slice(i, i + 256)}\x07`);
-      }
-      // finalizer skipped
-      // write spinfox.png
-      await ctx.proxy.write(TESTDATA_IIP[1][0]);
-      deepStrictEqual(await getOrigSize(1), TESTDATA_IIP[1][1]);
-    });
-  });
-
   test.describe('IIP support - testimages', () => {
     test('palette.png', async () => {
       await ctx.proxy.write(TESTDATA_IIP[0][0]);

addons/addon-image/test/KittyGraphics.test.ts

@@ -539,6 +539,7 @@ test.describe('Kitty Graphics Protocol', () => {
 
   test.describe('Query support (a=q)', () => {
     test('responds with OK for capability query without payload', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -547,11 +548,12 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=31,a=q;\x1b\\');
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=31;OK\x1b\\');
     });
 
     test('responds with OK for valid PNG query', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -560,7 +562,7 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write(`\x1b_Gi=42,a=q,f=100;${KITTY_BLACK_1X1_BASE64}\x1b\\`);
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=42;OK\x1b\\');
     });
 
@@ -576,6 +578,7 @@ test.describe('Kitty Graphics Protocol', () => {
     });
 
     test('responds with error for invalid base64', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -584,11 +587,12 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=60,a=q,f=100;!!!invalid!!!\x1b\\');
       await timeout(100);
 
-      const response: string = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response.startsWith('\x1b_Gi=60;EINVAL:'), true);
     });
 
     test('responds with error for RGB data without dimensions', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -597,7 +601,7 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=70,a=q,f=24;AAAA\x1b\\');
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=70;EINVAL:width and height required for raw pixel data\x1b\\');
     });
 
@@ -638,6 +642,7 @@ test.describe('Kitty Graphics Protocol', () => {
     });
 
     test('responds with EINVAL when both i and I keys are specified', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -647,11 +652,12 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write(`\x1b_Gi=100,I=200,a=q,f=100;${KITTY_BLACK_1X1_BASE64}\x1b\\`);
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=100;EINVAL:cannot specify both i and I keys\x1b\\');
     });
 
     test('responds with EINVAL for i+I conflict even without payload', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -661,7 +667,7 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=101,I=201,a=d\x1b\\');
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=101;EINVAL:cannot specify both i and I keys\x1b\\');
     });
   });

addons/addon-ligatures/package.json

@@ -31,11 +31,15 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "lru-cache": "^11.3.6",
-    "opentype.js": "^2.0.0"
+    "lru-cache": "^6.0.0",
+    "opentype.js": "^0.8.0"
   },
   "devDependencies": {
-    "@types/opentype.js": "^1.3.9",
-    "font-finder": "^1.1.0"
+    "@types/lru-cache": "^5.1.0",
+    "@types/opentype.js": "^0.7.0",
+    "axios": "^1.15.2",
+    "font-finder": "^1.1.0",
+    "mkdirp": "0.5.5",
+    "yauzl": "^3.2.1"
   }
 }

addons/addon-ligatures/src/fontLigatures/index.ts

@@ -1,5 +1,5 @@
 import * as opentype from 'opentype.js';
-import { LRUCache } from 'lru-cache';
+import LRUCache = require('lru-cache');
 
 import { IFont, ILigatureData, IFlattenedLookupTree, ILookupTree, IOptions } from './types';
 import mergeTrees from './merge';
@@ -23,8 +23,8 @@ class FontImpl implements IFont {
 
     if (options.cacheSize > 0) {
       this._cache = new LRUCache({
-        maxSize: options.cacheSize,
-        sizeCalculation: ((val: ILigatureData | [number, number][], key: string) => key.length) as any
+        max: options.cacheSize,
+        length: ((val: ILigatureData | [number, number][], key: string) => key.length) as any
       });
     }
 

addons/addon-ligatures/src/fontLigatures/mergeRange.ts

@@ -44,6 +44,7 @@ export default function mergeRange(ranges: [number, number][], newRangeStart: nu
         // current range
         ranges[i - 1][1] = Math.max(newRangeEnd, range[1]);
         ranges.splice(i, 1);
+        inRange = false;
         return ranges;
       }
       // Case 7: New range extends from previous range past the

addons/addon-ligatures/src/index.ts

@@ -21,7 +21,7 @@ const CACHE_SIZE = 100000;
 
 /**
  * Enable ligature support for the provided Terminal instance. To function
- * properly, this must be called after `open()` is called on the terminal. If
+ * properly, this must be called after `open()` is called on the therminal. If
  * the font currently in use supports ligatures, the terminal will automatically
  * start to render them.
  * @param term Terminal instance from xterm.js

addons/addon-progress/test/ProgressAddon.test.ts

@@ -9,18 +9,15 @@ import { ITestContext, createTestContext, openTerminal } from '../../../test/pla
 
 
 let ctx: ITestContext;
+test.beforeAll(async ({ browser }) => {
+  ctx = await createTestContext(browser);
+  ctx.page.setViewportSize({ width: 1024, height: 768 });
+  await openTerminal(ctx);
+});
+test.afterAll(async () => await ctx.page.close());
+
 
 test.describe('ProgressAddon', () => {
-  test.describe.configure({ mode: 'serial' });
-
-  test.beforeAll(async ({ browser }) => {
-    ctx = await createTestContext(browser);
-    await openTerminal(ctx);
-  });
-  test.afterAll(async () => {
-    await ctx?.page?.close();
-  });
-
   test.beforeEach(async function(): Promise<any> {
     await ctx.page.evaluate(`
       window.progressStack = [];

addons/addon-search/.gitignore

@@ -1,2 +1,3 @@
 lib
-node_modules
+node_modules
+out-benchmark

addons/addon-search/README.md

@@ -20,4 +20,13 @@ terminal.loadAddon(searchAddon);
 searchAddon.findNext('foo');
 ```
 
+### Search options
+
+- `decorations` (`ISearchDecorationOptions`): Enables match highlighting and result tracking; pass a decoration options object (colors may be omitted).
+- `highlightLimit` (constructor option): Caps how many matches are tracked/highlighted (default `1000`).
+- `incremental`: Expands the current selection when the term still matches.
+- `wholeWord`, `regex`, `caseSensitive`: Control match semantics.
+
+`onDidChangeResults` fires after `findNext`/`findPrevious` when `decorations` is set. `clearDecorations()` clears highlights and tracked results but does not emit this event.
+
 See the full [API](https://github.com/xtermjs/xterm.js/blob/master/addons/addon-search/typings/addon-search.d.ts) for more advanced usage.

addons/addon-search/benchmark/SearchAddon.benchmark.ts

@@ -0,0 +1,284 @@
+/**
+ * Copyright (c) 2026 The xterm.js authors. All rights reserved.
+ * @license MIT
+ */
+
+import { perfContext, before, RuntimeCase } from 'xterm-benchmark';
+import { readFileSync } from 'fs';
+import { resolve } from 'path';
+import { Terminal } from 'browser/public/Terminal';
+import { SearchAddon } from 'SearchAddon';
+import type { ISearchOptions } from '@xterm/addon-search';
+
+const enum Constants {
+  COLS = 120,
+  ROWS = 40,
+  SCROLLBACK = 8000,
+  NAVIGATION_ITERATIONS = 250,
+  COLD_CACHE_ITERATIONS = 75,
+  INCREMENTAL_ITERATIONS = 75,
+  DECORATION_REFRESH_ITERATIONS = 25
+}
+
+const DECORATION_OPTIONS: ISearchOptions = {
+  decorations: {
+    activeMatchBackground: '#0000ff',
+    activeMatchColorOverviewRuler: '#ff0000',
+    matchBackground: '#ffff00',
+    matchBorder: '#000000',
+    matchOverviewRuler: '#00ffff'
+  }
+};
+
+class TestTerminal extends Terminal {
+  public writeSync(data: string): void {
+    (this as any)._core.writeSync(data);
+  }
+
+  public override select(_column: number, _row: number, _length: number): void {
+    // SearchAddon always selects matches; skip selection internals in headless benchmark runs.
+  }
+
+  public override clearSelection(): void {
+    // SearchAddon clears the previous selection before selecting another match.
+  }
+
+  public override scrollLines(_amount: number): void {
+    // No viewport scrolling is needed for API runtime measurement.
+  }
+}
+
+function buildRealWorldBuffer(): string {
+  const fixture = readFileSync(resolve(__dirname, '../../fixtures/issue-2444'), 'utf8')
+    .replace(/\r?\n/g, '\r\n');
+  const lines: string[] = [fixture];
+  for (let i = 0; i < 2500; i++) {
+    const minute = (i % 60).toString().padStart(2, '0');
+    const second = ((i * 7) % 60).toString().padStart(2, '0');
+    lines.push(`2026-05-25T16:${minute}:${second}Z INFO  [api-${i % 8}] requestId=req-${i.toString(16).padStart(6, '0')} path=/v1/projects/${i % 120}/search?q=opencv status=200 durationMs=${10 + (i % 90)}`);
+    if (i % 5 === 0) {
+      lines.push(`2026-05-25T16:${minute}:${second}Z WARN  [worker-${i % 4}] slow query detected query="SELECT * FROM runs WHERE status='pending'" elapsedMs=${500 + (i % 1200)}`);
+    }
+    if (i % 11 === 0) {
+      lines.push(`2026-05-25T16:${minute}:${second}Z ERROR [worker-${i % 4}] command failed: package.json parse error at column ${10 + (i % 70)}; retrying in ${2 + (i % 7)}s`);
+    }
+    if (i % 17 === 0) {
+      lines.push(`https://example.internal/run/${i}/details?source=terminal-search&state=error`);
+    }
+  }
+  return lines.join('\r\n') + '\r\n';
+}
+
+perfContext('SearchAddon API on real-world terminal content', () => {
+  const bufferContent = buildRealWorldBuffer();
+
+  perfContext('findNext/plain navigation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('opencv')) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/no match full scan', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('zzzznotfoundzzzz')) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== 0) {
+        throw new Error(`Expected 0 matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/case insensitive navigation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('OPENCV', { caseSensitive: false })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/regex navigation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('https://example\\.internal/run/\\d+/details\\?source=terminal-search', { regex: true })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findPrevious/incremental typing flow', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    const terms = ['e', 'er', 'err', 'erro', 'error'];
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.INCREMENTAL_ITERATIONS; i++) {
+        for (const term of terms) {
+          if (search.findPrevious(term, { incremental: true })) {
+            foundCount++;
+          }
+        }
+      }
+      return { payloadSize: Constants.INCREMENTAL_ITERATIONS * terms.length, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/cold cache', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.COLD_CACHE_ITERATIONS; i++) {
+        // Force a fresh logical-line reconstruction and match scan each search.
+        (search as any)._clearMatchCache();
+        if (search.findNext('opencv')) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.COLD_CACHE_ITERATIONS) {
+        throw new Error(`Expected ${Constants.COLD_CACHE_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.COLD_CACHE_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/wholeWord dense-punctuation', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findNext('error', { wholeWord: true })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findPrevious/regex wholeWord reverse', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon();
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.NAVIGATION_ITERATIONS; i++) {
+        if (search.findPrevious('error', { regex: true, wholeWord: true })) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.NAVIGATION_ITERATIONS) {
+        throw new Error(`Expected ${Constants.NAVIGATION_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.NAVIGATION_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+
+  perfContext('findNext/decorations refresh', () => {
+    let terminal: TestTerminal;
+    let search: SearchAddon;
+    before(() => {
+      terminal = new TestTerminal({ cols: Constants.COLS, rows: Constants.ROWS, scrollback: Constants.SCROLLBACK });
+      search = new SearchAddon({ highlightLimit: 1500 });
+      search.activate(terminal);
+      terminal.writeSync(bufferContent);
+    });
+    new RuntimeCase('', () => {
+      let foundCount = 0;
+      for (let i = 0; i < Constants.DECORATION_REFRESH_ITERATIONS; i++) {
+        const term = i % 2 === 0 ? 'WARN' : 'ERROR';
+        if (search.findNext(term, DECORATION_OPTIONS)) {
+          foundCount++;
+        }
+      }
+      if (foundCount !== Constants.DECORATION_REFRESH_ITERATIONS) {
+        throw new Error(`Expected ${Constants.DECORATION_REFRESH_ITERATIONS} matches, got ${foundCount}`);
+      }
+      return { payloadSize: Constants.DECORATION_REFRESH_ITERATIONS, foundCount };
+    }, { fork: false }).showAverageRuntime();
+  });
+});

addons/addon-search/benchmark/benchmark.json

@@ -0,0 +1,13 @@
+{
+  "APP_PATH": ".benchmark",
+  "evalConfig": {
+    "tolerance": {
+      "*": [0.9, 1.2],
+      "SearchAddon.benchmark.js.*.averageRuntime.mean": [0.93, 1.12]
+    },
+    "skip": [
+      "*.median",
+      "*.runs"
+    ]
+  }
+}

addons/addon-search/benchmark/tsconfig.json

@@ -0,0 +1,29 @@
+{
+  "compilerOptions": {
+    "lib": [
+      "dom",
+      "es2021"
+    ],
+    "rootDir": "..",
+    "outDir": "../out-benchmark",
+    "types": ["../../../node_modules/@types/node"],
+    "moduleResolution": "node",
+    "strict": false,
+    "target": "es2021",
+    "module": "commonjs",
+    "paths": {
+      "common/*": ["../../../src/common/*"],
+      "browser/*": ["../../../src/browser/*"],
+      "SearchAddon": ["../src/SearchAddon"],
+      "@xterm/addon-search": [
+        "../typings/addon-search.d.ts"
+      ]
+    }
+  },
+  "include": ["../**/*", "../../../typings/xterm.d.ts"],
+  "exclude": ["../../../**/*test.ts", "../../**/*api.ts"],
+  "references": [
+    { "path": "../../../src/common" },
+    { "path": "../../../src/browser" }
+  ]
+}

addons/addon-search/package.json

@@ -19,6 +19,9 @@
     "prepackage": "../../node_modules/.bin/tsgo -p .",
     "package": "../../node_modules/.bin/webpack",
     "prepublishOnly": "npm run package",
-    "start": "node ../../demo/start"
+    "start": "node ../../demo/start",
+    "benchmark": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json out-benchmark/benchmark/*benchmark.js",
+    "benchmark-baseline": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 10 -c benchmark/benchmark.json --baseline out-benchmark/benchmark/*benchmark.js",
+    "benchmark-eval": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 10 -c benchmark/benchmark.json --eval -F out-benchmark/benchmark/*benchmark.js"
   }
 }

addons/addon-search/src/DecorationManager.test.ts

@@ -1,81 +0,0 @@
-/**
- * Copyright (c) 2026 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import { assert } from 'chai';
-import { DecorationManager } from './DecorationManager';
-import { SearchEngine } from './SearchEngine';
-import { SearchLineCache } from './SearchLineCache';
-import { Terminal } from 'browser/public/Terminal';
-import type { ISearchDecorationOptions } from '@xterm/addon-search';
-import type { IDecorationOptions } from '@xterm/xterm';
-import { DisposableStore } from 'common/Lifecycle';
-
-function writeP(terminal: Terminal, data: string): Promise<void> {
-  return new Promise(r => terminal.write(data, r));
-}
-
-describe('DecorationManager', () => {
-  let store: DisposableStore;
-  let terminal: Terminal;
-  let decorationManager: DecorationManager;
-
-  beforeEach(() => {
-    store = new DisposableStore();
-    terminal = store.add(new Terminal({ cols: 10, rows: 5 }));
-    decorationManager = store.add(new DecorationManager(terminal));
-  });
-
-  it('should split highlight decorations for a wrapped match', async () => {
-    await writeP(terminal, '0123456789abcde');
-    const searchEngine = new SearchEngine(terminal, store.add(new SearchLineCache(terminal)));
-    const match = searchEngine.find('9abc', 0, 0);
-    assert.ok(match);
-
-    const decorationOptions: IDecorationOptions[] = [];
-    const registerDecoration = terminal.registerDecoration.bind(terminal);
-    terminal.registerDecoration = (options: IDecorationOptions) => {
-      decorationOptions.push(options);
-      return registerDecoration(options);
-    };
-
-    const options: ISearchDecorationOptions = {
-      matchOverviewRuler: '#ff0000',
-      activeMatchColorOverviewRuler: '#00ff00'
-    };
-    decorationManager.createHighlightDecorations([match], options);
-
-    assert.strictEqual(decorationOptions.length, 2);
-    assert.strictEqual(decorationOptions[0].x, 9);
-    assert.strictEqual(decorationOptions[0].width, 1);
-    assert.strictEqual(decorationOptions[1].x, 0);
-    assert.strictEqual(decorationOptions[1].width, 3);
-
-    const withOverviewRuler = decorationOptions.filter(o => o.overviewRulerOptions !== undefined);
-    assert.strictEqual(withOverviewRuler.length, 2);
-  });
-
-  it('should only add one overview ruler marker per buffer line', async () => {
-    await writeP(terminal, 'abcdefghij');
-    const decorationOptions: IDecorationOptions[] = [];
-    const registerDecoration = terminal.registerDecoration.bind(terminal);
-    terminal.registerDecoration = (options: IDecorationOptions) => {
-      decorationOptions.push(options);
-      return registerDecoration(options);
-    };
-
-    const options: ISearchDecorationOptions = {
-      matchOverviewRuler: '#ff0000',
-      activeMatchColorOverviewRuler: '#00ff00'
-    };
-    decorationManager.createHighlightDecorations([
-      { term: 'a', col: 0, row: 0, size: 1 },
-      { term: 'f', col: 5, row: 0, size: 1 }
-    ], options);
-
-    const withOverviewRuler = decorationOptions.filter(o => o.overviewRulerOptions !== undefined);
-    assert.strictEqual(withOverviewRuler.length, 1);
-    assert.strictEqual(withOverviewRuler[0].x, 0);
-  });
-});

addons/addon-search/src/DecorationManager.ts

@@ -1,158 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { Terminal, IDisposable, IDecoration } from '@xterm/xterm';
-import type { ISearchDecorationOptions } from '@xterm/addon-search';
-import { dispose, Disposable, toDisposable } from 'common/Lifecycle';
-import type { ISearchResult } from './SearchEngine';
-
-/**
- * Interface for managing a highlight decoration.
- */
-interface IHighlight extends IDisposable {
-  decoration: IDecoration;
-  match: ISearchResult;
-}
-
-/**
- * Interface for managing multiple decorations for a single match.
- */
-interface IMultiHighlight extends IDisposable {
-  decorations: IDecoration[];
-  match: ISearchResult;
-}
-
-/**
- * Manages visual decorations for search results including highlighting and active selection
- * indicators. This class handles the creation, styling, and disposal of search-related decorations.
- */
-export class DecorationManager extends Disposable {
-  private _highlightDecorations: IHighlight[] = [];
-  private _highlightedLines: Set<number> = new Set();
-
-  constructor(private readonly _terminal: Terminal) {
-    super();
-    this._register(toDisposable(() => this.clearHighlightDecorations()));
-  }
-
-  /**
-   * Creates decorations for all provided search results.
-   * @param results The search results to create decorations for.
-   * @param options The decoration options.
-   */
-  public createHighlightDecorations(results: ISearchResult[], options: ISearchDecorationOptions): void {
-    this.clearHighlightDecorations();
-
-    for (const match of results) {
-      const decorations = this._createResultDecorations(match, options, false);
-      if (decorations) {
-        for (const decoration of decorations) {
-          this._storeDecoration(decoration, match);
-        }
-      }
-    }
-  }
-
-  /**
-   * Creates decorations for the currently active search result.
-   * @param result The active search result.
-   * @param options The decoration options.
-   * @returns The multi-highlight decoration or undefined if creation failed.
-   */
-  public createActiveDecoration(result: ISearchResult, options: ISearchDecorationOptions): IMultiHighlight | undefined {
-    const decorations = this._createResultDecorations(result, options, true);
-    if (decorations) {
-      return { decorations, match: result, dispose() { dispose(decorations); } };
-    }
-    return undefined;
-  }
-
-  /**
-   * Clears all highlight decorations.
-   */
-  public clearHighlightDecorations(): void {
-    dispose(this._highlightDecorations);
-    this._highlightDecorations = [];
-    this._highlightedLines.clear();
-  }
-
-  /**
-   * Stores a decoration and tracks it for management.
-   * @param decoration The decoration to store.
-   * @param match The search result this decoration represents.
-   */
-  private _storeDecoration(decoration: IDecoration, match: ISearchResult): void {
-    this._highlightedLines.add(decoration.marker.line);
-    this._highlightDecorations.push({ decoration, match, dispose() { decoration.dispose(); } });
-  }
-
-  /**
-   * Applies styles to the decoration when it is rendered.
-   * @param element The decoration's element.
-   * @param borderColor The border color to apply.
-   * @param isActiveResult Whether the element is part of the active search result.
-   */
-  private _applyStyles(element: HTMLElement, borderColor: string | undefined, isActiveResult: boolean): void {
-    if (!element.classList.contains('xterm-find-result-decoration')) {
-      element.classList.add('xterm-find-result-decoration');
-      if (borderColor) {
-        element.style.outline = `1px solid ${borderColor}`;
-      }
-    }
-    if (isActiveResult) {
-      element.classList.add('xterm-find-active-result-decoration');
-    }
-  }
-
-  /**
-   * Creates a decoration for the result and applies styles
-   * @param result the search result for which to create the decoration
-   * @param options the options for the decoration
-   * @param isActiveResult whether this is the currently active result
-   * @returns the decorations or undefined if the marker has already been disposed of
-   */
-  private _createResultDecorations(result: ISearchResult, options: ISearchDecorationOptions, isActiveResult: boolean): IDecoration[] | undefined {
-    // Gather decoration ranges for this match as it could wrap
-    const decorationRanges: [number, number, number][] = [];
-    let currentCol = result.col;
-    let remainingSize = result.size;
-    let markerOffset = -this._terminal.buffer.active.baseY - this._terminal.buffer.active.cursorY + result.row;
-    while (remainingSize > 0) {
-      const amountThisRow = Math.min(this._terminal.cols - currentCol, remainingSize);
-      decorationRanges.push([markerOffset, currentCol, amountThisRow]);
-      currentCol = 0;
-      remainingSize -= amountThisRow;
-      markerOffset++;
-    }
-
-    // Create the decorations
-    const decorations: IDecoration[] = [];
-    for (const range of decorationRanges) {
-      const marker = this._terminal.registerMarker(range[0]);
-      const decoration = this._terminal.registerDecoration({
-        marker,
-        x: range[1],
-        width: range[2],
-        layer: isActiveResult ? 'top' : 'bottom',
-        backgroundColor: isActiveResult ? options.activeMatchBackground : options.matchBackground,
-        overviewRulerOptions: this._highlightedLines.has(marker.line) ? undefined : {
-          color: isActiveResult ? options.activeMatchColorOverviewRuler : options.matchOverviewRuler,
-          position: 'center'
-        }
-      });
-      if (decoration) {
-        const disposables: IDisposable[] = [];
-        disposables.push(marker);
-        disposables.push(decoration.onRender((e) => this._applyStyles(e, isActiveResult ? options.activeMatchBorder : options.matchBorder, false)));
-        disposables.push(decoration.onDispose(() => dispose(disposables)));
-        decorations.push(decoration);
-      }
-    }
-
-    return decorations.length === 0 ? undefined : decorations;
-  }
-}
-
-

addons/addon-search/src/SearchEngine.test.ts

@@ -1,708 +0,0 @@
-/**
- * Copyright (c) 2024 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-import { assert } from 'chai';
-import { SearchEngine } from './SearchEngine';
-import { SearchLineCache } from './SearchLineCache';
-import { Terminal } from 'browser/public/Terminal';
-import type { ISearchOptions } from '@xterm/addon-search';
-import { DisposableStore } from 'common/Lifecycle';
-
-function writeP(terminal: Terminal, data: string): Promise<void> {
-  return new Promise(r => terminal.write(data, r));
-}
-
-describe('SearchEngine', () => {
-  let store: DisposableStore;
-  let terminal: Terminal;
-  let lineCache: SearchLineCache;
-  let searchEngine: SearchEngine;
-
-  beforeEach(() => {
-    store = new DisposableStore();
-    terminal = store.add(new Terminal({ cols: 80, rows: 24 }));
-    lineCache = store.add(new SearchLineCache(terminal));
-    searchEngine = new SearchEngine(terminal, lineCache);
-  });
-
-  afterEach(() => {
-    store.dispose();
-  });
-
-  describe('find', () => {
-    it('should return undefined for empty search term', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('', 0, 0), undefined);
-    });
-
-    it('should find basic text in terminal content', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.deepStrictEqual(searchEngine.find('World', 0, 0), {
-        term: 'World',
-        col: 6,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should find text starting from specified position', async () => {
-      await writeP(terminal, 'Hello Hello Hello');
-
-      assert.deepStrictEqual(searchEngine.find('Hello', 0, 7), {
-        term: 'Hello',
-        col: 12,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should search across multiple rows', async () => {
-      await writeP(terminal, 'Line 1\r\nLine 2 target\r\nLine 3');
-
-      assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-        term: 'target',
-        col: 7,
-        row: 1,
-        size: 6
-      });
-    });
-
-    it('should return undefined when text is not found', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('NotFound', 0, 0), undefined);
-    });
-
-    it('should throw error for invalid column position', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.throws(() => {
-        searchEngine.find('Hello', 0, 100);
-      }, /Invalid col: 100 to search in terminal of 80 cols/);
-    });
-
-    it('should handle search starting from last column', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('Hello', 0, 79), undefined);
-    });
-
-    it('should handle search from middle of match', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.find('llo', 0, 3), undefined); // Should not find partial match that starts before search position
-    });
-  });
-
-  describe('search options', () => {
-    describe('caseSensitive', () => {
-      it('should find text with case-insensitive search (default)', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should find text with case-sensitive search when enabled', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.deepStrictEqual(searchEngine.find('WORLD', 0, 0, { caseSensitive: true }), {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should not find text with case-sensitive search when case differs', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.strictEqual(searchEngine.find('world', 0, 0, { caseSensitive: true }), undefined);
-      });
-    });
-
-    describe('wholeWord', () => {
-      it('should find whole word when enabled', async () => {
-        await writeP(terminal, 'Hello world wonderful');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should not find partial word when wholeWord is enabled', async () => {
-        await writeP(terminal, 'Hello wonderful');
-
-        assert.strictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), undefined);
-      });
-
-      it('should find word at beginning of line with wholeWord', async () => {
-        await writeP(terminal, 'world is great');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should find word at end of line with wholeWord', async () => {
-        await writeP(terminal, 'hello world');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle word boundaries with punctuation', async () => {
-        await writeP(terminal, 'hello,world!test');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), {
-          term: 'world',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should not match when not whole word', async () => {
-        await writeP(terminal, 'helloworld');
-
-        assert.strictEqual(searchEngine.find('world', 0, 0, { wholeWord: true }), undefined);
-      });
-    });
-
-    describe('regex', () => {
-      it('should find text using simple regex pattern', async () => {
-        await writeP(terminal, 'Hello 123 World');
-
-        assert.deepStrictEqual(searchEngine.find('[0-9]+', 0, 0, { regex: true }), {
-          term: '123',
-          col: 6,
-          row: 0,
-          size: 3
-        });
-      });
-
-      it('should find text using regex with case-insensitive flag', async () => {
-        await writeP(terminal, 'Hello WORLD');
-
-        assert.deepStrictEqual(searchEngine.find('world', 0, 0, { regex: true, caseSensitive: false }), {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should find text using regex with case-sensitive flag', async () => {
-        await writeP(terminal, 'Hello WORLD world');
-
-        assert.deepStrictEqual(searchEngine.find('WORLD', 0, 0, { regex: true, caseSensitive: true }), {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle complex regex patterns', async () => {
-        await writeP(terminal, 'Email: test@example.com and another@domain.org');
-
-        assert.deepStrictEqual(searchEngine.find('[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}', 0, 0, { regex: true }), {
-          term: 'test@example.com',
-          col: 7,
-          row: 0,
-          size: 16
-        });
-      });
-
-      it('should return undefined for invalid regex pattern', async () => {
-        await writeP(terminal, 'Hello World');
-
-        // Invalid regex should be handled gracefully
-        assert.throws(() => {
-          searchEngine.find('[invalid', 0, 0, { regex: true });
-        }, /Invalid regular expression/);
-      });
-
-      it('should handle empty regex matches', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.strictEqual(searchEngine.find('.*?', 0, 0, { regex: true }), undefined); // Empty matches should be ignored
-      });
-    });
-
-    describe('combined options', () => {
-      it('should handle regex + caseSensitive combination', async () => {
-        await writeP(terminal, 'Hello WORLD world');
-
-        assert.deepStrictEqual(searchEngine.find('[A-Z]+', 0, 0, { regex: true, caseSensitive: true }), {
-          term: 'H',
-          col: 0,
-          row: 0,
-          size: 1
-        });
-      });
-
-      it('should handle wholeWord + caseSensitive combination', async () => {
-        await writeP(terminal, 'Hello WORLD wonderful');
-
-        const result1 = searchEngine.find('WORLD', 0, 0, { wholeWord: true, caseSensitive: true });
-        assert.deepStrictEqual(result1, {
-          term: 'WORLD',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-
-        const result2 = searchEngine.find('world', 0, 0, { wholeWord: true, caseSensitive: true });
-        assert.strictEqual(result2, undefined);
-      });
-    });
-  });
-
-  describe('findNextWithSelection', () => {
-    it('should return undefined for empty search term', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findNextWithSelection(''), undefined);
-    });
-
-    it('should find first occurrence when no selection exists', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello'), {
-        term: 'Hello',
-        col: 0,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should find next occurrence after current selection', async () => {
-      await writeP(terminal, 'Hello World Hello Again');
-
-      // Mock the getSelectionPosition to return a selection at first "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello', undefined, 'Hello'), {
-        term: 'Hello',
-        col: 12,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should wrap around to beginning when reaching end', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      // Mock selection at the end
-      terminal.getSelectionPosition = () => ({ start: { x: 12, y: 0 }, end: { x: 17, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello', undefined, 'Hello'), {
-        term: 'Hello',
-        col: 0,
-        row: 0,
-        size: 5
-      }); // Should wrap to first occurrence
-    });
-
-    it('should wrap across multiple rows', async () => {
-      await writeP(terminal, 'Line 1 test\r\nLine 2\r\nLine 3 test');
-
-      // Mock selection at first "test"
-      terminal.getSelectionPosition = () => ({ start: { x: 7, y: 0 }, end: { x: 11, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('test', undefined, 'test'), {
-        term: 'test',
-        col: 7,
-        row: 2,
-        size: 4
-      });
-    });
-
-    it('should return same selection if only one match exists', async () => {
-      await writeP(terminal, 'Hello World');
-
-      // Mock selection at "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      assert.deepStrictEqual(searchEngine.findNextWithSelection('Hello'), {
-        term: 'Hello',
-        col: 0,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should clear selection and return undefined when term not found', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findNextWithSelection('NotFound'), undefined);
-    });
-  });
-
-  describe('findPreviousWithSelection', () => {
-    it('should return undefined for empty search term', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findPreviousWithSelection(''), undefined);
-    });
-
-    it('should find last occurrence when no selection exists', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      assert.deepStrictEqual(searchEngine.findPreviousWithSelection('Hello'), {
-        term: 'Hello',
-        col: 12,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should find previous occurrence before current selection', async () => {
-      await writeP(terminal, 'Hello World Hello Again');
-
-      // Mock selection at second "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 12, y: 0 }, end: { x: 17, y: 0 } });
-
-      const result = searchEngine.findPreviousWithSelection('Hello');
-      assert.notStrictEqual(result, undefined);
-      // It may find the same selection first due to expansion attempt
-      assert.strictEqual(typeof result!.col, 'number');
-      assert.strictEqual(result!.row, 0);
-    });
-
-    it('should wrap around to end when reaching beginning', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      // Mock selection at first "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      const result = searchEngine.findPreviousWithSelection('Hello');
-      assert.notStrictEqual(result, undefined);
-      // Due to the expansion attempt, it may find the same Hello first
-      assert.strictEqual(typeof result!.col, 'number');
-      assert.strictEqual(result!.row, 0);
-    });
-
-    it('should work across multiple rows in reverse', async () => {
-      await writeP(terminal, 'test Line 1\r\nLine 2\r\ntest Line 3');
-
-      // Mock selection at last "test"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 2 }, end: { x: 4, y: 2 } });
-
-      const result = searchEngine.findPreviousWithSelection('test');
-      assert.notStrictEqual(result, undefined);
-      // The algorithm will find the current selection first due to expansion attempt
-      assert.strictEqual(typeof result!.row, 'number');
-      assert.strictEqual(typeof result!.col, 'number');
-    });
-
-    it('should handle selection expansion correctly', async () => {
-      await writeP(terminal, 'Hello World Hello');
-
-      // Mock selection at first "Hello"
-      terminal.getSelectionPosition = () => ({ start: { x: 0, y: 0 }, end: { x: 5, y: 0 } });
-
-      const result = searchEngine.findPreviousWithSelection('Hello');
-      assert.notStrictEqual(result, undefined);
-      // The algorithm tries expansion first, so it may find the same Hello
-      assert.strictEqual(typeof result!.col, 'number');
-      assert.strictEqual(result!.row, 0);
-    });
-
-    it('should clear selection and return undefined when term not found', async () => {
-      await writeP(terminal, 'Hello World');
-
-      assert.strictEqual(searchEngine.findPreviousWithSelection('NotFound'), undefined);
-    });
-  });
-
-  describe('edge cases and error handling', () => {
-    describe('unicode and special characters', () => {
-      it('should handle unicode characters correctly', async () => {
-        await writeP(terminal, 'Hello 世界 World');
-
-        assert.deepStrictEqual(searchEngine.find('世界', 0, 0), {
-          term: '世界',
-          col: 6,
-          row: 0,
-          size: 4
-        });
-      });
-
-
-
-      it('should handle wide characters', async () => {
-        await writeP(terminal, '中文测试');
-
-        assert.deepStrictEqual(searchEngine.find('测试', 0, 0), {
-          term: '测试',
-          col: 4,
-          row: 0,
-          size: 4
-        });
-      });
-
-
-    });
-
-    describe('wrapped lines', () => {
-      it('should handle search across wrapped lines', async () => {
-        const longText = 'A'.repeat(100) + 'target' + 'B'.repeat(50);
-        await writeP(terminal, longText);
-
-        assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-          term: 'target',
-          col: 20,
-          row: 1,
-          size: 6
-        });
-      });
-
-      it('should handle wrapped lines with unicode', async () => {
-        const longText = '中'.repeat(50) + 'target' + '文'.repeat(30);
-        await writeP(terminal, longText);
-
-        assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-          term: 'target',
-          col: 20,
-          row: 1,
-          size: 6
-        });
-      });
-
-      it('should skip wrapped lines correctly in findInLine', async () => {
-        const longText = 'A'.repeat(200);
-        await writeP(terminal, longText + '\r\nNext line with target');
-
-        assert.deepStrictEqual(searchEngine.find('target', 0, 0), {
-          term: 'target',
-          col: 15,
-          row: 3,
-          size: 6
-        });
-      });
-    });
-
-    describe('buffer boundaries', () => {
-
-
-      it('should handle empty buffer gracefully', () => {
-        assert.strictEqual(searchEngine.find('anything', 0, 0), undefined);
-      });
-
-      it('should handle search beyond buffer size', () => {
-        assert.strictEqual(searchEngine.find('test', 1000, 0), undefined);
-      });
-    });
-
-    describe('invalid inputs', () => {
-      it('should handle undefined search options gracefully', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.deepStrictEqual(searchEngine.find('Hello', 0, 0, undefined), {
-          term: 'Hello',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle negative start positions', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.deepStrictEqual(searchEngine.find('Hello', -1, -1), {
-          term: 'Hello',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should handle search options with undefined properties', async () => {
-        await writeP(terminal, 'Hello World');
-
-        const options: ISearchOptions = {
-          caseSensitive: undefined,
-          regex: undefined,
-          wholeWord: undefined
-        };
-
-        assert.deepStrictEqual(searchEngine.find('Hello', 0, 0, options), {
-          term: 'Hello',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-      });
-    });
-  });
-
-  describe('private method behaviors (tested indirectly)', () => {
-    describe('_isWholeWord behavior', () => {
-      it('should recognize word boundaries with various punctuation', async () => {
-        await writeP(terminal, 'word1 word2,word3(word4)word5[word6]word7{word8}');
-
-        const tests = [
-          { term: 'word1', expected: true },
-          { term: 'word2', expected: true },
-          { term: 'word3', expected: true },
-          { term: 'word4', expected: true },
-          { term: 'word5', expected: true },
-          { term: 'word6', expected: true },
-          { term: 'word7', expected: true },
-          { term: 'word8', expected: true }
-        ];
-
-        for (const test of tests) {
-          const result = searchEngine.find(test.term, 0, 0, { wholeWord: true });
-          if (test.expected) {
-            assert.notStrictEqual(result, undefined, `Should find whole word: ${test.term}`);
-          } else {
-            assert.strictEqual(result, undefined, `Should not find non-whole word: ${test.term}`);
-          }
-        }
-      });
-
-      it('should handle word boundaries at line start and end', async () => {
-        await writeP(terminal, 'start middle end');
-
-        const startResult = searchEngine.find('start', 0, 0, { wholeWord: true });
-        assert.deepStrictEqual(startResult, {
-          term: 'start',
-          col: 0,
-          row: 0,
-          size: 5
-        });
-
-        const endResult = searchEngine.find('end', 0, 0, { wholeWord: true });
-        assert.deepStrictEqual(endResult, {
-          term: 'end',
-          col: 13,
-          row: 0,
-          size: 3
-        });
-
-        const middleResult = searchEngine.find('middle', 0, 0, { wholeWord: true });
-        assert.deepStrictEqual(middleResult, {
-          term: 'middle',
-          col: 6,
-          row: 0,
-          size: 6
-        });
-      });
-    });
-
-    describe('buffer offset calculations', () => {
-      it('should handle wide character offset calculations', async () => {
-        await writeP(terminal, '中文 test 测试');
-
-        const result = searchEngine.find('test', 0, 0);
-        assert.notStrictEqual(result, undefined);
-        assert.strictEqual(result!.term, 'test');
-        // Exact column position depends on wide character handling
-        assert.strictEqual(typeof result!.col, 'number');
-      });
-
-
-
-
-    });
-
-    describe('string to buffer size conversions', () => {
-      it('should correctly calculate size for simple text', async () => {
-        await writeP(terminal, 'Hello World');
-
-        assert.deepStrictEqual(searchEngine.find('World', 0, 0), {
-          term: 'World',
-          col: 6,
-          row: 0,
-          size: 5
-        });
-      });
-
-      it('should correctly calculate size for unicode text', async () => {
-        await writeP(terminal, 'Hello 世界');
-
-        const result = searchEngine.find('世界', 0, 0);
-        assert.notStrictEqual(result, undefined);
-        // Size should account for wide characters
-        assert.strictEqual(typeof result!.size, 'number');
-        assert.strictEqual(result!.size >= 2, true);
-      });
-
-      it('should handle size calculation across wrapped lines', async () => {
-        const longMatch = 'A'.repeat(100);
-        await writeP(terminal, longMatch);
-
-        const result = searchEngine.find(longMatch, 0, 0);
-        assert.notStrictEqual(result, undefined);
-        assert.strictEqual(result!.size >= 100, true);
-      });
-    });
-  });
-
-  describe('integration with SearchLineCache', () => {
-    it('should use cache for line translation', async () => {
-      await writeP(terminal, 'Hello World');
-
-      // Initialize cache
-      lineCache.initLinesCache();
-
-      const result1 = searchEngine.find('World', 0, 0);
-      const result2 = searchEngine.find('World', 0, 0);
-
-      assert.notStrictEqual(result1, undefined);
-      assert.notStrictEqual(result2, undefined);
-      assert.deepStrictEqual(result1, result2);
-    });
-
-    it('should handle cache misses gracefully', async () => {
-      await writeP(terminal, 'Hello World');
-
-      // Don't initialize cache
-      assert.deepStrictEqual(searchEngine.find('World', 0, 0), {
-        term: 'World',
-        col: 6,
-        row: 0,
-        size: 5
-      });
-    });
-
-    it('should work correctly with cache invalidation', async () => {
-      await writeP(terminal, 'Initial text');
-      lineCache.initLinesCache();
-
-      const result1 = searchEngine.find('Initial', 0, 0);
-      assert.notStrictEqual(result1, undefined);
-
-      // Change terminal content which should invalidate cache
-      await writeP(terminal, '\r\nNew line');
-
-      const result2 = searchEngine.find('New', 0, 0);
-      assert.deepStrictEqual(result2, {
-        term: 'New',
-        col: 0,
-        row: 1,
-        size: 3
-      });
-    });
-  });
-});

addons/addon-search/src/SearchEngine.ts

@@ -1,392 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { Terminal } from '@xterm/xterm';
-import type { ISearchOptions } from '@xterm/addon-search';
-import type { SearchLineCache } from './SearchLineCache';
-
-/**
- * Represents the position to start a search from.
- */
-interface ISearchPosition {
-  startCol: number;
-  startRow: number;
-}
-
-/**
- * Represents a search result with its position and content.
- */
-export interface ISearchResult {
-  term: string;
-  col: number;
-  row: number;
-  size: number;
-}
-
-/**
- * Configuration constants for the search engine functionality.
- */
-const enum Constants {
-  /**
-   * Characters that are considered non-word characters for search boundary detection. These
-   * characters are used to determine word boundaries when performing whole-word searches. Includes
-   * common punctuation, symbols, and whitespace characters.
-   */
-  NON_WORD_CHARACTERS = ' ~!@#$%^&*()+`-=[]{}|\\;:"\',./<>?'
-}
-
-/**
- * Core search engine that handles finding text within terminal content.
- * This class is responsible for the actual search algorithms and position calculations.
- */
-export class SearchEngine {
-  constructor(
-    private readonly _terminal: Terminal,
-    private readonly _lineCache: SearchLineCache
-  ) {}
-
-  /**
-   * Find the first occurrence of a term starting from a specific position.
-   * @param term The search term.
-   * @param startRow The row to start searching from.
-   * @param startCol The column to start searching from.
-   * @param searchOptions Search options.
-   * @returns The search result if found, undefined otherwise.
-   */
-  public find(term: string, startRow: number, startCol: number, searchOptions?: ISearchOptions): ISearchResult | undefined {
-    if (!term || term.length === 0) {
-      this._terminal.clearSelection();
-      return undefined;
-    }
-    if (startCol >= this._terminal.cols) {
-      throw new Error(`Invalid col: ${startCol} to search in terminal of ${this._terminal.cols} cols`);
-    }
-
-    this._lineCache.initLinesCache();
-
-    const searchPosition: ISearchPosition = {
-      startRow,
-      startCol
-    };
-
-    // Search startRow
-    let result = this._findInLine(term, searchPosition, searchOptions);
-    // Search from startRow + 1 to end
-    if (!result) {
-      for (let y = startRow + 1; y < this._terminal.buffer.active.baseY + this._terminal.rows; y++) {
-        searchPosition.startRow = y;
-        searchPosition.startCol = 0;
-        result = this._findInLine(term, searchPosition, searchOptions);
-        if (result) {
-          break;
-        }
-      }
-    }
-    return result;
-  }
-
-  /**
-   * Find the next occurrence of a term with wrapping and selection management.
-   * @param term The search term.
-   * @param searchOptions Search options.
-   * @param cachedSearchTerm The cached search term to determine incremental behavior.
-   * @returns The search result if found, undefined otherwise.
-   */
-  public findNextWithSelection(term: string, searchOptions?: ISearchOptions, cachedSearchTerm?: string): ISearchResult | undefined {
-    if (!term || term.length === 0) {
-      this._terminal.clearSelection();
-      return undefined;
-    }
-
-    const prevSelectedPos = this._terminal.getSelectionPosition();
-    this._terminal.clearSelection();
-
-    let startCol = 0;
-    let startRow = 0;
-    if (prevSelectedPos) {
-      if (cachedSearchTerm === term) {
-        startCol = prevSelectedPos.end.x;
-        startRow = prevSelectedPos.end.y;
-      } else {
-        startCol = prevSelectedPos.start.x;
-        startRow = prevSelectedPos.start.y;
-      }
-    }
-
-    this._lineCache.initLinesCache();
-
-    const searchPosition: ISearchPosition = {
-      startRow,
-      startCol
-    };
-
-    // Search startRow
-    let result = this._findInLine(term, searchPosition, searchOptions);
-    // Search from startRow + 1 to end
-    if (!result) {
-      for (let y = startRow + 1; y < this._terminal.buffer.active.baseY + this._terminal.rows; y++) {
-        searchPosition.startRow = y;
-        searchPosition.startCol = 0;
-        result = this._findInLine(term, searchPosition, searchOptions);
-        if (result) {
-          break;
-        }
-      }
-    }
-    // If we hit the bottom and didn't search from the very top wrap back up
-    if (!result && startRow !== 0) {
-      for (let y = 0; y < startRow; y++) {
-        searchPosition.startRow = y;
-        searchPosition.startCol = 0;
-        result = this._findInLine(term, searchPosition, searchOptions);
-        if (result) {
-          break;
-        }
-      }
-    }
-
-    // If there is only one result, wrap back and return selection if it exists.
-    if (!result && prevSelectedPos) {
-      searchPosition.startRow = prevSelectedPos.start.y;
-      searchPosition.startCol = 0;
-      result = this._findInLine(term, searchPosition, searchOptions);
-    }
-
-    return result;
-  }
-
-  /**
-   * Find the previous occurrence of a term with wrapping and selection management.
-   * @param term The search term.
-   * @param searchOptions Search options.
-   * @param cachedSearchTerm The cached search term to determine if expansion should occur.
-   * @returns The search result if found, undefined otherwise.
-   */
-  public findPreviousWithSelection(term: string, searchOptions?: ISearchOptions, cachedSearchTerm?: string): ISearchResult | undefined {
-    if (!term || term.length === 0) {
-      this._terminal.clearSelection();
-      return undefined;
-    }
-
-    const prevSelectedPos = this._terminal.getSelectionPosition();
-    this._terminal.clearSelection();
-
-    let startRow = this._terminal.buffer.active.baseY + this._terminal.rows - 1;
-    const startCol = this._terminal.cols;
-    const isReverseSearch = true;
-
-    this._lineCache.initLinesCache();
-    const searchPosition: ISearchPosition = {
-      startRow,
-      startCol
-    };
-
-    let result: ISearchResult | undefined;
-    if (prevSelectedPos) {
-      searchPosition.startRow = startRow = prevSelectedPos.start.y;
-      searchPosition.startCol = prevSelectedPos.start.x;
-      if (cachedSearchTerm !== term) {
-        // Try to expand selection to right first.
-        result = this._findInLine(term, searchPosition, searchOptions, false);
-        if (!result) {
-          // If selection was not able to be expanded to the right, then try reverse search
-          searchPosition.startRow = startRow = prevSelectedPos.end.y;
-          searchPosition.startCol = prevSelectedPos.end.x;
-        }
-      }
-    }
-
-    result ??= this._findInLine(term, searchPosition, searchOptions, isReverseSearch);
-
-    // Search from startRow - 1 to top
-    if (!result) {
-      searchPosition.startCol = Math.max(searchPosition.startCol, this._terminal.cols);
-      for (let y = startRow - 1; y >= 0; y--) {
-        searchPosition.startRow = y;
-        result = this._findInLine(term, searchPosition, searchOptions, isReverseSearch);
-        if (result) {
-          break;
-        }
-      }
-    }
-    // If we hit the top and didn't search from the very bottom wrap back down
-    if (!result && startRow !== (this._terminal.buffer.active.baseY + this._terminal.rows - 1)) {
-      for (let y = (this._terminal.buffer.active.baseY + this._terminal.rows - 1); y >= startRow; y--) {
-        searchPosition.startRow = y;
-        result = this._findInLine(term, searchPosition, searchOptions, isReverseSearch);
-        if (result) {
-          break;
-        }
-      }
-    }
-
-    return result;
-  }
-
-  /**
-   * A found substring is a whole word if it doesn't have an alphanumeric character directly
-   * adjacent to it.
-   * @param searchIndex starting index of the potential whole word substring
-   * @param line entire string in which the potential whole word was found
-   * @param term the substring that starts at searchIndex
-   */
-  private _isWholeWord(searchIndex: number, line: string, term: string): boolean {
-    return ((searchIndex === 0) || (Constants.NON_WORD_CHARACTERS.includes(line[searchIndex - 1]))) &&
-      (((searchIndex + term.length) === line.length) || (Constants.NON_WORD_CHARACTERS.includes(line[searchIndex + term.length])));
-  }
-
-  /**
-   * Searches a line for a search term. Takes the provided terminal line and searches the text line,
-   * which may contain subsequent terminal lines if the text is wrapped. If the provided line number
-   * is part of a wrapped text line that started on an earlier line then it is skipped since it will
-   * be properly searched when the terminal line that the text starts on is searched.
-   * @param term The search term.
-   * @param searchPosition The position to start the search.
-   * @param searchOptions Search options.
-   * @param isReverseSearch Whether the search should start from the right side of the terminal and
-   * search to the left.
-   * @returns The search result if it was found.
-   */
-  private _findInLine(term: string, searchPosition: ISearchPosition, searchOptions: ISearchOptions = {}, isReverseSearch: boolean = false): ISearchResult | undefined {
-    const row = searchPosition.startRow;
-    const col = searchPosition.startCol;
-
-    // Ignore wrapped lines, only consider on unwrapped line (first row of command string).
-    const firstLine = this._terminal.buffer.active.getLine(row);
-    if (firstLine?.isWrapped) {
-      if (isReverseSearch) {
-        searchPosition.startCol += this._terminal.cols;
-        return;
-      }
-
-      // This will iterate until we find the line start.
-      // When we find it, we will search using the calculated start column.
-      searchPosition.startRow--;
-      searchPosition.startCol += this._terminal.cols;
-      return this._findInLine(term, searchPosition, searchOptions);
-    }
-    let cache = this._lineCache.getLineFromCache(row);
-    if (!cache) {
-      cache = this._lineCache.translateBufferLineToStringWithWrap(row, true);
-      this._lineCache.setLineInCache(row, cache);
-    }
-    const [stringLine, offsets] = cache;
-
-    const offset = this._bufferColsToStringOffset(row, col);
-    let searchTerm = term;
-    let searchStringLine = stringLine;
-    if (!searchOptions.regex) {
-      searchTerm = searchOptions.caseSensitive ? term : term.toLowerCase();
-      searchStringLine = searchOptions.caseSensitive ? stringLine : stringLine.toLowerCase();
-    }
-
-    let resultIndex = -1;
-    if (searchOptions.regex) {
-      const searchRegex = RegExp(searchTerm, searchOptions.caseSensitive ? 'g' : 'gi');
-      let foundTerm: RegExpExecArray | null;
-      if (isReverseSearch) {
-        // This loop will get the resultIndex of the _last_ regex match in the range 0..offset
-        while (foundTerm = searchRegex.exec(searchStringLine.slice(0, offset))) {
-          resultIndex = searchRegex.lastIndex - foundTerm[0].length;
-          term = foundTerm[0];
-          searchRegex.lastIndex -= (term.length - 1);
-        }
-      } else {
-        foundTerm = searchRegex.exec(searchStringLine.slice(offset));
-        if (foundTerm && foundTerm[0].length > 0) {
-          resultIndex = offset + (searchRegex.lastIndex - foundTerm[0].length);
-          term = foundTerm[0];
-        }
-      }
-    } else {
-      if (isReverseSearch) {
-        if (offset - searchTerm.length >= 0) {
-          resultIndex = searchStringLine.lastIndexOf(searchTerm, offset - searchTerm.length);
-        }
-      } else {
-        resultIndex = searchStringLine.indexOf(searchTerm, offset);
-      }
-    }
-
-    if (resultIndex >= 0) {
-      if (searchOptions.wholeWord && !this._isWholeWord(resultIndex, searchStringLine, term)) {
-        return;
-      }
-
-      // Adjust the row number and search index if needed since a "line" of text can span multiple
-      // rows
-      let startRowOffset = 0;
-      while (startRowOffset < offsets.length - 1 && resultIndex >= offsets[startRowOffset + 1]) {
-        startRowOffset++;
-      }
-      let endRowOffset = startRowOffset;
-      while (endRowOffset < offsets.length - 1 && resultIndex + term.length >= offsets[endRowOffset + 1]) {
-        endRowOffset++;
-      }
-      const startColOffset = resultIndex - offsets[startRowOffset];
-      const endColOffset = resultIndex + term.length - offsets[endRowOffset];
-      const startColIndex = this._stringLengthToBufferSize(row + startRowOffset, startColOffset);
-      const endColIndex = this._stringLengthToBufferSize(row + endRowOffset, endColOffset);
-      const size = endColIndex - startColIndex + this._terminal.cols * (endRowOffset - startRowOffset);
-
-      return {
-        term,
-        col: startColIndex,
-        row: row + startRowOffset,
-        size
-      };
-    }
-  }
-
-  private _stringLengthToBufferSize(row: number, offset: number): number {
-    const line = this._terminal.buffer.active.getLine(row);
-    if (!line) {
-      return 0;
-    }
-    for (let i = 0; i < offset; i++) {
-      const cell = line.getCell(i);
-      if (!cell) {
-        break;
-      }
-      // Adjust the searchIndex to normalize emoji into single chars
-      const char = cell.getChars();
-      if (char.length > 1) {
-        offset -= char.length - 1;
-      }
-      // Adjust the searchIndex for empty characters following wide unicode
-      // chars (eg. CJK)
-      const nextCell = line.getCell(i + 1);
-      if (nextCell && nextCell.getWidth() === 0) {
-        offset++;
-      }
-    }
-    return offset;
-  }
-
-  private _bufferColsToStringOffset(startRow: number, cols: number): number {
-    let lineIndex = startRow;
-    let offset = 0;
-    let line = this._terminal.buffer.active.getLine(lineIndex);
-    while (cols > 0 && line) {
-      for (let i = 0; i < cols && i < this._terminal.cols; i++) {
-        const cell = line.getCell(i);
-        if (!cell) {
-          break;
-        }
-        if (cell.getWidth()) {
-          // Treat null characters as whitespace to align with the translateToString API
-          offset += cell.getCode() === 0 ? 1 : cell.getChars().length;
-        }
-      }
-      lineIndex++;
-      line = this._terminal.buffer.active.getLine(lineIndex);
-      if (line && !line.isWrapped) {
-        break;
-      }
-      cols -= this._terminal.cols;
-    }
-    return offset;
-  }
-}

addons/addon-search/src/SearchLineCache.test.ts

@@ -1,287 +0,0 @@
-/**
- * Copyright (c) 2024 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-import { assert } from 'chai';
-import { SearchLineCache, LineCacheEntry } from './SearchLineCache';
-import { Terminal } from 'browser/public/Terminal';
-import { timeout } from 'common/Async';
-
-function writeP(terminal: Terminal, data: string): Promise<void> {
-  return new Promise(r => terminal.write(data, r));
-}
-
-describe('SearchLineCache', () => {
-  let terminal: Terminal;
-  let cache: SearchLineCache;
-
-  beforeEach(() => {
-    terminal = new Terminal({ cols: 80, rows: 24 });
-    cache = new SearchLineCache(terminal);
-  });
-
-  afterEach(() => {
-    cache.dispose();
-    terminal.dispose();
-  });
-
-  describe('constructor', () => {
-    it('should create a SearchLineCache instance', () => {
-      assert.instanceOf(cache, SearchLineCache);
-    });
-
-    it('should start with no cache initialized', () => {
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-  });
-
-  describe('initLinesCache', () => {
-    it('should initialize the lines cache array', () => {
-      cache.initLinesCache();
-      assert.equal(cache.getLineFromCache(0), undefined, 'cache should be initialized but empty');
-    });
-
-    it('should not reinitialize if cache already exists', () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      cache.initLinesCache();
-
-      const entry = cache.getLineFromCache(0);
-      assert.deepEqual(entry, ['test', [0]], 'cache should still contain the previously set entry');
-    });
-
-    it('should set up TTL timeout', () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]], 'entry should exist after initialization');
-    });
-  });
-
-  describe('getLineFromCache', () => {
-    it('should return undefined when cache is not initialized', () => {
-      assert.equal(cache.getLineFromCache(0), undefined);
-      assert.equal(cache.getLineFromCache(10), undefined);
-    });
-
-    it('should return undefined for unset entries when cache is initialized', () => {
-      cache.initLinesCache();
-      assert.equal(cache.getLineFromCache(0), undefined);
-      assert.equal(cache.getLineFromCache(50), undefined);
-    });
-
-    it('should return cached entries', () => {
-      cache.initLinesCache();
-      const entry: LineCacheEntry = ['test content', [0]];
-      cache.setLineInCache(5, entry);
-
-      assert.deepEqual(cache.getLineFromCache(5), entry);
-    });
-  });
-
-  describe('setLineInCache', () => {
-    it('should not set entries when cache is not initialized', () => {
-      const entry: LineCacheEntry = ['test content', [0]];
-      cache.setLineInCache(0, entry);
-
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-
-    it('should set entries when cache is initialized', () => {
-      cache.initLinesCache();
-      const entry: LineCacheEntry = ['test content', [0]];
-      cache.setLineInCache(10, entry);
-
-      assert.deepEqual(cache.getLineFromCache(10), entry);
-    });
-
-    it('should overwrite existing entries', () => {
-      cache.initLinesCache();
-      const entry1: LineCacheEntry = ['first content', [0]];
-      const entry2: LineCacheEntry = ['second content', [0]];
-
-      cache.setLineInCache(0, entry1);
-      assert.deepEqual(cache.getLineFromCache(0), entry1);
-
-      cache.setLineInCache(0, entry2);
-      assert.deepEqual(cache.getLineFromCache(0), entry2);
-    });
-  });
-
-  describe('translateBufferLineToStringWithWrap', () => {
-    it('should translate a single line without wrapping', async () => {
-      await writeP(terminal, 'Hello World');
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], 'Hello World');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle trimRight parameter', async () => {
-      await writeP(terminal, 'Hello World   ');
-      const resultTrimmed = cache.translateBufferLineToStringWithWrap(0, true);
-      const resultNotTrimmed = cache.translateBufferLineToStringWithWrap(0, false);
-
-      assert.equal(resultTrimmed[0].trimEnd(), 'Hello World');
-      assert.isTrue(resultNotTrimmed[0].startsWith('Hello World   '));
-      assert.isTrue(resultNotTrimmed[0].length > resultTrimmed[0].length, 'non-trimmed result should be longer');
-    });
-
-    it('should handle wrapped lines', async () => {
-      const longText = 'A'.repeat(200);
-      await writeP(terminal, longText);
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], longText);
-      assert.isTrue(result[1].length > 1, 'should have multiple offsets due to wrapping');
-      assert.equal(result[1][0], 0, 'first offset should be 0');
-    });
-
-    it('should handle wide characters', async () => {
-      await writeP(terminal, 'Hello 世界');
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], 'Hello 世界');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle empty lines', () => {
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], '');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle lines beyond buffer', () => {
-      const result = cache.translateBufferLineToStringWithWrap(1000, true);
-      assert.equal(result[0], '');
-      assert.deepEqual(result[1], [0]);
-    });
-
-    it('should handle complex wrapped content', async () => {
-      await writeP(terminal, 'Line 1\r\n');
-      await writeP(terminal, 'Line 2 with some longer content that might wrap\r\n');
-      await writeP(terminal, 'Line 3');
-
-      const result1 = cache.translateBufferLineToStringWithWrap(0, true);
-      const result2 = cache.translateBufferLineToStringWithWrap(1, true);
-      const result3 = cache.translateBufferLineToStringWithWrap(2, true);
-
-      assert.equal(result1[0], 'Line 1');
-      assert.equal(result2[0], 'Line 2 with some longer content that might wrap');
-      assert.equal(result3[0], 'Line 3');
-    });
-  });
-
-  describe('cache invalidation', () => {
-    it('should invalidate cache on line feed', async () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      terminal.write('test\r\n');
-
-      await timeout(10);
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-
-    it('should invalidate cache on cursor move', async () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      await writeP(terminal, 'some text');
-      await timeout(10);
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-
-    it('should invalidate cache on resize', async () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      terminal.resize(100, 30);
-
-      await timeout(10);
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-  });
-
-  describe('disposal', () => {
-    it('should clean up resources on dispose', () => {
-      cache.initLinesCache();
-      cache.setLineInCache(0, ['test', [0]]);
-
-      assert.deepEqual(cache.getLineFromCache(0), ['test', [0]]);
-
-      cache.dispose();
-
-      assert.equal(cache.getLineFromCache(0), undefined, 'cache should be destroyed after disposal');
-    });
-
-    it('should be safe to dispose multiple times', () => {
-      cache.initLinesCache();
-      cache.dispose();
-      cache.dispose();
-
-      assert.equal(cache.getLineFromCache(0), undefined);
-    });
-  });
-
-  describe('LineCacheEntry type', () => {
-    it('should handle complex line offsets', () => {
-      const entry: LineCacheEntry = [
-        'A very long line that wraps multiple times across several terminal lines',
-        [0, 20, 40, 60]
-      ];
-
-      cache.initLinesCache();
-      cache.setLineInCache(0, entry);
-
-      const retrieved = cache.getLineFromCache(0);
-      assert.deepEqual(retrieved, entry);
-      assert.equal(retrieved![0].length, 72);
-      assert.equal(retrieved![1].length, 4);
-    });
-
-    it('should handle unicode characters in cache entries', () => {
-      const entry: LineCacheEntry = [
-        'Hello 世界 🌍 测试',
-        [0]
-      ];
-
-      cache.initLinesCache();
-      cache.setLineInCache(0, entry);
-
-      const retrieved = cache.getLineFromCache(0);
-      assert.deepEqual(retrieved, entry);
-      assert.equal(retrieved![0], 'Hello 世界 🌍 测试');
-    });
-  });
-
-  describe('integration with real terminal content', () => {
-    it('should correctly translate real buffer content', async () => {
-      await writeP(terminal, 'Hello World');
-      const cached = cache.translateBufferLineToStringWithWrap(0, true);
-      const directTranslation = terminal.buffer.active.getLine(0)?.translateToString(true) || '';
-
-      assert.equal(cached[0], directTranslation);
-    });
-
-    it('should handle real wrapped content correctly', async () => {
-      const longContent = 'This is a very long line that will definitely wrap around in an 80 column terminal and should be handled correctly by the cache';
-      await writeP(terminal, longContent);
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.equal(result[0], longContent);
-      assert.isTrue(result[1].length > 1, 'should have wrapped');
-    });
-
-    it('should work with real escape sequences', async () => {
-      await writeP(terminal, 'Before\x1b[31mRed Text\x1b[0mAfter');
-      const result = cache.translateBufferLineToStringWithWrap(0, true);
-      assert.include(result[0], 'Before');
-      assert.include(result[0], 'Red Text');
-      assert.include(result[0], 'After');
-    });
-  });
-});

addons/addon-search/src/SearchLineCache.ts

@@ -1,136 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { Terminal } from '@xterm/xterm';
-import { combinedDisposable, Disposable, MutableDisposable, toDisposable } from 'common/Lifecycle';
-import { disposableTimeout } from 'common/Async';
-
-export type LineCacheEntry = [
-  /**
-   * The string representation of a line (as opposed to the buffer cell representation).
-   */
-  lineAsString: string,
-  /**
-   * The offsets where each line starts when the entry describes a wrapped line.
-   */
-  lineOffsets: number[]
-];
-
-/**
- * Configuration constants for the search line cache functionality.
- */
-const enum Constants {
-  /**
-   * Time-to-live for cached search results in milliseconds. After this duration, cached search
-   * results will be invalidated to ensure they remain consistent with terminal content changes.
-   */
-  LINES_CACHE_TIME_TO_LIVE = 15000
-}
-
-export class SearchLineCache extends Disposable {
-  /**
-   * translateBufferLineToStringWithWrap is a fairly expensive call.
-   * We memoize the calls into an array that has a time based ttl.
-   * _linesCache is also invalidated when the terminal cursor moves.
-   */
-  private _linesCache: LineCacheEntry[] | undefined;
-  private _linesCacheTimeout = this._register(new MutableDisposable());
-  private _linesCacheDisposables = this._register(new MutableDisposable());
-  // Track access to avoid recreating a timeout on every init call which occurs once per search
-  // result (findNext/findPrevious -> _highlightAllMatches -> find loop).
-  private _lastAccessTimestamp = 0;
-
-  constructor(private readonly _terminal: Terminal) {
-    super();
-    this._register(toDisposable(() => this._destroyLinesCache()));
-  }
-
-  /**
-   * Sets up a line cache with a ttl
-   */
-  public initLinesCache(): void {
-    if (!this._linesCache) {
-      this._linesCache = new Array(this._terminal.buffer.active.length);
-      this._linesCacheDisposables.value = combinedDisposable(
-        this._terminal.onLineFeed(() => this._destroyLinesCache()),
-        this._terminal.onCursorMove(() => this._destroyLinesCache()),
-        this._terminal.onResize(() => this._destroyLinesCache())
-      );
-    }
-
-    this._lastAccessTimestamp = Date.now();
-    if (!this._linesCacheTimeout.value) {
-      this._scheduleLinesCacheTimeout(Constants.LINES_CACHE_TIME_TO_LIVE);
-    }
-  }
-
-  private _destroyLinesCache(): void {
-    this._linesCache = undefined;
-    this._lastAccessTimestamp = 0;
-    this._linesCacheDisposables.clear();
-    this._linesCacheTimeout.clear();
-  }
-
-  private _scheduleLinesCacheTimeout(delay: number): void {
-    this._linesCacheTimeout.value = disposableTimeout(() => {
-      if (!this._linesCache) {
-        return;
-      }
-      const now = Date.now();
-      const elapsed = now - this._lastAccessTimestamp;
-      if (elapsed >= Constants.LINES_CACHE_TIME_TO_LIVE) {
-        this._destroyLinesCache();
-        return;
-      }
-      this._scheduleLinesCacheTimeout(Constants.LINES_CACHE_TIME_TO_LIVE - elapsed);
-    }, delay);
-  }
-
-  public getLineFromCache(row: number): LineCacheEntry | undefined {
-    return this._linesCache?.[row];
-  }
-
-  public setLineInCache(row: number, entry: LineCacheEntry): void {
-    if (this._linesCache) {
-      this._linesCache[row] = entry;
-    }
-  }
-
-  /**
-   * Translates a buffer line to a string, including subsequent lines if they are wraps.
-   * Wide characters will count as two columns in the resulting string. This
-   * function is useful for getting the actual text underneath the raw selection
-   * position.
-   * @param lineIndex The index of the line being translated.
-   * @param trimRight Whether to trim whitespace to the right.
-   */
-  public translateBufferLineToStringWithWrap(lineIndex: number, trimRight: boolean): LineCacheEntry {
-    const strings = [];
-    const lineOffsets = [0];
-    let line = this._terminal.buffer.active.getLine(lineIndex);
-    while (line) {
-      const nextLine = this._terminal.buffer.active.getLine(lineIndex + 1);
-      const lineWrapsToNext = nextLine ? nextLine.isWrapped : false;
-      let string = line.translateToString(!lineWrapsToNext && trimRight);
-      if (lineWrapsToNext && nextLine) {
-        const lastCell = line.getCell(line.length - 1);
-        const lastCellIsNull = lastCell && lastCell.getCode() === 0 && lastCell.getWidth() === 1;
-        // a wide character wrapped to the next line
-        if (lastCellIsNull && nextLine.getCell(0)?.getWidth() === 2) {
-          string = string.slice(0, -1);
-        }
-      }
-      strings.push(string);
-      if (lineWrapsToNext) {
-        lineOffsets.push(lineOffsets[lineOffsets.length - 1] + string.length);
-      } else {
-        break;
-      }
-      lineIndex++;
-      line = nextLine;
-    }
-    return [strings.join(''), lineOffsets];
-  }
-}

addons/addon-search/src/SearchResultTracker.ts

@@ -1,119 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { ISearchResultChangeEvent } from '@xterm/addon-search';
-import type { IDisposable } from '@xterm/xterm';
-import { Emitter, type IEvent } from 'common/Event';
-import { Disposable } from 'common/Lifecycle';
-import type { ISearchResult } from './SearchEngine';
-
-/**
- * Interface for managing a currently selected decoration.
- */
-interface ISelectedDecoration extends IDisposable {
-  match: ISearchResult;
-}
-
-/**
- * Tracks search results, manages result indexing, and fires events when results change.
- * This class provides centralized management of search result state and notifications.
- */
-export class SearchResultTracker extends Disposable {
-  private _searchResults: ISearchResult[] = [];
-  private _selectedDecoration: ISelectedDecoration | undefined;
-
-  private readonly _onDidChangeResults = this._register(new Emitter<ISearchResultChangeEvent>());
-  public get onDidChangeResults(): IEvent<ISearchResultChangeEvent> { return this._onDidChangeResults.event; }
-
-  /**
-   * Gets the current search results.
-   */
-  public get searchResults(): ReadonlyArray<ISearchResult> {
-    return this._searchResults;
-  }
-
-  /**
-   * Gets the currently selected decoration.
-   */
-  public get selectedDecoration(): ISelectedDecoration | undefined {
-    return this._selectedDecoration;
-  }
-
-  /**
-   * Sets the currently selected decoration.
-   */
-  public set selectedDecoration(decoration: ISelectedDecoration | undefined) {
-    this._selectedDecoration = decoration;
-  }
-
-  /**
-   * Updates the search results with a new set of results.
-   * @param results The new search results.
-   * @param maxResults The maximum number of results to track.
-   */
-  public updateResults(results: ISearchResult[], maxResults: number): void {
-    this._searchResults = results.slice(0, maxResults);
-  }
-
-  /**
-   * Clears all search results.
-   */
-  public clearResults(): void {
-    this._searchResults = [];
-  }
-
-  /**
-   * Clears the selected decoration.
-   */
-  public clearSelectedDecoration(): void {
-    if (this._selectedDecoration) {
-      this._selectedDecoration.dispose();
-      this._selectedDecoration = undefined;
-    }
-  }
-
-  /**
-   * Finds the index of a result in the current results array.
-   * @param result The result to find.
-   * @returns The index of the result, or -1 if not found.
-   */
-  public findResultIndex(result: ISearchResult): number {
-    for (let i = 0; i < this._searchResults.length; i++) {
-      const match = this._searchResults[i];
-      if (match.row === result.row && match.col === result.col && match.size === result.size) {
-        return i;
-      }
-    }
-    return -1;
-  }
-
-  /**
-   * Fires a result change event with the current state.
-   * @param hasDecorations Whether decorations are enabled.
-   */
-  public fireResultsChanged(hasDecorations: boolean): void {
-    if (!hasDecorations) {
-      return;
-    }
-
-    let resultIndex = -1;
-    if (this._selectedDecoration) {
-      resultIndex = this.findResultIndex(this._selectedDecoration.match);
-    }
-
-    this._onDidChangeResults.fire({
-      resultIndex,
-      resultCount: this._searchResults.length
-    });
-  }
-
-  /**
-   * Resets all state.
-   */
-  public reset(): void {
-    this.clearSelectedDecoration();
-    this.clearResults();
-  }
-}

addons/addon-search/src/SearchState.ts

@@ -1,106 +0,0 @@
-/**
- * Copyright (c) 2017 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import type { ISearchOptions } from '@xterm/addon-search';
-
-/**
- * Manages search state including cached search terms, options tracking, and validation.
- * This class provides a centralized way to handle search state consistency and option changes.
- */
-export class SearchState {
-  private _cachedSearchTerm: string | undefined;
-  private _lastSearchOptions: ISearchOptions | undefined;
-
-  /**
-   * Gets the currently cached search term.
-   */
-  public get cachedSearchTerm(): string | undefined {
-    return this._cachedSearchTerm;
-  }
-
-  /**
-   * Sets the cached search term.
-   */
-  public set cachedSearchTerm(term: string | undefined) {
-    this._cachedSearchTerm = term;
-  }
-
-  /**
-   * Gets the last search options used.
-   */
-  public get lastSearchOptions(): ISearchOptions | undefined {
-    return this._lastSearchOptions;
-  }
-
-  /**
-   * Sets the last search options used.
-   */
-  public set lastSearchOptions(options: ISearchOptions | undefined) {
-    this._lastSearchOptions = options;
-  }
-
-  /**
-   * Validates a search term to ensure it's not empty or invalid.
-   * @param term The search term to validate.
-   * @returns true if the term is valid for searching.
-   */
-  public isValidSearchTerm(term: string): boolean {
-    return !!(term && term.length > 0);
-  }
-
-  /**
-   * Determines if search options have changed compared to the last search.
-   * @param newOptions The new search options to compare.
-   * @returns true if the options have changed.
-   */
-  public didOptionsChange(newOptions?: ISearchOptions): boolean {
-    if (!this._lastSearchOptions) {
-      return true;
-    }
-    if (!newOptions) {
-      return false;
-    }
-    if (this._lastSearchOptions.caseSensitive !== newOptions.caseSensitive) {
-      return true;
-    }
-    if (this._lastSearchOptions.regex !== newOptions.regex) {
-      return true;
-    }
-    if (this._lastSearchOptions.wholeWord !== newOptions.wholeWord) {
-      return true;
-    }
-    return false;
-  }
-
-  /**
-   * Determines if a new search should trigger highlighting updates.
-   * @param term The search term.
-   * @param options The search options.
-   * @returns true if highlighting should be updated.
-   */
-  public shouldUpdateHighlighting(term: string, options?: ISearchOptions): boolean {
-    if (!options?.decorations) {
-      return false;
-    }
-    return this._cachedSearchTerm === undefined ||
-           term !== this._cachedSearchTerm ||
-           this.didOptionsChange(options);
-  }
-
-  /**
-   * Clears the cached search term.
-   */
-  public clearCachedTerm(): void {
-    this._cachedSearchTerm = undefined;
-  }
-
-  /**
-   * Resets all state.
-   */
-  public reset(): void {
-    this._cachedSearchTerm = undefined;
-    this._lastSearchOptions = undefined;
-  }
-}

addons/addon-search/test/SearchAddon.test.ts

@@ -45,6 +45,45 @@ test.describe('Search Tests', () => {
     deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('$^1_3{}test$#')`), true);
     deepStrictEqual(await ctx.proxy.getSelection(), '$^1_3{}test$#');
   });
+  test('Search should not scroll when match is already in viewport', async () => {
+    let dataString = '';
+    for (let i = 0; i < 100; i++) {
+      if (i === 40) {
+        dataString += `line ${i} needle-in-view`;
+      } else {
+        dataString += `line ${i}`;
+      }
+      dataString += '\n\r';
+    }
+    await ctx.proxy.write(dataString);
+    await ctx.page.evaluate('window.term.scrollToLine(35)');
+    strictEqual(await ctx.page.evaluate('window.term.buffer.active.viewportY'), 35);
+
+    strictEqual(await ctx.page.evaluate(`window.search.findNext('needle-in-view')`), true);
+    deepStrictEqual(await ctx.proxy.getSelection(), 'needle-in-view');
+    strictEqual(await ctx.page.evaluate('window.term.buffer.active.viewportY'), 35);
+  });
+  test('Search should center the match when it is outside the viewport', async () => {
+    let dataString = '';
+    for (let i = 0; i < 100; i++) {
+      if (i === 60) {
+        dataString += `line ${i} needle-center`;
+      } else {
+        dataString += `line ${i}`;
+      }
+      dataString += '\n\r';
+    }
+    await ctx.proxy.write(dataString);
+    await ctx.page.evaluate('window.term.scrollToLine(0)');
+    strictEqual(await ctx.page.evaluate('window.term.buffer.active.viewportY'), 0);
+
+    strictEqual(await ctx.page.evaluate(`window.search.findNext('needle-center')`), true);
+    deepStrictEqual(await ctx.proxy.getSelection(), 'needle-center');
+    deepStrictEqual(await ctx.page.evaluate('(() => { const viewportY = window.term.buffer.active.viewportY; const rows = window.term.rows; const selection = window.term.getSelectionPosition(); return { viewportY: viewportY, expectedViewportY: selection.start.y - Math.floor(rows / 2) }; })()'), {
+      viewportY: 48,
+      expectedViewportY: 48
+    });
+  });
   test('Incremental Find Previous', async () => {
     await ctx.proxy.writeln(`package.jsonc\n`);
     await ctx.proxy.write('package.json pack package.lock');
@@ -277,8 +316,7 @@ test.describe('Search Tests', () => {
           { resultCount: 1, resultIndex: 0 },
           { resultCount: 2, resultIndex: 1 }
         ]);
-        await timeout(2000);
-        strictEqual(await ctx.page.evaluate(`debugger; window.search.findPrevious('d', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), false);
+        strictEqual(await ctx.page.evaluate(`window.search.findPrevious('d', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), false);
         deepStrictEqual(await ctx.page.evaluate('window.calls'), [
           { resultCount: 1, resultIndex: 0 },
           { resultCount: 2, resultIndex: 1 },
@@ -417,7 +455,7 @@ test.describe('Search Tests', () => {
     test.describe('#2444 wrapped line content not being found', () => {
       let fixture: string;
       test.beforeAll(async () => {
-        fixture = (await new Promise<Buffer>((res, rej) => readFile(resolve(__dirname, '../fixtures/issue-2444'), (err, data) => err ? rej(err) : res(data)))).toString();
+        fixture = (await new Promise<Buffer>(r => readFile(resolve(__dirname, '../fixtures/issue-2444'), (err, data) => r(data)))).toString();
         if (process.platform !== 'win32') {
           fixture = fixture.replace(/\n/g, '\n\r');
         }
@@ -501,7 +539,7 @@ test.describe('Search Tests', () => {
         window.search.onDidChangeResults(e => window.calls.push(e));
       `);
       // Move cursor forward 1 time to create a null character, as opposed to regular whitespace
-      await ctx.proxy.write('\x1b[CHi Hi');
+      await ctx.proxy.write('\\x1b[CHi Hi');
       strictEqual(await ctx.page.evaluate(`window.search.findPrevious('h', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
         { resultCount: 2, resultIndex: 1 }

addons/addon-search/tsconfig.json

@@ -3,6 +3,7 @@
   "include": [],
   "references": [
     { "path": "./src" },
-    { "path": "./test" }
+    { "path": "./test" },
+    { "path": "./benchmark" }
   ]
 }

addons/addon-search/typings/addon-search.d.ts

@@ -17,7 +17,8 @@ declare module '@xterm/addon-search' {
 
     /**
      * Whether to search for a whole word, the result is only valid if it's
-     * surrounded in "non-word" characters such as `_`, `(`, `)` or space.
+     * surrounded by start/end of line or non-word separators such as whitespace
+     * and punctuation (for example `(`, `)`, or space).
      */
     wholeWord?: boolean;
 
@@ -28,8 +29,7 @@ declare module '@xterm/addon-search' {
 
     /**
      * Whether to do an incremental search, this will expand the selection if it
-     * still matches the term the user typed. Note that this only affects
-     * `findNext`, not `findPrevious`.
+     * still matches the term the user typed.
      */
     incremental?: boolean;
 
@@ -43,7 +43,7 @@ declare module '@xterm/addon-search' {
   /**
    * Options for showing decorations when searching.
    */
-  interface ISearchDecorationOptions {
+  export interface ISearchDecorationOptions {
     /**
      * The background color of a match, this must use #RRGGBB format.
      */
@@ -57,7 +57,7 @@ declare module '@xterm/addon-search' {
     /**
      * The overview ruler color of a match.
      */
-    matchOverviewRuler: string;
+    matchOverviewRuler?: string;
 
     /**
      * The background color for the currently active match, this must use #RRGGBB format.
@@ -72,7 +72,7 @@ declare module '@xterm/addon-search' {
     /**
      * The overview ruler color of the currently active match.
      */
-    activeMatchColorOverviewRuler: string;
+    activeMatchColorOverviewRuler?: string;
   }
 
   /**
@@ -80,12 +80,13 @@ declare module '@xterm/addon-search' {
    */
   export interface ISearchResultChangeEvent {
     /**
-     * The index of the currently active result, -1 when the threshold of matches is exceeded.
+     * The index of the currently active result within tracked highlights, or -1 when
+     * the active match is not in the tracked result set.
      */
     resultIndex: number;
 
     /**
-     * The total number of search results found.
+     * The number of tracked search results (capped by `highlightLimit` when decorations are enabled).
      */
     resultCount: number;
   }
@@ -96,9 +97,9 @@ declare module '@xterm/addon-search' {
   export interface ISearchAddonOptions {
     /**
      * Max number of matches highlighted when decorations are enabled.
-     * Defaults to 1000 highlighted matches
+     * Defaults to 1000. Invalid values fall back to the default.
      */
-    highlightLimit: number
+    highlightLimit?: number;
   }
 
   /**
@@ -140,7 +141,7 @@ declare module '@xterm/addon-search' {
     public findPrevious(term: string, searchOptions?: ISearchOptions): boolean;
 
     /**
-     * Clears the decorations and selection
+     * Clears highlight decorations and tracked results.
      */
     public clearDecorations(): void;
 
@@ -162,7 +163,8 @@ declare module '@xterm/addon-search' {
     readonly onBeforeSearch: IEvent<void>;
 
     /**
-     * When decorations are enabled, fires when the search results change.
+     * When decorations are enabled, fires after `findNext`/`findPrevious` when tracked
+     * search results change. Does not fire from `clearDecorations()`.
      */
     readonly onDidChangeResults: IEvent<ISearchResultChangeEvent>;
   }

addons/addon-serialize/benchmark/tsconfig.json

@@ -7,10 +7,10 @@
     "rootDir": "..",
     "outDir": "../out-benchmark",
     "types": ["../../../node_modules/@types/node"],
-    "moduleResolution": "nodenext",
+    "moduleResolution": "node",
     "strict": false,
     "target": "es2021",
-    "module": "nodenext",
+    "module": "commonjs",
     "paths": {
       "common/*": ["../../../src/common/*"],
       "browser/*": ["../../../src/browser/*"],

addons/addon-serialize/package.json

@@ -21,8 +21,8 @@
     "package": "../../node_modules/.bin/webpack",
     "prepublishOnly": "npm run package",
     "start": "node ../../demo/start",
-    "benchmark": "../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json",
-    "benchmark-baseline": "../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --baseline out-benchmark/benchmark/*benchmark.js",
-    "benchmark-eval": "../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --eval out-benchmark/benchmark/*benchmark.js"
+    "benchmark": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json",
+    "benchmark-baseline": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --baseline out-benchmark/benchmark/*benchmark.js",
+    "benchmark-eval": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --eval out-benchmark/benchmark/*benchmark.js"
   }
 }

addons/addon-serialize/src/SerializeAddon.ts

@@ -7,8 +7,7 @@
 
 import type { IBuffer, IBufferCell, IBufferRange, ITerminalAddon, Terminal } from '@xterm/xterm';
 import type { IHTMLSerializeOptions, SerializeAddon as ISerializeApi, ISerializeOptions, ISerializeRange } from '@xterm/addon-serialize';
-import { IColor } from 'common/Types';
-import { IAttributeData } from 'common/buffer/Types';
+import { IAttributeData, IColor } from 'common/Types';
 import { DEFAULT_ANSI_COLORS } from 'browser/Types';
 import { UnderlineStyle } from 'common/buffer/Constants';
 
@@ -173,7 +172,7 @@ class StringSerializeHandler extends BaseSerializeHandler {
   private _thisRowLastSecondChar: IBufferCell = this._buffer.getNullCell();
   private _nextRowFirstChar: IBufferCell = this._buffer.getNullCell();
   protected _rowEnd(row: number, isLastRow: boolean): void {
-    // if there is colorful empty cell at line end, we must pad it back, or the color block
+    // if there is colorful empty cell at line end, whe must pad it back, or the the color block
     // will missing
     if (this._nullCellCount > 0 && !equalBg(this._cursorStyle, this._backgroundCell)) {
       // use clear right to set background.
@@ -221,7 +220,7 @@ class StringSerializeHandler extends BaseSerializeHandler {
             // you can't use control sequence to move cursor to (x === row)
             (thisRowLastChar.getChars() || thisRowLastChar.getWidth() === 0) &&
             // change background of the first wrapped cell also affects BCE
-            // so we mark it as invalid to simplify the process to determine line separator
+            // so we mark it as invalid to simply the process to determine line separator
             equalBg(thisRowLastChar, nextRowFirstChar)
           ) {
             isValid = true;
@@ -233,7 +232,7 @@ class StringSerializeHandler extends BaseSerializeHandler {
             isNextRowFirstCharDoubleWidth &&
             (thisRowLastSecondChar.getChars() || thisRowLastSecondChar.getWidth() === 0) &&
             // change background of the first wrapped cell also affects BCE
-            // so we mark it as invalid to simplify the process to determine line separator
+            // so we mark it as invalid to simply the process to determine line separator
             equalBg(thisRowLastChar, nextRowFirstChar) &&
             equalBg(thisRowLastSecondChar, nextRowFirstChar)
           ) {

addons/addon-serialize/test/SerializeAddon.test.ts

@@ -192,7 +192,7 @@ test.describe('SerializeAddon', () => {
     const cols = 10;
     const line = '+'.repeat(cols);
     const lines: string[] = [
-      sgr(FG_P16_GREEN) + line,  // Workaround: If we clear all flags at the end, serialize will use \x1b[0m to clear instead of the specific disable sequence
+      sgr(FG_P16_GREEN) + line,  // Workaround: If we clear all flags a the end, serialize will use \x1b[0m to clear instead of the sepcific disable sequence
       sgr(INVERSE) + line,
       sgr(BOLD) + line,
       sgr(UNDERLINED) + line,

addons/addon-unicode-graphemes/benchmark/tsconfig.json

@@ -4,10 +4,10 @@
     "rootDir": "..",
     "outDir": "../out-benchmark",
     "types": ["../../../node_modules/@types/node"],
-    "moduleResolution": "nodenext",
+    "moduleResolution": "node",
     "strict": false,
     "target": "es2015",
-    "module": "nodenext",
+    "module": "commonjs",
     "paths": {
       "common/*": ["../../../src/common/*"],
       "browser/*": ["../../../src/browser/*"],

addons/addon-unicode-graphemes/package.json

@@ -21,8 +21,8 @@
     "package": "../../node_modules/.bin/webpack",
     "prepublishOnly": "npm run package",
     "start": "node ../../demo/start",
-    "benchmark": "../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json out-benchmark/benchmark/*benchmark.js",
-    "benchmark-baseline": "../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --baseline out-benchmark/benchmark/*benchmark.js",
-    "benchmark-eval": "../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --eval out-benchmark/benchmark/*benchmark.js"
+    "benchmark": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json out-benchmark/benchmark/*benchmark.js",
+    "benchmark-baseline": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --baseline out-benchmark/benchmark/*benchmark.js",
+    "benchmark-eval": "NODE_PATH=../../out:./out:./out-benchmark/ ../../node_modules/.bin/xterm-benchmark -r 5 -c benchmark/benchmark.json --eval out-benchmark/benchmark/*benchmark.js"
   }
 }

addons/addon-unicode-graphemes/src/UnicodeGraphemesAddon.ts

@@ -2,7 +2,7 @@
  * Copyright (c) 2023 The xterm.js authors. All rights reserved.
  * @license MIT
  *
- * UnicodeVersionProvider for V15 with grapheme cluster handling.
+ * UnicodeVersionProvider for V15 with grapeme cluster handleing.
  */
 
 import type { Terminal, ITerminalAddon, IUnicodeHandling } from '@xterm/xterm';

addons/addon-web-fonts/test/WebFontsAddon.test.ts

@@ -78,22 +78,7 @@ test.describe('WebFontsAddon', () => {
       const data = await ctx.page.evaluate(`
           document.styleSheets[0].insertRule("@font-face {font-family: Kongtext; src: url(/fonts/kongtext.regular.ttf) format('truetype'); unicode-range: U+00A0-00FF}", 0);
         `);
-      let fonts = await getDocumentFonts();
-      // safari may have loaded the font, firefox & chrome never load it
-      if (browser.browserType().name() === 'webkit') {
-        try {
-          deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loading' }]);
-        } catch (e) {
-          try {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loaded' }]);
-          } catch (e) {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
-          }
-        }
-      } else {
-        deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
-      }
-
+      deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'unloaded' }]);
 
       // broken case: webfont in ctor without addon usage
       await ctx.page.evaluate(`
@@ -101,20 +86,15 @@ test.describe('WebFontsAddon', () => {
           window.helperTerm.open(term.element);
         `);
 
-      fonts = await getDocumentFonts();
-      // safari might load the font, firefox & chrome dont
+      // safari loads the font, firefox & chrome dont
       if (browser.browserType().name() === 'webkit') {
         try {
-          deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loading' }]);
+          deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'loading' }]);
         } catch (e) {
-          try {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loaded' }]);
-          } catch (e) {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
-          }
+          deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'loaded' }]);
         }
       } else {
-        deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
+        deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'unloaded' }]);
       }
 
       // good case: addon fixes layout for webfont in ctor

addons/addon-web-fonts/test/tsconfig.json

@@ -5,6 +5,7 @@
     "lib": [
       "es2021",
     ],
+    // "downlevelIteration": true,
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,

addons/addon-web-links/src/WebLinkProvider.ts

@@ -57,8 +57,7 @@ function isUrl(urlString: string): boolean {
 
 export class LinkComputer {
   public static computeLink(y: number, regex: RegExp, terminal: Terminal, activate: (event: MouseEvent, uri: string) => void): ILink[] {
-    const flags = regex.flags.includes('g') ? regex.flags : `${regex.flags}g`;
-    const rex = new RegExp(regex.source, flags);
+    const rex = new RegExp(regex.source, (regex.flags || '') + 'g');
 
     const [lines, startLineIndex] = LinkComputer._getWindowedLineStrings(y - 1, terminal);
     const line = lines.join('');
@@ -114,8 +113,8 @@ export class LinkComputer {
     let line: IBufferLine | undefined;
     let topIdx = lineIndex;
     let bottomIdx = lineIndex;
-    let length;
-    let content;
+    let length = 0;
+    let content = '';
     const lines: string[] = [];
 
     if ((line = terminal.buffer.active.getLine(lineIndex))) {

addons/addon-web-links/src/WebLinksAddon.ts

@@ -7,13 +7,13 @@ import type { Terminal, ITerminalAddon, IDisposable } from '@xterm/xterm';
 import type { WebLinksAddon as IWebLinksApi } from '@xterm/addon-web-links';
 import { ILinkProviderOptions, WebLinkProvider } from './WebLinkProvider';
 
-// consider everything starting with http:// or https://
+// consider everthing starting with http:// or https://
 // up to first whitespace, `"` or `'` as url
 // NOTE: The repeated end clause is needed to not match a dangling `:`
 // resembling the old (...)*([^:"\'\\s]) final path clause
 // additionally exclude early + final:
 // - unsafe from rfc3986: !*'()
-// - unsafe chars from rfc1738: {}|\^~[]` (minus [] for ipv6 addresses, also allow ~)
+// - unsafe chars from rfc1738: {}|\^~[]` (minus [] as we need them for ipv6 adresses, also allow ~)
 // also exclude as finals:
 // - final interpunction like ,.!?
 // - any sort of brackets <>()[]{} (not spec conform, but often used to enclose urls)

addons/addon-web-links/test/tsconfig.json

@@ -5,6 +5,7 @@
     "lib": [
       "es2021",
     ],
+    // "downlevelIteration": true,
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,

addons/addon-webgl/README.md

@@ -23,7 +23,7 @@ See the full [API](https://github.com/xtermjs/xterm.js/blob/master/addons/addon-
 
 ### Handling Context Loss
 
-The browser may drop WebGL contexts for various reasons like OOM or after the system has been suspended. There is an API exposed that fires the `webglcontextlost` event on the canvas so embedders can handle it however they wish. An easy, but suboptimal way, to handle this is by disposing of WebglAddon when the event fires:
+The browser may drop WebGL contexts for various reasons like OOM or after the system has been suspended. There is an API exposed that fires the `webglcontextlost` event fired on the canvas so embedders can handle it however they wish. An easy, but suboptimal way, to handle this is by disposing of WebglAddon when the event fires:
 
 ```ts
 const terminal = new Terminal();

addons/addon-webgl/src/CellColorResolver.ts

@@ -3,7 +3,7 @@ import { ICoreBrowserService, IThemeService } from 'browser/services/Services';
 import { ReadonlyColorSet } from 'browser/Types';
 import { Attributes, BgFlags, ExtFlags, FgFlags, NULL_CELL_CODE, UnderlineStyle } from 'common/buffer/Constants';
 import { IDecorationService, IOptionsService } from 'common/services/Services';
-import { ICellData } from 'common/buffer/Types';
+import { ICellData } from 'common/Types';
 import { Terminal } from '@xterm/xterm';
 import { rgba } from 'common/Color';
 import { treatGlyphAsBackgroundColor } from 'browser/renderer/shared/RendererUtils';

addons/addon-webgl/src/CharAtlasUtils.test.ts

@@ -1,87 +0,0 @@
-/**
- * Copyright (c) 2026 The xterm.js authors. All rights reserved.
- * @license MIT
- */
-
-import { assert } from 'chai';
-import { configEquals } from './CharAtlasUtils';
-import { ICharAtlasConfig } from './Types';
-import { NULL_COLOR } from 'common/Color';
-import { IColor } from 'common/Types';
-
-function createTestConfig(overrides: Partial<ICharAtlasConfig> = {}): ICharAtlasConfig {
-  const color: IColor = { css: '#ffffff', rgba: 0xffffffff };
-  const contrastCache = {
-    clear: () => {},
-    setCss: () => {},
-    getCss: () => undefined,
-    setColor: () => {},
-    getColor: () => undefined
-  };
-  const colors = {
-    foreground: color,
-    background: color,
-    cursor: NULL_COLOR,
-    cursorAccent: NULL_COLOR,
-    selectionForeground: undefined,
-    selectionBackgroundTransparent: NULL_COLOR,
-    selectionBackgroundOpaque: NULL_COLOR,
-    selectionInactiveBackgroundTransparent: NULL_COLOR,
-    selectionInactiveBackgroundOpaque: NULL_COLOR,
-    overviewRulerBorder: NULL_COLOR,
-    scrollbarSliderBackground: NULL_COLOR,
-    scrollbarSliderHoverBackground: NULL_COLOR,
-    scrollbarSliderActiveBackground: NULL_COLOR,
-    ansi: new Array(256).fill(color),
-    contrastCache,
-    halfContrastCache: contrastCache
-  };
-  return {
-    customGlyphs: true,
-    devicePixelRatio: 1,
-    deviceMaxTextureSize: 4096,
-    letterSpacing: 0,
-    lineHeight: 1,
-    fontSize: 15,
-    fontFamily: 'monospace',
-    fontWeight: 'normal',
-    fontWeightBold: 'bold',
-    deviceCellWidth: 10,
-    deviceCellHeight: 20,
-    deviceCharWidth: 8,
-    deviceCharHeight: 16,
-    allowTransparency: false,
-    drawBoldTextInBrightColors: true,
-    minimumContrastRatio: 1,
-    colors,
-    ...overrides
-  };
-}
-
-describe('CharAtlasUtils', () => {
-  describe('configEquals', () => {
-    it('should return true for identical configs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig();
-      assert.ok(configEquals(a, b));
-    });
-
-    it('should return false when deviceMaxTextureSize differs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig({ deviceMaxTextureSize: 8192 });
-      assert.ok(!configEquals(a, b));
-    });
-
-    it('should return false when deviceCellWidth differs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig({ deviceCellWidth: 11 });
-      assert.ok(!configEquals(a, b));
-    });
-
-    it('should return false when deviceCellHeight differs', () => {
-      const a = createTestConfig();
-      const b = createTestConfig({ deviceCellHeight: 21 });
-      assert.ok(!configEquals(a, b));
-    });
-  });
-});

addons/addon-webgl/src/CharAtlasUtils.ts

@@ -59,7 +59,6 @@ export function configEquals(a: ICharAtlasConfig, b: ICharAtlasConfig): boolean
     }
   }
   return a.devicePixelRatio === b.devicePixelRatio &&
-      a.deviceMaxTextureSize === b.deviceMaxTextureSize &&
       a.customGlyphs === b.customGlyphs &&
       a.lineHeight === b.lineHeight &&
       a.letterSpacing === b.letterSpacing &&
@@ -68,8 +67,6 @@ export function configEquals(a: ICharAtlasConfig, b: ICharAtlasConfig): boolean
       a.fontWeight === b.fontWeight &&
       a.fontWeightBold === b.fontWeightBold &&
       a.allowTransparency === b.allowTransparency &&
-      a.deviceCellWidth === b.deviceCellWidth &&
-      a.deviceCellHeight === b.deviceCellHeight &&
       a.deviceCharWidth === b.deviceCharWidth &&
       a.deviceCharHeight === b.deviceCharHeight &&
       a.drawBoldTextInBrightColors === b.drawBoldTextInBrightColors &&

addons/addon-webgl/src/GlyphRenderer.ts

@@ -9,7 +9,7 @@ import { Disposable, toDisposable } from 'common/Lifecycle';
 import { Terminal } from '@xterm/xterm';
 import { IRenderModel, IWebGL2RenderingContext, IWebGLVertexArrayObject, type IRasterizedGlyph, type ITextureAtlas } from './Types';
 import { createProgram, GLTexture, PROJECTION_MATRIX } from './WebglUtils';
-import type { ILogService, IOptionsService } from 'common/services/Services';
+import type { IOptionsService } from 'common/services/Services';
 import { allowRescaling, throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
 
 interface IVertices {
@@ -114,8 +114,7 @@ export class GlyphRenderer extends Disposable {
     private readonly _terminal: Terminal,
     private readonly _gl: IWebGL2RenderingContext,
     private _dimensions: IRenderDimensions,
-    private readonly _optionsService: IOptionsService,
-    private readonly _logService: ILogService
+    private readonly _optionsService: IOptionsService
   ) {
     super();
 
@@ -128,7 +127,7 @@ export class GlyphRenderer extends Disposable {
       TextureAtlas.maxTextureSize = throwIfFalsy(gl.getParameter(gl.MAX_TEXTURE_SIZE) as number | null);
     }
 
-    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, createFragmentShaderSource(TextureAtlas.maxAtlasPages), this._logService));
+    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, createFragmentShaderSource(TextureAtlas.maxAtlasPages)));
     this._register(toDisposable(() => gl.deleteProgram(this._program)));
 
     // Uniform locations
@@ -137,9 +136,8 @@ export class GlyphRenderer extends Disposable {
     this._textureLocation = throwIfFalsy(gl.getUniformLocation(this._program, 'u_texture'));
 
     // Create and set the vertex array object
-    const vertexArrayObject = this._vertexArrayObject = gl.createVertexArray();
-    this._register(toDisposable(() => gl.deleteVertexArray(vertexArrayObject)));
-    gl.bindVertexArray(vertexArrayObject);
+    this._vertexArrayObject = gl.createVertexArray();
+    gl.bindVertexArray(this._vertexArrayObject);
 
     // Setup a_unitquad, this defines the 4 vertices of a rectangle
     const unitQuadVertices = new Float32Array([0, 0, 1, 0, 0, 1, 1, 1]);
@@ -220,7 +218,7 @@ export class GlyphRenderer extends Disposable {
   public updateCell(x: number, y: number, code: number, bg: number, fg: number, ext: number, chars: string, width: number, lastBg: number): void {
     // Since this function is called for every cell (`rows*cols`), it must be very optimized. It
     // should not instantiate any variables unless a new glyph is drawn to the cache where the
-    // slight slowdown is acceptable for the developer ergonomics provided as it's a one-off for
+    // slight slowdown is acceptable for the developer ergonomics provided as it's a once of for
     // each glyph.
     this._updateCell(this._vertices.attributes, x, y, code, bg, fg, ext, chars, width, lastBg);
   }
@@ -389,9 +387,8 @@ export class GlyphRenderer extends Disposable {
     gl.bindTexture(gl.TEXTURE_2D, this._atlasTextures[i].texture);
     gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_S, gl.CLAMP_TO_EDGE);
     gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_WRAP_T, gl.CLAMP_TO_EDGE);
-    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR);
-    gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR);
     gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, atlas.pages[i].canvas);
+    gl.generateMipmap(gl.TEXTURE_2D);
     this._atlasTextures[i].version = atlas.pages[i].version;
   }
 

addons/addon-webgl/src/RectangleRenderer.ts

@@ -14,7 +14,6 @@ import { RenderModelConstants } from './RenderModel';
 import { IRenderModel, IWebGL2RenderingContext, IWebGLVertexArrayObject } from './Types';
 import { createProgram, expandFloat32Array, PROJECTION_MATRIX } from './WebglUtils';
 import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
-import type { ILogService } from 'common/services/Services';
 
 const enum VertexAttribLocations {
   POSITION = 0,
@@ -90,23 +89,21 @@ export class RectangleRenderer extends Disposable {
     private _terminal: Terminal,
     private _gl: IWebGL2RenderingContext,
     private _dimensions: IRenderDimensions,
-    private readonly _themeService: IThemeService,
-    private readonly _logService: ILogService
+    private readonly _themeService: IThemeService
   ) {
     super();
 
     const gl = this._gl;
 
-    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, fragmentShaderSource, this._logService));
+    this._program = throwIfFalsy(createProgram(gl, vertexShaderSource, fragmentShaderSource));
     this._register(toDisposable(() => gl.deleteProgram(this._program)));
 
     // Uniform locations
     this._projectionLocation = throwIfFalsy(gl.getUniformLocation(this._program, 'u_projection'));
 
     // Create and set the vertex array object
-    const vertexArrayObject = this._vertexArrayObject = gl.createVertexArray();
-    this._register(toDisposable(() => gl.deleteVertexArray(vertexArrayObject)));
-    gl.bindVertexArray(vertexArrayObject);
+    this._vertexArrayObject = gl.createVertexArray();
+    gl.bindVertexArray(this._vertexArrayObject);
 
     // Setup a_unitquad, this defines the 4 vertices of a rectangle
     const unitQuadVertices = new Float32Array([0, 0, 1, 0, 0, 1, 1, 1]);

addons/addon-webgl/src/TextureAtlas.ts

@@ -69,7 +69,7 @@ export class TextureAtlas implements ITextureAtlas {
   private _overflowSizePage: AtlasPage | undefined;
 
   private _tmpCanvas: HTMLCanvasElement;
-  // A temporary context that glyphs are drawn to before being transferred to the atlas.
+  // A temporary context that glyphs are drawn to before being transfered to the atlas.
   private _tmpCtx: CanvasRenderingContext2D;
 
   private _workBoundingBox: IBoundingBox = { top: 0, left: 0, bottom: 0, right: 0 };
@@ -109,7 +109,6 @@ export class TextureAtlas implements ITextureAtlas {
       page.canvas.remove();
     }
     this._onAddTextureAtlasCanvas.dispose();
-    this._onRemoveTextureAtlasCanvas.dispose();
   }
 
   public warmUp(): void {
@@ -152,7 +151,7 @@ export class TextureAtlas implements ITextureAtlas {
   }
 
   private _createNewPage(): AtlasPage {
-    // Try merge the set of the 4 most used pages of the largest size. This is deferred to a
+    // Try merge the set of the 4 most used pages of the largest size. This is is deferred to a
     // microtask to ensure it does not interrupt textures that will be rendered in the current
     // animation frame which would result in blank rendered areas. This is actually not that
     // expensive relative to drawing the glyphs, so there is no need to wait for an idle callback.
@@ -191,7 +190,7 @@ export class TextureAtlas implements ITextureAtlas {
         return newPage;
       }
 
-      const sortedMergingPagesIndexes = mergingPages.map(e => e.glyphs[0].texturePage).sort((a, b) => a - b);
+      const sortedMergingPagesIndexes = mergingPages.map(e => e.glyphs[0].texturePage).sort((a, b) => a > b ? 1 : -1);
       const mergedPageIndex = this.pages.length - mergingPages.length;
 
       // Merge into the new page
@@ -530,7 +529,7 @@ export class TextureAtlas implements ITextureAtlas {
     let customGlyph = false;
     if (this._config.customGlyphs !== false) {
       const variantOffset = this._workAttributeData.getUnderlineVariantOffset();
-      customGlyph = tryDrawCustomGlyph(this._tmpCtx, chars, padding, padding, this._config.deviceCellWidth, this._config.deviceCellHeight, this._config.deviceCharWidth, this._config.deviceCharHeight, this._config.fontSize, this._config.devicePixelRatio, this._logService, backgroundColor.css, variantOffset);
+      customGlyph = tryDrawCustomGlyph(this._tmpCtx, chars, padding, padding, this._config.deviceCellWidth, this._config.deviceCellHeight, this._config.deviceCharWidth, this._config.deviceCharHeight, this._config.fontSize, this._config.devicePixelRatio, backgroundColor.css, variantOffset);
     }
 
     // Whether to clear pixels based on a threshold difference between the glyph color and the
@@ -1080,33 +1079,17 @@ class AtlasPage {
     size: number,
     sourcePages?: AtlasPage[]
   ) {
+    if (sourcePages) {
+      for (const p of sourcePages) {
+        this._glyphs.push(...p.glyphs);
+        this._usedPixels += p._usedPixels;
+      }
+    }
     this.canvas = createCanvas(document, size, size);
     // The canvas needs alpha because we use clearColor to convert the background color to alpha.
     // It might also contain some characters with transparent backgrounds if allowTransparency is
     // set.
     this.ctx = throwIfFalsy(this.canvas.getContext('2d', { alpha: true }));
-    if (sourcePages) {
-      if (sourcePages.length === 4) {
-        // optimized for quadmerge
-        this._glyphs = this._glyphs.concat(
-          sourcePages[0].glyphs,
-          sourcePages[1].glyphs,
-          sourcePages[2].glyphs,
-          sourcePages[3].glyphs
-        );
-        this._usedPixels = sourcePages[0]._usedPixels +
-          sourcePages[1]._usedPixels +
-          sourcePages[2]._usedPixels +
-          sourcePages[3]._usedPixels;
-      } else {
-        // fallback for non quadmerges (should never be used)
-        for (let i = 0; i < sourcePages.length; ++i) {
-          this._glyphs = this._glyphs.concat(sourcePages[i].glyphs);
-          this._usedPixels += sourcePages[i]._usedPixels;
-        }
-
-      }
-    }
   }
 
   public clear(): void {
@@ -1141,7 +1124,7 @@ function clearColor(imageData: ImageData, bg: IColor, fg: IColor, enableThreshol
   // were covered (fg=#8ae234, bg=#c4a000).
   const threshold = Math.floor((Math.abs(r - fgR) + Math.abs(g - fgG) + Math.abs(b - fgB)) / 12);
 
-  // Set alpha channel of relevant pixels to 0
+  // Set alpha channel of relevent pixels to 0
   let isEmpty = true;
   for (let offset = 0; offset < imageData.data.length; offset += 4) {
     // Check exact match

addons/addon-webgl/src/Types.ts

@@ -28,7 +28,6 @@ export interface ICursorRenderModel {
 export interface IWebGL2RenderingContext extends WebGLRenderingContext {
   vertexAttribDivisor(index: number, divisor: number): void;
   createVertexArray(): IWebGLVertexArrayObject;
-  deleteVertexArray(vao: IWebGLVertexArrayObject): void;
   bindVertexArray(vao: IWebGLVertexArrayObject): void;
   drawElementsInstanced(mode: number, count: number, type: number, offset: number, instanceCount: number): void;
 }

addons/addon-webgl/src/WebglAddon.ts

@@ -9,7 +9,7 @@ import { ICharacterJoinerService, ICharSizeService, ICoreBrowserService, IRender
 import { ITerminal } from 'browser/Types';
 import { Disposable, toDisposable } from 'common/Lifecycle';
 import { getSafariVersion, isSafari } from 'common/Platform';
-import { ICoreService, IDecorationService, ILogService, IOptionsService } from 'common/services/Services';
+import { ICoreService, IDecorationService, IOptionsService } from 'common/services/Services';
 import { IWebGL2RenderingContext } from './Types';
 import { WebglRenderer } from './WebglRenderer';
 import { Emitter, EventUtils } from 'common/Event';
@@ -40,7 +40,7 @@ export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi
       };
       const gl = document.createElement('canvas').getContext('webgl2', contextAttributes) as IWebGL2RenderingContext;
       if (!gl) {
-        throw new Error('WebGL2 is only supported on Safari 16 and above');
+        throw new Error('Webgl2 is only supported on Safari 16 and above');
       }
     }
     super();
@@ -65,7 +65,6 @@ export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi
     const charSizeService: ICharSizeService = unsafeCore._charSizeService;
     const coreBrowserService: ICoreBrowserService = unsafeCore._coreBrowserService;
     const decorationService: IDecorationService = unsafeCore._decorationService;
-    const logService: ILogService = unsafeCore._logService;
     const themeService: IThemeService = unsafeCore._themeService;
 
     this._renderer = this._register(new WebglRenderer(
@@ -75,7 +74,6 @@ export class WebglAddon extends Disposable implements ITerminalAddon, IWebglApi
       coreBrowserService,
       coreService,
       decorationService,
-      logService,
       optionsService,
       themeService,
       this._customGlyphs,

addons/addon-webgl/src/WebglRenderer.ts

@@ -10,12 +10,12 @@ import { CursorBlinkStateManager } from './CursorBlinkStateManager';
 import { observeDevicePixelDimensions } from './DevicePixelObserver';
 import { IRenderDimensions, IRenderer, IRequestRedrawEvent } from 'browser/renderer/shared/Types';
 import { ICharSizeService, ICharacterJoinerService, ICoreBrowserService, IThemeService } from 'browser/services/Services';
-import { CharData, IBufferLine, ICellData } from 'common/buffer/Types';
+import { CharData, IBufferLine, ICellData } from 'common/Types';
 import { AttributeData } from 'common/buffer/AttributeData';
 import { CellData } from 'common/buffer/CellData';
 import { Attributes, Content, FgFlags, NULL_CELL_CHAR, NULL_CELL_CODE } from 'common/buffer/Constants';
 import { TextBlinkStateManager } from 'browser/renderer/shared/TextBlinkStateManager';
-import { ICoreService, IDecorationService, ILogService, IOptionsService } from 'common/services/Services';
+import { ICoreService, IDecorationService, IOptionsService } from 'common/services/Services';
 import { Terminal } from '@xterm/xterm';
 import { GlyphRenderer } from './GlyphRenderer';
 import { RectangleRenderer } from './RectangleRenderer';
@@ -77,7 +77,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
     private readonly _coreBrowserService: ICoreBrowserService,
     private readonly _coreService: ICoreService,
     private readonly _decorationService: IDecorationService,
-    private readonly _logService: ILogService,
     private readonly _optionsService: IOptionsService,
     private readonly _themeService: IThemeService,
     private readonly _customGlyphs: boolean = true,
@@ -123,19 +122,19 @@ export class WebglRenderer extends Disposable implements IRenderer {
     this._deviceMaxTextureSize = this._gl.getParameter(this._gl.MAX_TEXTURE_SIZE);
 
     this._register(addDisposableListener(this._canvas, 'webglcontextlost', (e) => {
-      this._logService.debug('webglcontextlost event received');
+      console.log('webglcontextlost event received');
       // Prevent the default behavior in order to enable WebGL context restoration.
       e.preventDefault();
       // Wait a few seconds to see if the 'webglcontextrestored' event is fired.
       // If not, dispatch the onContextLoss notification to observers.
       this._contextRestorationTimeout = setTimeout(() => {
         this._contextRestorationTimeout = undefined;
-        this._logService.warn('webgl context not restored; firing onContextLoss');
+        console.warn('webgl context not restored; firing onContextLoss');
         this._onContextLoss.fire(e);
       }, 3000 /* ms */);
     }));
     this._register(addDisposableListener(this._canvas, 'webglcontextrestored', (e) => {
-      this._logService.warn('webglcontextrestored event received');
+      console.warn('webglcontextrestored event received');
       clearTimeout(this._contextRestorationTimeout);
       this._contextRestorationTimeout = undefined;
       // The texture atlas and glyph renderer must be fully reinitialized
@@ -159,8 +158,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
     this._isAttached = this._core.screenElement!.isConnected;
 
     this._register(toDisposable(() => {
-      clearTimeout(this._contextRestorationTimeout);
-      this._contextRestorationTimeout = undefined;
       for (const l of this._renderLayers) {
         l.dispose();
       }
@@ -277,8 +274,8 @@ export class WebglRenderer extends Disposable implements IRenderer {
    * Initializes members dependent on WebGL context state.
    */
   private _initializeWebGLState(): [RectangleRenderer, GlyphRenderer] {
-    this._rectangleRenderer.value = new RectangleRenderer(this._terminal, this._gl, this.dimensions, this._themeService, this._logService);
-    this._glyphRenderer.value = new GlyphRenderer(this._terminal, this._gl, this.dimensions, this._optionsService, this._logService);
+    this._rectangleRenderer.value = new RectangleRenderer(this._terminal, this._gl, this.dimensions, this._themeService);
+    this._glyphRenderer.value = new GlyphRenderer(this._terminal, this._gl, this.dimensions, this._optionsService);
 
     // Update dimensions and acquire char atlas
     this.handleCharSizeChanged();
@@ -427,8 +424,8 @@ export class WebglRenderer extends Disposable implements IRenderer {
     let line: IBufferLine;
     let joinedRanges: [number, number][];
     let isJoined: boolean;
-    let skipJoinedCheckUntilX: number;
-    let isValidJoinRange: boolean;
+    let skipJoinedCheckUntilX: number = 0;
+    let isValidJoinRange: boolean = true;
     let lastCharX: number;
     let range: [number, number];
     let isCursorRow: boolean;
@@ -456,18 +453,7 @@ export class WebglRenderer extends Disposable implements IRenderer {
 
     for (y = start; y <= end; y++) {
       row = y + terminal.buffer.ydisp;
-      const bufferLine = terminal.buffer.lines.get(row);
-      if (!bufferLine) {
-        this._model.lineLengths[y] = 0;
-        for (x = 0; x < terminal.cols; x++) {
-          j = ((y * terminal.cols) + x) * RenderModelConstants.INDICIES_PER_CELL;
-          modelUpdated = true;
-          this._nullModelCell(x, y, j, 0, 0, 0);
-        }
-        this._setRowBlinkState(y, false);
-        continue;
-      }
-      line = bufferLine;
+      line = terminal.buffer.lines.get(row)!;
       let rowHasBlinkingCells = false;
       this._model.lineLengths[y] = 0;
       isCursorRow = cursorY === row;
@@ -598,9 +584,13 @@ export class WebglRenderer extends Disposable implements IRenderer {
           // Null out non-first cells
           for (x++; x <= lastCharX; x++) {
             j = ((y * terminal.cols) + x) * RenderModelConstants.INDICIES_PER_CELL;
+            this._glyphRenderer.value!.updateCell(x, y, NULL_CELL_CODE, 0, 0, 0, NULL_CELL_CHAR, 0, 0);
+            this._model.cells[j] = NULL_CELL_CODE;
             // Don't re-resolve the cell color since multi-colored ligature backgrounds are not
             // supported
-            this._nullModelCell(x, y, j, this._cellColorResolver.result.bg, this._cellColorResolver.result.fg, this._cellColorResolver.result.ext);
+            this._model.cells[j + RenderModelConstants.BG_OFFSET] = this._cellColorResolver.result.bg;
+            this._model.cells[j + RenderModelConstants.FG_OFFSET] = this._cellColorResolver.result.fg;
+            this._model.cells[j + RenderModelConstants.EXT_OFFSET] = this._cellColorResolver.result.ext;
           }
           x--; // Go back to the previous update cell for next iteration
         }
@@ -614,14 +604,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
     this._updateTextBlinkState();
   }
 
-  private _nullModelCell(x: number, y: number, cellIndex: number, bg: number, fg: number, ext: number): void {
-    this._glyphRenderer.value!.updateCell(x, y, NULL_CELL_CODE, bg, fg, ext, NULL_CELL_CHAR, 0, 0);
-    this._model.cells[cellIndex] = NULL_CELL_CODE;
-    this._model.cells[cellIndex + RenderModelConstants.BG_OFFSET] = bg;
-    this._model.cells[cellIndex + RenderModelConstants.FG_OFFSET] = fg;
-    this._model.cells[cellIndex + RenderModelConstants.EXT_OFFSET] = ext;
-  }
-
   private _resetBlinkingRowState(): void {
     this._rowHasBlinkingCells = new Array(this._terminal.rows).fill(false);
     this._rowHasBlinkingCellsCount = 0;
@@ -679,10 +661,10 @@ export class WebglRenderer extends Disposable implements IRenderer {
     this.dimensions.device.canvas.height = this._terminal.rows * this.dimensions.device.cell.height;
     this.dimensions.device.canvas.width = this._terminal.cols * this.dimensions.device.cell.width;
 
-    // The size of the canvas on the page. It's important that this rounds to nearest integer
+    // The the size of the canvas on the page. It's important that this rounds to nearest integer
     // and not ceils as browsers often have floating point precision issues where
     // `window.devicePixelRatio` ends up being something like `1.100000023841858` for example, when
-    // it's actually 1.1. Ceiling may cause blurriness as the backing canvas image is 1 pixel too
+    // it's actually 1.1. Ceiling may causes blurriness as the backing canvas image is 1 pixel too
     // large for the canvas element size.
     this.dimensions.css.canvas.height = Math.round(this.dimensions.device.canvas.height / this._devicePixelRatio);
     this.dimensions.css.canvas.width = Math.round(this.dimensions.device.canvas.width / this._devicePixelRatio);

addons/addon-webgl/src/WebglUtils.ts

@@ -4,7 +4,6 @@
  */
 
 import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
-import type { ILogService } from 'common/services/Services';
 
 /**
  * A matrix that when multiplies will translate 0-1 coordinates (left to right,
@@ -17,21 +16,21 @@ export const PROJECTION_MATRIX = new Float32Array([
   -1, 1, 0, 1
 ]);
 
-export function createProgram(gl: WebGLRenderingContext, vertexSource: string, fragmentSource: string, logService: ILogService): WebGLProgram | undefined {
+export function createProgram(gl: WebGLRenderingContext, vertexSource: string, fragmentSource: string): WebGLProgram | undefined {
   const program = throwIfFalsy(gl.createProgram());
-  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.VERTEX_SHADER, vertexSource, logService)));
-  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.FRAGMENT_SHADER, fragmentSource, logService)));
+  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.VERTEX_SHADER, vertexSource)));
+  gl.attachShader(program, throwIfFalsy(createShader(gl, gl.FRAGMENT_SHADER, fragmentSource)));
   gl.linkProgram(program);
   const success = gl.getProgramParameter(program, gl.LINK_STATUS);
   if (success) {
     return program;
   }
 
-  logService.error(gl.getProgramInfoLog(program));
+  console.error(gl.getProgramInfoLog(program));
   gl.deleteProgram(program);
 }
 
-export function createShader(gl: WebGLRenderingContext, type: number, source: string, logService: ILogService): WebGLShader | undefined {
+export function createShader(gl: WebGLRenderingContext, type: number, source: string): WebGLShader | undefined {
   const shader = throwIfFalsy(gl.createShader(type));
   gl.shaderSource(shader, source);
   gl.compileShader(shader);
@@ -40,7 +39,7 @@ export function createShader(gl: WebGLRenderingContext, type: number, source: st
     return shader;
   }
 
-  logService.error(gl.getShaderInfoLog(shader));
+  console.error(gl.getShaderInfoLog(shader));
   gl.deleteShader(shader);
 }
 

addons/addon-webgl/src/customGlyphs/CustomGlyphDefinitions.ts

@@ -5,7 +5,7 @@
 
 import { CustomGlyphDefinitionType, CustomGlyphScaleType, CustomGlyphVectorType, type CustomGlyphCharacterDefinition, type CustomGlyphDefinitionPart, type CustomGlyphPathDrawFunctionDefinition } from './Types';
 
-/* oxlint-disable @stylistic/max-len -- generated glyph path data */
+/* eslint-disable max-len */
 
 const enum Shapes {
   /** │ */ TOP_TO_BOTTOM = 'M.5,0 L.5,1',

addons/addon-webgl/src/customGlyphs/CustomGlyphRasterizer.ts

@@ -4,7 +4,6 @@
  */
 
 import { throwIfFalsy } from 'browser/renderer/shared/RendererUtils';
-import type { ILogService } from 'common/services/Services';
 import { customGlyphDefinitions } from './CustomGlyphDefinitions';
 import { CustomGlyphDefinitionType, CustomGlyphScaleType, CustomGlyphVectorType, type CustomGlyphDefinitionPart, type CustomGlyphPathDrawFunctionDefinition, type CustomGlyphPatternDefinition, type ICustomGlyphSolidOctantBlockVector, type ICustomGlyphVectorShape } from './Types';
 
@@ -23,7 +22,6 @@ export function tryDrawCustomGlyph(
   deviceCharHeight: number,
   fontSize: number,
   devicePixelRatio: number,
-  logService: ILogService,
   backgroundColor?: string,
   variantOffset: number = 0
 ): boolean {
@@ -32,7 +30,7 @@ export function tryDrawCustomGlyph(
     // Normalize to array for uniform handling
     const parts = Array.isArray(unifiedCharDefinition) ? unifiedCharDefinition : [unifiedCharDefinition];
     for (const part of parts) {
-      drawDefinitionPart(ctx, part, xOffset, yOffset, deviceCellWidth, deviceCellHeight, deviceCharWidth, deviceCharHeight, fontSize, devicePixelRatio, logService, backgroundColor, variantOffset);
+      drawDefinitionPart(ctx, part, xOffset, yOffset, deviceCellWidth, deviceCellHeight, deviceCharWidth, deviceCharHeight, fontSize, devicePixelRatio, backgroundColor, variantOffset);
     }
     return true;
   }
@@ -51,7 +49,6 @@ function drawDefinitionPart(
   deviceCharHeight: number,
   fontSize: number,
   devicePixelRatio: number,
-  logService: ILogService,
   backgroundColor?: string,
   variantOffset: number = 0
 ): void {
@@ -82,7 +79,7 @@ function drawDefinitionPart(
       drawPatternChar(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, variantOffset);
       break;
     case CustomGlyphDefinitionType.PATH_FUNCTION:
-      drawPathFunctionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, logService, part.strokeWidth);
+      drawPathFunctionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, part.strokeWidth);
       break;
     case CustomGlyphDefinitionType.PATH:
       drawPathDefinitionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, part.strokeWidth);
@@ -91,7 +88,7 @@ function drawDefinitionPart(
       drawPathNegativeDefinitionCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, devicePixelRatio, backgroundColor);
       break;
     case CustomGlyphDefinitionType.VECTOR_SHAPE:
-      drawVectorShape(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, fontSize, devicePixelRatio, logService);
+      drawVectorShape(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight, fontSize, devicePixelRatio);
       break;
     case CustomGlyphDefinitionType.BRAILLE:
       drawBrailleCharacter(ctx, part.data, drawXOffset, drawYOffset, drawWidth, drawHeight);
@@ -221,8 +218,8 @@ function drawPathDefinitionCharacter(
       const rx = parseFloat(args[0]) * deviceCellWidth;
       const ry = parseFloat(args[1]) * deviceCellHeight;
       const xAxisRotation = parseFloat(args[2]) * Math.PI / 180;
-      const largeArcFlag = parseInt(args[3], 10);
-      const sweepFlag = parseInt(args[4], 10);
+      const largeArcFlag = parseInt(args[3]);
+      const sweepFlag = parseInt(args[4]);
       const x = xOffset + parseFloat(args[5]) * deviceCellWidth;
       const y = yOffset + parseFloat(args[6]) * deviceCellHeight;
       drawSvgArc(ctx, currentX, currentY, rx, ry, xAxisRotation, largeArcFlag, sweepFlag, x, y);
@@ -513,7 +510,6 @@ function drawPathFunctionCharacter(
   deviceCellWidth: number,
   deviceCellHeight: number,
   devicePixelRatio: number,
-  logService: ILogService,
   strokeWidth?: number
 ): void {
   ctx.save();
@@ -540,7 +536,7 @@ function drawPathFunctionCharacter(
     }
     const f = svgToCanvasInstructionMap[type];
     if (!f) {
-      logService.error(`Could not find drawing instructions for "${type}"`);
+      console.error(`Could not find drawing instructions for "${type}"`);
       continue;
     }
     const args: string[] = instruction.substring(1).split(',');
@@ -602,8 +598,7 @@ function drawVectorShape(
   deviceCellWidth: number,
   deviceCellHeight: number,
   fontSize: number,
-  devicePixelRatio: number,
-  logService: ILogService
+  devicePixelRatio: number
 ): void {
   // Clip the cell to make sure drawing doesn't occur beyond bounds
   const clipRegion = new Path2D();
@@ -624,7 +619,7 @@ function drawVectorShape(
     }
     const f = svgToCanvasInstructionMap[type];
     if (!f) {
-      logService.error(`Could not find drawing instructions for "${type}"`);
+      console.error(`Could not find drawing instructions for "${type}"`);
       continue;
     }
     const args: string[] = instruction.substring(1).split(',');

addons/addon-webgl/src/tsconfig.json

@@ -25,6 +25,7 @@
       ]
     },
     "strict": true,
+    "downlevelIteration": true,
     "experimentalDecorators": true,
     "types": [
       "../../../node_modules/@types/mocha"

addons/addon-webgl/typings/addon-webgl.d.ts

@@ -23,12 +23,12 @@ declare module '@xterm/addon-webgl' {
     public readonly onChangeTextureAtlas: IEvent<HTMLCanvasElement>;
 
     /**
-     * An event that is fired when a new page is added to the texture atlas.
+     * An event that is fired when the a new page is added to the texture atlas.
      */
     public readonly onAddTextureAtlasCanvas: IEvent<HTMLCanvasElement>;
 
     /**
-     * An event that is fired when a page is removed from the texture atlas.
+     * An event that is fired when the a page is removed from the texture atlas.
      */
     public readonly onRemoveTextureAtlasCanvas: IEvent<HTMLCanvasElement>;
 

bin/esbuild_all.mjs

@@ -19,17 +19,14 @@ for (const addon of addons) {
 // Demo job - This requires the others to be built so it's not included when building all
 // jobs.push(createJob('demo-client', [`--demo-client`]));
 
-const codes = await Promise.all(jobs.map(job => {
+await Promise.all(jobs.map((job, i) => {
   return new Promise(r => {
     job.cp.on('exit', code => {
       log(`Finished \x1b[32m${job.name}\x1b[0m${code ? ' \x1b[31mwith errors\x1b[0m' : ''}`);
-      r(code ?? 1);
+      r(code);
     });
   });
 }));
-if (codes.some(code => code !== 0)) {
-  process.exit(1);
-}
 
 /**
  * @param {string} message

bin/lint_changes.js

@@ -33,47 +33,17 @@ if (files.length === 0) {
 
 console.log(`Linting ${files.length} changed file(s)...`);
 
-const cwd = path.join(__dirname, '..');
-const isWin = process.platform === 'win32';
-
-/**
- * @param {string} command
- * @param {string[]} args
- * @returns {Promise<void>}
- */
-function run(command, args) {
-  return new Promise(/** @type {(resolve: () => void, reject: (reason: Error) => void) => void} */ ((resolve, reject) => {
-    const child = spawn(command, args, {
-      stdio: 'inherit',
-      cwd,
-      shell: isWin
-    });
-    child.on('close', code => {
-      if (code === 0) {
-        resolve();
-      } else {
-        reject(new Error(`${command} exited with code ${code}`));
-      }
-    });
-  }));
+const eslintArgs = ['--max-warnings', '0', '--no-warn-ignored'];
+if (fix) {
+  eslintArgs.push('--fix');
 }
+eslintArgs.push(...files);
 
-async function main() {
-  const oxlintArgs = ['--type-aware', '--max-warnings', '0'];
-  if (fix) {
-    oxlintArgs.push('--fix');
-  }
-  oxlintArgs.push(...files);
-
-  const oxlint = isWin ? 'oxlint.cmd' : 'oxlint';
-  await run(oxlint, oxlintArgs);
-
-  const eslintArgs = ['--config', 'eslint.config.naming.mjs', '--max-warnings', '0', ...files];
-  const eslint = isWin ? 'eslint.cmd' : 'eslint';
-  await run(eslint, eslintArgs);
-}
-
-main().catch(err => {
-  console.error(err.message);
-  process.exit(1);
+const eslint = process.platform === 'win32' ? 'eslint.cmd' : 'eslint';
+const child = spawn(eslint, eslintArgs, {
+  stdio: 'inherit',
+  cwd: path.join(__dirname, '..'),
+  shell: process.platform === 'win32'
 });
+
+child.on('close', code => process.exit(code ?? 0));

bin/setup-full.mjs

@@ -5,7 +5,7 @@ import { spawnSync } from 'node:child_process';
 import { basename, dirname, resolve, sep } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
-const repoRoot = resolve(dirname(fileURLToPath(import.meta.url)), '..');
+const repoRoot = resolve(dirname(fileURLToPath(import.meta.url)), '../..');
 const nodeModulesPath = resolve(repoRoot, 'node_modules');
 const npmExecutable = process.platform === 'win32' ? 'npm.cmd' : 'npm';
 
@@ -13,7 +13,7 @@ const npmExecutable = process.platform === 'win32' ? 'npm.cmd' : 'npm';
 
 /** @param {string} message */
 function log(message) {
-  console.info(`[setup-full] ${message}`);
+  console.info(`[setup-fast] ${message}`);
 }
 
 /** @param {string[]} args */

bin/test_integration.js

@@ -12,7 +12,7 @@ let argv = process.argv.slice(2);
 let suiteFilter = undefined;
 while (argv.some(e => e.startsWith('--suite='))) {
   const i = argv.findIndex(e => e.startsWith('--suite='));
-  const match = argv[i].match(/--suite=(?<suitename>.+)/);
+  const match = argv[i].match(/--suite=(?<suitename>.+)/)
   suiteFilter = match?.groups?.suitename ?? undefined;
   argv.splice(i, 1);
 }
@@ -42,18 +42,12 @@ if (suiteFilter) {
   configs = configs.filter(e => e.name === suiteFilter);
 }
 
-if (suiteFilter && configs.length === 0) {
-  console.error(`Unknown suite: ${suiteFilter}`);
-  process.exit(1);
-}
-
 function npmBinScript(script) {
   return path.resolve(__dirname, `../node_modules/.bin/` + (process.platform === 'win32' ?
     `${script}.cmd` : script));
 }
 
 async function run() {
-  let exitCode = 0;
   for (const config of configs) {
     const command = npmBinScript('playwright');
     const args = ['test', '-c', config.path, ...argv];
@@ -68,13 +62,10 @@ async function run() {
 
     if (run.error) {
       console.error(run.error);
-      process.exit(run.status ?? 1);
+      process.exit(run.status ?? -1);
     }
 
-    if (run.status) {
-      exitCode = run.status;
-    }
+    process.exit(run.status);
   }
-  process.exit(exitCode);
 }
 run();

bin/test_mousemodes.js

@@ -177,7 +177,7 @@ const ENC = {
 }
 
 function printMenu() {
-  console.log('\x1b[2J\x1b[HTest mouse reports [Ctrl-C to exit]');
+  console.log('\x1b[2J\x1b\[HTest mouse reports [Ctrl-C to exit]');
   console.log();
   console.log('  Selected protocol [Ctrl-A to switch]');
   const protocols = Object.keys(PROTOCOLS);

bin/test_unit.js

@@ -8,7 +8,7 @@ const path = require('path');
 
 const COVERAGE_LINES_THRESHOLD = 40;
 
-// Add `out-esbuild` to NODE_PATH so addon path-mapped imports (common/*, browser/*) resolve.
+// Add `out` to the NODE_PATH so absolute paths can be resolved.
 const env = { ...process.env };
 env.NODE_PATH = path.resolve(__dirname, '../out-esbuild');
 
@@ -21,7 +21,7 @@ if (process.argv.length > 2) {
   flagArgs = args.filter(e => e.startsWith('--'));
   // ability to inject particular test files via
   // npm run test [testFileA testFileB ...]
-  const files = args.filter(e => !e.startsWith('--'));
+  files = args.filter(e => !e.startsWith('--'));
   if (files.length) {
     testFiles = files;
   }
@@ -39,6 +39,8 @@ if (checkCoverage) {
     ...testFiles,
     ...flagArgs
   ];
+  console.info('executable', executable);
+  console.info('args', args);
   const run = cp.spawnSync(
     executable,
     args,
@@ -49,7 +51,7 @@ if (checkCoverage) {
       stdio: 'inherit'
     }
   );
-  process.exit(run.status ?? -1);
+  process.exit(run.status);
 }
 
 const run = cp.spawnSync(

demo/client/components/window/addonImageWindow.ts

@@ -65,8 +65,7 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
     const dtIip = document.createElement('dt');
     dtIip.textContent = 'IIP (iTerm)';
     dlIip.appendChild(dtIip);
-    this._addDdWithButton(dlIip, 'image-demo3', 'palette (png File)');
-    this._addDdWithButton(dlIip, 'image-demo4', 'dice (qoi MultipartFile)');
+    this._addDdWithButton(dlIip, 'image-demo3', 'palette');
     container.appendChild(dlIip);
 
     // Kitty demos
@@ -142,21 +141,6 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
         this._terminal.write(`\x1b]1337;File=inline=1;size=${data.length}:${btoa(sdata)}\x1b\\`);
       });
 
-    const iipDemoMulti = (url: string) => () => fetch(url)
-      .then(resp => resp.arrayBuffer())
-      .then(buffer => {
-        const data = new Uint8Array(buffer);
-        let sdata = '';
-        for (let i = 0; i < data.length; ++i) sdata += String.fromCharCode(data[i]);
-        const encoded = btoa(sdata);
-        this._terminal.write('\r\n');
-        this._terminal.write(`\x1b]1337;MultipartFile=inline=1\x1b\\`);
-        for (let i = 0; i < encoded.length; i += 100) {
-          this._terminal.write(`\x1b]1337;FilePart=${encoded.slice(i, i + 100)}\x1b\\`);
-        }
-        this._terminal.write(`\x1b]1337;FileEnd\x1b\\`);
-      });
-
     const kittyDemo = (url: string) => () => fetch(url)
       .then(resp => resp.arrayBuffer())
       .then(buffer => {
@@ -174,8 +158,6 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
       sixelDemo('https://raw.githubusercontent.com/jerch/node-sixel/master/testfiles/test2.sixel'));
     document.getElementById('image-demo3')!.addEventListener('click',
       iipDemo('https://raw.githubusercontent.com/jerch/node-sixel/master/palette.png'));
-    document.getElementById('image-demo4')!.addEventListener('click',
-      iipDemoMulti('https://raw.githubusercontent.com/jerch/xterm-wasm-parts/master/fixtures/qoi/dice.qoi'));
     document.getElementById('image-demo-kitty1')!.addEventListener('click',
       kittyDemo('https://raw.githubusercontent.com/jerch/node-sixel/master/palette.png'));
 
@@ -194,7 +176,7 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
       //   }
       // }
 
-      const pos = (this._terminal as any)._core._mouseCoordsService!.getCoords(ev, (this._terminal as any)._core.screenElement!, this._terminal.cols, this._terminal.rows);
+      const pos = (this._terminal as any)._core._mouseService!.getCoords(ev, (this._terminal as any)._core.screenElement!, this._terminal.cols, this._terminal.rows);
       const x = pos[0] - 1;
       const y = pos[1] - 1;
       const canvas = ev.shiftKey

demo/client/components/window/gpuWindow.ts

@@ -43,7 +43,7 @@ export class GpuWindow extends BaseWindow implements IControlWindow {
   }
 
   private _styleAtlasPage(canvas: HTMLCanvasElement): void {
-    // oxlint-disable-next-line eslint-js/no-restricted-syntax
+    // eslint-disable-next-line no-restricted-syntax
     const dpr = window.devicePixelRatio;
     canvas.style.width = `${canvas.width / dpr}px`;
     canvas.style.height = `${canvas.height / dpr}px`;

demo/client/components/window/webglWindow.ts

@@ -11,33 +11,8 @@ export class WebglWindow extends BaseWindow implements IControlWindow {
   public readonly label = 'webgl';
 
   private _textureAtlasContainer!: HTMLElement;
-  private _stressRunning = false;
-  private _stressScrolling: HTMLInputElement | undefined;
 
   public build(container: HTMLElement): void {
-    const stressDiv = document.createElement('div');
-    const stressStart = document.createElement('button');
-    stressStart.id = 'stress-start';
-    stressStart.textContent = 'atlas stress start';
-    stressStart.addEventListener('click', () => this._stress());
-    stressDiv.appendChild(stressStart);
-
-    const stressStop = document.createElement('button');
-    stressStop.id = 'stress-stop';
-    stressStop.textContent = 'atlas stress stop';
-    stressStop.addEventListener('click', () => this._stressRunning = false);
-    stressDiv.appendChild(stressStop);
-
-    this._stressScrolling = document.createElement('input');
-    this._stressScrolling.type = 'checkbox';
-    this._stressScrolling.id = 'stress-scrolling';
-    stressDiv.appendChild(this._stressScrolling);
-    const stressScrollingLabel = document.createElement('label');
-    stressScrollingLabel.htmlFor = 'stress-scrolling';
-    stressScrollingLabel.textContent = 'stress scrolling';
-    stressDiv.appendChild(stressScrollingLabel);
-    container.appendChild(stressDiv);
-
     const zoomCheckbox = document.createElement('input');
     zoomCheckbox.type = 'checkbox';
     zoomCheckbox.id = 'texture-atlas-zoom';
@@ -68,38 +43,9 @@ export class WebglWindow extends BaseWindow implements IControlWindow {
   }
 
   private _styleAtlasPage(canvas: HTMLCanvasElement): void {
-    // oxlint-disable-next-line eslint-js/no-restricted-syntax
+    // eslint-disable-next-line no-restricted-syntax
     const dpr = window.devicePixelRatio;
     canvas.style.width = `${canvas.width / dpr}px`;
     canvas.style.height = `${canvas.height / dpr}px`;
   }
-
-  private async _stress(): Promise<void> {
-    const TEXT = '!"#$%&\'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~';
-    if (this._stressRunning) {
-      return;
-    }
-    this._stressRunning = true;
-    const scrolling = !!(this._stressScrolling?.checked);
-    for (let r = 0; r < 256; r += 2) {
-      for (let g = 0; g < 256; g += 2) {
-        let s: string[] = [];
-        for (let b = 0; b < 256; b += 2) {
-          if (!this._stressRunning) {
-            return;
-          }
-          const rbg = `RGB: ${[r, g, b]}`;
-          s.push(`\r\x1b[38;2;${r};${g};${b}m${rbg.padEnd(18, ' ')}${TEXT}`);
-          if (s.length >= 16) {
-            if (scrolling) {
-              await new Promise<void>(r => this._terminal.write(s.join('\r\n') + '\r\n', r));
-            } else {
-              await new Promise<void>(r => this._terminal.write('\x1b[H' + s.join('\r\n'), r));
-            }
-            s = [];
-          }
-        }
-      }
-    }
-  }
 }

demo/client/tsconfig.json

@@ -2,54 +2,25 @@
   "compilerOptions": {
     "module": "commonjs",
     "target": "es2021",
-    "types": [
-      "node"
-    ],
     "outDir": "../out-demo/client",
     "rootDir": ".",
     "sourceMap": true,
     "strict": true,
     "skipLibCheck": true,
     "paths": {
-      "@xterm/addon-attach": [
-        "../../addons/addon-attach"
-      ],
-      "@xterm/addon-clipboard": [
-        "../../addons/addon-clipboard"
-      ],
-      "@xterm/addon-fit": [
-        "../../addons/addon-fit"
-      ],
-      "@xterm/addon-image": [
-        "../../addons/addon-image"
-      ],
-      "@xterm/addon-progress": [
-        "../../addons/addon-progress"
-      ],
-      "@xterm/addon-search": [
-        "../../addons/addon-search"
-      ],
-      "@xterm/addon-serialize": [
-        "../../addons/addon-serialize"
-      ],
-      "@xterm/addon-web-fonts": [
-        "../../addons/addon-web-fonts"
-      ],
-      "@xterm/addon-web-links": [
-        "../../addons/addon-web-links"
-      ],
-      "@xterm/addon-webgl": [
-        "../../addons/addon-webgl"
-      ],
-      "@xterm/addon-unicode11": [
-        "../../addons/addon-unicode11"
-      ],
-      "@xterm/addon-unicode-graphemes": [
-        "../../addons/addon-unicode-graphemes"
-      ],
-      "@xterm/addon-ligatures": [
-        "../../addons/addon-ligatures"
-      ],
+      "@xterm/addon-attach": ["../../addons/addon-attach"],
+      "@xterm/addon-clipboard": ["../../addons/addon-clipboard"],
+      "@xterm/addon-fit": ["../../addons/addon-fit"],
+      "@xterm/addon-image": ["../../addons/addon-image"],
+      "@xterm/addon-progress": ["../../addons/addon-progress"],
+      "@xterm/addon-search": ["../../addons/addon-search"],
+      "@xterm/addon-serialize": ["../../addons/addon-serialize"],
+      "@xterm/addon-web-fonts": ["../../addons/addon-web-fonts"],
+      "@xterm/addon-web-links": ["../../addons/addon-web-links"],
+      "@xterm/addon-webgl": ["../../addons/addon-webgl"],
+      "@xterm/addon-unicode11": ["../../addons/addon-unicode11"],
+      "@xterm/addon-unicode-graphemes": ["../../addons/addon-unicode-graphemes"],
+      "@xterm/addon-ligatures": ["../../addons/addon-ligatures"],
       "*": ["./*"]
     }
   },

demo/server/server.ts

@@ -118,7 +118,7 @@ function startServer(): void {
   });
 
   appWs.ws('/terminals/:pid', function (ws, req) {
-    const term = terminals[parseInt(Array.isArray(req.params.pid) ? req.params.pid[0] : req.params.pid)];
+    const term = terminals[parseInt(req.params.pid)];
     console.log('Connected to terminal ' + term.pid);
     temporaryDisposable[term.pid].dispose();
     delete temporaryDisposable[term.pid];

eslint.config.mjs

@@ -37,13 +37,12 @@ export default tseslint.config(
       '@stylistic/comma-spacing': ['warn', { before: false, after: true }],
       '@stylistic/indent': ['warn', 2],
       '@stylistic/semi': ['warn', 'always'],
-      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: 'always' }],
+      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: true }],
       '@stylistic/member-delimiter-style': ['warn', {
         multiline: { delimiter: 'semi', requireLast: true },
         singleline: { delimiter: 'comma', requireLast: false }
       }],
       '@stylistic/type-annotation-spacing': 'warn',
-      '@stylistic/space-unary-ops': 'warn',
 
       '@typescript-eslint/array-type': ['warn', { default: 'array', readonly: 'generic' }],
       '@typescript-eslint/consistent-type-assertions': 'warn',
@@ -86,7 +85,6 @@ export default tseslint.config(
       'eqeqeq': ['warn', 'always'],
       'jsdoc/check-alignment': 'warn',
       'jsdoc/check-param-names': 'warn',
-      'jsdoc/multiline-blocks': 'warn',
       'jsdoc/no-multi-asterisks': 'warn',
       'keyword-spacing': 'warn',
       'max-len': ['warn', {

eslint.config.naming.mjs

@@ -1,71 +0,0 @@
-// @ts-check
-import tseslint from 'typescript-eslint';
-
-const ignores = [
-  'addons/*/src/third-party/*.ts',
-  '**/out/*',
-  '**/out-test/*',
-  '**/out-esbuild/*',
-  '**/out-esbuild-test/*',
-  '**/inwasm-sdks/*',
-  '**/node_modules',
-  '**/*.js',
-  '**/*.mjs'
-];
-
-const namingConventionMain = [
-  'warn',
-  { selector: 'default', format: ['camelCase'], filter: { regex: '^[a-z]', match: true } },
-  { selector: 'variable', format: ['camelCase', 'UPPER_CASE'] },
-  { selector: 'variable', filter: '^I.+Service$', format: ['PascalCase'], prefix: ['I'] },
-  { selector: 'memberLike', modifiers: ['private'], format: ['camelCase'], leadingUnderscore: 'require' },
-  { selector: 'memberLike', modifiers: ['protected'], format: ['camelCase'], leadingUnderscore: 'require' },
-  { selector: 'enumMember', format: ['UPPER_CASE'] },
-  { selector: 'property', modifiers: ['public'], format: ['camelCase', 'UPPER_CASE'], filter: { regex: '^[a-z]', match: true } },
-  { selector: 'method', modifiers: ['public'], format: ['camelCase', 'UPPER_CASE'], custom: { regex: '^on[A-Z].+', match: false } },
-  { selector: 'method', modifiers: ['private'], format: ['camelCase'], leadingUnderscore: 'require', custom: { regex: '^on[A-Z].+', match: false } },
-  { selector: 'method', modifiers: ['protected'], format: ['camelCase'], leadingUnderscore: 'require', custom: { regex: '^on[A-Z].+', match: false } },
-  { selector: 'typeLike', format: ['PascalCase'] },
-  { selector: 'interface', format: ['PascalCase'], prefix: ['I'] }
-];
-
-const namingConventionTypings = [
-  'warn',
-  { selector: 'typeLike', format: ['PascalCase'] },
-  { selector: 'interface', format: ['PascalCase'], prefix: ['I'] }
-];
-
-export default tseslint.config(
-  {
-    ignores
-  },
-  {
-    files: ['**/*.ts'],
-    ignores: ['typings/**/*.d.ts', 'addons/**/typings/**'],
-    plugins: {
-      '@typescript-eslint': tseslint.plugin
-    },
-    languageOptions: {
-      parser: tseslint.parser,
-      parserOptions: {
-        projectService: true,
-        tsconfigRootDir: import.meta.dirname
-      }
-    },
-    rules: {
-      '@typescript-eslint/naming-convention': namingConventionMain
-    }
-  },
-  {
-    files: ['typings/**/*.d.ts'],
-    plugins: {
-      '@typescript-eslint': tseslint.plugin
-    },
-    languageOptions: {
-      parser: tseslint.parser
-    },
-    rules: {
-      '@typescript-eslint/naming-convention': namingConventionTypings
-    }
-  }
-);

eslint.config.typings.mjs

@@ -17,7 +17,7 @@ export default tseslint.config(
     rules: {
       '@stylistic/indent': ['warn', 2],
       '@stylistic/semi': ['warn', 'always'],
-      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: 'always' }],
+      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: true }],
       '@stylistic/member-delimiter-style': ['warn', {
         multiline: { delimiter: 'semi', requireLast: true },
         singleline: { delimiter: 'comma', requireLast: false }