Daniel Imms
cc6def57e4
Use readonly color set in canvas addon
2022-10-08 11:46:41 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
5d8e4a0af4
Add lint rule to ensure _on prefix is only for event emitters
2022-10-08 11:05:52 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
f61d8c91a3
Properly register disposables in SearchAddon
2022-10-08 08:30:39 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms
34475f24c3
Release canvas texture atlas
2022-10-08 08:11:28 -07:00
Daniel Imms
8116e035b4
Register webgl renderers
2022-10-08 08:06:43 -07:00
Daniel Imms
56b37a73ac
Free WebglAddon
2022-10-08 07:37:55 -07:00
Daniel Imms
fc8043a25a
Ensure webgl texture atlas is released on dispose
2022-10-08 07:32:51 -07:00
Daniel Imms
f88c0e7480
Polish emitter registering in canvas renderer
...
Part of #4167
2022-10-08 07:24:35 -07:00
Daniel Imms
d948b31304
Merge pull request #4181 from Tyriar/clear_race
...
Fix race condition that could when clearing atlas on 2+ terminals
2022-10-07 16:34:27 -07:00
Daniel Imms
8e7093f03b
Remove the canvas char atlas
...
This was unused and removing from cache was broken apparently
2022-10-07 16:20:01 -07:00
Daniel Imms and Megan Rogge
c4eef2f470
Fix race condition that could when clearing atlas on 2+ terminals
...
This is the proper fix for microsoft/vscode#162996 , after a bunch of
investigation we found that this is causing the problem:
VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.
Co-Authored-By: Megan Rogge <merogge@microsoft.com >
2022-10-07 16:17:11 -07:00
Daniel Imms
5fcb084089
Merge pull request #4180 from Tyriar/clear_atlas
...
Fix clearTextureAtlas call as implemented on IRenderer
2022-10-07 14:31:28 -07:00
Daniel Imms
e89c507d06
Fix clearTextureAtlas call as implemented on IRenderer
...
This is the root cause of microsoft/vscode#162996
2022-10-07 14:22:51 -07:00
Daniel Imms
ffa4d921bb
Merge remote-tracking branch 'upstream/master' into renderer_before_open
2022-10-07 10:10:24 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd1f8e6f0952
2022-10-06 09:48:54 -07:00
Daniel Imms
e0324e32a8
Bring back ImageBitmap optimization in canvas renderer
...
It's more simple than it used to be, it will clear and debounce all
glyphs when any change is made.
2022-10-04 15:24:10 -07:00
Daniel Imms
3b260a2193
Fix resolved todo
2022-10-04 14:46:00 -07:00
Daniel Imms
622acaaad7
Remove old selection start/end values
2022-10-04 14:45:19 -07:00
Daniel Imms
0d7e18d236
Add CellColorResolver to share load color code
2022-10-04 14:41:27 -07:00
Daniel Imms
83c09c34db
Share selection render model code
2022-10-04 14:23:09 -07:00
Daniel Imms
03e3105c55
Fix fg/bg overrides in canvas
2022-10-04 14:10:27 -07:00
Daniel Imms
9259ec258f
Fix combined chars in canvas
2022-10-02 14:27:43 -07:00
Daniel Imms
c741c13409
Add ps to output string
2022-10-02 14:25:08 -07:00
Daniel Imms
dbef850039
Hook up attributes to new texture atlas
2022-10-02 13:57:35 -07:00
Daniel Imms
590a8219e3
Merge remote-tracking branch 'upstream/master' into shared_cache
2022-10-02 13:42:44 -07:00
Daniel Imms
d22f7c9edd
Merge pull request #4166 from Tyriar/event_with_emitter
...
Create new event with emitter object to simplify code
2022-10-02 13:41:37 -07:00
Daniel Imms
c2bf87ee34
Initial working shared atlas
2022-10-02 11:38:46 -07:00
Daniel Imms
0bc5ca8f80
Fix imports
2022-10-02 11:08:06 -07:00
Daniel Imms
f38a49b4d5
Move remaining webgl atlas to shared
2022-10-02 08:48:55 -07:00
Daniel Imms
26c974f9b6
Shuffle some utils
2022-10-02 08:37:13 -07:00
Daniel Imms
333b0e28ac
Add ITextureAtlas and use that instead of WebglCharAtlas
2022-10-02 07:48:43 -07:00
Daniel Imms
0bc71156bf
Merge remote-tracking branch 'upstream/master' into shared_cache
2022-10-02 07:26:23 -07:00
Daniel Imms
dece3cc41c
DynamicCharAtlas -> CanvasCharAtlas
2022-10-02 07:20:55 -07:00
Daniel Imms
8752c4fa8e
Remove canvas char atlas base class
2022-10-02 07:19:57 -07:00
Daniel Imms
af6f03600f
Show canvas texture atlas on demo
2022-10-02 07:10:37 -07:00
Daniel Imms
1f8e6f0952
Merge pull request #4169 from Tyriar/canvas_freq
...
Add willReadFrequently to canvas renderer too
2022-10-01 21:46:13 -07:00
Daniel Imms
f087bd121e
Add willReadFrequently to canvas renderer too
2022-10-01 21:38:01 -07:00
Daniel Imms
d669c6e9d6
Fix remaining references
2022-10-01 18:03:43 -07:00
Daniel Imms
c5f9eacbb1
Move other render parts to shared folder
2022-10-01 17:41:16 -07:00
Daniel Imms
6fcc496547
Move cache utils to core shared/ folder
...
Part of #4065
2022-10-01 17:36:16 -07:00
Daniel Imms
2a602ef231
Ensure texture atlas comparison uses rgba not object
...
Fixes #4128
2022-10-01 10:20:37 -07:00
Daniel Imms
2e8b793ba0
Format files
2022-10-01 08:56:56 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
8e378c07e9
Merge pull request #4165 from Tyriar/4164
...
Define all events and emitters consistently
2022-10-01 08:28:18 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Daniel Imms
