Merge pull request #4165 from Tyriar/4164

Define all events and emitters consistently

addons/xterm-addon-canvas/src/CanvasRenderer.ts

@@ -27,8 +27,8 @@ export class CanvasRenderer extends Disposable implements IRenderer {
 
   public dimensions: IRenderDimensions;
 
-  private _onRequestRedraw = new EventEmitter<IRequestRedrawEvent>();
-  public get onRequestRedraw(): IEvent<IRequestRedrawEvent> { return this._onRequestRedraw.event; }
+  private readonly _onRequestRedraw = new EventEmitter<IRequestRedrawEvent>();
+  public readonly onRequestRedraw = this._onRequestRedraw.event;
 
   constructor(
     private _colors: IColorSet,

addons/xterm-addon-webgl/src/WebglAddon.ts

@@ -15,10 +15,10 @@ export class WebglAddon implements ITerminalAddon {
   private _terminal?: Terminal;
   private _renderer?: WebglRenderer;
 
-  private _onChangeTextureAtlas = new EventEmitter<HTMLElement>();
-  public get onChangeTextureAtlas(): IEvent<HTMLElement> { return this._onChangeTextureAtlas.event; }
-  private _onContextLoss = new EventEmitter<void>();
-  public get onContextLoss(): IEvent<void> { return this._onContextLoss.event; }
+  private readonly _onChangeTextureAtlas = new EventEmitter<HTMLElement>();
+  public readonly onChangeTextureAtlas = this._onChangeTextureAtlas.event;
+  private readonly _onContextLoss = new EventEmitter<void>();
+  public readonly onContextLoss = this._onContextLoss.event;
 
   constructor(
     private _preserveDrawingBuffer?: boolean

addons/xterm-addon-webgl/src/WebglRenderer.ts

@@ -53,13 +53,12 @@ export class WebglRenderer extends Disposable implements IRenderer {
   private _isAttached: boolean;
   private _contextRestorationTimeout: number | undefined;
 
-  private _onChangeTextureAtlas = new EventEmitter<HTMLCanvasElement>();
-  public get onChangeTextureAtlas(): IEvent<HTMLCanvasElement> { return this._onChangeTextureAtlas.event; }
-  private _onRequestRedraw = new EventEmitter<IRequestRedrawEvent>();
-  public get onRequestRedraw(): IEvent<IRequestRedrawEvent> { return this._onRequestRedraw.event; }
-
-  private _onContextLoss = new EventEmitter<void>();
-  public get onContextLoss(): IEvent<void> { return this._onContextLoss.event; }
+  private readonly _onChangeTextureAtlas = new EventEmitter<HTMLCanvasElement>();
+  public readonly onChangeTextureAtlas = this._onChangeTextureAtlas.event;
+  private readonly _onRequestRedraw = new EventEmitter<IRequestRedrawEvent>();
+  public readonly onRequestRedraw = this._onRequestRedraw.event;
+  private readonly _onContextLoss = new EventEmitter<void>();
+  public readonly onContextLoss = this._onContextLoss.event;
 
   constructor(
     private _terminal: Terminal,

addons/xterm-addon-webgl/typings/xterm-addon-webgl.d.ts

@@ -15,12 +15,12 @@ declare module 'xterm-addon-webgl' {
     /**
      * An event that is fired when the renderer loses its canvas context.
      */
-     public get onContextLoss(): IEvent<void>;
+    public readonly onContextLoss: IEvent<void>;
 
     /**
      * An event that is fired when the texture atlas of the renderer changes.
      */
-    public get onChangeTextureAtlas(): IEvent<HTMLCanvasElement>;
+    public readonly onChangeTextureAtlas: IEvent<HTMLCanvasElement>;
 
     constructor(preserveDrawingBuffer?: boolean);