fix(addon-image): cast buffer line lookups to IBufferLineExt | undefined

Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
fix(addon-image): skip missing lines in viewportResize
2026-06-06 16:26:54 +00:00 · 2026-06-03 03:36:42 +00:00 · 2026-06-03 03:36:41 +00:00 · 2026-06-03 03:36:41 +00:00
1 changed files with 7 additions and 4 deletions
@@ -431,8 +431,8 @@ export class ImageStorage implements IDisposable {
    // because text writes clear the BG flag but leave image tile data intact.
    // This lets top-layer images survive text overwrites (kitty C=1 behavior).
    for (let row = start; row <= end; ++row) {
-      const line = buffer.lines.get(row + buffer.ydisp) as IBufferLineExt;
-      if (!line) return;
+      const line = buffer.lines.get(row + buffer.ydisp) as IBufferLineExt | undefined;
+      if (!line) continue;
      for (let col = 0; col < cols; ++col) {
        let e: IExtendedAttrsImage;
        if (line.getBg(col) & BgFlags.HAS_EXTENDED) {
@@ -513,7 +513,10 @@ export class ImageStorage implements IDisposable {
    const rows = buffer.lines.length;
    const oldCol = this._viewportMetrics.cols - 1;
    for (let row = 0; row < rows; ++row) {
-      const line = buffer.lines.get(row) as IBufferLineExt;
+      const line = buffer.lines.get(row) as IBufferLineExt | undefined;
+      if (!line) {
+        continue;
+      }
      if (line.getBg(oldCol) & BgFlags.HAS_EXTENDED) {
        const e: IExtendedAttrsImage = line._extendedAttrs[oldCol] ?? EMPTY_ATTRS;
        const imageId = e.imageId;
@@ -531,7 +534,7 @@ export class ImageStorage implements IDisposable {
        }
        // expand only if right side is empty (nothing got wrapped from below)
        let hasData = false;
-        for (let rightCol = oldCol + 1; rightCol > metrics.cols; ++rightCol) {
+        for (let rightCol = oldCol + 1; rightCol < metrics.cols; ++rightCol) {
          if (line._data[rightCol * Cell.SIZE + Cell.CONTENT] & Content.HAS_CONTENT_MASK) {
            hasData = true;
            break;
Author	SHA1	Message	Date
Cursor AgentandDaniel Imms	467eb5a227	fix(addon-image): cast buffer line lookups to IBufferLineExt \| undefined Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>	2026-06-06 16:26:54 +00:00
Daniel ImmsandCursor	a8632435a6	fix(addon-image): skip missing lines in viewportResize viewportResize walks the full buffer when the terminal widens but called line.getBg without checking that lines.get(row) returned a line. During resize or trim gaps that could throw and abort tile expansion for remaining rows. Skip missing buffer lines with continue, consistent with render(). Co-authored-by: Cursor <cursoragent@cursor.com>	2026-06-03 03:36:42 +00:00
Cursor AgentandDaniel Imms	a0919b9004	fix(addon-image): skip missing buffer lines in render Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>	2026-06-03 03:36:41 +00:00
Daniel ImmsandCursor	b5e0cdb20c	fix(addon-image): scan new columns on viewport width increase viewportResize() should check whether cells in newly exposed columns (oldCol + 1 through cols - 1) already have content before expanding image tiles to the right. The loop used `rightCol > metrics.cols`, which is false when widening (rightCol starts at oldCol + 1), so the loop never ran, hasData stayed false, and tiles could overwrite cells that already held text. Use `rightCol < metrics.cols` so the emptiness check runs over the intended column range. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-06-03 03:36:41 +00:00