Align browser registerMarker alt-buffer guard with headless

Block registerMarker on the alternate buffer in CoreBrowserTerminal,
matching headless addMarker behavior. Update public typings to
IMarker | undefined and add regression tests.

Fixes #5937

Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>

.gitignore

@@ -24,7 +24,6 @@ test-results/
 
 # Tracing/debug files
 .cursor/nal-trace/
-.cursor/*.log
 
 # Keep bundled code out of Git
 dist/

AGENTS.md

@@ -98,15 +98,3 @@ const cell = line?.getCell(0);
 ## Writing unit tests
 
 - Unit tests live alongside the source code file of the thing it's testing with a .test.ts suffix.
-
-## Cursor Cloud specific instructions
-
-**Demo server**: Start with `npm start` (port 3000). The demo server uses node-pty to spawn real shell sessions over WebSocket. Integration tests auto-start it via Playwright's `webServer` config, so you don't need to start it manually for `npm run test-integration`.
-
-**Build before testing**: Always run `npm run build && npm run esbuild` before `npm run test-unit`. Integration tests also need `npm run esbuild-demo-client` and `npm run esbuild-demo-server`. The update script handles this automatically on session start.
-
-**No external services**: This project has zero external dependencies (no databases, Docker, or APIs). Everything runs locally with Node.js.
-
-**TypeScript compiler**: The project uses `tsgo` (native TypeScript compiler preview) rather than standard `tsc`. It's installed via the `@typescript/native-preview` package.
-
-**Lint only changed files**: Prefer `npm run lint-changes` over `npm run lint` when iterating on code changes — it's significantly faster.

addons/addon-image/README.md

@@ -1,7 +1,6 @@
 ## @xterm/addon-image
 
-Inline image output in xterm.js. Supports SIXEL, iTerm's inline image protocol (IIP)
-and partially Kitty's terminal graphics prtocol (TGP).
+Inline image output in xterm.js. Supports SIXEL and iTerm's inline image protocol (IIP).
 
 
 ![](fixture/example.png)
@@ -44,6 +43,9 @@ terminal.loadAddon(imageAddon);
 
 ### General Notes
 
+- *IMPORTANT:* The worker approach as done in previous releases got removed.
+  The addon contructor no longer expects a worker path as first argument.
+
 - By default the addon will activate these `windowOptions` reports on the terminal:
   - getWinSizePixels (CSI 14 t)
   - getCellSizePixels (CSI 16 t)
@@ -71,7 +73,7 @@ terminal.loadAddon(imageAddon);
 
 - **Cursor Positioning**  
   If scrolling is set, the cursor will be placed at the first image column of the last image row (VT340 mode).
-  Other cursor positioning modes as used by xterm or mintty are not supported for sixel.
+  Other cursor positioning modes as used by xterm or mintty are not supported.
 
 - **SIXEL Palette Handling**  
   By default the addon limits the palette size to 256 registers (as demanded by the DEC specification).
@@ -98,24 +100,17 @@ terminal.loadAddon(imageAddon);
   Set by default, change it with `{iipSupport: true}`.
 
   The IIP implementation has the following features / restrictions (sequence will silently fail for unmet conditions):
-  - Supported formats: PNG, JPEG, GIF and QOI
+  - Supported formats: PNG, JPEG and GIF
   - No animation support.
   - Image type hinting is not supported (always deducted from data header).
   - File download is not supported.
   - Filename gets parsed but not used.
   - Strict base64 handling as of RFC4648 §4 (standard alphabet, optional padding, no separator bytes allowed).
+  - Payload size may not exceed CEIL(sizeParameter * 4 / 3).
   - Image scaling beyond terminal viewport size is allowed (e.g. `width=200%`).
   - Image pixel size is restricted by `pixelLimit` (pre- and post resizing).
-  - Playload size is restricted by `iipSizeLimit`.
-  - size parameter is not mandatory anymore.
-  - Cursor gets positioned at the next cell of the last image line.
-  - ReportCellSize sequence is supported.
-  - Hi-res display support is currently limited (image gets blurred).
-
-- **Kitty Graphics Support (TGP)**  
-  Set by default, change it with `{kittySupport: true}`.
-
-  Note that the kitty graphics support is still WIP.
+  - Size parameter is restricted by `iipSizeLimit`.
+  - Cursor positioning behaves the same as for sixel (see above).
 
 
 ### Storage and Drawing Settings
@@ -132,7 +127,6 @@ The addon exposes two properties to interact with the storage limits at runtime:
 By default the addon will show a placeholder pattern for evicted images that are still part
 of the terminal (e.g. in the scrollback). The pattern can be deactivated by toggling `showPlaceholder`.
 
-
 ### Image Data Retrieval
 
 The addon provides the following API endpoints to retrieve raw image data as canvas:
@@ -146,7 +140,6 @@ The addon provides the following API endpoints to retrieve raw image data as can
   The buffer position is the 0-based absolute index (including scrollback at top).
   Note that the canvas gets created and data copied over for every call, thus it is not suitable for performance critical actions.
 
-
 ### Memory Usage
 
 The addon does most image processing in Javascript and therefore can occupy a rather big amount of memory. To get an idea where the memory gets eaten, lets look at the data flow and processing steps:
@@ -187,8 +180,8 @@ _How can I adjust the memory usage?_
   A constructor setting, thus you would have to anticipate, whether (multiple) terminals in your page gonna do lots of concurrent decoding. Since this is normally not the case and the memory usage is only temporarily peaking, a rather high value should work even with multiple terminals in one page.
 - `storageLimit`  
   A constructor and a runtime setting. In conjunction with `storageUsage` you can do runtime checks and adjust the limit to your needs. If you have to lower the limit below the current usage, images will be removed in FIFO order and may turn into a placeholder in the terminal's scrollback (if `showPlaceholder` is set). When adjusting keep in mind to leave enough room for memory peaking for decoding.
-- `sixelSizeLimit | iipSizeLimit | kittySizeLimit`  
-  Constructor settings. This has only a small impact on peaking memory during decoding. It is meant to avoid processing of overly big or broken image sequences at an earlier phase, thus may stop the invoked decoders from entering memory intensive tasks for potentially invalid data.
+- `sixelSizeLimit`  
+  A constructor setting. This has only a small impact on peaking memory during decoding. It is meant to avoid processing of overly big or broken SIXEL sequences at an earlier phase, thus may stop the decoder from entering its memory intensive task for potentially invalid data.
 
 
 ### Terminal Interaction
@@ -218,5 +211,23 @@ _How can I adjust the memory usage?_
 
 ### Status
 
-- Sixel and IIP support and image handling in xterm.js is considered beta quality.
-- Kitty support is in alpha stage. Please file a bug for any awkwardities or missing features.
+- Sixel support and image handling in xterm.js is considered beta quality.
+- IIP support is in alpha stage. Please file a bug for any awkwardities.
+
+
+### Changelog
+
+- 0.5.0 integrate with xtermjs base repo (at v0.4.3)
+- 0.4.3 defer canvas creation
+- 0.4.2 fix image canvas resize
+- 0.4.1 compat release for xterm.js 5.2.0
+- 0.4.0 IIP support
+- 0.3.1 compat release for xterm.js 5.1.0
+- 0.3.0 important change: worker removed from addon
+- 0.2.0 compat release for xterm.js 5.0.0
+- 0.1.3 bugfix: avoid striping
+- 0.1.2 bugfix: reset clear flag
+- 0.1.1 bugfixes:
+  - clear sticky image tiles on render
+  - create folder from bootstrap.sh
+  - fix peer dependency in package.json

addons/addon-image/src/IIPHandler.ts

@@ -8,7 +8,7 @@ import { IIPImageStorage } from './IIPImageStorage';
 import { CELL_SIZE_DEFAULT } from './ImageStorage';
 import Base64Decoder from 'xterm-wasm-parts/lib/base64/Base64Decoder.wasm';
 import QoiDecoder from 'xterm-wasm-parts/lib/qoi/QoiDecoder.wasm';
-import { HeaderParser, IHeaderFields, HeaderState, SequenceType } from './IIPHeaderParser';
+import { HeaderParser, IHeaderFields, HeaderState } from './IIPHeaderParser';
 import { imageType, UNSUPPORTED_TYPE } from './IIPMetrics';
 
 // Local const enum mirror - esbuild can't inline const enums from external packages
@@ -23,7 +23,6 @@ const enum DecoderConst {
 
 // default IIP header values
 const DEFAULT_HEADER: IHeaderFields = {
-  type: SequenceType.INVALID,
   name: 'Unnamed file',
   size: 0,
   width: 'auto',
@@ -40,8 +39,6 @@ export class IIPHandler implements IOscHandler, IResetHandler {
   private _dec: Base64Decoder;
   private _qoiDec: QoiDecoder;
   private _metrics = UNSUPPORTED_TYPE;
-  private _isMultipart = false;
-  private _abortMulti = false;
 
   constructor(
     private readonly _opts: IImageAddonOptions,
@@ -55,14 +52,11 @@ export class IIPHandler implements IOscHandler, IResetHandler {
     this._qoiDec = new QoiDecoder(DecoderConst.KEEP_DATA);
   }
 
-  public reset(): void {
-    this._hp.reset();
-    this._dec.release();
-    this._qoiDec.release();
-  }
+  public reset(): void {}
 
   public start(): void {
     this._aborted = false;
+    this._header = DEFAULT_HEADER;
     this._metrics  = UNSUPPORTED_TYPE;
     this._hp.reset();
   }
@@ -82,27 +76,15 @@ export class IIPHandler implements IOscHandler, IResetHandler {
         return;
       }
       if (dataPos > 0) {
-        const seqType = this._hp.fields.type;
-        if (seqType === SequenceType.FILE) {
-          if (this._isMultipart) {
-            this._isMultipart = false;
-            this._abortMulti = false;
-            this._dec.release();
-          }
-          this._header = Object.assign({}, DEFAULT_HEADER, this._hp.fields);
-          if (!this._header.inline) {
-            this._aborted = true;
-            return;
-          }
-          this._dec.init();
-        } else if (this._abortMulti) {
+        this._header = Object.assign({}, DEFAULT_HEADER, this._hp.fields);
+        if (!this._header.inline || !this._header.size || this._header.size > this._opts.iipSizeLimit) {
           this._aborted = true;
           return;
         }
+        this._dec.init();
         if ((this._dec.put(data.subarray(dataPos, end)) as number) !== DecoderConst.OK) {
           this._dec.release();
           this._aborted = true;
-          if (this._isMultipart) this._abortMulti = true;
         }
       }
     }
@@ -111,58 +93,22 @@ export class IIPHandler implements IOscHandler, IResetHandler {
   public end(success: boolean): boolean | Promise<boolean> {
     if (this._aborted) return true;
 
-    if (this._hp.state !== HeaderState.END) {
-      if (this._hp.end()) return true;
-    }
-    const seqType = this._hp.fields.type;
-
-    if (seqType === SequenceType.FILEPART) return true;
-
-    if (seqType === SequenceType.REPORTCELLSIZE) {
-      // OSC 1337 ; ReportCellSize=[height];[width];[scale] ST
-      let width = CELL_SIZE_DEFAULT.width;
-      let height = CELL_SIZE_DEFAULT.height;
-      if (this._renderer.dimensions) {
-        width = this._renderer.dimensions.css.canvas.width / this._coreTerminal.cols;
-        height = this._renderer.dimensions.css.canvas.height / this._coreTerminal.rows;
-      }
-      const scale = this._coreTerminal._core._coreBrowserService?.dpr ?? 1;
-      const report = `\x1b]1337;ReportCellSize=${height.toFixed(3)};${width.toFixed(3)};${scale.toFixed(3)}\x1b\\`;
-      this._coreTerminal.input(report, false);
-      return true;
-    }
-
-    if (seqType === SequenceType.MULTIPARTFILE) {
-      this._header = Object.assign({}, DEFAULT_HEADER, this._hp.fields);
-      this._isMultipart = true;
-      this._abortMulti = false;
-      this._dec.release();
-      this._dec.init();
-      return true;
-    }
-
-    if (seqType === SequenceType.FILEEND) {
-      if (!this._isMultipart) return true;
-      this._isMultipart = false;
-      if (this._abortMulti || this._header.type !== SequenceType.MULTIPARTFILE) return true;
-    }
-
-    // fallthrough for SequenceType.FILE & SequenceType.FILEEND
-
     let w = 0;
     let h = 0;
 
     // early exit condition chain
-    let cond: number | boolean;
+    let cond: number | boolean = true;
     if (cond = success) {
       if (cond = !this._dec.end()) {
-        this._metrics = imageType(this._dec.data8);
-        if (cond = this._metrics.mime !== 'unsupported') {
-          w = this._metrics.width;
-          h = this._metrics.height;
-          if (cond = w && h && w * h < this._opts.pixelLimit) {
-            [w, h] = this._resize(w, h).map(Math.floor);
-            cond = w && h && w * h < this._opts.pixelLimit;
+        if (cond = this._dec.data8.length === this._header.size) {
+          this._metrics = imageType(this._dec.data8);
+          if (cond = this._metrics.mime !== 'unsupported') {
+            w = this._metrics.width;
+            h = this._metrics.height;
+            if (cond = w && h && w * h < this._opts.pixelLimit) {
+              [w, h] = this._resize(w, h).map(Math.floor);
+              cond = w && h && w * h < this._opts.pixelLimit;
+            }
           }
         }
       }

addons/addon-image/src/IIPHeaderParser.test.ts

@@ -4,20 +4,19 @@
  */
 
 import { assert } from 'chai';
-import { HeaderParser, HeaderState, IHeaderFields, SequenceType } from './IIPHeaderParser';
+import { HeaderParser, HeaderState, IHeaderFields } from './IIPHeaderParser';
 
 
 const CASES: [string, IHeaderFields][] = [
-  ['File=size=123456;name=dGVzdA==:', {type: SequenceType.FILE, name: 'test', size: 123456}],
-  ['File=size=123456;name=dGVzdA:', {type: SequenceType.FILE, name: 'test', size: 123456}],
+  ['File=size=123456;name=dGVzdA==:', {name: 'test', size: 123456}],
+  ['File=size=123456;name=dGVzdA:', {name: 'test', size: 123456}],
   // utf-8 encoding in name
-  ['File=size=123456;name=w7xtbMOkdXTDnw==:', {type: SequenceType.FILE, name: 'ümläutß', size: 123456}],
-  ['File=size=123456;name=w7xtbMOkdXTDnw:', {type: SequenceType.FILE, name: 'ümläutß', size: 123456}],
+  ['File=size=123456;name=w7xtbMOkdXTDnw==:', {name: 'ümläutß', size: 123456}],
+  ['File=size=123456;name=w7xtbMOkdXTDnw:', {name: 'ümläutß', size: 123456}],
   // full header spec
   [
     'File=inline=1;width=10px;height=20%;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw:',
     {
-      type: SequenceType.FILE,
       inline: 1,
       width: '10px',
       height: '20%',
@@ -29,7 +28,6 @@ const CASES: [string, IHeaderFields][] = [
   [
     'File=inline=1;width=auto;height=20;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw:',
     {
-      type: SequenceType.FILE,
       inline: 1,
       width: 'auto',
       height: '20',
@@ -103,7 +101,7 @@ describe('IIPHeaderParser', () => {
     let res = hp.parse(inp, 0, inp.length);
     assert.strictEqual(res, inp.length);
     assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, {type: SequenceType.FILE, name: 'test', size: 0});
+    assert.deepEqual(hp.fields, {name: 'test', size: 0});
     hp.reset();
     inp = fromBs(CASES[0][0]);
     res = hp.parse(inp, 0, inp.length);
@@ -117,7 +115,7 @@ describe('IIPHeaderParser', () => {
     let res = hp.parse(inp, 0, inp.length);
     assert.strictEqual(res, inp.length);
     assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, {type: SequenceType.FILE, name: '', size: 123456});
+    assert.deepEqual(hp.fields, {name: '', size: 123456});
     hp.reset();
     inp = fromBs(CASES[0][0]);
     res = hp.parse(inp, 0, inp.length);
@@ -137,124 +135,4 @@ describe('IIPHeaderParser', () => {
     assert.strictEqual(hp.state, HeaderState.END);
     assert.deepEqual(hp.fields, CASES[0][1]);
   });
-  it('FilePart sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FilePart=w7xtbMOkdXTDnw');
-    const res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, 9);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEPART);
-  });
-  it('FilePart sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FilePart=w7xtbMOkdXTDnw');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, 1);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEPART);
-  });
-  it('MultipartFile sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('MultipartFile=inline=1;width=10px;height=20%;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw');
-    let res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.VALUE);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(
-      hp.fields,
-      {
-        type: SequenceType.MULTIPARTFILE,
-        inline: 1,
-        width: '10px',
-        height: '20%',
-        preserveAspectRatio: 1,
-        size: 123456,
-        name: 'ümläutß'
-      }
-    );
-  });
-  it('MultipartFile sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('MultipartFile=inline=1;width=10px;height=20%;preserveAspectRatio=1;size=123456;name=w7xtbMOkdXTDnw');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.VALUE);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(
-      hp.fields,
-      {
-        type: SequenceType.MULTIPARTFILE,
-        inline: 1,
-        width: '10px',
-        height: '20%',
-        preserveAspectRatio: 1,
-        size: 123456,
-        name: 'ümläutß'
-      }
-    );
-  });
-  it('FileEnd sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FileEnd');
-    let res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEEND);
-  });
-  it('FileEnd sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('FileEnd');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields.type, SequenceType.FILEEND);
-  });
-  it('ReportCellSize sequence', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('ReportCellSize');
-    let res = hp.parse(inp, 0, inp.length);
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, { type: SequenceType.REPORTCELLSIZE });
-  });
-  it('ReportCellSize sequence - bytewise', () => {
-    const hp = new HeaderParser();
-    const inp = fromBs('ReportCellSize');
-    let res = -2;
-    let pos = 0;
-    while (res === -2 && pos < inp.length) {
-      res = hp.parse(new Uint32Array([inp[pos++]]), 0, 1);
-    }
-    assert.strictEqual(res, -2);
-    assert.strictEqual(hp.state, HeaderState.START);
-    res = hp.end();
-    assert.strictEqual(res, 0);
-    assert.strictEqual(hp.state, HeaderState.END);
-    assert.deepEqual(hp.fields, { type: SequenceType.REPORTCELLSIZE });
-  });
 });

addons/addon-image/src/IIPHeaderParser.ts

@@ -6,27 +6,9 @@
 // eslint-disable-next-line
 declare const Buffer: any;
 
-export const enum HeaderState {
-  START = 0,
-  ABORT = 1,
-  KEY = 2,
-  VALUE = 3,
-  END = 4
-}
-
-export const enum SequenceType {
-  INVALID = 0,
-  FILE = 1,
-  MULTIPARTFILE = 2,
-  FILEPART = 3,
-  FILEEND = 4,
-  REPORTCELLSIZE = 5
-}
 
 export interface IHeaderFields {
   [key: string]: number | string | Uint32Array | null | undefined;
-  // sequence type
-  type: SequenceType;
   // base-64 encoded filename. Defaults to "Unnamed file".
   name: string;
   // File size in bytes. The file transfer will be canceled if this size is exceeded.
@@ -47,6 +29,14 @@ export interface IHeaderFields {
   inline?: number;
 }
 
+export const enum HeaderState {
+  START = 0,
+  ABORT = 1,
+  KEY = 2,
+  VALUE = 3,
+  END = 4
+}
+
 // field value decoders
 
 // ASCII bytes to string
@@ -102,19 +92,7 @@ const DECODERS: {[key: string]: (v: Uint32Array) => number | string} = {
 };
 
 
-// sequence type markers
-// File
 const FILE_MARKER = [70, 105, 108, 101];
-// MultipartFile
-const MULTIPARTFILE_MARKER = [77, 117, 108, 116, 105, 112, 97, 114, 116, 70, 105, 108, 101];
-// FilePart
-const FILEPART_MARKER = [70, 105, 108, 101, 80, 97, 114, 116];
-// FileEnd
-const FILEEND_MARKER = [70, 105, 108, 101, 69, 110, 100];
-// ReportCellSize
-const REPORTCELLSIZE_MARKER = [82, 101, 112, 111, 114, 116, 67, 101, 108, 108, 83, 105, 122, 101];
-
-// max allowed chars for sequence header
 const MAX_FIELDCHARS = 1024;
 
 
@@ -133,43 +111,12 @@ export class HeaderParser {
     this._key = '';
   }
 
-  public end(): number {
-    if (this.state === HeaderState.START) {
-      if (this._position === FILEEND_MARKER.length) {
-        for (let k = 0; k < FILEEND_MARKER.length; ++k) {
-          if (this._buffer[k] !== FILEEND_MARKER[k]) return this._a();
-        }
-        this.fields['type'] = SequenceType.FILEEND;
-        this.state = HeaderState.END;
-        return 0;
-      }
-      if (this._position === REPORTCELLSIZE_MARKER.length) {
-        for (let k = 0; k < REPORTCELLSIZE_MARKER.length; ++k) {
-          if (this._buffer[k] !== REPORTCELLSIZE_MARKER[k]) return this._a();
-        }
-        this.fields['type'] = SequenceType.REPORTCELLSIZE;
-        this.state = HeaderState.END;
-        return 0;
-      }
-      return this._a();
-    }
-    if (this.state === HeaderState.END) return 0;
-    if (this.state === HeaderState.VALUE
-      && this.fields.type === SequenceType.MULTIPARTFILE
-    ) {
-      if (!this._storeValue(this._position)) return this._a();
-      this.state = HeaderState.END;
-      return 0;
-    }
-    return this._a();
-  }
-
   public parse(data: Uint32Array, start: number, end: number): number {
     let state = this.state;
     let pos = this._position;
     const buffer = this._buffer;
     if (state === HeaderState.ABORT || state === HeaderState.END) return -1;
-    if (state === HeaderState.START && pos > 14) return -1;
+    if (state === HeaderState.START && pos > 6) return -1;
     for (let i = start; i < end; ++i) {
       const c = data[i];
       switch (c) {
@@ -180,29 +127,8 @@ export class HeaderParser {
           break;
         case 61: // =
           if (state === HeaderState.START) {
-            if (buffer[0] === 70) {
-              // 'File' or 'FilePart'
-              let k = 0;
-              for (; k < FILE_MARKER.length; ++k) {
-                if (buffer[k] !== FILE_MARKER[k]) return this._a();
-              }
-              this.fields['type'] = SequenceType.FILE;
-              if (pos === FILEPART_MARKER.length) {
-                for (; k < FILEPART_MARKER.length; ++k) {
-                  if (buffer[k] !== FILEPART_MARKER[k]) return this._a();
-                }
-                this.fields['type'] = SequenceType.FILEPART;
-                this.state = HeaderState.END;
-                return i + 1;
-              }
-            } else if (buffer[0] === 77) {
-              // 'MultipartFile'
-              for (let k = 0; k < MULTIPARTFILE_MARKER.length; ++k) {
-                if (buffer[k] !== MULTIPARTFILE_MARKER[k]) return this._a();
-              }
-              this.fields['type'] = SequenceType.MULTIPARTFILE;
-            } else {
-              return this._a();
+            for (let k = 0; k < FILE_MARKER.length; ++k) {
+              if (buffer[k] !== FILE_MARKER[k]) return this._a();
             }
             state = HeaderState.KEY;
             pos = 0;
@@ -232,7 +158,6 @@ export class HeaderParser {
   }
 
   private _a(): number {
-    this.fields.type = SequenceType.INVALID;
     this.state = HeaderState.ABORT;
     return -1;
   }

addons/addon-image/src/IIPImageStorage.ts

@@ -3,7 +3,6 @@
  * @license MIT
  */
 
-import { IAddImageOpts } from 'Types';
 import { ImageStorage } from './ImageStorage';
 
 /**
@@ -13,7 +12,6 @@ import { ImageStorage } from './ImageStorage';
  * - Always uses scrolling mode (cursor advances with image)
  */
 export class IIPImageStorage {
-  private _addImageOpts: IAddImageOpts = { scrolling: true, layer: 'top', zIndex: 0, cursorPos: 'iip' };
   constructor(
     private readonly _storage: ImageStorage
   ) {}
@@ -23,6 +21,6 @@ export class IIPImageStorage {
    * Always uses scrolling mode — cursor advances past the image.
    */
   public addImage(img: HTMLCanvasElement | ImageBitmap): void {
-    this._storage.addImage(img, this._addImageOpts);
+    this._storage.addImage(img, true);
   }
 }

addons/addon-image/src/IIPMetrics.test.ts

@@ -30,8 +30,7 @@ const TEST_IMAGES: [string, IMetrics][] = [
   ['iphone_hdr_YES.jpg', { mime: 'image/jpeg', width: 3264, height: 2448 }],
   ['nikon-e950.jpg', { mime: 'image/jpeg', width: 800, height: 600 }],
   ['agfa-makernotes.jpg', { mime: 'image/jpeg', width: 8, height: 8 }],
-  ['sony-alpha-6000.jpg', { mime: 'image/jpeg', width: 6000, height: 4000 }],
-  ['dice.qoi', { mime: 'image/qoi', width: 800, height: 600 }],
+  ['sony-alpha-6000.jpg', { mime: 'image/jpeg', width: 6000, height: 4000 }]
 ];
 
 

addons/addon-image/src/ImageAddon.ts

@@ -137,6 +137,11 @@ export class ImageAddon implements ITerminalAddon, IImageApi {
 
     // enable size reports
     if (this._opts.enableSizeReports) {
+      // const windowOptions = terminal.getOption('windowOptions');
+      // windowOptions.getWinSizePixels = true;
+      // windowOptions.getCellSizePixels = true;
+      // windowOptions.getWinSizeChars = true;
+      // terminal.setOption('windowOptions', windowOptions);
       const windowOps = terminal.options.windowOptions ?? {};
       windowOps.getWinSizePixels = true;
       windowOps.getCellSizePixels = true;
@@ -255,7 +260,7 @@ export class ImageAddon implements ITerminalAddon, IImageApi {
   }
 
   private _report(s: string): void {
-    this._terminal?._core.input(s, false);
+    this._terminal?._core.coreService.triggerDataEvent(s);
   }
 
   private _decset(params: (number | number[])[]): boolean {

addons/addon-image/src/ImageRenderer.ts

@@ -146,7 +146,7 @@ export class ImageRenderer extends Disposable implements IDisposable {
   public clearLines(start: number, end: number, layer?: ImageLayer): void {
     const y = start * (this.dimensions?.css.cell.height || 0);
     const w = this.dimensions?.css.canvas.width || 0;
-    const h = (end + 1 - start) * (this.dimensions?.css.cell.height || 0);
+    const h = (++end - start) * (this.dimensions?.css.cell.height || 0);
     if (!layer || layer === 'top') {
       this._layers.get('top')?.clearRect(0, y, w, h);
     }

addons/addon-image/src/ImageStorage.ts

@@ -5,11 +5,7 @@
 
 import { IDisposable } from '@xterm/xterm';
 import { ImageRenderer } from './ImageRenderer';
-import {
-  ITerminalExt, IExtendedAttrsImage, IImageAddonOptions, IImageSpec,
-  IBufferLineExt, BgFlags, Cell, Content, ICellSize, ExtFlags, Attributes,
-  UnderlineStyle, IAddImageOpts
-} from './Types';
+import { ITerminalExt, IExtendedAttrsImage, IImageAddonOptions, IImageSpec, IBufferLineExt, BgFlags, Cell, Content, ICellSize, ExtFlags, Attributes, UnderlineStyle, ImageLayer } from './Types';
 
 
 // fallback default cell size
@@ -239,15 +235,13 @@ export class ImageStorage implements IDisposable {
   /**
    * Method to add an image to the storage.
    * @param img - The image to add (canvas or bitmap).
-   * @param opts - Options for addImage:
-   *   - scrolling:  When true, cursor advances with the image.
-   *                 When false, image is placed at ORIGIN and cursor does not move.
-   *   - layer:      Which canvas layer to render on ('top' or 'bottom').
-   *   - zIndex:     Z-index for image layering within the same layer.
-   *   - cursorPos:  'vt340' for bottom-left, 'iip' for bottom.right.
+   * @param scrolling - When true, cursor advances with the image (lineFeed per row).
+   *   When false, image is placed at (0,0) and cursor is restored (DECSET 80 / sixel origin mode).
+   * @param layer - Which canvas layer to render on ('top' or 'bottom').
+   * @param zIndex - Z-index for image layering within the same layer.
    * @returns The internal image ID assigned to the stored image.
    */
-  public addImage(img: HTMLCanvasElement | ImageBitmap, opts: IAddImageOpts): number {
+  public addImage(img: HTMLCanvasElement | ImageBitmap, scrolling: boolean, layer: ImageLayer = 'top', zIndex: number = 0): number {
     // never allow storage to exceed memory limit
     this._evictOldest(img.width * img.height);
 
@@ -269,7 +263,7 @@ export class ImageStorage implements IDisposable {
     let offset = originX;
     let tileCount = 0;
 
-    if (!opts.scrolling) {
+    if (!scrolling) {
       buffer.x = 0;
       buffer.y = 0;
       offset = 0;
@@ -283,7 +277,7 @@ export class ImageStorage implements IDisposable {
         this._writeToCell(line as IBufferLineExt, offset + col, imageId, row * cols + col);
         tileCount++;
       }
-      if (opts.scrolling) {
+      if (scrolling) {
         if (row < rows - 1) this._terminal._core._inputHandler.lineFeed();
       } else {
         if (++buffer.y >= termRows) break;
@@ -293,12 +287,8 @@ export class ImageStorage implements IDisposable {
     this._terminal._core._inputHandler._dirtyRowTracker.markDirty(buffer.y);
 
     // cursor positioning modes
-    if (opts.scrolling) {
-      if (opts.cursorPos === 'iip') {
-        buffer.x = Math.min(offset + cols, termCols);
-      } else {
-        buffer.x = offset;
-      }
+    if (scrolling) {
+      buffer.x = offset;
     } else {
       buffer.x = originX;
       buffer.y = originY;
@@ -341,8 +331,8 @@ export class ImageStorage implements IDisposable {
       marker: endMarker || undefined,
       tileCount,
       bufferType: this._terminal.buffer.active.type,
-      layer: opts.layer,
-      zIndex: opts.zIndex
+      layer,
+      zIndex
     };
 
     // finally add the image
@@ -465,6 +455,7 @@ export class ImageStorage implements IDisposable {
             if (!nextE || nextE.imageId !== imageId || nextE.tileId !== startTile + count) {
               break;
             }
+            e = nextE;
             count++;
           }
           col--;

addons/addon-image/src/SixelImageStorage.ts

@@ -4,7 +4,7 @@
  */
 
 import { ImageStorage, CELL_SIZE_DEFAULT } from './ImageStorage';
-import { IImageAddonOptions, ITerminalExt, IAddImageOpts } from './Types';
+import { IImageAddonOptions, ITerminalExt } from './Types';
 import { ImageRenderer } from './ImageRenderer';
 
 /**
@@ -15,7 +15,6 @@ import { ImageRenderer } from './ImageRenderer';
  * - advanceCursor for empty sixels carrying only height
  */
 export class SixelImageStorage {
-  private _addImageOpts: IAddImageOpts = { scrolling: true, layer: 'top', zIndex: 0, cursorPos: 'vt340' };
   constructor(
     private readonly _storage: ImageStorage,
     private readonly _opts: IImageAddonOptions,
@@ -28,8 +27,7 @@ export class SixelImageStorage {
    * Cursor behavior depends on the sixelScrolling option (DECSET 80).
    */
   public addImage(img: HTMLCanvasElement | ImageBitmap): void {
-    this._addImageOpts.scrolling = this._opts.sixelScrolling;
-    this._storage.addImage(img, this._addImageOpts);
+    this._storage.addImage(img, this._opts.sixelScrolling);
   }
 
   /**

addons/addon-image/src/Types.ts

@@ -100,14 +100,6 @@ export interface ICellSize {
 }
 
 export type ImageLayer = 'top' | 'bottom';
-export type CursorPos = 'vt340' | 'iip';
-
-export interface IAddImageOpts {
-  scrolling: boolean;
-  layer: ImageLayer;
-  zIndex: number;
-  cursorPos: CursorPos;
-}
 
 export interface IImageSpec {
   orig: HTMLCanvasElement | ImageBitmap | undefined;

addons/addon-image/src/kitty/KittyImageStorage.ts

@@ -5,7 +5,7 @@
 
 import { IDisposable } from '@xterm/xterm';
 import { ImageStorage } from '../ImageStorage';
-import { ImageLayer, IAddImageOpts } from '../Types';
+import { ImageLayer } from '../Types';
 import { IKittyImageData } from './KittyGraphicsTypes';
 
 // Kitty-specific image storage controller.
@@ -42,7 +42,6 @@ export class KittyImageStorage implements IDisposable {
       this._images.delete(kittyId);
     }
   };
-  private _addImageOpts: IAddImageOpts = { scrolling: true, layer: 'top', zIndex: 0, cursorPos: 'iip' };
 
   constructor(
     private readonly _storage: ImageStorage
@@ -99,10 +98,7 @@ export class KittyImageStorage implements IDisposable {
     if (oldStorageId !== undefined) {
       this._storageIdToKittyId.delete(oldStorageId);
     }
-    this._addImageOpts.scrolling = scrolling;
-    this._addImageOpts.layer = layer;
-    this._addImageOpts.zIndex = zIndex;
-    const storageId = this._storage.addImage(image, this._addImageOpts);
+    const storageId = this._storage.addImage(image, scrolling, layer, zIndex);
     this._kittyIdToStorageId.set(kittyId, storageId);
     this._storageIdToKittyId.set(storageId, kittyId);
   }

addons/addon-image/test/ImageAddon.test.ts

@@ -290,67 +290,6 @@ test.describe('ImageAddon', () => {
     });
   });
 
-  test.describe('IIP support', () => {
-    test('size params is optional/informative', async () => {
-      // too small size param
-      await ctx.proxy.write(`\x1b]1337;File=inline=1;size=5:${PALETTE_PNG_BASE64}\x07`);
-      deepStrictEqual(await getOrigSize(1), [640, 80]);
-      // no size aparm at all
-      await ctx.proxy.write(`\x1b[10H\x1b]1337;File=inline=1:${PALETTE_QOI_BASE64}\x07`);
-      deepStrictEqual(await getOrigSize(2), [640, 80]);
-    });
-    test.skip('FilePart support - bytewise', async () => {
-      // opener
-      await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      // byte-wise
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; ++i) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64[i]}\x07`);
-      }
-      // finalizer
-      await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      deepStrictEqual(await getOrigSize(1), [640, 80]);
-    });
-    test('FilePart support - chunks', async () => {
-      // opener
-      await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      // chunks
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; i += 256) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64.slice(i, i + 256)}\x07`);
-      }
-      // finalizer
-      await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      deepStrictEqual(await getOrigSize(1), [640, 80]);
-    });
-    test('FilePart support - edgecases', async () => {
-      // multiple opener do not harm
-      for (let i = 0; i < 10; ++i) {
-        await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      }
-      // multiple finalizer do not harm
-      for (let i = 0; i < 5; ++i) {
-        await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      }
-      // chunks w'o opener are ignored
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; i += 256) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64.slice(i, i + 256)}\x07`);
-      }
-      await ctx.proxy.write(`\x1b]1337;FileEnd\x07`);
-      pollFor(ctx.page, 'window.imageAddon._storage._images.size', 0);
-    });
-    test('FilePart support - other IIP sequence cancels chunked image', async () => {
-      // opener
-      await ctx.proxy.write(`\x1b]1337;MultipartFile=inline=1\x07`);
-      // chunks
-      for (let i = 0; i < PALETTE_PNG_BASE64.length; i += 256) {
-        await ctx.proxy.write(`\x1b]1337;FilePart=${PALETTE_PNG_BASE64.slice(i, i + 256)}\x07`);
-      }
-      // finalizer skipped
-      // write spinfox.png
-      await ctx.proxy.write(TESTDATA_IIP[1][0]);
-      deepStrictEqual(await getOrigSize(1), TESTDATA_IIP[1][1]);
-    });
-  });
-
   test.describe('IIP support - testimages', () => {
     test('palette.png', async () => {
       await ctx.proxy.write(TESTDATA_IIP[0][0]);

addons/addon-image/test/KittyGraphics.test.ts

@@ -539,6 +539,7 @@ test.describe('Kitty Graphics Protocol', () => {
 
   test.describe('Query support (a=q)', () => {
     test('responds with OK for capability query without payload', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -547,11 +548,12 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=31,a=q;\x1b\\');
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=31;OK\x1b\\');
     });
 
     test('responds with OK for valid PNG query', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -560,7 +562,7 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write(`\x1b_Gi=42,a=q,f=100;${KITTY_BLACK_1X1_BASE64}\x1b\\`);
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=42;OK\x1b\\');
     });
 
@@ -576,6 +578,7 @@ test.describe('Kitty Graphics Protocol', () => {
     });
 
     test('responds with error for invalid base64', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -584,11 +587,12 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=60,a=q,f=100;!!!invalid!!!\x1b\\');
       await timeout(100);
 
-      const response: string = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response.startsWith('\x1b_Gi=60;EINVAL:'), true);
     });
 
     test('responds with error for RGB data without dimensions', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -597,7 +601,7 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=70,a=q,f=24;AAAA\x1b\\');
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=70;EINVAL:width and height required for raw pixel data\x1b\\');
     });
 
@@ -638,6 +642,7 @@ test.describe('Kitty Graphics Protocol', () => {
     });
 
     test('responds with EINVAL when both i and I keys are specified', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -647,11 +652,12 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write(`\x1b_Gi=100,I=200,a=q,f=100;${KITTY_BLACK_1X1_BASE64}\x1b\\`);
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=100;EINVAL:cannot specify both i and I keys\x1b\\');
     });
 
     test('responds with EINVAL for i+I conflict even without payload', async () => {
+      let response = '';
       await ctx.page.evaluate(() => {
         (window as any).kittyResponse = '';
         (window as any).term.onData((data: string) => { (window as any).kittyResponse = data; });
@@ -661,7 +667,7 @@ test.describe('Kitty Graphics Protocol', () => {
       await ctx.proxy.write('\x1b_Gi=101,I=201,a=d\x1b\\');
       await timeout(100);
 
-      const response = await ctx.page.evaluate('window.kittyResponse');
+      response = await ctx.page.evaluate('window.kittyResponse');
       strictEqual(response, '\x1b_Gi=101;EINVAL:cannot specify both i and I keys\x1b\\');
     });
   });

addons/addon-ligatures/package.json

@@ -31,11 +31,15 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "lru-cache": "^11.3.6",
-    "opentype.js": "^2.0.0"
+    "lru-cache": "^6.0.0",
+    "opentype.js": "^0.8.0"
   },
   "devDependencies": {
-    "@types/opentype.js": "^1.3.9",
-    "font-finder": "^1.1.0"
+    "@types/lru-cache": "^5.1.0",
+    "@types/opentype.js": "^0.7.0",
+    "axios": "^1.15.2",
+    "font-finder": "^1.1.0",
+    "mkdirp": "0.5.5",
+    "yauzl": "^3.2.1"
   }
 }

addons/addon-ligatures/src/fontLigatures/index.ts

@@ -1,5 +1,5 @@
 import * as opentype from 'opentype.js';
-import { LRUCache } from 'lru-cache';
+import LRUCache = require('lru-cache');
 
 import { IFont, ILigatureData, IFlattenedLookupTree, ILookupTree, IOptions } from './types';
 import mergeTrees from './merge';
@@ -23,8 +23,8 @@ class FontImpl implements IFont {
 
     if (options.cacheSize > 0) {
       this._cache = new LRUCache({
-        maxSize: options.cacheSize,
-        sizeCalculation: ((val: ILigatureData | [number, number][], key: string) => key.length) as any
+        max: options.cacheSize,
+        length: ((val: ILigatureData | [number, number][], key: string) => key.length) as any
       });
     }
 

addons/addon-ligatures/src/fontLigatures/mergeRange.ts

@@ -44,6 +44,7 @@ export default function mergeRange(ranges: [number, number][], newRangeStart: nu
         // current range
         ranges[i - 1][1] = Math.max(newRangeEnd, range[1]);
         ranges.splice(i, 1);
+        inRange = false;
         return ranges;
       }
       // Case 7: New range extends from previous range past the

addons/addon-progress/test/ProgressAddon.test.ts

@@ -9,18 +9,15 @@ import { ITestContext, createTestContext, openTerminal } from '../../../test/pla
 
 
 let ctx: ITestContext;
+test.beforeAll(async ({ browser }) => {
+  ctx = await createTestContext(browser);
+  ctx.page.setViewportSize({ width: 1024, height: 768 });
+  await openTerminal(ctx);
+});
+test.afterAll(async () => await ctx.page.close());
+
 
 test.describe('ProgressAddon', () => {
-  test.describe.configure({ mode: 'serial' });
-
-  test.beforeAll(async ({ browser }) => {
-    ctx = await createTestContext(browser);
-    await openTerminal(ctx);
-  });
-  test.afterAll(async () => {
-    await ctx?.page?.close();
-  });
-
   test.beforeEach(async function(): Promise<any> {
     await ctx.page.evaluate(`
       window.progressStack = [];

addons/addon-search/src/DecorationManager.ts

@@ -131,6 +131,9 @@ export class DecorationManager extends Disposable {
     const decorations: IDecoration[] = [];
     for (const range of decorationRanges) {
       const marker = this._terminal.registerMarker(range[0]);
+      if (!marker) {
+        continue;
+      }
       const decoration = this._terminal.registerDecoration({
         marker,
         x: range[1],

addons/addon-search/src/SearchEngine.ts

@@ -174,7 +174,7 @@ export class SearchEngine {
     this._terminal.clearSelection();
 
     let startRow = this._terminal.buffer.active.baseY + this._terminal.rows - 1;
-    const startCol = this._terminal.cols;
+    let startCol = this._terminal.cols;
     const isReverseSearch = true;
 
     this._lineCache.initLinesCache();
@@ -186,14 +186,14 @@ export class SearchEngine {
     let result: ISearchResult | undefined;
     if (prevSelectedPos) {
       searchPosition.startRow = startRow = prevSelectedPos.start.y;
-      searchPosition.startCol = prevSelectedPos.start.x;
+      searchPosition.startCol = startCol = prevSelectedPos.start.x;
       if (cachedSearchTerm !== term) {
         // Try to expand selection to right first.
         result = this._findInLine(term, searchPosition, searchOptions, false);
         if (!result) {
           // If selection was not able to be expanded to the right, then try reverse search
           searchPosition.startRow = startRow = prevSelectedPos.end.y;
-          searchPosition.startCol = prevSelectedPos.end.x;
+          searchPosition.startCol = startCol = prevSelectedPos.end.x;
         }
       }
     }

addons/addon-serialize/benchmark/tsconfig.json

@@ -7,10 +7,10 @@
     "rootDir": "..",
     "outDir": "../out-benchmark",
     "types": ["../../../node_modules/@types/node"],
-    "moduleResolution": "nodenext",
+    "moduleResolution": "node",
     "strict": false,
     "target": "es2021",
-    "module": "nodenext",
+    "module": "commonjs",
     "paths": {
       "common/*": ["../../../src/common/*"],
       "browser/*": ["../../../src/browser/*"],

addons/addon-unicode-graphemes/benchmark/tsconfig.json

@@ -4,10 +4,10 @@
     "rootDir": "..",
     "outDir": "../out-benchmark",
     "types": ["../../../node_modules/@types/node"],
-    "moduleResolution": "nodenext",
+    "moduleResolution": "node",
     "strict": false,
     "target": "es2015",
-    "module": "nodenext",
+    "module": "commonjs",
     "paths": {
       "common/*": ["../../../src/common/*"],
       "browser/*": ["../../../src/browser/*"],

addons/addon-web-fonts/test/WebFontsAddon.test.ts

@@ -78,22 +78,7 @@ test.describe('WebFontsAddon', () => {
       const data = await ctx.page.evaluate(`
           document.styleSheets[0].insertRule("@font-face {font-family: Kongtext; src: url(/fonts/kongtext.regular.ttf) format('truetype'); unicode-range: U+00A0-00FF}", 0);
         `);
-      let fonts = await getDocumentFonts();
-      // safari may have loaded the font, firefox & chrome never load it
-      if (browser.browserType().name() === 'webkit') {
-        try {
-          deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loading' }]);
-        } catch (e) {
-          try {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loaded' }]);
-          } catch (e) {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
-          }
-        }
-      } else {
-        deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
-      }
-
+      deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'unloaded' }]);
 
       // broken case: webfont in ctor without addon usage
       await ctx.page.evaluate(`
@@ -101,20 +86,15 @@ test.describe('WebFontsAddon', () => {
           window.helperTerm.open(term.element);
         `);
 
-      fonts = await getDocumentFonts();
-      // safari might load the font, firefox & chrome dont
+      // safari loads the font, firefox & chrome dont
       if (browser.browserType().name() === 'webkit') {
         try {
-          deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loading' }]);
+          deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'loading' }]);
         } catch (e) {
-          try {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'loaded' }]);
-          } catch (e) {
-            deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
-          }
+          deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'loaded' }]);
         }
       } else {
-        deepStrictEqual(fonts, [{ family: 'Kongtext', status: 'unloaded' }]);
+        deepStrictEqual(await getDocumentFonts(), [{ family: 'Kongtext', status: 'unloaded' }]);
       }
 
       // good case: addon fixes layout for webfont in ctor

addons/addon-web-fonts/test/tsconfig.json

@@ -5,6 +5,7 @@
     "lib": [
       "es2021",
     ],
+    // "downlevelIteration": true,
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,

addons/addon-web-links/src/WebLinkProvider.ts

@@ -113,8 +113,8 @@ export class LinkComputer {
     let line: IBufferLine | undefined;
     let topIdx = lineIndex;
     let bottomIdx = lineIndex;
-    let length;
-    let content;
+    let length = 0;
+    let content = '';
     const lines: string[] = [];
 
     if ((line = terminal.buffer.active.getLine(lineIndex))) {

addons/addon-web-links/test/tsconfig.json

@@ -5,6 +5,7 @@
     "lib": [
       "es2021",
     ],
+    // "downlevelIteration": true,
     "rootDir": ".",
     "outDir": "../out-test",
     "sourceMap": true,

addons/addon-webgl/src/WebglRenderer.ts

@@ -427,8 +427,8 @@ export class WebglRenderer extends Disposable implements IRenderer {
     let line: IBufferLine;
     let joinedRanges: [number, number][];
     let isJoined: boolean;
-    let skipJoinedCheckUntilX: number;
-    let isValidJoinRange: boolean;
+    let skipJoinedCheckUntilX: number = 0;
+    let isValidJoinRange: boolean = true;
     let lastCharX: number;
     let range: [number, number];
     let isCursorRow: boolean;

addons/addon-webgl/src/tsconfig.json

@@ -25,6 +25,7 @@
       ]
     },
     "strict": true,
+    "downlevelIteration": true,
     "experimentalDecorators": true,
     "types": [
       "../../../node_modules/@types/mocha"

demo/client/components/window/addonImageWindow.ts

@@ -65,8 +65,7 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
     const dtIip = document.createElement('dt');
     dtIip.textContent = 'IIP (iTerm)';
     dlIip.appendChild(dtIip);
-    this._addDdWithButton(dlIip, 'image-demo3', 'palette (png File)');
-    this._addDdWithButton(dlIip, 'image-demo4', 'dice (qoi MultipartFile)');
+    this._addDdWithButton(dlIip, 'image-demo3', 'palette');
     container.appendChild(dlIip);
 
     // Kitty demos
@@ -142,21 +141,6 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
         this._terminal.write(`\x1b]1337;File=inline=1;size=${data.length}:${btoa(sdata)}\x1b\\`);
       });
 
-    const iipDemoMulti = (url: string) => () => fetch(url)
-      .then(resp => resp.arrayBuffer())
-      .then(buffer => {
-        const data = new Uint8Array(buffer);
-        let sdata = '';
-        for (let i = 0; i < data.length; ++i) sdata += String.fromCharCode(data[i]);
-        const encoded = btoa(sdata);
-        this._terminal.write('\r\n');
-        this._terminal.write(`\x1b]1337;MultipartFile=inline=1\x1b\\`);
-        for (let i = 0; i < encoded.length; i += 100) {
-          this._terminal.write(`\x1b]1337;FilePart=${encoded.slice(i, i + 100)}\x1b\\`);
-        }
-        this._terminal.write(`\x1b]1337;FileEnd\x1b\\`);
-      });
-
     const kittyDemo = (url: string) => () => fetch(url)
       .then(resp => resp.arrayBuffer())
       .then(buffer => {
@@ -174,8 +158,6 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
       sixelDemo('https://raw.githubusercontent.com/jerch/node-sixel/master/testfiles/test2.sixel'));
     document.getElementById('image-demo3')!.addEventListener('click',
       iipDemo('https://raw.githubusercontent.com/jerch/node-sixel/master/palette.png'));
-    document.getElementById('image-demo4')!.addEventListener('click',
-      iipDemoMulti('https://raw.githubusercontent.com/jerch/xterm-wasm-parts/master/fixtures/qoi/dice.qoi'));
     document.getElementById('image-demo-kitty1')!.addEventListener('click',
       kittyDemo('https://raw.githubusercontent.com/jerch/node-sixel/master/palette.png'));
 
@@ -194,7 +176,7 @@ export class AddonImageWindow extends BaseWindow implements IControlWindow {
       //   }
       // }
 
-      const pos = (this._terminal as any)._core._mouseCoordsService!.getCoords(ev, (this._terminal as any)._core.screenElement!, this._terminal.cols, this._terminal.rows);
+      const pos = (this._terminal as any)._core._mouseService!.getCoords(ev, (this._terminal as any)._core.screenElement!, this._terminal.cols, this._terminal.rows);
       const x = pos[0] - 1;
       const y = pos[1] - 1;
       const canvas = ev.shiftKey

demo/client/components/window/testWindow.ts

@@ -753,7 +753,7 @@ async function loadTestLongLines(term: Terminal, addons: AddonCollection): Promi
 
 function addDecoration(term: Terminal, dim: number = 1): void {
   term.options.scrollbar = { ...(term.options.scrollbar ?? {}), width: 14, overviewRuler: term.options.scrollbar?.overviewRuler ?? {} };
-  const marker = term.registerMarker(1);
+  const marker = term.registerMarker(1)!;
   const decoration = term.registerDecoration({
     marker,
     height: dim,
@@ -770,14 +770,14 @@ function addDecoration(term: Terminal, dim: number = 1): void {
 
 function addOverviewRuler(term: Terminal): void {
   term.options.scrollbar = { ...(term.options.scrollbar ?? {}), width: 14, overviewRuler: term.options.scrollbar?.overviewRuler ?? {} };
-  term.registerDecoration({ marker: term.registerMarker(1), overviewRulerOptions: { color: '#ef2929' } });
-  term.registerDecoration({ marker: term.registerMarker(3), overviewRulerOptions: { color: '#8ae234' } });
-  term.registerDecoration({ marker: term.registerMarker(5), overviewRulerOptions: { color: '#729fcf' } });
-  term.registerDecoration({ marker: term.registerMarker(7), overviewRulerOptions: { color: '#ef2929', position: 'left' } });
-  term.registerDecoration({ marker: term.registerMarker(7), overviewRulerOptions: { color: '#8ae234', position: 'center' } });
-  term.registerDecoration({ marker: term.registerMarker(7), overviewRulerOptions: { color: '#729fcf', position: 'right' } });
-  term.registerDecoration({ marker: term.registerMarker(10), overviewRulerOptions: { color: '#8ae234', position: 'center' } });
-  term.registerDecoration({ marker: term.registerMarker(10), overviewRulerOptions: { color: '#ffffff80', position: 'full' } });
+  term.registerDecoration({ marker: term.registerMarker(1)!, overviewRulerOptions: { color: '#ef2929' } });
+  term.registerDecoration({ marker: term.registerMarker(3)!, overviewRulerOptions: { color: '#8ae234' } });
+  term.registerDecoration({ marker: term.registerMarker(5)!, overviewRulerOptions: { color: '#729fcf' } });
+  term.registerDecoration({ marker: term.registerMarker(7)!, overviewRulerOptions: { color: '#ef2929', position: 'left' } });
+  term.registerDecoration({ marker: term.registerMarker(7)!, overviewRulerOptions: { color: '#8ae234', position: 'center' } });
+  term.registerDecoration({ marker: term.registerMarker(7)!, overviewRulerOptions: { color: '#729fcf', position: 'right' } });
+  term.registerDecoration({ marker: term.registerMarker(10)!, overviewRulerOptions: { color: '#8ae234', position: 'center' } });
+  term.registerDecoration({ marker: term.registerMarker(10)!, overviewRulerOptions: { color: '#ffffff80', position: 'full' } });
 }
 
 let decorationStressTestDecorations: IDisposable[] | undefined;
@@ -795,7 +795,7 @@ function decorationStressTest(term: Terminal): void {
       for (let y = 0; y < term.buffer.active.length; y++) {
         const cursorOffsetY = y - cursorY;
         const decoration = term.registerDecoration({
-          marker: term.registerMarker(cursorOffsetY),
+          marker: term.registerMarker(cursorOffsetY)!,
           x,
           width: 4,
           backgroundColor: '#FF0000',

demo/client/tsconfig.json

@@ -2,7 +2,6 @@
   "compilerOptions": {
     "module": "commonjs",
     "target": "es2021",
-    "types": ["node"],
     "outDir": "../out-demo/client",
     "rootDir": ".",
     "sourceMap": true,

demo/server/server.ts

@@ -118,7 +118,7 @@ function startServer(): void {
   });
 
   appWs.ws('/terminals/:pid', function (ws, req) {
-    const term = terminals[parseInt(Array.isArray(req.params.pid) ? req.params.pid[0] : req.params.pid)];
+    const term = terminals[parseInt(req.params.pid)];
     console.log('Connected to terminal ' + term.pid);
     temporaryDisposable[term.pid].dispose();
     delete temporaryDisposable[term.pid];

eslint.config.mjs

@@ -37,7 +37,7 @@ export default tseslint.config(
       '@stylistic/comma-spacing': ['warn', { before: false, after: true }],
       '@stylistic/indent': ['warn', 2],
       '@stylistic/semi': ['warn', 'always'],
-      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: 'always' }],
+      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: true }],
       '@stylistic/member-delimiter-style': ['warn', {
         multiline: { delimiter: 'semi', requireLast: true },
         singleline: { delimiter: 'comma', requireLast: false }

eslint.config.typings.mjs

@@ -17,7 +17,7 @@ export default tseslint.config(
     rules: {
       '@stylistic/indent': ['warn', 2],
       '@stylistic/semi': ['warn', 'always'],
-      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: 'always' }],
+      '@stylistic/quotes': ['warn', 'single', { allowTemplateLiterals: true }],
       '@stylistic/member-delimiter-style': ['warn', {
         multiline: { delimiter: 'semi', requireLast: true },
         singleline: { delimiter: 'comma', requireLast: false }