Commit Graph
100 Commits
Author SHA1 Message Date
Daniel Imms f03d00a497 Clean up buffer clean up/fill logic
The alt buffer is now cleared immediated after activating the normal buffer and
is filled when switching to it. The tests were failing because the alt buffer
wasn't being cleared properly with the previous solution.
2017-08-05 19:42:54 -07:00
Daniel Imms 3d20c2f266 Resize both buffers on resize
This brings in proper support to resize both buffers (#510) and fixes an
exception that was caused by wrongfully not clearing the normal buffer when
resizing while the alt buffer is active.

There was an obscure bug in this that could have caused some great confusion
later on; When switching to the alt buffer, a hard terminal reset was performed
which tried to retain the buffers. However, because buffers was initialized in
the Terminal constructor to a new BufferSet, the Terminal.buffer convenience
pointer was pointing at a stale alt buffer which was the one actually being
used, not Terminal.buffers.alt.

Fixes #842
Fixes #510
2017-08-05 18:59:44 -07:00
Daniel Imms 3479614c73 Disable selection override on Windows/Linux 2017-07-28 14:06:55 -07:00
Daniel Imms 6ea7758ab1 Add test for save and restore cursor 2017-07-27 16:35:48 -07:00
Daniel Imms 604959a319 Fix save and restore cursor behavior
This broke in #717.

Fixes #818
2017-07-27 16:28:27 -07:00
Daniel Imms e56f710cd1 Make SelectionManager more resilient
Fixes #809
2017-07-21 05:45:53 -07:00
Daniel Imms e3ded61122 Add null check when mouse coords are bad
This happens if the viewport is bad (which was fixed in another commit).

Fixes #801
2017-07-18 20:34:24 -07:00
Daniel Imms 59f75555bc Add IBuffer, IBufferSet and fix CircularList type 2017-07-16 03:47:15 +03:00
Daniel Imms adc657898c Remove bad getOption param 2017-07-13 09:23:56 -07:00
Daniel Imms 4c0e7b2462 Merge remote-tracking branch 'ups/master' into 553_find_api 2017-07-09 01:57:04 -07:00
Daniel Imms 73970ec5a2 Fix casing of search.js 2017-07-09 01:49:17 -07:00
Daniel Imms c62923fb1d Change case of browserify-addons files 2017-07-09 01:09:44 -07:00
Daniel Imms c13b86a885 Add find to demo 2017-07-09 01:03:10 -07:00
Daniel Imms 2564592c09 Change case of search addon files 2017-07-09 00:55:50 -07:00
Daniel Imms 4b0cf2ffce jsdoc 2017-07-09 00:43:31 -07:00
Daniel Imms fab039ddf3 Rearrange module loader to work with browserify 2017-07-09 00:26:33 -07:00
Daniel Imms 3c0e142f73 Fix sourcemaps 2017-07-08 23:53:16 -07:00
Daniel Imms 80f7a37118 Point to search addon properly 2017-07-08 23:13:41 -07:00
Daniel Imms 11de0d0ca0 Merge remote-tracking branch 'ups/master' into 553_find_api 2017-07-08 23:07:57 -07:00
Daniel Imms 5e815de82a Remove comments from Travis config 2017-07-08 19:13:43 -07:00
Daniel Imms 0536862b8f Try fix build 2017-07-08 17:47:54 -07:00
Daniel Imms b520e2fd35 Use standard naming for functions 2017-07-08 17:33:18 -07:00
Daniel Imms 740d4a45f9 Remove dependency on sleep module 2017-07-08 17:32:47 -07:00
Daniel Imms cb53cdd728 Merge remote-tracking branch 'ups/master' into 687_macos_ci 2017-07-08 17:19:47 -07:00
Daniel Imms 9b8cb03c55 Properly mark initial viewport lines as wrapped
Fixes #767
2017-07-07 11:18:18 -07:00
Daniel Imms 729f646a28 Use emit directly due to #766 2017-07-06 22:28:33 -07:00
Daniel Imms 85c892c218 Don't refresh terminal when scrollDisp doesn't scroll
Fixes #765
2017-07-06 21:16:20 -07:00
Daniel Imms 7f5e72dbdb Ensure scroll bar is refreshed after erase all in display
Fixes #760
2017-07-05 13:06:10 -07:00
Daniel Imms 3e8ddd1966 Add jsdoc 2017-07-03 21:43:52 -07:00
Daniel Imms 7463166aec Fix tests 2017-07-02 12:29:31 -07:00
Daniel Imms ca03f8928d Remove colon from the word separators
Fixes #745
2017-06-30 17:07:52 -07:00
Daniel Imms cfe22e6fd2 Use crlf when copying on Windows
Fixes #737
2017-06-29 07:38:41 -07:00
Daniel Imms 645a5920da Drop selection when the active buffer changes
Fixes #732
2017-06-27 10:13:16 -07:00
Daniel Imms 19381454ad Get find working as an addon 2017-06-22 19:36:53 -07:00
Daniel Imms 6854def13c Use case-insensitive search by default 2017-06-20 17:40:31 -07:00
Daniel Imms 63d63c27e7 Ensure outside selection pastes are respected
We were resetting the selection on every auxclick, meaning outside
selections could not be pasted in when the terminal had a current
selection.
2017-06-20 11:17:12 -07:00
Daniel Imms ef1e2ab9e2 Use auxclick event 2017-06-20 10:49:58 -07:00
Daniel Imms 7b46940772 Have Terminal.hasSelection return false when no selection
Fixes #724
2017-06-20 10:38:33 -07:00
Daniel Imms 6f5f68df1a Add a comment 2017-06-20 10:24:16 -07:00
Daniel Imms dc165175cf Handle middle click to paste selection
This appears to work in Chrome but not Firefox
2017-06-20 10:18:29 -07:00
Daniel Imms 32f1782c84 Fix context menu in firefox
Fixes #721
2017-06-20 10:01:39 -07:00
Daniel Imms 8811d96a8b Fix selection going to clipboard
Part of #699
2017-06-19 15:45:18 -07:00
Daniel Imms 6dbc476cdc Allow mouse events to pass through selection 2017-06-19 11:26:52 -07:00
Daniel Imms 57921e3fe0 Render selection on top of rows
Fixes #718
2017-06-19 11:18:55 -07:00
Daniel Imms 320fb55ddc Use an enum for selection mode 2017-06-18 12:56:32 -07:00
Daniel Imms 4b170ca43f Select to the word at the mouse after double click
Fixes #697
2017-06-18 12:52:43 -07:00
Daniel Imms b05814e6a5 Improve selection cell selection
Fixes #709
2017-06-18 12:02:58 -07:00
Daniel Imms 07882c42dc Also consider ' and " word separators
For example URIs in json
2017-06-18 11:51:00 -07:00
Daniel Imms 7f2e94c30c Don't select colon or brackets when double clicking
Fixes #713
2017-06-18 10:38:04 -07:00
Daniel Imms 528f06bc62 Remove log 2017-06-13 20:03:29 -07:00
Daniel Imms 5360277594 Merge remote-tracking branch 'origin/master' into 553_find_api 2017-06-13 19:57:52 -07:00
Daniel Imms b957130787 Consolidate translateBufferLineToString functions 2017-06-13 19:55:29 -07:00
Daniel Imms f88dcd160c Expose API on Terminal 2017-06-13 19:49:12 -07:00
Daniel Imms 7d8f698096 Add findPrevious 2017-06-13 19:43:18 -07:00
Daniel Imms d3f5a06517 Fix search scrolling up 2017-06-13 19:34:25 -07:00
Daniel Imms 280b698a50 More work on findNext 2017-06-12 21:59:46 -07:00
Daniel Imms 8d12881a1c Very basic find implementation
Part of #553
2017-06-12 16:27:13 -07:00
Daniel Imms 2a0f44b0fb Prevent mousedown event default selection behavior
Fixes #698
2017-06-12 14:51:58 -07:00
Daniel Imms 0950369a5c Merge remote-tracking branch 'origin/master' into set_row_height_explicitly 2017-06-10 10:21:20 -07:00
Daniel Imms 346b5177bc Retain wrapped line state when copying
Fixes #443
2017-06-09 17:12:00 -07:00
Daniel Imms 9246d524cb Use a single element for the middle of the selection
This reduces the number of DOM nodes used for the selection dramatically.
2017-06-09 16:35:26 -07:00
Daniel Imms 6480933861 Skip failing tests of macOS and add to CI
Fixes #687
2017-06-09 16:27:47 -07:00
Daniel Imms 6075498c24 Add class header comments 2017-06-09 12:47:16 -07:00
Daniel Imms ee1da73a69 Add regression test 2017-06-09 11:59:18 -07:00
Daniel Imms 29ac6a153e Fix issue with strings in wrapped spans being duplicated
This was happening because the linkifier assumed that top-level spans
in the terminal would only contain single text nodes

Fixes #642
2017-06-09 11:48:12 -07:00
Daniel Imms 28ed7772c6 Select last character in bottom right in select all 2017-06-07 14:44:16 -07:00
Daniel Imms a047359f81 Add more selection manager/model tests 2017-06-07 14:37:09 -07:00
Daniel Imms b81c165bea Add SelectionModel tests 2017-06-07 14:15:18 -07:00
Daniel Imms 4405f5e163 Fix clearSelection in select all mode 2017-06-07 13:48:12 -07:00
Daniel Imms 2012c8c91d Move prepareTextForClipboard logic into SelectionManager 2017-06-07 13:42:08 -07:00
Daniel Imms f719a4e91b Fix tests 2017-06-07 13:20:44 -07:00
Daniel Imms 5d33727ae4 Add clearSelection API 2017-06-07 13:07:34 -07:00
Daniel Imms 1343b83fc3 Add hasSelection public API 2017-06-07 12:40:48 -07:00
Daniel Imms 9e47ec9af2 Add getSelectionText API
This allows consumers to implement their own copy functionality/keybindings
2017-06-07 11:59:28 -07:00
Daniel Imms 9c459aacc7 Explicitly size selectionContainer to allow for more flexible layouts 2017-06-07 11:48:31 -07:00
Daniel Imms 72724abac8 Ensure host program handles copy if mouseevents are active 2017-06-07 11:20:03 -07:00
Daniel Imms 9a86eeb333 Support copying in the alt buffer 2017-06-07 11:10:05 -07:00
Daniel Imms 46f6fd18b0 Merge remote-tracking branch 'ups/master' into set_row_height_explicitly 2017-06-06 14:34:07 -07:00
Daniel Imms 603f22a7bb Set row height when char size is changed
When zoomed in line-height and actual rendered row height differs. This
can be seen in the viewport being too large when zoomed in right now
but also has additional impacts in the new selection model #207
2017-06-06 14:31:57 -07:00
Daniel Imms 13c401cbaa Only refresh the selection on an animation frame 2017-06-06 10:52:42 -07:00
Daniel Imms b812991072 Fix multiple drag scroll intervals being registered 2017-06-06 10:40:22 -07:00
Daniel Imms 2b2431824f Fix select all with no start and include content below viewport 2017-06-06 23:13:50 -07:00
Daniel Imms 7147787441 Undo CiruclarList id changes, fix null check, lint 2017-06-06 22:59:16 -07:00
Daniel Imms ec3bf1139d Resolve TODOs 2017-06-06 22:33:32 -07:00
Daniel Imms d0b603d033 jsdoc all of SelectionManager 2017-06-06 21:55:52 -07:00
Daniel Imms 2621be819e Resolve more TODOs, add jsdoc 2017-06-06 21:43:19 -07:00
Daniel Imms f380153f42 Resolve some TODOs 2017-06-06 21:29:30 -07:00
Daniel Imms fd91c5e1a8 Add _selectLineAt test 2017-06-06 15:22:35 -07:00
Daniel Imms f61d852f3c Don't allow double click selection on empty row going out of viewport 2017-06-06 15:05:22 -07:00
Daniel Imms 5bc1112151 Select lines when dragging a triple click 2017-06-06 15:02:52 -07:00
Daniel Imms 59cc0b675e Merge remote-tracking branch 'ups/master' into 207_selection_manager 2017-06-06 14:35:06 -07:00
Daniel Imms db8ded2a02 Implement shift+click 2017-06-06 14:19:12 -07:00
Daniel Imms d3865ad23f Add some SelectionManager selectWorkAt tests, fix lint 2017-06-01 17:36:47 -07:00
Daniel Imms 8b1067d180 Remove no longer valid clipboard test and add new one 2017-06-01 17:11:07 -07:00
Daniel Imms a53a0acd65 Fix issue with trimming whitespace 2017-06-01 17:04:59 -07:00
Daniel Imms 11cec31da6 Clean up wide char select word code 2017-05-25 21:12:44 -07:00
Daniel Imms d9991b25a4 Support wide char double click 2017-05-25 20:48:48 -07:00
Daniel Imms cb6533f3a6 Get double click selection for wide chars mostly working 2017-05-25 20:22:43 -07:00
Daniel Imms 54e7f65d4e Support selecting wide characters 2017-05-25 19:34:32 -07:00
Daniel Imms ec61f3acf0 Only trim the right whitespace from selection
Fixes #673
2017-05-25 18:52:06 -07:00