Daniel Imms
ef1cd4318b
Merge pull request #4688 from Tyriar/cursor_style
...
Simplify cursor style types in webgl
2023-08-19 04:51:15 -07:00
Daniel Imms
7b7dbd36d6
Merge pull request #4689 from Tyriar/4685
...
Track CursorBlinkStateManager in MutableDisposable
2023-08-18 14:38:05 -07:00
Daniel Imms
d03b5c9481
Track CursorBlinkStateManager in MutableDisposable
...
Fixes #4685
2023-08-18 14:26:56 -07:00
Daniel Imms
93e060aeb2
Add MutableDisposable tests
2023-08-18 14:24:50 -07:00
Daniel Imms
a84351ad0c
Add MutableDisposable
...
Part of #4685
2023-08-18 14:15:56 -07:00
Daniel Imms
25a78c77f2
Simplify cursor style types in webgl
...
Fixes #4686
2023-08-18 14:11:17 -07:00
Daniel Imms
a35fa611ff
Merge pull request #4687 from Tyriar/tracing
...
Add trace log level, @traceCall decorator and use in webgl
2023-08-18 11:14:52 -07:00
Daniel Imms
0b54c9a5d6
Add trace log level, traceCall decorator and use in webgl
...
- New 'trace' log level in the API, you should expect very spammy logs when
trace is on and filter them down. As opposed to 'debug' which should be more
readable.
- traceCall decorator logs the args and return value of the decorated method.
Wecan use this on key functions in various parts of the code to assist
debugging issues that are hard to reproduce such as #4665 .
- Decorated a few webgl render methods for #4665 .
- There's an early exit in traceCall when not on the trace log level so the
runtime impact when not in trace is negligable.
Part of #4665
2023-08-18 11:04:23 -07:00
Daniel Imms
3b3b23a2fd
Merge pull request #4683 from Tyriar/tyriar/minor_cleanup
...
Remove unneeded comments, headless options
2023-08-17 09:25:31 -07:00
Daniel Imms
7b874473d3
Remove unneeded comments, headless options
2023-08-17 09:10:38 -07:00
Daniel Imms
9d7b9293eb
Merge pull request #4681 from PerBothner/dom-selection
...
Fix bug in selection handling in dom renderer
2023-08-17 09:01:12 -07:00
Per Bothner
957e3e0f08
Fix bug in selection handling in dom renderer
2023-08-16 15:34:35 -07:00
Daniel Imms
2f0a7eee8d
Merge pull request #4679 from Tyriar/4663
...
Reduce repetition with internal terminal types and inherit docs from API
2023-08-15 08:49:40 -07:00
Daniel Imms
1a3e14a24c
Merge pull request #4680 from Tyriar/crash
...
Revert Stylesheet change
2023-08-15 08:49:05 -07:00
Daniel Imms
a6b67fb8a6
Remove unused headless types file
2023-08-15 08:39:20 -07:00
Daniel Imms
843bdc4d55
Revert "Merge pull request #4611 from SimonSiefke/constructed-stylesheets"
...
This reverts commit 5889344dd2 , reversing
changes made to 679c149164 .
2023-08-15 08:33:42 -07:00
Daniel Imms
2aee19f0e1
Revert "Workaround crash that can happen in Electron/Chromium"
...
This reverts commit 2ca0ccbe0c .
2023-08-15 08:31:34 -07:00
Daniel Imms
9f3be5e28d
Simplify terminal interfaces
...
Fixes #4663
2023-08-15 07:49:31 -07:00
Daniel Imms
f69f803f0f
Implement public APIs internally to inherit docs
...
Part of #4663
2023-08-15 07:46:51 -07:00
Daniel Imms
2eca26b210
Merge pull request #4678 from Tyriar/vscode189753
...
Workaround crash that can happen in Electron/Chromium
2023-08-15 07:01:28 -07:00
Daniel Imms
2ca0ccbe0c
Workaround crash that can happen in Electron/Chromium
...
Part of microsoft/vscode#189753
2023-08-15 06:46:35 -07:00
Daniel Imms
c908eeed5c
Merge pull request #4667 from Dennnnny/fix-transparent-foreground-color
...
Fix transparent foreground color
2023-08-14 12:11:04 -07:00
Daniel Imms
caa1223e5c
Merge pull request #4677 from Tyriar/fix_headless
...
Fix headless types regression
2023-08-14 07:18:50 -07:00
Daniel Imms
62cf3d39e1
Fix headless types regression
...
From the API lint PR
2023-08-14 07:15:20 -07:00
Daniel Imms
2437b68d5d
Merge pull request #4676 from Tyriar/4097_2
...
Remove redundant condition
2023-08-14 06:01:07 -07:00
Daniel Imms
09fc798e80
Remove redundant condition
...
Part of #4097
2023-08-14 05:47:25 -07:00
Daniel Imms
7ae6febedc
Merge pull request #4673 from Tyriar/4097
...
DOM: Render selection color instead of cell bg
2023-08-14 05:34:14 -07:00
Daniel Imms
39ae0f45fd
Fix selectionForeground dom tests
2023-08-14 04:43:55 -07:00
dennnnny
855e911398
Fix transparent foreground color
2023-08-14 09:49:18 +08:00
Daniel Imms
73a77cda3d
DOM: Render selection color instead of cell bg
...
Summary:
- Selection cell reuse has been added to the DOM renderer
- Selection bg override is now correctly set correctly
- Selection elements 'pretend' to be a decoration in order to render bg
Fixes #4097
2023-08-13 13:56:51 -07:00
Daniel Imms
6c9346011d
Merge pull request #4672 from Tyriar/4262
...
Enforce half minimum contrast ratio for dim text
2023-08-13 13:14:45 -07:00
Daniel Imms
28c4732abc
Fix ThemeService.ctor test
2023-08-13 13:04:40 -07:00
Daniel Imms
1cef30cca0
Enforce half minimum contrast ratio for dim text
...
Provided MCR is not too high, this ensures dim text differs from normal
text and has a reasonable difference in contrast.
Fixes #4262
2023-08-13 11:27:57 -07:00
Daniel Imms
af787e1c85
Merge pull request #4671 from Tyriar/4652
...
Fix SortedList.values iteration and general dec lifecycle fixes
2023-08-13 10:53:20 -07:00
Daniel Imms
70f6fa2bc9
Fix SortedList.values iteration and general dec lifecycle fixes
...
Fixes #4652
2023-08-13 10:42:45 -07:00
dennnnny
bef87403db
Fix force transparent foreground colors to be opaque
2023-08-13 17:52:49 +08:00
Daniel Imms
5890029f71
Merge pull request #4669 from Tyriar/api_lint
...
Lint API .d.ts files
2023-08-12 10:32:53 -07:00
Daniel Imms
1f4fe0a8c0
Lint API .d.ts files
...
Similar to #4668 , this brings linting to the API files with a cut down
set of rules. One of the bigger ones is comment length is restricted to 80,
this was done as opposed to 100 for regular code to reduce the chance of
wrapping or API going off screen regardless of resolution or window/browser
size
2023-08-12 09:33:35 -07:00
Daniel Imms
519f6a3d4a
Merge pull request #4668 from Tyriar/comment_lint
...
Restrict comments to 100 characters
2023-08-12 09:18:14 -07:00
Daniel Imms
530f758905
Restrict comments to 100 characters
...
This is a rule I try enforce in PR but it's a bit of a hassle, this will
give a lint warning when it happens resulting in:
- Yellow underline in supported editors when eslint is installed
- Compilation will succeed since it's a warning not an error
- CI will fail as it does not allow lint warnings
Special case comments are ignored which includes @vt comments, table
comments and commented out code.
2023-08-12 09:04:41 -07:00
dennnnny
fb7349bc87
Fix transparent foreground color
2023-08-12 08:39:39 +08:00
Daniel Imms
dc390ab03a
Merge pull request #4657 from tisilent/add-cursorInactiveStyle-option
...
Add cursorInactiveStyle option
2023-08-11 13:16:51 -07:00
Daniel Imms
6f6cc6a686
Remove string mapping, improve types, standardize on 'outline'
2023-08-11 13:09:31 -07:00
Daniel Imms
136e2f2afe
Improve API wording
2023-08-11 13:07:04 -07:00
Daniel Imms
73bb72dbcf
Merge pull request #4666 from Tyriar/nvm
...
Add nvmrc using node 16
2023-08-11 10:03:41 -07:00
Daniel Imms
4b2f774f53
Merge pull request #4664 from tisilent/fix-canvas-underline-cutoff
...
Fix canvas underline is cut off.
2023-08-11 10:01:28 -07:00
Daniel Imms
0a4151fbfa
Add nvmrc using node 16
...
node-pty doesn't seem to work 18 yet and VS Code has moved over to be based
on 18 so that's my main (don't ask me why it's working there but not in this
repo)
2023-08-11 09:52:15 -07:00
Daniel Imms
07d187151e
Update src/browser/renderer/shared/TextureAtlas.ts
2023-08-11 09:50:22 -07:00
Daniel Imms
47f606f0df
Merge pull request #4662 from Tyriar/inwasm
...
Add functional yarn wasm
2023-08-11 05:09:25 -07:00
Daniel Imms
18125dad84
Add functional yarn wasm
...
This is what I tried after seeing the error so it will improve the #4646
experience until a real fix is in place
Part of #4646
2023-08-11 04:58:07 -07:00