xterm.js

1,329 Commits 45 Branches 121 Tags

2 Commits

Author	SHA1	Message	Date
Michael Irwin	0cb8ecc6f7	Use boundingClientRect instead of style to get actual height PR #598	2017-03-15 09:06:56 -04:00
Michael Irwin	3c3a646d42	Fixed characterHeight calculation, which could cause overflowing The previous calculation was simply using the height of the letter W, but wasn't taking into account that each row has a lineHeight, which might be greater. If the lineHeight is .4px off, after many rows, it will cause the proposedGeometry to have an extra row, potentially causing hidden rows (based on layout).	2017-03-14 17:02:53 -04:00

Author

SHA1

Message

Date

Michael Irwin

0cb8ecc6f7

Use boundingClientRect instead of style to get actual height

PR #598

2017-03-15 09:06:56 -04:00

Michael Irwin

3c3a646d42

Fixed characterHeight calculation, which could cause overflowing

The previous calculation was simply using the height of the letter
W, but wasn't taking into account that each row has a lineHeight,
which might be greater. If the lineHeight is .4px off, after many
rows, it will cause the proposedGeometry to have an extra row,
potentially causing hidden rows (based on layout).

2017-03-14 17:02:53 -04:00