Commit Graph
7756 Commits
Author SHA1 Message Date
Daniel Imms 4cdf308c2f Merge pull request #3866 from Tyriar/vsc_152478
Fix clipping of non-powerline chars
2022-06-17 08:12:13 -07:00
Daniel Imms d24a27d93e Fix clipping of non-powerline chars
See microsoft/vscode#152478
2022-06-17 08:01:10 -07:00
Daniel Imms 55beec8b96 Merge pull request #3865 from mmis1000/fix/serialize-addon-test-typo
Fix a typo in serialize addon test
2022-06-16 14:16:06 -07:00
mmis1000 81dce7a4ba Fix typo in serialize addon test 2022-06-17 01:09:50 +08:00
Daniel Imms ddf3f08a6c Merge pull request #3862 from Tyriar/3861
Fix webgl clipping powerline y axis
2022-06-14 18:03:11 -07:00
Daniel Imms 8c6140c2e3 Merge pull request #3863 from Tyriar/3847
Fix webgl min contrast ratio api tests
2022-06-14 18:01:01 -07:00
Daniel Imms 1639c0a031 Fix webgl min contrast ratio api tests
Fixes #3847
2022-06-14 16:45:19 -07:00
Daniel Imms fb950fcbe5 Fix webgl clipping powerline y axis
Fixes #3861
2022-06-14 15:09:00 -07:00
Daniel Imms 1bb465d6b0 Merge pull request #3860 from Tyriar/3855
Fix column selection issues
2022-06-14 09:40:41 -07:00
Daniel Imms efb939d171 Fix column selection issues
The following parts were not respecting the column selection edge case where the
start column was greater than the end column while the start row was less than the
end row:

- Webgl renderer
- DOM renderer
- Selection service (ie. getSelection(), I don't think this was a
  regression)

Fixes #3855
2022-06-14 06:51:54 -07:00
Daniel Imms fe99422ca4 Merge pull request #3856 from Tyriar/custom_powerline_glyphs
Custom common powerline glyph rendering
2022-06-14 06:24:47 -07:00
Daniel Imms d28819de41 Add horizontal padding to powerline outline chars 2022-06-14 06:12:05 -07:00
Daniel Imms f8e9f1813a Custom common powerline glyph rendering
Fixes #3827
2022-06-11 16:15:04 -07:00
Daniel Imms 48b8e31794 Merge pull request #3852 from umaxyon/issue/3851-organize_demo_test_buttons
organize demo test buttons
2022-06-10 12:12:39 -07:00
Umaxyon 58b657bc3b organaize demo test buttons 2022-06-04 12:52:43 +09:00
Megan RoggeandDaniel Imms bc9c9dd6fd fix #3846 (#3849)
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2022-06-02 18:02:36 +00:00
Megan Rogge 6b16732192 exclude box and block glyphs from contrast ratio demands (#3844) 2022-06-01 17:05:27 -07:00
Daniel Imms 5aaa8dafc5 Merge pull request #3841 from Tyriar/3840
Allow up to double the size for overview ruler decorations
2022-05-27 12:03:21 -07:00
Daniel Imms 7a652c4169 Allow up to double the size for overview ruler decorations
Fixes #3840
2022-05-27 11:56:54 -07:00
Daniel Imms 1980f675f9 Merge pull request #3839 from Tyriar/3838
Support opaque selections in DOM renderer
2022-05-27 10:58:16 -07:00
Daniel Imms 98c40e3f8e Add opaque selection dom renderer tests 2022-05-27 10:46:23 -07:00
Daniel Imms 6ced3014cf Support opaque selections in DOM renderer
Brings the DOM renderer closer to the webgl renderer which draws the text
on top of the selection. This is done by leveraging the override system
similar to in webgl and as well as forcing the element above the selection.
This also improves contrast color caching for the DOM renderer.

This should result in a slight performance hit but only when a selection
is being made. The improved contrast seems worth it.

Fixes #3838
2022-05-27 10:38:32 -07:00
Daniel Imms 3e8aecaea3 Merge pull request #3837 from lp1dev/patch-1
Update of README to add hack.courses
2022-05-27 07:37:04 -07:00
Jérémie e3c008ba38 Update of README to add hack.courses
Update of README to add hack.courses as a project using xterm.js (https://hack.courses)
2022-05-27 15:52:40 +02:00
Daniel Imms d2083c5e8c Merge pull request #3835 from Tyriar/3834
Fix search when the search line contains a null character
2022-05-26 15:15:19 -07:00
Daniel Imms 0c0a34d888 Fix search when the search line contains a null character
Fixes #3834
2022-05-26 15:09:01 -07:00
Daniel Imms cd975d22cc Merge pull request #3831 from Tyriar/vscode148109
Test search event, fix returning -1 for no results
2022-05-26 11:58:47 -07:00
Daniel Imms b5f53b341d Test search event, fix returning -1 for no results
Fixes #3830
2022-05-26 11:37:54 -07:00
Daniel Imms 221db55680 Add find result count/index to demo
Part of #148109
2022-05-26 10:32:53 -07:00
Daniel Imms 5cc1114594 Merge pull request #3828 from Tyriar/powerlines
Add powerline symbol test button to demo
2022-05-25 06:35:51 -07:00
Daniel Imms 49872f9377 Merge pull request #3826 from Tyriar/vscode148061
Take padding into account when converting mouse coord to cell
2022-05-23 12:10:48 -07:00
Daniel Imms 1e17ba7a80 Add some NF icons 2022-05-23 12:08:28 -07:00
Daniel Imms 1c8b08d55c Add test button to print all powerline symbols
Part of #3807
2022-05-23 10:42:31 -07:00
Daniel Imms ca083f257c Pass window in to fix tests 2022-05-23 07:23:15 -07:00
Daniel Imms 8b53b8c255 Take padding into account when converting mouse coord to cell
Part of microsoft/vscode#148061
2022-05-23 06:49:52 -07:00
Daniel Imms ba078ca1f9 Merge pull request #3824 from Tyriar/toColor_standard
Standardize css.toColor output to #rrggbb[aa]
2022-05-20 12:48:16 -07:00
Daniel ImmsandMegan Rogge 4ededf5b06 Update src/common/Color.test.ts
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-20 12:35:51 -07:00
Daniel Imms 384cd9db30 Standardize css.toColor output to #rrggbb[aa]
This will help reduce the chance of runtime exceptions that would
break the render loop.
2022-05-20 11:06:19 -07:00
Daniel Imms 55b420b016 Merge pull request #3823 from Tyriar/3814_2
Correct rgba() parsing to use float alpha channel
2022-05-20 06:50:03 -07:00
Daniel Imms ddd43e0f09 Correct rgba() parsing to use float alpha channel
Fixes #3814
2022-05-20 06:34:17 -07:00
Daniel Imms 41fdb96b68 Merge pull request #3822 from Tyriar/3821
Deflake registerLinkProvider tests
2022-05-19 15:51:58 -07:00
Daniel ImmsandMegan Rogge e5fb255b79 Update package.json
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-19 15:51:31 -07:00
Daniel ImmsandMegan Rogge 7f14bfc7d9 Update package.json
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-19 15:51:28 -07:00
Daniel Imms 8f97a5a786 Deflake registerLinkProvider tests
The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.

Fixes #3821
2022-05-19 15:30:12 -07:00
Daniel Imms 5353808437 Update playwright 2022-05-19 15:26:52 -07:00
Daniel Imms 38f8bc5f3c Merge pull request #3820 from Tyriar/3818
Fix decoration positioning
2022-05-19 10:24:42 -07:00
Daniel Imms 48c21dc3ae Merge pull request #3819 from Tyriar/3814
Support rgb() and rgba() in css.toColor
2022-05-19 10:24:32 -07:00
Daniel Imms bcb71e854f Fix decoration positioning
In _createElement the element wasn't set on the decoration yet.

Fixes 3818
2022-05-19 09:32:57 -07:00
Daniel Imms e3c361327c Support rgb() and rgba()
This is used for default theme colors and decoration bg/fg.

Fixes #3814
2022-05-19 09:23:36 -07:00
Daniel Imms 51ef27894e Merge pull request #3815 from ChaseKnowlden/ChaseKnowlden/issue3814
Add #rgba format
2022-05-19 09:07:48 -07:00