Daniel Imms
2ca0ccbe0c
Workaround crash that can happen in Electron/Chromium
...
Part of microsoft/vscode#189753
2023-08-15 06:46:35 -07:00
Daniel Imms
c908eeed5c
Merge pull request #4667 from Dennnnny/fix-transparent-foreground-color
...
Fix transparent foreground color
2023-08-14 12:11:04 -07:00
Daniel Imms
caa1223e5c
Merge pull request #4677 from Tyriar/fix_headless
...
Fix headless types regression
2023-08-14 07:18:50 -07:00
Daniel Imms
62cf3d39e1
Fix headless types regression
...
From the API lint PR
2023-08-14 07:15:20 -07:00
Daniel Imms
2437b68d5d
Merge pull request #4676 from Tyriar/4097_2
...
Remove redundant condition
2023-08-14 06:01:07 -07:00
Daniel Imms
09fc798e80
Remove redundant condition
...
Part of #4097
2023-08-14 05:47:25 -07:00
Daniel Imms
7ae6febedc
Merge pull request #4673 from Tyriar/4097
...
DOM: Render selection color instead of cell bg
2023-08-14 05:34:14 -07:00
Daniel Imms
39ae0f45fd
Fix selectionForeground dom tests
2023-08-14 04:43:55 -07:00
dennnnny
855e911398
Fix transparent foreground color
2023-08-14 09:49:18 +08:00
Daniel Imms
73a77cda3d
DOM: Render selection color instead of cell bg
...
Summary:
- Selection cell reuse has been added to the DOM renderer
- Selection bg override is now correctly set correctly
- Selection elements 'pretend' to be a decoration in order to render bg
Fixes #4097
2023-08-13 13:56:51 -07:00
Daniel Imms
6c9346011d
Merge pull request #4672 from Tyriar/4262
...
Enforce half minimum contrast ratio for dim text
2023-08-13 13:14:45 -07:00
Daniel Imms
28c4732abc
Fix ThemeService.ctor test
2023-08-13 13:04:40 -07:00
Daniel Imms
1cef30cca0
Enforce half minimum contrast ratio for dim text
...
Provided MCR is not too high, this ensures dim text differs from normal
text and has a reasonable difference in contrast.
Fixes #4262
2023-08-13 11:27:57 -07:00
Daniel Imms
af787e1c85
Merge pull request #4671 from Tyriar/4652
...
Fix SortedList.values iteration and general dec lifecycle fixes
2023-08-13 10:53:20 -07:00
Daniel Imms
70f6fa2bc9
Fix SortedList.values iteration and general dec lifecycle fixes
...
Fixes #4652
2023-08-13 10:42:45 -07:00
dennnnny
bef87403db
Fix force transparent foreground colors to be opaque
2023-08-13 17:52:49 +08:00
Daniel Imms
5890029f71
Merge pull request #4669 from Tyriar/api_lint
...
Lint API .d.ts files
2023-08-12 10:32:53 -07:00
Daniel Imms
1f4fe0a8c0
Lint API .d.ts files
...
Similar to #4668 , this brings linting to the API files with a cut down
set of rules. One of the bigger ones is comment length is restricted to 80,
this was done as opposed to 100 for regular code to reduce the chance of
wrapping or API going off screen regardless of resolution or window/browser
size
2023-08-12 09:33:35 -07:00
Daniel Imms
519f6a3d4a
Merge pull request #4668 from Tyriar/comment_lint
...
Restrict comments to 100 characters
2023-08-12 09:18:14 -07:00
Daniel Imms
530f758905
Restrict comments to 100 characters
...
This is a rule I try enforce in PR but it's a bit of a hassle, this will
give a lint warning when it happens resulting in:
- Yellow underline in supported editors when eslint is installed
- Compilation will succeed since it's a warning not an error
- CI will fail as it does not allow lint warnings
Special case comments are ignored which includes @vt comments, table
comments and commented out code.
2023-08-12 09:04:41 -07:00
dennnnny
fb7349bc87
Fix transparent foreground color
2023-08-12 08:39:39 +08:00
Daniel Imms
dc390ab03a
Merge pull request #4657 from tisilent/add-cursorInactiveStyle-option
...
Add cursorInactiveStyle option
2023-08-11 13:16:51 -07:00
Daniel Imms
6f6cc6a686
Remove string mapping, improve types, standardize on 'outline'
2023-08-11 13:09:31 -07:00
Daniel Imms
136e2f2afe
Improve API wording
2023-08-11 13:07:04 -07:00
Daniel Imms
73bb72dbcf
Merge pull request #4666 from Tyriar/nvm
...
Add nvmrc using node 16
2023-08-11 10:03:41 -07:00
Daniel Imms
4b2f774f53
Merge pull request #4664 from tisilent/fix-canvas-underline-cutoff
...
Fix canvas underline is cut off.
2023-08-11 10:01:28 -07:00
Daniel Imms
0a4151fbfa
Add nvmrc using node 16
...
node-pty doesn't seem to work 18 yet and VS Code has moved over to be based
on 18 so that's my main (don't ask me why it's working there but not in this
repo)
2023-08-11 09:52:15 -07:00
Daniel Imms
07d187151e
Update src/browser/renderer/shared/TextureAtlas.ts
2023-08-11 09:50:22 -07:00
Daniel Imms
47f606f0df
Merge pull request #4662 from Tyriar/inwasm
...
Add functional yarn wasm
2023-08-11 05:09:25 -07:00
Daniel Imms
18125dad84
Add functional yarn wasm
...
This is what I tried after seeing the error so it will improve the #4646
experience until a real fix is in place
Part of #4646
2023-08-11 04:58:07 -07:00
tisilent
f317b96262
Fix canvas underline is cut off.
2023-08-11 17:58:29 +08:00
tisilent
c3d8c2a919
Update test and fix
2023-08-11 15:47:50 +08:00
tisilent
5c1e6dce99
Add block to cursorInactiveStyle,
...
change line to bar
2023-08-11 11:36:40 +08:00
tisilent
0321bcb715
Remove special classes.
...
Add xterm-cursor-outline class.
2023-08-11 09:40:06 +08:00
Daniel Imms
bb5d61fb14
Merge pull request #4659 from SvanT/dispose-blink-state-manager
...
Dispose blink state manager
2023-08-10 10:27:24 -07:00
Svante Boberg
3b3012353f
Use disposable registration
2023-08-10 19:04:20 +02:00
Svante Boberg
adad53d526
Dispose blink state manager
2023-08-10 18:47:04 +02:00
Daniel Imms
1b4460e37d
Merge pull request #4655 from Tyriar/tyriar/4645
...
Fix API facade memory leaks
2023-08-10 07:29:14 -07:00
tisilent
482dad3036
Add cursorInactiveStyle option
2023-08-10 16:11:04 +08:00
Daniel Imms
7276027861
Merge pull request #4651 from jerch/fix_4642
...
fix decorations on DOM renderer
2023-08-09 16:08:23 -07:00
Daniel Imms
62055522fb
Fix API facade memory leaks
...
We need to register/dispose any event created in the facades, otherwise
embedders need to dispose of the listeners manually.
Fixes #4645
2023-08-09 15:55:31 -07:00
jerch
0366aa2217
Merge branch 'master' into fix_4642
2023-08-10 00:24:03 +02:00
Jörg Breitbart
2b79b7b29f
faster SortedList._search
2023-08-10 00:12:00 +02:00
Daniel Imms
02243173c2
Merge pull request #4648 from tisilent/fix-double-underline
...
fix double underline, upwards
2023-08-09 06:45:03 -07:00
Jörg Breitbart
a84a95055d
exclude decorated cells from merging
2023-08-09 14:20:08 +02:00
tisilent
b8bf35be17
Add restrictToCellHeight,Restore abnormal format
2023-08-09 11:53:30 +08:00
tisilent
3ba579f680
fix double underline, upwards
2023-08-08 18:36:44 +08:00
Daniel Imms
4f41070b45
Merge pull request #4638 from Tyriar/4603
...
Fix reset and clear leaving viewport in a bad state
2023-08-02 11:55:14 -07:00
Daniel Imms
d2031955ec
Remove error from MockViewport.reset
2023-08-02 11:42:40 -07:00
Daniel Imms
91c08ed48e
Fix clear leaving viewport in a bad state
...
Fixes #4603
2023-08-02 11:30:43 -07:00