Commit Graph
64 Commits
Author SHA1 Message Date
Daniel Imms 4443ed69c7 Add noUnusedLocals tsconfig flag, fix issues
Two parts were commented out:
- _writeStopped: This is because _xoffSentToCatchUp references this variable
  and the feature is sort of half implemented/disabled.
- _clearChar: This is because some comments still reference this, it's part
  of the work needed to do better line redrawing.
2018-03-08 10:56:10 -08:00
Daniel Imms b20fe80f9b Merge pull request #1308 from bgw/rm-did-char-size-change
Remove didCharSizeChange logic from renderer
2018-03-08 05:10:53 -08:00
Bruno Ribeiro 34034b849f Merge branch 'master' into allow-named-theme-colors-1195 2018-03-05 23:22:12 +00:00
Benjamin Woodruff 18fb134910 Remove didCharSizeChange logic from renderer
The only thing `didCharSizeChange` was used for was to figure out if we
need to refresh the character atlas or not. However, `acquireCharAtlas`
already inspects the atlas owned by this terminal, and if it matches, it
avoids generating a new atlas.

So if `didCharSizeChange` is true and it's not needed, it quickly bails
out as a no-op. But if `didCharSizeChange` is false, and it was needed
(possible given the complexity of testing all of these edge cases), it
could introduce a bug.

I think it makes sense to just get rid of `didCharSizeChange`, and just
always call `acquireCharAtlas`.
2018-03-04 20:55:42 -08:00
Bruno Ribeito 1114977a21 Fix tests 2018-02-21 23:35:37 +00:00
Daniel Griffen 183fd2fe79 fix terminal width calculation 2018-02-16 10:18:03 -08:00
Daniel Imms f089b997c0 Merge branch 'master' into 731_screen_reader 2018-02-14 09:03:31 -08:00
Thomas Zilz dc759a93bc Support setting padding on the .xterm element (#1208)
* Support padding on the .xterm element
2018-02-06 12:31:17 +01:00
Daniel Imms 106704b5d8 Merge remote-tracking branch 'ups/master' into pr/1148 2018-01-28 13:39:07 -08:00
Daniel Imms ec156f62e1 Only update a11y manager dimensions after a renderer resize 2018-01-27 18:38:28 -08:00
Daniel Imms b9976c3d17 Merge remote-tracking branch 'origin/master' into 731_screen_reader 2018-01-26 10:24:09 -08:00
Daniel Imms 2e23dd34e0 Move xterm-internal types back into Types.ts files 2018-01-25 11:06:52 -08:00
Daniel Imms 177edfa66e Merge interfaces and types files 2018-01-25 10:03:28 -08:00
Daniel Imms 067acd8803 Merge branch 'master' into pr/1148 2018-01-23 08:33:55 -08:00
Daniel Imms e4abd4dd8a Move Shared interfaces into a new typings file
This will enable sharing the internal interface with addons (and catching
breakages early)
2018-01-19 09:48:33 -08:00
Daniel Imms 1e9fb8696a Merge remote-tracking branch 'origin/master' into 731_screen_reader 2018-01-16 09:56:19 -08:00
Daniel Imms 80f13792a3 Ensure renderer uses latest options at open
Fixes #1194
2018-01-16 06:34:22 -08:00
Daniel Imms bbc9a010b9 Listen to dpr change in a11y manager 2018-01-11 09:27:37 -08:00
Daniel Imms c46304c716 Merge remote-tracking branch 'origin/master' into 731_screen_reader 2018-01-05 14:28:08 -08:00
Daniel Imms f6da87f3b4 Merge remote-tracking branch 'origin/master' into 1118_dpi_change 2018-01-05 14:19:21 -08:00
Daniel Imms b66578a4ca Merge branch 'master' into 880_renderer_pause 2018-01-05 11:00:11 -08:00
Daniel Imms b0b6c8d878 Merge branch 'master' into transparency 2018-01-05 10:58:59 -08:00
Daniel Imms e20d2caa0e Use consistent refresh/render method names 2018-01-05 08:19:30 -08:00
Daniel Imms a846e8c08d Pull render animation frame logic into a helper class 2018-01-05 08:15:21 -08:00
Daniel Imms bb830eb1ae Rate limit row refresh, tweak live region 2018-01-05 07:39:45 -08:00
Daniel Imms 72d946e089 Use a more robust solution to changing devicePixelRatio 2017-12-29 13:54:01 -08:00
Thomas Zilz b4e52b2334 Fix fit() sizing and also support letterSpacing, enhanced (#1157)
Fixes #1081

* Make sure character dimensions are available right after calling term.open()
* Do not assume var assignments are global anymore, webpack will isolate them
* Use DocumentFragment to build Viewport and helpers before attaching them to the DOM
* Shield term.focus call from crashing when used before term.open
2017-12-20 20:06:23 +01:00
CHaBou 9c5aaed441 Fix some function parameters 2017-12-15 00:02:37 +01:00
CHaBou 9f85790ad1 Add allowTransparency option
Fixes #1004
2017-12-14 22:55:01 +01:00
Daniel Imms 47a50acc55 Use IntersectionObserver to turn off renderer when hidden
Fixes #880
2017-12-11 15:16:13 -08:00
Daniel Imms eb57cc3e9e Clip rows using the row's cell height, not char height 2017-10-09 20:10:13 -07:00
Daniel Imms 1b2bac7aef Add letterSpacing option
This provides an option for fonts to be more spaced out. This is particularly useful
for fonts that can seem crammed due to not allowing floating point numbers when
drawing, such as Monoid or Operator Mono.
2017-10-09 20:07:30 -07:00
Daniel Imms a8174398f5 Calculate mouse coordinates using correct char dimensions
Previously the Mouse class was using raw CSS pixels, we need CSS pixels based
on the amount of space the cells take up on the canvas

See Microsoft/vscode#35114
2017-09-28 17:23:45 -04:00
Daniel Imms aca7ab63e8 Set background color on Renderer immediately
Prevents black flash on init
2017-09-14 00:22:57 -07:00
Daniel Imms 3656617044 Start merging fg/bg layers, draw using SP-AA 2017-09-13 15:21:40 -07:00
Daniel Imms 5538481833 Draw characters to a grid 2017-09-13 15:07:01 -07:00
Daniel Imms 403fd3cd4f Draw text using decimal numbers
Fixes #972
2017-09-12 18:55:59 -07:00
Daniel Imms ae741348a6 Fix several issues with line height
Fixes #966
Fixes #967
2017-09-10 10:31:19 -07:00
Daniel Imms 75b91c618e Update license text 2017-09-08 10:16:42 -07:00
Daniel Imms ea8dbbd29f Underline links on hover 2017-09-07 10:20:48 -07:00
Daniel Imms b69ff5d31a Redraw terminal when devicePixelRatio changes 2017-09-06 10:22:33 -07:00
Daniel Imms 46b0857ef6 Resolve TODOs 2017-09-04 14:13:41 -07:00
Daniel Imms 1f38c2f467 Remove unused file 2017-09-04 09:53:53 -07:00
Daniel Imms 36778186e1 Fix tests 2017-09-03 14:34:50 -07:00
Daniel Imms 2d1a1bfb76 Fix inconsistency with lineHeight 2017-09-03 09:05:26 -07:00
Daniel Imms deb47e29bf Fix canvas resizing with non-1 lineHeight 2017-09-03 07:41:18 -07:00
Daniel Imms 5a4851630e Prevent updating of invalid terminal row ranges 2017-09-03 07:27:52 -07:00
Daniel Imms 4f81cdfe8c Make the terminal background theme aware 2017-09-02 13:59:22 -07:00
Daniel Imms c92a2f964a Support lineHeight 2017-09-02 12:27:09 -07:00
Daniel Imms cf7237d2a4 Fix remaining cursor animation state issues 2017-09-01 23:47:17 -07:00