Daniel Imms
171ba446bd
Update other files
2022-10-15 15:32:02 -07:00
Daniel Imms
2c9e711cae
Move all other refs in webgl over
2022-10-15 13:55:36 -07:00
Daniel Imms
b0f1c38fd2
Move all other refs in canvas over
2022-10-15 13:44:52 -07:00
Daniel Imms
b393008b54
Use new render dimensions in canvasrenderer
2022-10-15 13:19:04 -07:00
Daniel Imms
65f41a151e
Use new render dimensions in webglrenderer
2022-10-15 13:15:12 -07:00
Daniel Imms
ddc4e75583
Add new dimensions properties, helper creation function
...
Part of #3925
2022-10-15 10:31:43 -07:00
Daniel Imms
16ea621a5f
Merge pull request #4206 from Tyriar/eslint-jsdoc
...
Add eslint-plugin-jsdoc with minimal comment rules
2022-10-15 08:55:07 -07:00
Daniel Imms
5204374494
Add no-multi-asterisks rule
2022-10-15 08:43:06 -07:00
Daniel Imms
9f1a71485c
Fix invalid jsdoc tags
2022-10-15 08:41:49 -07:00
Daniel Imms
49e0480f78
Add rule jsdoc/check-alignment
2022-10-15 08:39:32 -07:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
fb4a4e6127
Draw quads with triangle strip
...
This reduces the number of needed vertices from 6 to 4, it may not have a
noticeable performance impact but it's less data and simpler
2022-10-15 07:54:31 -07:00
Daniel Imms
a37ea14d10
Use options service in renderers
2022-10-09 10:57:49 -07:00
Simon Lamon
f8a5d3a91e
Fallback to default_ansi_colors when running headless terminal
2022-10-09 17:16:06 +00:00
Daniel Imms
8d7137417b
Split renderer safe vs unsafe api on activate
2022-10-09 10:12:19 -07:00
Daniel Imms
e47296c1b9
Use options service directly in renderers
2022-10-09 09:28:18 -07:00
Simon Lamon
1c345bef48
Handle onWillFire if it fails, so it loads dom renderer
2022-10-09 15:01:15 +00:00
Simon Lamon
627410a537
Add broken demo to investigate
2022-10-09 14:26:08 +00:00
Simon Lamon
bd661fdb07
Fix demo again
2022-10-09 11:29:33 +00:00
Daniel Imms
0ba12301a6
Merge pull request #4188 from Tyriar/4184
...
Create theme service
2022-10-08 15:51:44 -07:00
Daniel Imms
97e084aa50
Remove document from test
2022-10-08 15:44:21 -07:00
Daniel Imms
e0fb3b4d19
Remove ColorManager
2022-10-08 15:23:29 -07:00
Daniel Imms
a1050d1a11
Merge ColorManager into ThemeService
2022-10-08 15:20:15 -07:00
Daniel Imms
48f15cb543
Remove remaining setColors methods
2022-10-08 14:07:28 -07:00
Daniel Imms
6e35bcd767
Use theme service in more places
2022-10-08 13:55:23 -07:00
Daniel Imms
4f5154fd21
Ensure stale bitmap is not used when drawing new characters
...
This would cause a problem where the first time a glyph is used it would
not be visible because it was using the old invalidated bitmap.
2022-10-08 11:56:29 -07:00
Daniel Imms
cc6def57e4
Use readonly color set in canvas addon
2022-10-08 11:46:41 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
5d8e4a0af4
Add lint rule to ensure _on prefix is only for event emitters
2022-10-08 11:05:52 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
f61d8c91a3
Properly register disposables in SearchAddon
2022-10-08 08:30:39 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms
34475f24c3
Release canvas texture atlas
2022-10-08 08:11:28 -07:00
Daniel Imms
8116e035b4
Register webgl renderers
2022-10-08 08:06:43 -07:00
Daniel Imms
56b37a73ac
Free WebglAddon
2022-10-08 07:37:55 -07:00
Daniel Imms
fc8043a25a
Ensure webgl texture atlas is released on dispose
2022-10-08 07:32:51 -07:00
Daniel Imms
f88c0e7480
Polish emitter registering in canvas renderer
...
Part of #4167
2022-10-08 07:24:35 -07:00
Daniel Imms
d948b31304
Merge pull request #4181 from Tyriar/clear_race
...
Fix race condition that could when clearing atlas on 2+ terminals
2022-10-07 16:34:27 -07:00
Daniel Imms
8e7093f03b
Remove the canvas char atlas
...
This was unused and removing from cache was broken apparently
2022-10-07 16:20:01 -07:00
Daniel Imms and Megan Rogge
c4eef2f470
Fix race condition that could when clearing atlas on 2+ terminals
...
This is the proper fix for microsoft/vscode#162996 , after a bunch of
investigation we found that this is causing the problem:
VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.
Co-Authored-By: Megan Rogge <merogge@microsoft.com >
2022-10-07 16:17:11 -07:00
Daniel Imms
5fcb084089
Merge pull request #4180 from Tyriar/clear_atlas
...
Fix clearTextureAtlas call as implemented on IRenderer
2022-10-07 14:31:28 -07:00
Daniel Imms
e89c507d06
Fix clearTextureAtlas call as implemented on IRenderer
...
This is the root cause of microsoft/vscode#162996
2022-10-07 14:22:51 -07:00
Daniel Imms
ffa4d921bb
Merge remote-tracking branch 'upstream/master' into renderer_before_open
2022-10-07 10:10:24 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd1f8e6f0952
2022-10-06 09:48:54 -07:00
Daniel Imms
e0324e32a8
Bring back ImageBitmap optimization in canvas renderer
...
It's more simple than it used to be, it will clear and debounce all
glyphs when any change is made.
2022-10-04 15:24:10 -07:00
Daniel Imms
3b260a2193
Fix resolved todo
2022-10-04 14:46:00 -07:00
Daniel Imms
622acaaad7
Remove old selection start/end values
2022-10-04 14:45:19 -07:00
Daniel Imms
0d7e18d236
Add CellColorResolver to share load color code
2022-10-04 14:41:27 -07:00
Daniel Imms
83c09c34db
Share selection render model code
2022-10-04 14:23:09 -07:00
Daniel Imms
Simon Lamon
