Fix ansi bright text being bold without bold flag

Fixes #1047
2017-10-10 22:37:13 -07:00
parent 058de25977
commit a56edd65a7
1 changed files with 4 additions and 1 deletions
@@ -234,7 +234,10 @@ export abstract class BaseRenderLayer implements IRenderLayer {
      }
    }
    const isAscii = code < 256;
-    const isBasicColor = (colorIndex > 1 && fg < 16);
+    // A color is basic if it is one of the standard normal or bold weight
+    // colors of the characters held in the char atlas. Note that this excludes
+    // the normal weight light color characters
+    const isBasicColor = (colorIndex > 1 && fg < 16) && (fg < 8 || bold);
    const isDefaultColor = fg >= 256;
    const isDefaultBackground = bg >= 256;
    if (this._charAtlas && isAscii && (isBasicColor || isDefaultColor) && isDefaultBackground) {