Nicola Murino e3e62d9601 ssh: fix spinloop in channel SendRequest drain on closed channel ...

The drain loop added in 3c7c869 ("ssh: fix deadlock on unexpected
channel responses") receives from ch.msg without checking the comma-ok
flag. Once ch.msg is closed by channel.close(), receives succeed
immediately with the zero value, so the default arm is never taken
and the loop spins forever, pinning a CPU core for every concurrent
SendRequest caller on a torn-down channel.

Use the comma-ok idiom to detect the closed channel and break out.

Fixes golang/go#79658

Change-Id: Id80aa5d8429550c7a68e8759aed9ffba3aabb006
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/783680
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Neal Patel <neal@golang.org>
Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
Reviewed-by: Neal Patel <nealpatel@google.com>

2026-05-28 10:16:26 -07:00

..

agent

ssh/agent: support parallel signing using request pipelining

2026-05-21 19:39:50 -07:00

internal/bcrypt_pbkdf

ssh: support encrypted OpenSSH private keys

2020-02-04 10:40:54 +00:00

knownhosts

ssh/knownhosts: respect @revoked CA keys

2026-05-21 10:58:49 -07:00

terminal

ssh/terminal: replace with a golang.org/x/term wrapper

2020-11-16 15:36:03 +00:00

test

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

testdata

ssh: fix error message on unsupported cipher

2025-11-12 10:42:48 -08:00

benchmark_test.go

ssh: fix call to Fatalf from a non-test goroutine

2023-07-31 18:14:41 +00:00

buffer_test.go

go.crypto/ssh: import gosshnew.

2014-04-09 13:57:52 -07:00

buffer.go

ssh: remove unused buffer.eof return value

2017-09-25 11:19:01 +00:00

certs_test.go

ssh: enforce user presence verification for security keys

2026-05-21 17:03:20 -07:00

certs.go

ssh: enforce user presence verification for security keys

2026-05-21 17:03:20 -07:00

channel_test.go

ssh: fix infinite loop on large channel writes due to integer overflow

2026-05-21 17:03:23 -07:00

channel.go

ssh: fix spinloop in channel SendRequest drain on closed channel

2026-05-28 10:16:26 -07:00

cipher_test.go

ssh: expose negotiated algorithms

2025-05-15 10:44:04 -07:00

cipher.go

ssh: fix incorrect operator order

2026-05-21 17:03:25 -07:00

client_auth_test.go

ssh: add AuthCallback to ClientConfig

2026-05-21 19:36:57 -07:00

client_auth.go

ssh: add AuthCallback to ClientConfig

2026-05-21 19:36:57 -07:00

client_test.go

ssh: export supported algorithms

2025-05-15 10:43:30 -07:00

client.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

common_test.go

ssh: return clearer error when signature algorithm is used as key format

2025-09-15 23:32:56 -07:00

common.go

ssh: add support for FIPS mode

2025-09-27 12:36:52 -07:00

connection.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

control_test.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

control.go

ssh: add openssh controlmaster socket support

2026-05-21 19:39:36 -07:00

doc.go

ssh: add support for FIPS mode

2025-09-27 12:36:52 -07:00

example_test.go

all: fix some typos in comment

2025-10-08 13:58:26 -07:00

handshake_test.go

all: fix some typos in comment

2025-10-08 13:58:26 -07:00

handshake.go

ssh: remove custom contains, use slices.Contains

2025-09-15 23:33:16 -07:00

kex_test.go

ssh: add diffie-hellman-group16-sha512 kex

2023-07-31 17:46:52 +00:00

kex.go

ssh: add support for FIPS mode

2025-09-27 12:36:52 -07:00

keys_test.go

ssh: enforce user presence verification for security keys

2026-05-21 17:03:20 -07:00

keys.go

ssh: enforce user presence verification for security keys

2026-05-21 17:03:20 -07:00

mac.go

ssh: add support for FIPS mode

2025-09-27 12:36:52 -07:00

mempipe_test.go

ssh: defer channel window adjustment

2023-11-27 17:27:49 +00:00

messages_test.go

ssh: use reflect.TypeFor instead of reflect.TypeOf

2025-10-09 11:10:29 -07:00

messages.go

ssh: use reflect.TypeFor instead of reflect.TypeOf

2025-10-09 11:10:29 -07:00

mlkem.go

ssh: remove Go 1.24 build tag for ML-KEM kex

2025-08-26 00:42:33 -07:00

mux_test.go

ssh: fix spinloop in channel SendRequest drain on closed channel

2026-05-28 10:16:26 -07:00

mux.go

ssh: fix deadlock on unexpected global responses

2026-05-21 17:02:53 -07:00

server_multi_auth_test.go

ssh: add server side multi-step authentication

2024-04-03 07:40:24 +00:00

server_test.go

ssh: cap total userauth attempts per server connection

2026-05-27 09:40:09 -07:00

server.go

ssh: cap total userauth attempts per server connection

2026-05-27 09:40:09 -07:00

session_test.go

ssh: prevent malformed exit-status panic

2026-05-25 19:49:21 -07:00

session.go

ssh: prevent malformed exit-status panic

2026-05-25 19:49:21 -07:00

ssh_gss_test.go

ssh: curb GSSAPI DoS risk by limiting number of specified OIDs

2025-11-19 11:28:37 -08:00

ssh_gss.go

ssh: curb GSSAPI DoS risk by limiting number of specified OIDs

2025-11-19 11:28:37 -08:00

streamlocal.go

ssh: allow to bind to a hostname in remote forwarding

2025-11-12 10:42:45 -08:00

tcpip_test.go

ssh: add (*Client).DialContext method

2023-11-27 15:35:52 +00:00

tcpip.go

ssh: allow to bind to a hostname in remote forwarding

2025-11-12 10:42:45 -08:00

testdata_test.go

ssh: don't advertise rsa-sha2 algorithms if we can't use them

2022-03-14 23:46:59 +00:00

transport_test.go

ssh: fix protocol version exchange (for multi-line)

2018-01-11 10:11:23 +00:00

transport.go

ssh: add support for FIPS mode

2025-09-27 12:36:52 -07:00