2 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Reinaldo de Souza Jr	6318898455	crypto/openpgp: return error from userIdSignatureHash ... Signature#SignUserId was ignoring the error returned by userIdSignatureHash. This error can happen, for example, when the Signature's Hash property is uninitialized. Not returning the error makes it hard for the user to detect the problem. Change-Id: I0ae0033e77bfb1ea1c06b0769f949e48c713adc6 Reviewed-on: https://go-review.googlesource.com/27997 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2016-09-08 19:28:14 +00:00
Reinaldo de Souza Jr	aedad9a179	otr: Fix revealing MAC keys when a DH key is rotated ... The existing implementation did not save all the fields in keySlot, which not only caused a cache miss on every calcDataKeys() but also caused the rotate keys functions to not find the MAC keys that should be revealed. It also stops revealing the sending MAC keys. The finite-state analysis of the otr v2 spec[1] revealed an attack on message integrity when sending MAC keys are revealed. The spec had been updated accordingly [2]. 1 - http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.165.7945&rep=rep1&type=pdf 2 - http://sourceforge.net/p/otr/libotr/ci/58fd90cb77c836ff9fa762e91d2b2becc6d5aae8/ Change-Id: Iee36205994ebdb27d8c890ae25fd9981326401df Reviewed-on: https://go-review.googlesource.com/12781 Reviewed-by: Adam Langley <agl@golang.org>	2015-08-30 18:06:42 +00:00