eiac/crypto
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
207 Commits 11 Branches 57 Tags
2dfe547928fdf792f2d4b626eeab4490419ca5f4
Commit Graph
207 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Adam Langley 2dfe547928 go.crypto/ssh: use permissions from public key cache when accepting a key. 
Fixes golang/go#7913.

LGTM=hanwen
R=hanwen
CC=golang-codereviews
https://golang.org/cl/96220043
 2014-05-12 11:19:56 -07:00
Han-Wen Nienhuys 6f0540ef5e go.crypto/ssh: try authentication methods in ClientConfig order. 
LGTM=jpsugar, agl
R=agl, jpsugar
CC=golang-codereviews
https://golang.org/cl/92240045
 2014-05-12 11:16:49 -07:00
Mikio Hara f8eacb97ce go.crypto/ssh/test: enable test cases on dragonfly 
LGTM=agl
R=golang-codereviews, agl
CC=golang-codereviews
https://golang.org/cl/98840043
 2014-05-05 12:10:24 -07:00
Mikio Hara b71337fce2 go.crypto/ssh/terminal: add support for BSD variants 
LGTM=agl
R=golang-codereviews, agl
CC=golang-codereviews
https://golang.org/cl/97850043
 2014-05-05 12:07:22 -07:00
Dmitry Chestnykh c261757620 go.crypto/blowfish: no need for key in initCipher 
LGTM=robert.hencke
R=golang-codereviews, robert.hencke
CC=golang-codereviews
https://golang.org/cl/84860043
 2014-05-05 11:42:21 -07:00
Adam Langley aa3adaf1aa go.crypto/openpgp: check for revoked keys. 
R=agl
CC=golang-codereviews
https://golang.org/cl/95050043
 2014-05-05 11:41:50 -07:00
David Calavera df2851958a ssh/forward: Fix reference to the functions to call to route authentication requests. 
R=agl
CC=golang-codereviews, hanwen
https://golang.org/cl/95910043
 2014-05-02 10:55:29 -07:00
Han-Wen Nienhuys 7c7765c32f go.crypto/ssh/agent: add key type to testAgentInterface failure messages. 
R=agl, dave, jpsugar
CC=golang-codereviews
https://golang.org/cl/88260043
 2014-04-15 13:48:43 -07:00
Han-Wen Nienhuys 15264ff7c7 go.crypto/ssh/agent: prefix errors with "agent". 
R=agl, dave, jpsugar
CC=golang-codereviews
https://golang.org/cl/87810047
 2014-04-15 13:42:07 -07:00
Han-Wen Nienhuys dac81c328b go.crypto/ssh: fix messages_test.go on 32-bit platforms. 
LGTM=dave
R=agl, dave
CC=golang-codereviews
https://golang.org/cl/88060043
 2014-04-15 09:09:03 -07:00
Yan Zou e1b0d6c49f go.crypto/ssh: Add support for the pre-2006 RC4 cipher mode. 
LGTM=hanwen
R=agl, hanwen
CC=golang-codereviews
https://golang.org/cl/86600044
 2014-04-14 10:43:20 -07:00
Han-Wen Nienhuys 058f0eec52 go.crypto/ssh: only offset channel IDs when debugMux is 
set.

Otherwise, the package leaks data about total number of
connections established through its channel IDs.

R=agl, jpsugar
CC=golang-codereviews
https://golang.org/cl/87280043
 2014-04-14 09:23:18 -07:00
David du Colombier 7e43632730 go.crypto/ssh: build test_unix_test on Plan 9 
LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://golang.org/cl/86630043
 2014-04-12 22:07:48 +02:00
Adam Langley 43c4f8a896 go.crypto/ssh: remove old files. 
In c0fc595a2cb5, hg didn't notice the files that had been removed from
the working directory. These, old files are breaking the build.

CC=golang-codereviews
https://golang.org/cl/86240043
 2014-04-09 14:37:07 -07:00
Adam Langley fa50e7408b go.crypto/ssh: import gosshnew. 
See https://groups.google.com/d/msg/Golang-nuts/AoVxQ4bB5XQ/i8kpMxdbVlEJ

R=hanwen
CC=golang-codereviews
https://golang.org/cl/86190043
 2014-04-09 13:57:52 -07:00
Adam Langley 8f45c680ce go.crypto/blowfish: allow shorter passwords. 
bcrypt didn't allow one, two and three letter passwords which is a
policy decision best left to the user of the code. Some users have
legacy issues which require such short passwords to be processed.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/81800044
 2014-03-31 13:41:02 -04:00
David du Colombier a2c10b4975 go.crypto/ssh: build tests on Plan 9 
LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://golang.org/cl/64390044
 2014-02-19 20:51:49 +01:00
Péter Szilágyi f82d56354e go.crypto/hkdf: implement hash-based, key derivation. 
Detailed description in RFC 5869.

LGTM=agl
R=agl, minux.ma
CC=golang-codereviews
https://golang.org/cl/7474049
 2014-02-12 14:08:25 -05:00
Brad Fitzpatrick 63a71ca82d undo CL 51690043 / abf8f8812575 
Breaks FreeBSD build of subrepo for non-tip users.

««« original CL description
go.crypto/ssh/terminal: enable freebsd build

syscall.Termios, which was the only thing breaking the build, is
available in go tip now
(https://code.google.com/p/go/source/detail?r=873d664b00ec)

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/51690043

»»»

R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/51100044
 2014-01-13 15:00:50 -08:00
Michael Gehring ef64186525 go.crypto/ssh/terminal: enable freebsd build 
syscall.Termios, which was the only thing breaking the build, is
available in go tip now
(https://code.google.com/p/go/source/detail?r=873d664b00ec)

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/51690043
 2014-01-13 14:35:19 -08:00
Rob Pike 9717de930f .hgignore: add comment setting policy 
R=golang-codereviews, rsc
CC=golang-codereviews
https://golang.org/cl/44830043
 2013-12-20 16:30:29 -08:00
Russ Cox 08da9c60bc codereview: switch defaultcc to golang-codereviews 
See this thread for background:
https://groups.google.com/forum/#!topic/golang-dev/xG7vPi21r8g

R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/44120046
 2013-12-20 10:57:29 -05:00
Jakob Borg 4758fe8ce4 go.crypto/ssh: Increase window size. 
Increase window size for channels (session and tcpip) to 64 *
max packet size (32 KB), which is the same value that OpenSSH
uses. Also breaks out the relevant harcoded constants into named
constants in channel.go.

Fixes golang/go#6675.

R=golang-dev, dave, hanwen, agl
CC=golang-dev
https://golang.org/cl/18120043
 2013-11-01 04:24:39 +11:00
Han-Wen Nienhuys 577ae2abf9 go.crypto/ssh: cosmetic: unnest signing code for public key auth. 
R=dave
CC=golang-dev
https://golang.org/cl/15930044
 2013-10-26 03:25:59 +11:00
Han-Wen Nienhuys 34df1ce598 go.crypto/ssh: in {Server,Client}Conn, read session ID from 
transport layer.

R=agl, dave
CC=golang-dev
https://golang.org/cl/15870044
 2013-10-25 11:15:34 -04:00
Dave Cheney c0d640c887 go.crypto/ssh: ensure {Server,Client}Conn do not expose io.ReadWriter 
Transport should not be a ReadWriter. It can only write packets, i.e. no partial reads or writes. Furthermore, you can currently do ClientConn.Write() while the connection is live, which sends raw bytes over the connection. Doing so will confuse the transports because the data is not encrypted.

As a consequence, ClientConn and ServerConn stop being a net.Conn

Finally, ensure that {Server,Client}Conn implement LocalAddr and RemoteAddr methods that previously were exposed by an embedded net.Conn field.

R=hanwen
CC=golang-dev
https://golang.org/cl/16610043
 2013-10-25 06:29:58 +11:00
Han-Wen Nienhuys 105632d35b go.crypto/ssh: only close connection if it was open in TestClientUnsupportedKex. 
R=dave
CC=golang-dev
https://golang.org/cl/15450046
 2013-10-24 04:12:59 +11:00
Jonathan Pittman 94779a0cf1 go.crypto/ssh: Implement CertTime to properly handle the "infinite" time 
value ^0, which would become negative when expressed as int64.

R=agl, dave, jpsugar, hanwen
CC=golang-dev
https://golang.org/cl/15520047
 2013-10-23 12:44:23 -04:00
Dave Cheney 0b167df1b4 go.crypto/ssh: additional coverage of message unmarshaling 
R=golang-dev, hanwen
CC=golang-dev
https://golang.org/cl/14767043
 2013-10-23 08:45:49 +11:00
Jonathan Pittman 9112f50fcd go.crypto/ssh: Add certificate verification, step up support for authorized keys 
R=agl, hanwen, jpsugar, dave
CC=golang-dev
https://golang.org/cl/14540051
 2013-10-22 15:12:41 -04:00
Han-Wen Nienhuys f5f25bdad0 go.crypto/ssh: put version exchange in function 
R=golang-dev, dave, jpsugar, agl
CC=golang-dev
https://golang.org/cl/14641044
 2013-10-17 08:54:15 +11:00
Han-Wen Nienhuys ed40a6cc35 go.crypto/ssh: move channelForwardMsg declaration. 
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/14669046
 2013-10-16 14:24:28 +11:00
Han-Wen Nienhuys 49702c17cc go.crypto/ssh: (un)marshal data without type byte prefix. 
This helps manipulating data in global and channel request
payloads.

R=agl, dave, jpsugar
CC=golang-dev
https://golang.org/cl/14438068
 2013-10-15 16:18:32 +11:00
Han-Wen Nienhuys 4a7557f2bd go.crypto/ssh: add String method to RejectionReason. 
R=agl, dave
CC=golang-dev
https://golang.org/cl/14494055
 2013-10-14 16:13:09 -04:00
Han-Wen Nienhuys 7dc9a79b3e go.crypto/ssh: implement memTransport using sync.Cond. 
This makes memTransport safe for use with multiple
writers/closers.

R=golang-dev, dave
CC=agl, golang-dev
https://golang.org/cl/14532048
 2013-10-13 08:34:25 +11:00
Jonathan Pittman 44256fa2df go.crypto/ssh: cosmetic only spelling fixes 
R=agl, hanwen
CC=dave, golang-dev, jpsugar
https://golang.org/cl/14430055
 2013-10-10 11:35:15 -04:00
Adam Langley 7bb6c099c0 go.crypto/openpgp: support v3 detached signatures. 
Although the package doesn't attempt to fully support ancient, version
3 messages, supporting v3 detached signatures is fairly easy and some
projects (in this case, Ubuntu) are using them for unknown reasons.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14590043
 2013-10-09 17:24:09 -04:00
JP Sugarbroad 15d8abf5c4 go.crypto/ssh: fix certificate parsing/marshaling. 
The change to add the PublicKey interface accidentally caused certificate handling to expect an extra copy of the private key algorithm name in the binary representation. This change adapts a suitable parsing API and adds a test to ensure that cert handling isn't easily broken in the future.

R=agl, hanwen, jmpittman
CC=golang-dev
https://golang.org/cl/13272055
 2013-10-09 12:56:09 -04:00
Han-Wen Nienhuys 4147256c9c go.crypto/ssh: move interpretation of msgNewKeys into 
transport.

Sending the msgNewKeys packet and setting up the key material
now happen under a lock, preventing races with concurrent
writers.

R=kardianos, agl, jpsugar, hanwenn
CC=golang-dev
https://golang.org/cl/14476043
 2013-10-08 15:47:04 -04:00
Han-Wen Nienhuys 41400feb0b go.crypto/ssh: let client accept DSA and ECDSA host key algorithms. 
R=agl, dave, jpsugar, m4dh4tt3r, agl
CC=golang-dev
https://golang.org/cl/14420045
 2013-10-07 18:30:34 -04:00
Frithjof Schulze 153ce2a1d2 go.crypto/ssh/terminal: Allow ^A and ^E as synonyms for Home and End. 
I understand that ssh/terminal can't implement everybodys
favorite keyboard shortcuts, but I think these are very
widespread. They exist not only in Emacs or Readline, but also
in Acme and Sam. Also they almost come for free.

R=golang-dev
CC=agl, golang-dev
https://golang.org/cl/13839047
 2013-09-30 16:06:07 -04:00
Han-Wen Nienhuys 4e0581245c go.crypto/ssh: parse DSA private keys too. 
R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/13966043
 2013-09-26 11:17:52 -04:00
Han-Wen Nienhuys 73e99326fb go.crypto/ssh: separate kex algorithms into kexAlgorithm class. 
Adds readPacket() to conn, and renames conn to packetConn.
Key exchanges operate on packetConn, so they can be
unittested.

R=agl, jpsugar, dave
CC=golang-dev
https://golang.org/cl/13352055
 2013-09-24 12:26:29 -04:00
Frithjof Schulze a3c6050446 go.crypto/otr: Reset Conversation.myKeyId for each AKE. 
This shouldn't be necessary according to the OTRv2 spec,
but is expected by at least one other client.

CC=golang-dev
https://golang.org/cl/13823043
 2013-09-22 15:38:36 -04:00
Han-Wen Nienhuys 934c14ffe9 go.crypto/ssh: introduce Signer method, an abstraction of 
private keys.

R=agl, jpsugar, jonathan.mark.pittman
CC=golang-dev
https://golang.org/cl/13338044
 2013-09-19 14:45:31 -04:00
Adam Langley 28dc961a18 go.crypto/ssh/terminal: fix non-ASCII history. 
The length of history buffer entries (which are stored as strings) was
being used as the number of runes. This was correct until ff9ce887b46b,
which allowed unicode entry, but can now cause a panic when editing
history that contains non-ASCII codepoints.

R=golang-dev, sfrithjof, r
CC=golang-dev
https://golang.org/cl/13255050
 2013-09-15 12:48:02 -04:00
Adam Langley cb60f353cb go.crypto/ssh/terminal: support Unicode entry. 
Previously, terminal only supported ASCII characters. This change
alters some []byte to []rune so that the full range of Unicode is
supported. The only thing that doesn't appear to work correctly are
grapheme clusters as the code still assumes one rune per glyph. Still,
this change allows many more languages to work than did previously.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13704043
 2013-09-13 14:33:00 -04:00
Han-Wen Nienhuys e62b2aead4 go.crypto/ssh: introduce PublicKey interface type. 
Public functions affected:
-AgentKey.Key
-AgentClient.SignRequest
-ClientKeyring.Key
-MarshalPublicKey
-ParsePublicKey

R=agl, jpsugar, jmpittman
CC=golang-dev
https://golang.org/cl/13642043
 2013-09-13 14:25:14 -04:00
Jonathan Pittman 6a743c56c7 go.crypto/ssh: Begin adding server side support for more than RSA for client key auth 
R=agl, dave, hanwen
CC=ekg, golang-dev
https://golang.org/cl/13528044
 2013-09-09 13:06:04 -04:00
Han-Wen Nienhuys f17d130281 go.crypto/ssh: remove misleading marshalPrivRSA. 
Properly capitalize publicKey throughout.

R=golang-dev
CC=agl, dave, golang-dev, jpsugar
https://golang.org/cl/13415046
 2013-09-05 11:36:51 -04:00