mirror of
https://github.com/github/awesome-copilot.git
synced 2026-10-12 23:04:14 +00:00
* Add submission-gate check, merge-risk tiers, and PR status state machine (#4184) Phase 2 (enforcement) of github/awesome-copilot#4184: - submission-gate aggregate required check (reader) with infra vs contribution failure classification - merge-risk:low/medium/high classification from .github/risk-tiers.yml with tier approval policy - Submission Gate Writer maintaining state labels and a persistent status comment - /rerun-checks and /request-review PR commands - validate-skills and validate-submission-gate workflows, unit tests, and maintainer docs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell findings and add spelling to submission gate checks Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Harden submission gate per review feedback - Publish the submission-gate check from the trusted writer via the Checks API and flag any other submission-gate check run as tampering - Fail closed on truncated file lists, unscannable diffs, permission lookup errors, and skipped required checks - Discard evaluations when the PR head or reviews change mid-run - Low tier requires a resource owner approval - Commands must start the comment, matching the workflow filter Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Address #4190 review: command reader/writer, pools, paths, staleness - Split /rerun-checks and /request-review into a read-only issue_comment reader and a workflow_run writer that re-reads the comment, PR, and permission before writing. - Drop the workflow-security pool; agentic workflows and hooks are content (medium unless they add scripts or hook commands); the core pool is core-maintainers. - Include each check's workflow file and eng scripts in its paths. - Discard evaluations when the base branch or risk labels change; run the gate on PR edits (retargeting). - Correct copies of the writer's check that claim success while the evaluation fails. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on lost contributor signal; publish gate check before labels - A contributor check whose pr-check job succeeded but whose result artifact is missing or unreadable is now an infrastructure failure, so a lost HIGH signal can't lower the approval tier. - Publish the submission-gate check right after stale-state revalidation; label and comment sync are independent and reported afterwards. - Revert the self-path added to validate-agentic-workflows-pr.yml's trigger: that workflow rejects any .github change. Exempt it in the drift test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fail closed on bad routing config; advisory checks never hold the gate - loadGateConfig: a missing review-routing.yml still falls back, but a file that can't be parsed (or whose pools isn't a mapping) now throws instead of silently relaxing approvals. - Pending required: false checks no longer keep the PR in awaiting-automation or the gate check in progress, and the polling loop doesn't wait on them. They render as pending (advisory). - PR commands: 👀 marks a command as claimed; 🚀 is written only after the reply is posted and is the only replay guard, so a run that failed partway can be retried. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix codespell: unparseable -> unparsable Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
156 lines
6.1 KiB
YAML
156 lines
6.1 KiB
YAML
name: Submission Gate Writer
|
|
|
|
# Trusted writer for the submission gate. Recomputes the PR evaluation from the GitHub
|
|
# API with code from the default branch (never from the PR), then publishes the
|
|
# required `submission-gate` check run on the PR head commit and applies exactly one
|
|
# merge-risk:* label, one state label, and the persistent status comment.
|
|
# See docs/maintainers/submission-gate.md.
|
|
|
|
on:
|
|
workflow_run:
|
|
workflows: ["Submission Gate"]
|
|
types: [requested, completed]
|
|
schedule:
|
|
# Safety net: re-runs started with GITHUB_TOKEN and review events do not always
|
|
# produce workflow_run events, so refresh recently updated open PRs hourly.
|
|
- cron: "23 * * * *"
|
|
workflow_dispatch:
|
|
inputs:
|
|
pr_number:
|
|
description: "PR number to refresh (leave empty to sweep recently updated open PRs)"
|
|
required: false
|
|
type: string
|
|
|
|
permissions:
|
|
actions: read
|
|
checks: write
|
|
contents: read
|
|
issues: write
|
|
pull-requests: write
|
|
|
|
concurrency:
|
|
group: submission-gate-writer-${{ github.event.workflow_run.head_repository.id || 'repo' }}-${{ github.event.workflow_run.head_branch || inputs.pr_number || github.event_name }}
|
|
cancel-in-progress: ${{ github.event_name == 'workflow_run' }}
|
|
|
|
jobs:
|
|
sync-status:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
if: >-
|
|
github.event_name != 'workflow_run' ||
|
|
github.event.workflow_run.event == 'pull_request' ||
|
|
(github.event.workflow_run.event == 'pull_request_review' && github.event.action == 'completed')
|
|
steps:
|
|
- name: Checkout default branch
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
|
with:
|
|
persist-credentials: false
|
|
sparse-checkout: |
|
|
.github
|
|
eng
|
|
package.json
|
|
package-lock.json
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
|
|
with:
|
|
node-version: "22"
|
|
cache: "npm"
|
|
|
|
- name: Install dependencies
|
|
run: npm ci --ignore-scripts
|
|
|
|
- name: Sync PR status
|
|
uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0
|
|
env:
|
|
GH_TOKEN: ${{ github.token }}
|
|
PR_NUMBER: ${{ inputs.pr_number }}
|
|
SWEEP_LIMIT: "60"
|
|
SWEEP_MAX_AGE_DAYS: "30"
|
|
with:
|
|
script: |
|
|
const path = require('path');
|
|
const { pathToFileURL } = require('url');
|
|
|
|
const root = process.env.GITHUB_WORKSPACE;
|
|
const gate = await import(pathToFileURL(path.join(root, 'eng', 'submission-gate.mjs')).href);
|
|
const config = gate.loadGateConfig(root);
|
|
const { owner, repo } = context.repo;
|
|
const targets = [];
|
|
|
|
if (context.eventName === 'workflow_run') {
|
|
const workflowRun = context.payload.workflow_run;
|
|
const action = context.payload.action;
|
|
if (action === 'completed' && ['cancelled', 'skipped'].includes(workflowRun.conclusion)) {
|
|
core.info(`Gate run ${workflowRun.id} was ${workflowRun.conclusion}; a newer run supersedes it.`);
|
|
return;
|
|
}
|
|
const pullNumber = await gate.resolvePullRequestForWorkflowRun(github, { owner, repo, workflowRun });
|
|
if (!pullNumber) {
|
|
core.info(`No open PR matches gate run ${workflowRun.id} at ${workflowRun.head_sha}; it is stale or closed.`);
|
|
return;
|
|
}
|
|
targets.push({
|
|
pullNumber,
|
|
finalized: action === 'completed',
|
|
gateRunUrl: workflowRun.html_url,
|
|
expectedHeadSha: workflowRun.head_sha,
|
|
});
|
|
} else if (process.env.PR_NUMBER) {
|
|
const pullNumber = Number(process.env.PR_NUMBER);
|
|
if (!Number.isInteger(pullNumber) || pullNumber < 1) {
|
|
core.setFailed(`Invalid pr_number input: ${process.env.PR_NUMBER}`);
|
|
return;
|
|
}
|
|
targets.push({ pullNumber, finalized: 'auto' });
|
|
} else {
|
|
const limit = Number(process.env.SWEEP_LIMIT);
|
|
const cutoff = Date.now() - Number(process.env.SWEEP_MAX_AGE_DAYS) * 24 * 60 * 60 * 1000;
|
|
const open = await github.paginate(github.rest.pulls.list, {
|
|
owner,
|
|
repo,
|
|
state: 'open',
|
|
base: 'main',
|
|
sort: 'updated',
|
|
direction: 'desc',
|
|
per_page: 100,
|
|
});
|
|
for (const pr of open) {
|
|
if (targets.length >= limit || new Date(pr.updated_at).getTime() < cutoff) break;
|
|
targets.push({ pullNumber: pr.number, finalized: 'auto' });
|
|
}
|
|
}
|
|
|
|
let failures = 0;
|
|
for (const target of targets) {
|
|
try {
|
|
const evaluation = await gate.evaluateSubmission(github, {
|
|
owner,
|
|
repo,
|
|
pullNumber: target.pullNumber,
|
|
config,
|
|
finalized: target.finalized,
|
|
expectedHeadSha: target.expectedHeadSha || null,
|
|
token: process.env.GH_TOKEN,
|
|
log: (message) => core.info(message),
|
|
});
|
|
// A stale evaluation describes an older commit; the run for the new head reports.
|
|
if (evaluation.stale || evaluation.pr.state !== 'open') continue;
|
|
const gateRunUrl = target.gateRunUrl || evaluation.gateRun?.html_url || null;
|
|
await gate.syncPullRequestStatus(github, {
|
|
owner,
|
|
repo,
|
|
evaluation,
|
|
gateRunUrl,
|
|
publishCheck: true,
|
|
log: (message) => core.info(message),
|
|
});
|
|
} catch (error) {
|
|
failures += 1;
|
|
core.warning(`Could not sync PR #${target.pullNumber}: ${error.message}`);
|
|
}
|
|
}
|
|
if (failures > 0 && failures === targets.length) {
|
|
core.setFailed(`Failed to sync ${failures} PR(s).`);
|
|
}
|