mirror of
https://github.com/github/awesome-copilot.git
synced 2026-06-13 19:34:54 +00:00
React to accepted rerun intake comments (#1948)
* React to rerun intake comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * some whitespace fixes * more whitespace fixes --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -100,6 +100,13 @@ jobs:
|
||||
return;
|
||||
}
|
||||
|
||||
await github.rest.reactions.createForIssueComment({
|
||||
owner: context.repo.owner,
|
||||
repo: context.repo.repo,
|
||||
comment_id: context.payload.comment.id,
|
||||
content: 'eyes'
|
||||
});
|
||||
|
||||
const baseResult = await intake.evaluateExternalPluginIssue({
|
||||
issue: currentIssue,
|
||||
token: process.env.GITHUB_TOKEN,
|
||||
|
||||
+1
-1
@@ -235,7 +235,7 @@ The public-submission policy builds on those rules and also requires `license` p
|
||||
- install smoke test via Copilot CLI against an ephemeral marketplace entry generated from the submission
|
||||
4. **Ready for maintainer review**: if metadata validation and quality gates pass, automation removes `awaiting-review` and adds `ready-for-review`.
|
||||
5. **Submitter-fix blocker**: if metadata is valid but quality gates fail, automation applies `requires-submitter-fixes` instead of advancing to human review.
|
||||
6. **Requesting another intake pass**: after updating the issue body or source plugin, the issue author or a maintainer can comment `/rerun-intake` to re-run automated intake and quality gates on demand. Open issues still re-trigger intake automatically on edit, but closed rejected issues need `/rerun-intake`.
|
||||
6. **Requesting another intake pass**: after updating the issue body or source plugin, the issue author or a maintainer can comment `/rerun-intake` to re-run automated intake and quality gates on demand. Open issues still re-trigger intake automatically on edit, but closed rejected issues need `/rerun-intake`. When the rerun is accepted, automation reacts to the command comment with 👀 so it is visible that processing started.
|
||||
7. **Maintainer override path**: a maintainer with write access can comment `/mark-ready-for-review [optional reason]` to explicitly move a `requires-submitter-fixes` issue to `ready-for-review`.
|
||||
8. **Maintainer decision**: once in `ready-for-review`, a maintainer with write access performs the manual review, then comments `/approve` or `/reject <reason>` on the issue. Commands from non-maintainers are ignored.
|
||||
9. **Approval path**: on `/approve`, automation removes `ready-for-review`, adds `approved`, closes the issue, and opens or updates a PR against `staged` that updates `plugins/external.json` and generated marketplace outputs.
|
||||
|
||||
@@ -460,8 +460,10 @@ function buildMergedIntakeComment(baseResult, qualityResult, runId, owner, repo)
|
||||
"",
|
||||
qualitySection,
|
||||
"",
|
||||
"",
|
||||
"### Canonical external.json payload",
|
||||
"",
|
||||
"",
|
||||
"```json",
|
||||
JSON.stringify(baseResult.plugin ?? {}, null, 2),
|
||||
"```",
|
||||
@@ -546,12 +548,15 @@ export async function evaluateExternalPluginIssue({ issue, token, runId, owner,
|
||||
parsed.plugin.source.sha ? `- **SHA:** ${parsed.plugin.source.sha}` : undefined,
|
||||
`- **Keywords:** ${normalizedKeywords}`,
|
||||
"",
|
||||
"",
|
||||
"### Canonical external.json payload",
|
||||
"",
|
||||
"",
|
||||
payload,
|
||||
"",
|
||||
"### Reviewer notes",
|
||||
"",
|
||||
"",
|
||||
notes,
|
||||
dedupedWarnings.length > 0
|
||||
? ["", "### Warnings", "", ...dedupedWarnings.map((warning) => `- ${warning}`)].join("\n")
|
||||
|
||||
Reference in New Issue
Block a user