Commit Graph
1142 Commits
Author SHA1 Message Date
Daniel Imms eb57cc3e9e Clip rows using the row's cell height, not char height 2017-10-09 20:10:13 -07:00
Daniel Imms 1b2bac7aef Add letterSpacing option
This provides an option for fonts to be more spaced out. This is particularly useful
for fonts that can seem crammed due to not allowing floating point numbers when
drawing, such as Monoid or Operator Mono.
2017-10-09 20:07:30 -07:00
Daniel Imms b06eb44c45 Merge pull request #1034 from Tyriar/1033_ie11_support
Add support back for IE11
2017-10-06 09:27:15 -07:00
Daniel Imms 5bf81934cd Merge pull request #1022 from Tyriar/1020_mouse_events_linkifier
Ensure linkifier cancels mouse event when being handled
2017-10-06 09:23:42 -07:00
Daniel Imms 635cf268d4 Merge pull request #1019 from Tyriar/null_check_cursor_char
Add null check before cursor is drawn
2017-10-06 09:23:17 -07:00
Daniel Imms 3c2614ade7 Merge pull request #1017 from Tyriar/1015_fix_emoji_selection
Fix several issues related to emojis
2017-10-06 09:23:03 -07:00
Daniel Imms 06b9f1db87 Always draw entire line and allow overlapping
State/diffing code is kept in comments as it may be reinstated soon.

Fixes #1035
Fixes #1036
Fixes #1032
Fixes #1037
2017-10-05 23:25:03 -07:00
Daniel Imms 356a14bb16 Fix non-default backgrounds on left cell of wide/overlapping chars
Fixes #1031
2017-10-05 20:30:09 -07:00
Daniel Imms be8ddb11db Add support back for IE11
Fixes #1033
2017-10-05 20:22:05 -07:00
Daniel Imms 108534a4fe Fix null pointer exception 2017-10-05 20:09:17 -07:00
Daniel Imms 0a08d6389a Fix sub-pixel anti-aliasing for uncached text
Fixes #1032
2017-10-05 19:31:07 -07:00
Daniel Imms 2ab06779f9 Merge pull request #1026 from Tyriar/1025_fix_link_application_range
Fix links sometimes not getting applied
2017-10-05 08:04:36 -07:00
Jakob Gillich 7cfc108fb4 remove import file extension 2017-10-05 01:35:34 +02:00
Daniel Imms 2a126cf1dc Fix links sometimes not getting applied
There was an incorrect comparison which occasionally caused links to
not be picked up.

Fixes #1025
2017-10-04 11:45:13 -07:00
Daniel Imms 56da538ca0 Fix reference to document 2017-10-02 11:12:33 -07:00
Daniel Imms 42d5cb671e Merge remote-tracking branch 'ups/v3' into v3 2017-10-02 11:00:24 -07:00
Daniel Imms 95f68a41d7 Ensure linkifier cancels mouse event when being handled
The terminal mouse events handling code was being run before links were
being considered. This caused clicking link to have unexpected behavior
in mouse mode term apps.

Fixes #1020
2017-10-02 10:42:14 -07:00
Daniel Imms 29be4f6a92 Merge remote-tracking branch 'ups/v3' into 1015_fix_emoji_selection 2017-10-01 05:54:10 -07:00
Daniel Imms b1214063d2 Add more complex emoji selection tests 2017-09-30 10:00:18 -04:00
Daniel Imms da4e3e6e9f Improve documentation on word selection 2017-09-30 09:45:11 -04:00
Daniel Imms e0c28bc7d2 Fix selecting words containing ZWJ emojis 2017-09-30 09:32:33 -04:00
Daniel Imms 58259f8bd9 Fix select word on wide characters 2017-09-30 08:30:19 -04:00
Daniel Imms 4828c4a6fa Clean up logs/comments 2017-09-30 08:02:03 -04:00
Daniel Imms 3e29a03f87 Fix rendering issues for emojis that come out as wide chars
The fix is to disallow non-single cell width chars to be overlapping
2017-09-30 07:54:52 -04:00
Daniel Imms fa86f31f36 Fix copying emoji characters on the edge of selection
Fixes #1015
2017-09-30 06:30:14 -04:00
Daniel Imms feb2b958a4 Mostly emoji selection
Selection is not aware of characters that have a size greater than 1.

When the emoji is at the start of the selection it still doesn't work.

Fixes #1015
2017-09-30 06:13:58 -04:00
Daniel Imms e3d69d78a0 Merge pull request #1010 from Tyriar/vscode34466
Add null check when fetching line string
2017-09-30 05:37:11 -04:00
Daniel Imms ef5e393510 Merge pull request #1002 from Tyriar/990_fix_link_issues
Fix link clearing issues
2017-09-30 05:36:48 -04:00
Daniel Imms 91d22e3d84 Add null check before cursor is drawn 2017-09-28 21:23:27 -04:00
Daniel Imms a8174398f5 Calculate mouse coordinates using correct char dimensions
Previously the Mouse class was using raw CSS pixels, we need CSS pixels based
on the amount of space the cells take up on the canvas

See Microsoft/vscode#35114
2017-09-28 17:23:45 -04:00
Daniel Imms 0dafd0a38b Merge branch 'v3' into 1000_fix_horz_offset 2017-09-28 17:21:37 -04:00
Daniel Imms 13d46476c8 Add null check when fetching line string
See Microsoft/vscode#34466
2017-09-28 14:52:56 -04:00
Daniel Imms 313d1e6fec Merge pull request #1005 from Tyriar/fix_validation_callback
Fix validation callback to use the uri, not whole row
2017-09-25 13:24:45 -07:00
Daniel Imms a4485b8c09 Merge pull request #999 from Tyriar/vscode34493
Only refresh char atlas when char dimensions are valid
2017-09-25 06:14:58 -07:00
Daniel Imms a2389d5c5b Fix validation callback to use the uri, not whole row 2017-09-24 10:59:38 -07:00
Daniel Imms 8243eef67c Properly clear links
MouzeZoneManager rows are not 0-based

Fixes #990
2017-09-20 12:54:20 +09:00
Daniel Imms 0b54df14e2 Remove unnecessary rounding 2017-09-20 12:16:27 +09:00
Daniel Imms 79c07d436e Fix selection horizontal offset
Fixes #1000
2017-09-20 11:53:19 +09:00
Daniel Imms 40fdd00b9e Correct if statement, ensure charAtlas exists 2017-09-20 09:02:21 +09:00
Thomas Zilz c4da8325ac Allow all overflowing characters to extend to the next cell if followed by a space (Emojis etc) (#997)
* Measure characters and thread them if they are overlapping

* Fix whitespace

* Use charData and ctx.save/restore, code cleanup

* Fix trailing whitespace
2017-09-17 10:39:09 +02:00
Thomas Zilz c815310418 Fix inverted cells, make sure inverted cells are cleared correctly (#996)
* Corretly inverse foreground and background. Be more conservative when clearing

* add missing space

* Re-enable optimisation with better checks

* Fix insversed check
2017-09-16 20:36:55 +02:00
Daniel Imms 9b6c4e046f Only refresh char atlas when char dimensions are valid
See Microsoft/vscode#34493
2017-09-16 10:57:49 -07:00
Daniel Imms 691ab2b02c Merge remote-tracking branch 'ups/v3' into 986_selection_exception 2017-09-14 09:06:00 -07:00
Daniel Imms 0cf9f1d536 Fix tests 2017-09-14 09:05:50 -07:00
Daniel Imms bc824ad6a5 Fix tests 2017-09-14 09:03:41 -07:00
Daniel Imms b9872c9a67 Merge remote-tracking branch 'ups/v3' into 963_cursor_accent 2017-09-14 09:02:32 -07:00
Daniel Imms ea0c2285bc Merge remote-tracking branch 'ups/v3' into 963_cursor_accent 2017-09-14 09:02:00 -07:00
Daniel Imms a611fee7af Merge pull request #976 from Tyriar/975_mousezone_leave
Ensure leave is called when leaving a MouseZone
2017-09-14 09:01:28 -07:00
Daniel Imms c2502bf0b0 Merge pull request #978 from Tyriar/953_user_scrolling_fix
Improve scrolling while user has scrolled up
2017-09-14 09:01:13 -07:00
Daniel Imms 8bdc8fb7a2 Remove log 2017-09-14 01:00:19 -07:00