Daniel Imms
b5cd4f1492
Cache ICoreBrowserService.isFocused per task
...
This is called for every selected cell when rendering which ends up
consuming a bunch of CPU due to the DOM calls.
2022-10-27 16:50:45 -07:00
Daniel Imms
8d4d5bd54b
Fix dropped frame issue
...
This ensures decorations are refreshed in the same frame when called from
an animation frame callback
Fixes #4225
2022-10-21 13:02:24 -07:00
Sebastian Malton
11e90591f9
Change clearing innerText to using replaceChildren to fix testing using jsdom
...
Signed-off-by: Sebastian Malton <sebastian@malton.name >
2022-10-19 10:09:12 -04:00
Megan Rogge
0b84d17b18
revert decoration dispose changes ( #4215 )
2022-10-18 21:32:22 +00:00
Daniel Imms
8e65ee8832
Merge pull request #4210 from Tyriar/todo_type_tabs
...
Fix a bunch of TODOs
2022-10-16 07:15:19 -07:00
Daniel Imms
7796b4101a
Type Buffer.tabs
2022-10-16 06:58:20 -07:00
Daniel Imms
a982484392
Re-enable onData event test
2022-10-16 06:55:04 -07:00
Daniel Imms
22e8a2f8e7
Remove old dimension properties
2022-10-15 18:07:05 -07:00
Daniel Imms
171ba446bd
Update other files
2022-10-15 15:32:02 -07:00
Daniel Imms
89e0b87eac
Move to device/css in domrenderer
2022-10-15 14:22:04 -07:00
Daniel Imms
65f41a151e
Use new render dimensions in webglrenderer
2022-10-15 13:15:12 -07:00
Daniel Imms
ddc4e75583
Add new dimensions properties, helper creation function
...
Part of #3925
2022-10-15 10:31:43 -07:00
Daniel Imms
16ea621a5f
Merge pull request #4206 from Tyriar/eslint-jsdoc
...
Add eslint-plugin-jsdoc with minimal comment rules
2022-10-15 08:55:07 -07:00
Daniel Imms
5204374494
Add no-multi-asterisks rule
2022-10-15 08:43:06 -07:00
Daniel Imms
9f1a71485c
Fix invalid jsdoc tags
2022-10-15 08:41:49 -07:00
Daniel Imms
49e0480f78
Add rule jsdoc/check-alignment
2022-10-15 08:39:32 -07:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
aeba140c75
Merge pull request #4204 from silamon/proposedApiCheck
...
Remove check proposed api checks
2022-10-15 08:04:12 -07:00
Simon Lamon
073aa6d439
Fix test "Proposed API check"
2022-10-15 10:25:39 +02:00
Simon Lamon
6bbe5a82a8
Remove check proposed api checks
2022-10-15 07:28:21 +00:00
Daniel Imms
50d1834871
Remove clipImageData completely
...
putImageData works a little differently to drawImage which confused me
for a bit, you need to offset the destination as putImageData draws the
'dirty' parts of the texture using the same source image dimensions
Fixes #4197
2022-10-13 06:25:13 -07:00
Daniel Imms
1b13127f0b
Merge pull request #4195 from Tyriar/4190
...
Create onSpecificOptionChange and onMultipleOptionChange helpers
2022-10-09 11:04:59 -07:00
Daniel Imms
a37ea14d10
Use options service in renderers
2022-10-09 10:57:49 -07:00
Daniel Imms
e47296c1b9
Use options service directly in renderers
2022-10-09 09:28:18 -07:00
Daniel Imms
8ac88bc6bf
Move Terminal option updates into owning components
2022-10-09 09:07:01 -07:00
Daniel Imms
7eead44048
Add onMultipleOptionChange
2022-10-09 08:14:56 -07:00
Daniel Imms
49a0904857
Move onSpecificOptionChange adoption
2022-10-09 08:07:43 -07:00
Simon Lamon
1c345bef48
Handle onWillFire if it fails, so it loads dom renderer
2022-10-09 15:01:15 +00:00
Daniel Imms
415100e8b8
Adopt onSpecificOptionChange
2022-10-09 07:46:10 -07:00
Daniel Imms
cad9c4164c
onOptionChange/onSpecificOptionChange tests
2022-10-09 07:16:56 -07:00
Daniel Imms
a87b6c3f2e
Implement IOptionsService.onSpecificOptionChange
...
Part of #4190
2022-10-09 07:09:35 -07:00
Daniel Imms
e0fb3b4d19
Remove ColorManager
2022-10-08 15:23:29 -07:00
Daniel Imms
a1050d1a11
Merge ColorManager into ThemeService
2022-10-08 15:20:15 -07:00
Daniel Imms
7f9e3b1225
Remove resolved todo
2022-10-08 14:09:00 -07:00
Daniel Imms
48f15cb543
Remove remaining setColors methods
2022-10-08 14:07:28 -07:00
Daniel Imms
6e35bcd767
Use theme service in more places
2022-10-08 13:55:23 -07:00
Daniel Imms
80e474c6ad
Viewport listen to theme service
2022-10-08 13:31:31 -07:00
Daniel Imms
4dee0c5d4b
Build out theme service more
2022-10-08 12:15:21 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
5d8e4a0af4
Add lint rule to ensure _on prefix is only for event emitters
2022-10-08 11:05:52 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
d8cf3af555
Fix Marker.dispose
2022-10-08 10:23:19 -07:00
Daniel Imms
d3976c05f1
Fix marker dispose unit tests
2022-10-08 09:27:58 -07:00
Daniel Imms
94c3d11239
Fix compile
2022-10-08 09:11:28 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms and Megan Rogge
c4eef2f470
Fix race condition that could when clearing atlas on 2+ terminals
...
This is the proper fix for microsoft/vscode#162996 , after a bunch of
investigation we found that this is causing the problem:
VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.
Co-Authored-By: Megan Rogge <merogge@microsoft.com >
2022-10-07 16:17:11 -07:00
Daniel Imms
ffa4d921bb
Merge remote-tracking branch 'upstream/master' into renderer_before_open
2022-10-07 10:10:24 -07:00
Daniel Imms
a060c64a08
Merge pull request #4179 from Tyriar/4178
...
Split Utf8ToUtf32 decoder unit tests up
2022-10-06 10:38:03 -07:00
Daniel Imms
0d5a526e86
Split Utf8ToUtf32 decoder unit tests up
...
Fixes #4178
2022-10-06 10:28:54 -07:00