Daniel Imms
921da1a2ea
Ignore no-unused-vars in .api, organize all remaining imports
2023-08-23 04:47:53 -07:00
Daniel Imms
530f758905
Restrict comments to 100 characters
...
This is a rule I try enforce in PR but it's a bit of a hassle, this will
give a lint warning when it happens resulting in:
- Yellow underline in supported editors when eslint is installed
- Compilation will succeed since it's a warning not an error
- CI will fail as it does not allow lint warnings
Special case comments are ignored which includes @vt comments, table
comments and commented out code.
2023-08-12 09:04:41 -07:00
Daniel Imms
1067ec19a8
Implement smooth scroll for pages/top/bottom, add viewport request event
2023-08-01 05:31:30 -07:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
415100e8b8
Adopt onSpecificOptionChange
2022-10-09 07:46:10 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd1f8e6f0952
2022-10-06 09:48:54 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Daniel Imms
2cfbee413f
Add some OscLinkService unit tests
2022-08-07 11:30:08 -07:00
Simon Lamon
1dcc1d1baf
fix test and replace options with rawOptions
2022-01-08 08:20:50 +00:00
Simon Lamon
aa046b73fb
Handle undefined rows or cols better
2021-09-01 13:34:27 +00:00
meganrogge
1c087f6bcd
cherry picked commits and scrollSource
2021-04-01 13:24:02 -07:00
meganrogge
c096633f91
get tests to pass
...
Co-authored-by: Daniel Imms <daimms@microsoft.com >
2021-04-01 13:17:53 -07:00
meganrogge
e2885f3a38
move stuff to inputHandler and move scroll to bufferService
2021-04-01 13:16:39 -07:00
Daniel Imms and PretaSOFT
7145130835
Fix onBufferChange event not working after reset
...
Co-authored-by: Megan Rogge (megan.rogge@microsoft.com )
2021-01-05 09:32:09 -08:00
Daniel Imms
06b8d36cf0
Fix other leaking listeners
2020-05-03 14:37:20 -07:00
Daniel Imms
21bcef5008
Move a bunch of scroll logic into CoreTerminal
...
This change will now reset userScrolling on RIS
2020-04-26 09:54:44 -07:00
Daniel Imms
a6949d522e
Move resize event into bufferservice
2020-04-26 06:16:13 -07:00
Daniel Imms
eba372e2cc
More some of Terminal.resize into bufferservice
2020-04-25 20:52:59 -07:00
Daniel Imms
9817754f92
Fix explicit access
2020-04-14 06:23:11 -07:00
Daniel Imms
a0e2c9b270
Fix naming issue with serviceBrand
2019-07-13 23:45:25 -07:00
Daniel Imms
5cc8ad802c
Get type safety in DI, fix character joiner not using buffer service
2019-07-13 22:02:13 -07:00
Daniel Imms
21fbe25858
Dependency Injection prototype
2019-07-13 19:50:16 -07:00
Daniel Imms
1b07a03b2f
Properly reset buffer after Terminal.reset
2019-06-08 21:39:10 -07:00
Daniel Imms
09b0bbed32
Move buffer/buffers ownership to BufferService
2019-06-08 20:21:29 -07:00
Daniel Imms
0dfc1afc21
Create BufferService
2019-06-08 16:59:28 -07:00
Daniel Imms
Simon Lamon
meganrogge
Daniel ImmsandPretaSOFT
Daniel Imms