Commit Graph
859 Commits
Author SHA1 Message Date
Daniel Imms bb526aaa88 Fix exception when resizing both dimensions
This happened because buffers now resize themselves but they were
relying on Terminal to give them a blank line. The blank line was
coming back with the old columns value, causing an NPE.

Fixes #860
2017-08-08 12:59:02 -07:00
Daniel Imms 1361ff8e22 Merge branch 'master' into 842_resize_buffers_bug 2017-08-06 10:25:38 -07:00
Daniel Imms 0731f28615 jsdoc 2017-08-06 10:25:25 -07:00
Daniel Imms d46003843b Add tests for Buffer.fillViewportRows 2017-08-05 20:15:23 -07:00
Daniel Imms 13619d427a Add a bunch of Buffer tests 🎉 2017-08-05 20:11:26 -07:00
Daniel Imms f03d00a497 Clean up buffer clean up/fill logic
The alt buffer is now cleared immediated after activating the normal buffer and
is filled when switching to it. The tests were failing because the alt buffer
wasn't being cleared properly with the previous solution.
2017-08-05 19:42:54 -07:00
Daniel Imms 3d20c2f266 Resize both buffers on resize
This brings in proper support to resize both buffers (#510) and fixes an
exception that was caused by wrongfully not clearing the normal buffer when
resizing while the alt buffer is active.

There was an obscure bug in this that could have caused some great confusion
later on; When switching to the alt buffer, a hard terminal reset was performed
which tried to retain the buffers. However, because buffers was initialized in
the Terminal constructor to a new BufferSet, the Terminal.buffer convenience
pointer was pointing at a stale alt buffer which was the one actually being
used, not Terminal.buffers.alt.

Fixes #842
Fixes #510
2017-08-05 18:59:44 -07:00
Steven Silvester 6f749b196a Prevent webpack error 2017-08-03 14:43:51 -05:00
mofux 106eda7067 Merge changes from #828 2017-08-02 17:42:43 +02:00
thomas 5bc0ad879b Set xterm-color for cursor element
Prevent focus from getting lost when in vt mouse mode
Fix: cursor style not applied on init, set a class for block cursor
Make all cursors work under all conditions (focused, unfocused, blink)
Unify cursor rendering with normal rendering code
Make sure underline AND blink can be used in co-existence
Always show outlined block cursor in unfocused state
2017-08-02 15:41:18 +02:00
Paris Kasidiaris 72e85a352a Focus on mousedown, instead of click 2017-08-02 16:03:56 +03:00
Paris Kasidiaris 49c1ca3f57 Fix #827: Always focus terminal on click 2017-08-02 10:44:16 +03:00
Daniel Imms 3f7fec8c91 Merge branch 'master' into alt-selection 2017-07-28 14:07:43 -07:00
Daniel Imms 3479614c73 Disable selection override on Windows/Linux 2017-07-28 14:06:55 -07:00
Daniel Imms ff165e8627 Merge branch 'master' into 818_fix_save_restore_cursor 2017-07-28 08:33:52 -07:00
Jon Masters 2d4e617c95 Issue #821 - Prevent TypeError in resize() 2017-07-28 11:54:46 +00:00
Daniel Imms 6ea7758ab1 Add test for save and restore cursor 2017-07-27 16:35:48 -07:00
Daniel Imms 604959a319 Fix save and restore cursor behavior
This broke in #717.

Fixes #818
2017-07-27 16:28:27 -07:00
Joao Moreno 6a3b39b428 fix context menu in disabled state 2017-07-26 09:07:20 +02:00
Joao Moreno 9e80a12462 fix tests 2017-07-25 17:17:48 +02:00
Joao Moreno 0e0ecc2d6a listen to shift when in Linux 2017-07-25 17:11:41 +02:00
Joao Moreno f872ced863 oops, this is a function 2017-07-25 11:30:03 +02:00
Joao Moreno 9a30b98880 safeguard npe 2017-07-25 10:45:45 +02:00
t-amqi 23dd3d7a67 Fix indentation 2017-07-24 13:41:24 -07:00
t-amqi 79965708ab Add lineFeed event
- this is useful for checking when a cmd is entered or when a cmd finishes
- also handy to have for accessibility for output
2017-07-24 11:43:03 -07:00
Joao Moreno 80a83ff8d9 wip: alt forces selection 2017-07-24 18:08:11 +02:00
Daniel Imms e56f710cd1 Make SelectionManager more resilient
Fixes #809
2017-07-21 05:45:53 -07:00
Daniel Imms e3ded61122 Add null check when mouse coords are bad
This happens if the viewport is bad (which was fixed in another commit).

Fixes #801
2017-07-18 20:34:24 -07:00
Daniel Imms f8e3fa5a99 Fix browserify build and search addon (#804)
Fixes #803
2017-07-18 19:58:35 -07:00
Jörg Breitbart cd5827e69b higher timeout for test case 2017-07-18 22:19:55 +02:00
Daniel Imms 20048d31a1 Merge branch 'master' into faster_wcwidth 2017-07-17 11:06:38 -07:00
Jörg Breitbart 598a729fc0 fixes #799 - lookup table is created on first wcwidth call for char > 127 2017-07-17 19:07:02 +02:00
Jörg Breitbart 6ed5c9e64d speed test commented out 2017-07-16 23:53:41 +02:00
Jörg Breitbart 1232c00dd1 some fixes
- commenting the bit shifts
- switching to Uint32Array
- conditional for TypedArray
- fixing Math.floor slowdown in bisearch
2017-07-16 23:40:36 +02:00
Jörg Breitbart 5d87b54390 test speedup defensive 2017-07-16 14:09:25 +02:00
Jörg Breitbart 6733c6ce1f test speedup defensive 2017-07-16 14:05:55 +02:00
Jörg Breitbart ba2d0e8df2 fixing whitespaces 2017-07-16 13:57:04 +02:00
Jörg Breitbart 1722248065 fixing whitespaces 2017-07-16 13:48:48 +02:00
Jörg Breitbart dd0fcb6320 fixing whitespaces 2017-07-16 13:44:00 +02:00
Jörg Breitbart b965d0a0af faster wcwidth with lookup table 2017-07-16 13:26:38 +02:00
Paris Kasidiaris 634f4e29aa Remove redundant comment 2017-07-16 03:47:15 +03:00
Daniel Imms 59f75555bc Add IBuffer, IBufferSet and fix CircularList type 2017-07-16 03:47:15 +03:00
Paris Kasidiaris cb5a452c90 Implement tests for Buffer and BufferSet 2017-07-16 03:47:15 +03:00
Paris Kasidiaris 58b9f712df Improve documentation of Buffer and BufferSet classes 2017-07-16 03:47:15 +03:00
Paris Kasidiaris f09918f0d2 Fix variable name 2017-07-16 03:47:15 +03:00
Aleksandr Andriienko 4e35904392 Fix regression. Existing tests work again.
Signed-off-by: Aleksandr Andriienko <oandriie@redhat.com>
2017-07-16 03:47:15 +03:00
Paris Kasidiaris 82b3beb921 Fix reference to terminal.buffer.lines 2017-07-16 03:47:15 +03:00
Paris Kasidiaris 2806288489 Add semicolons 2017-07-16 03:47:15 +03:00
Paris Kasidiaris 0d498fcd52 Correct references to buffer lines 2017-07-16 03:47:15 +03:00
Paris Kasidiaris 83efc9afc4 Fix SelectionManager tests 2017-07-16 03:47:15 +03:00