Commit Graph
100 Commits
Author SHA1 Message Date
Daniel Imms b5f53b341d Test search event, fix returning -1 for no results
Fixes #3830
2022-05-26 11:37:54 -07:00
Daniel Imms 221db55680 Add find result count/index to demo
Part of #148109
2022-05-26 10:32:53 -07:00
Daniel Imms 5cc1114594 Merge pull request #3828 from Tyriar/powerlines
Add powerline symbol test button to demo
2022-05-25 06:35:51 -07:00
Daniel Imms 49872f9377 Merge pull request #3826 from Tyriar/vscode148061
Take padding into account when converting mouse coord to cell
2022-05-23 12:10:48 -07:00
Daniel Imms 1e17ba7a80 Add some NF icons 2022-05-23 12:08:28 -07:00
Daniel Imms 1c8b08d55c Add test button to print all powerline symbols
Part of #3807
2022-05-23 10:42:31 -07:00
Daniel Imms ca083f257c Pass window in to fix tests 2022-05-23 07:23:15 -07:00
Daniel Imms 8b53b8c255 Take padding into account when converting mouse coord to cell
Part of microsoft/vscode#148061
2022-05-23 06:49:52 -07:00
Daniel Imms ba078ca1f9 Merge pull request #3824 from Tyriar/toColor_standard
Standardize css.toColor output to #rrggbb[aa]
2022-05-20 12:48:16 -07:00
Daniel ImmsandMegan Rogge 4ededf5b06 Update src/common/Color.test.ts
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-20 12:35:51 -07:00
Daniel Imms 384cd9db30 Standardize css.toColor output to #rrggbb[aa]
This will help reduce the chance of runtime exceptions that would
break the render loop.
2022-05-20 11:06:19 -07:00
Daniel Imms 55b420b016 Merge pull request #3823 from Tyriar/3814_2
Correct rgba() parsing to use float alpha channel
2022-05-20 06:50:03 -07:00
Daniel Imms ddd43e0f09 Correct rgba() parsing to use float alpha channel
Fixes #3814
2022-05-20 06:34:17 -07:00
Daniel Imms 41fdb96b68 Merge pull request #3822 from Tyriar/3821
Deflake registerLinkProvider tests
2022-05-19 15:51:58 -07:00
Daniel ImmsandMegan Rogge e5fb255b79 Update package.json
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-19 15:51:31 -07:00
Daniel ImmsandMegan Rogge 7f14bfc7d9 Update package.json
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-19 15:51:28 -07:00
Daniel Imms 8f97a5a786 Deflake registerLinkProvider tests
The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.

Fixes #3821
2022-05-19 15:30:12 -07:00
Daniel Imms 5353808437 Update playwright 2022-05-19 15:26:52 -07:00
Daniel Imms 38f8bc5f3c Merge pull request #3820 from Tyriar/3818
Fix decoration positioning
2022-05-19 10:24:42 -07:00
Daniel Imms 48c21dc3ae Merge pull request #3819 from Tyriar/3814
Support rgb() and rgba() in css.toColor
2022-05-19 10:24:32 -07:00
Daniel Imms bcb71e854f Fix decoration positioning
In _createElement the element wasn't set on the decoration yet.

Fixes 3818
2022-05-19 09:32:57 -07:00
Daniel Imms e3c361327c Support rgb() and rgba()
This is used for default theme colors and decoration bg/fg.

Fixes #3814
2022-05-19 09:23:36 -07:00
Daniel Imms 51ef27894e Merge pull request #3815 from ChaseKnowlden/ChaseKnowlden/issue3814
Add #rgba format
2022-05-19 09:07:48 -07:00
Daniel Imms 7edc11bd04 Correct #rgba, add #rgb and tests 2022-05-19 09:00:50 -07:00
Daniel Imms 3d541dd323 Merge pull request #3813 from Tyriar/3810
Support selectionForeground theme color
2022-05-18 04:14:34 -07:00
Daniel Imms 53f05de3e7 Add selectionForeground webgl unit test 2022-05-17 12:12:01 -07:00
Daniel Imms d1a87facfd Fix selectionForeground column select mode on dom/canvas 2022-05-17 12:10:52 -07:00
Daniel Imms 18a2751471 Fix selectionForeground handling in test 2022-05-17 11:55:14 -07:00
Daniel Imms 59e1bddb6e Merge branch 'master' into 3810 2022-05-17 11:43:06 -07:00
Daniel Imms d6ad4a4fc3 Remove unneeded dep 2022-05-17 11:41:13 -07:00
Daniel Imms f9bd0b8fed Fix setting selection foreground on webgl 2022-05-17 11:39:14 -07:00
Daniel Imms ec26820ea6 Fix circular dependency mouseservice <-> renderservice 2022-05-17 11:23:33 -07:00
Daniel Imms d7fdf17eab Ensure color mode is set for selection foreground overrides 2022-05-17 11:20:20 -07:00
Daniel Imms f2b90d690f Selection foreground for canvas (circular dep issue) 2022-05-16 15:17:03 -07:00
Daniel Imms eec53261e0 Merge pull request #3779 from Tyriar/3773
Layout dimension left/right after renderer dims change
2022-05-16 14:29:16 -07:00
Daniel Imms eb96187801 Support selectionForeground in dom
Part of #3810
2022-05-16 10:08:51 -07:00
Daniel Imms c502272373 Support selection foreground in webgl
Part of #3810
2022-05-16 09:40:07 -07:00
Daniel Imms 87bc48f5bc Merge pull request #3808 from Tyriar/trigger_webgl
Whitespace change to trigger build
2022-05-13 12:32:36 -07:00
Daniel Imms d7fb0141d2 Whitespace change to trigger build
The fix for #3720 didn't touch any file in the webgl addon so it didn't end
up releasing.
2022-05-13 12:32:17 -07:00
Daniel Imms 2fa125904a Merge pull request #3806 from Tyriar/3720
Allow ensureContrastRatio to change luminance the other way
2022-05-13 11:31:37 -07:00
Daniel Imms de03391c2d Allow ensureContrastRatio to change luminance the other way
The higher ratio of the two results will be picked.

Fixes #3720
2022-05-13 11:19:38 -07:00
Daniel Imms a38e97f1ec Merge pull request #3805 from Tyriar/3804
Fire onSelectionChange when Terminal.select is called
2022-05-13 09:51:28 -07:00
Daniel Imms 5d98304249 Fire onSelectionChange when Terminal.select is called
Fixes #3804
2022-05-13 09:42:39 -07:00
Daniel Imms 995080c40c Merge pull request #3802 from Tyriar/3801
Allow styling active result decoration via .xterm-find-active-result-decoration
2022-05-13 08:47:11 -07:00
Daniel Imms 5ad12dff8d Merge pull request #3800 from Tyriar/3799
Dom renderer: top decorations above selection
2022-05-13 08:46:47 -07:00
Daniel ImmsandMegan Rogge a458bae36d Update src/browser/renderer/dom/DomRendererRowFactory.ts
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-13 08:46:40 -07:00
Daniel Imms 900200b871 Merge remote-tracking branch 'upstream/master' into 3773 2022-05-13 08:46:05 -07:00
Daniel Imms 77d5d52e71 Allow styling active result decoration via .xterm-find-active-result-decoration
Fixes #3801
2022-05-13 08:10:35 -07:00
Daniel Imms 1a50cfabe0 Dom renderer: top decorations above selection
Fixes #3799
2022-05-13 07:56:45 -07:00
Daniel Imms 3abbaa9ba9 Merge pull request #3678 from silamon/scrollbar-impro
Another way to turn off the scrollbar
2022-05-13 06:07:48 -07:00
Daniel Imms 5a9f2635d3 Merge branch 'master' into scrollbar-impro 2022-05-13 05:29:57 -07:00
Daniel Imms da93a35671 Merge pull request #3785 from Tyriar/layers
Support setting the layer of a decoration
2022-05-12 13:36:40 -07:00
Daniel Imms 7d4b61413e Merge pull request #3786 from Tyriar/default_highlight
Highlight all matches in demo by default
2022-05-12 13:25:23 -07:00
Daniel Imms 13e33a8da4 Merge pull request #3787 from Tyriar/3780
Merge .xterm css rules
2022-05-12 13:25:07 -07:00
Daniel Imms ede3d10528 Merge pull request #3788 from Tyriar/3762
Disable pointer events on the overview ruler
2022-05-12 13:24:53 -07:00
Daniel Imms 64ea96cc13 Merge pull request #3789 from Tyriar/3760
Add warning in demo code about flow control
2022-05-12 13:24:40 -07:00
Daniel Imms 47e3dc7bcd Merge pull request #3792 from Tyriar/casing_fix2
Fix missed decorations casing
2022-05-12 11:50:33 -07:00
Daniel Imms 748d0cc74f Fix missed decorations casing 2022-05-12 11:49:57 -07:00
Daniel Imms 343ea9bcd0 Merge pull request #3791 from Tyriar/decorations_lowercase2
Fix case of Decorations folder (take 2)
2022-05-12 11:20:10 -07:00
Daniel Imms cd01157e55 Rename decorations2 -> decorations to fix casing 2022-05-12 11:19:07 -07:00
Daniel Imms 4cc4b2cd42 Rename Decorations -> decoration2 to fix casing 2022-05-12 11:18:49 -07:00
Daniel Imms 29c1264b42 Add warning in demo code about flow control
Fixes #3760
2022-05-12 11:04:48 -07:00
Daniel Imms d84b71d4c6 Disable pointer events on the overview ruler
Fixes #3762
2022-05-12 10:59:57 -07:00
Daniel Imms f18528d2bb Clear _dimensionsChanged variable 2022-05-12 10:58:50 -07:00
Daniel Imms ddde738326 Merge .xterm css rules
Fixes #3780
2022-05-12 10:57:12 -07:00
Daniel Imms 24919e36f0 Highlight all matches in demo by default 2022-05-12 10:54:36 -07:00
Daniel Imms f5223d30b8 Fix typo 2022-05-12 10:52:16 -07:00
Daniel Imms 7b4423819e Support setting the layer of a decoration
Fixes #3778
2022-05-12 10:51:11 -07:00
Daniel Imms 372c2970e6 Merge pull request #3782 from Tyriar/3774
Correct positioning of decoration elements
2022-05-12 10:16:06 -07:00
Daniel Imms bc4158c9b8 Merge pull request #3783 from Tyriar/bg_decorations__selection_refactor
Remove selection-specific render pass, use bg overrides instead
2022-05-11 12:52:49 -07:00
Daniel Imms 8164c638e5 Merge branch 'master' into bg_decorations__selection_refactor 2022-05-11 12:34:28 -07:00
Daniel Imms 8b9fa324f4 Merge pull request #3775 from Tyriar/bg_decorations
Support for decorations to change cell foreground and background
2022-05-11 12:34:08 -07:00
Daniel Imms 0976b15709 Fix lint 2022-05-11 11:57:13 -07:00
Daniel Imms 181fb1cfe5 Remove selection-specific render pass, use bg overrides instead
Part of #3778
2022-05-11 11:46:44 -07:00
Daniel Imms 09aed4d339 Correct positioning of decoration elements
Fixes #3774
2022-05-11 10:27:35 -07:00
Daniel Imms aeb4fa0fe9 Fix compile after bad merge 2022-05-11 10:15:18 -07:00
Daniel Imms 0ae5aedcf9 Merge branch 'master' into 3773 2022-05-11 10:13:57 -07:00
Daniel Imms 3d41f028e4 Layout dimension left/right after renderer dims change
Fixes #3773
2022-05-11 10:12:48 -07:00
Daniel Imms 324ea2ecb7 Clean up/resolve todos 2022-05-11 09:54:40 -07:00
Daniel Imms 999f255893 Fix sorted list edge case 2022-05-11 09:49:23 -07:00
Daniel Imms 931ee9e89e Maintain decorations sorted by line 2022-05-11 09:34:51 -07:00
Daniel Imms c0b4edaf31 Reduce duplicate with getDecorationsAtCell method 2022-05-11 08:37:42 -07:00
Daniel Imms abdce874db Fix cases where only one override was with tests 2022-05-11 08:31:09 -07:00
Daniel Imms edba006045 Clear all decorations on reset 2022-05-10 12:32:06 -07:00
Daniel Imms 6b4df216d3 Remove unneeded code 2022-05-10 12:08:42 -07:00
Daniel Imms f502f55ae1 Merge branch 'master' into bg_decorations 2022-05-10 11:50:01 -07:00
Daniel Imms afe1d7ed6f Fix webgl contrast tests since a bug in luminance was fixed 2022-05-10 11:48:37 -07:00
Daniel Imms 1628795557 Fix fg/bg flags being set by negative ints 2022-05-10 09:42:12 -07:00
Daniel Imms e9643f5936 Ensure texture atlas isn't for overrides used in canvas renderer 2022-05-10 09:24:09 -07:00
Daniel Imms ba61509fdd Remove react to changes idea 2022-05-10 06:20:48 -07:00
Daniel Imms a67e7286d3 Use correct row for override in webgl renderer 2022-05-10 06:16:32 -07:00
Daniel Imms b85f5aacd6 Use correct row for override in canvas renderer 2022-05-10 06:14:53 -07:00
Daniel Imms de574a27fc Full re-render when there are decoration changes 2022-05-10 05:44:00 -07:00
Daniel Imms 7c87f5b47a Start to use new API in search addon 2022-05-10 05:31:49 -07:00
Daniel Imms 0a26cee08b Pull override color logic into a function 2022-05-10 05:06:20 -07:00
Daniel Imms 40716b8ca5 Consolidate override logic into model/WebglRenderer 2022-05-10 05:00:52 -07:00
Daniel Imms d29388394c Get Webgl rendering fg/bg overrides 2022-05-10 04:53:31 -07:00
Daniel Imms 714d4b1cd6 Fix fg color when there is a decoration override in canvas renderer 2022-05-10 04:06:06 -07:00
Daniel Imms 9f1db12b1b bg/fg decorations mostly working in canvas renderer 2022-05-09 16:19:58 -07:00
Daniel Imms 13abd2aa96 Support min contrast ratio in decoration fg/bg 2022-05-09 15:39:02 -07:00