Samuel Sampson
f1849cafaf
Introduce IRenderDebouncer interface, unifying RenderDebouncer and TimeBasedDebouncer types
2021-08-17 20:50:47 +00:00
Daniel Imms
f52d631fa4
Add eslint type assertions rule
...
Fixes #3359
2021-06-04 06:23:12 -07:00
meganrogge
be32590ef0
fix # https://github.com/microsoft/vscode/issues/123000
2021-05-05 08:21:26 -07:00
Daniel Imms
999116c536
Convert CharacterJoinerRegistry to a service
...
Part of #3094 , #3283
2021-04-02 07:43:39 -07:00
Daniel Imms
04092c80e8
Update src/browser/services/SelectionService.ts
2021-03-30 06:19:34 -07:00
Daniel Imms
b7e0489a53
Remove offset from link
...
The link range is absolute, not relative to viewport
2021-03-30 06:18:17 -07:00
Martin Sander
5185e5f894
Use linkifier2 to double click select links
...
Also works with right click select.
Fixes #682 .
2021-03-16 16:42:38 +01:00
jeanp413
350f6cfea1
Fixes https://github.com/microsoft/vscode/issues/102194
2021-02-05 11:15:39 -05:00
Martin Sander
554b4a8224
Store old selection when firing onSelectionChange
2021-01-22 16:41:57 +01:00
Martin Sander
c6f93701f5
fire onSelectionChange on right click select
...
fixes #3216 .
2021-01-16 10:14:11 +01:00
Daniel Imms and Megan Rogge
66c80d8b78
Simplify checks
...
Co-authored-by: Megan Rogge <merogge@microsoft.com >
2021-01-15 09:39:34 -08:00
Martin Sander
0cb38cfdcb
fire onSelectionChange on empty selection
...
Fire the onSelectionChange event when a selection is cleared by
single-clicking somewhere inside the terminal area.
fixes #3193 .
This also slightly changes the behaviour when re-selecting the same area
in the terminal. Before, this fired onSelectionChange, but it does not
anymore, even when changing the direction of the selection.
2021-01-14 23:08:34 +01:00
Tony Mottaz
f68ff2a455
Check for alt+click option sooner
2020-11-22 10:00:02 -06:00
Tony Mottaz
04e2bdd6ec
Make alt+click behavior configurable
2020-11-20 19:50:03 -06:00
Pete Blois
057a8f6f1b
Incorporate shadowRoot in focus calculation.
...
This adds a call to getRootNode to get either the Document or the
ShadowRoot to use when calculating whether the textarea has focus.
getRootNode is guarded for older browser compatibility (IE).
2020-11-09 13:12:03 -08:00
Tony Brix
3d9a33bb69
move measure before refreshRows
2020-10-25 10:59:30 -05:00
Daniel Imms
49d5608fa6
Define member bar in ctor
2020-09-11 05:29:24 -07:00
Tony Brix
9513c231c9
fix: rerender hidden terminal when visible
2020-09-11 00:42:18 -05:00
Andrew Schlackman
0abd121653
fix renderer pause again with handling of undefined
2020-07-12 10:07:47 -04:00
Daniel Imms
70e0c0385a
Revert "fix renderer pausing inadvertently in some cases"
...
This reverts commit 5738f4545f .
2020-07-10 12:14:59 -07:00
Andrew Schlackman
5738f4545f
fix renderer pausing inadvertently in some cases
2020-07-09 16:20:37 -04:00
Daniel Davis
0e6611b528
onSelectionChange() not getting called for single character selection #2617
2020-06-11 14:12:42 +01:00
Daniel Imms
6a0f7b0713
Fix exception when disposing Terminal twice
...
Fixes #2933
2020-05-15 10:58:09 -07:00
Daniel Imms
06b8d36cf0
Fix other leaking listeners
2020-05-03 14:37:20 -07:00
Daniel Imms
b75e42a56c
Fix terminal object leaking
2020-05-03 12:46:37 -07:00
Daniel Imms
bdb438972f
Fix errors in Terminal and elsewhere
...
This was mostly ! to compel TS, we should actually fix this down the road
but that can come later.
2020-04-26 10:44:44 -07:00
Daniel Imms
6f9730c652
Merge branch 'master' into layers2
2020-04-26 08:14:47 -07:00
Daniel Imms
3a1a0d6590
Remove input handler Terminal.resize dep
2020-04-26 06:34:36 -07:00
Daniel Imms
9346eba2f2
Remove Terminal.showCursor dep from input handler
2020-04-25 16:18:43 -07:00
Daniel Imms
353a8c5388
Create CoreTerminal, fix createInstance in strict mode
2020-04-25 10:21:56 -07:00
Daniel Imms
c185529ad5
Make sure selection gets redrawn when switching renderers
...
Fixes #2555
2020-04-25 07:11:43 -07:00
Daniel Imms
3a5def98e5
Correct selection types being optional
2020-04-25 06:56:00 -07:00
Daniel Imms
1472e7b051
Merge branch 'master' into 2824
2020-04-14 06:25:06 -07:00
Daniel Imms
9817754f92
Fix explicit access
2020-04-14 06:23:11 -07:00
Daniel Imms
04c1e4b57d
Remove readonly from ctors
2020-04-14 06:03:31 -07:00
Daniel Imms
309bdf3d70
Rename onRender
2020-04-11 09:53:32 -07:00
Daniel Imms
55f9203f60
Only fire IRenderService.onRender when buffer changes occurred
...
Fixes #2836
2020-04-11 09:51:28 -07:00
Daniel Imms
714daba393
Fix selection wrapping to end when not beyond viewport
...
This was happening as the devicePixelRatio wasn't being taken into account,
the fix was to rely on IRenderService to get the right canvas height.
Fixes #2833
2020-04-11 06:31:58 -07:00
Daniel Imms
88a50d3779
Fix most rules
2020-03-28 06:51:36 -07:00
Daniel Imms
22f4342194
Move options row refresh into render service
2019-11-09 10:07:24 -08:00
Daniel Imms
873de2b127
Move cursor render layer to browser
2019-11-07 18:39:46 -08:00
Daniel Imms
1e1038b2c7
Remove renderer circular dep on renderservice
...
Also fix super.dispose not being called correctly on RenderService
2019-11-07 18:09:40 -08:00
Daniel Imms
843d5ff53c
Adopt optional chaining
2019-11-05 11:09:47 -08:00
Daniel Imms
740d261d7a
Protect against exception when clicking on mouse zones
...
Still not sure how this happens but seems harmless to just not use the row as
wrapped here.
See microsoft/vscode#82309
2019-10-16 11:07:22 -07:00
Daniel Imms
81c5fd4988
Don't execute move to cell when the user has scrolled up
...
Fixes #2401
2019-09-06 09:27:20 -07:00
Daniel Imms
dd42eccb91
Fix dom -> canvas renderer switch not drawing viewport
...
Fixes #2204
2019-08-10 17:51:17 -07:00
Daniel Imms
29d8493a7a
Don't throw if first click is incremental
...
Fixes #2365
2019-08-07 07:18:27 -07:00
Daniel Imms
cdefb3e7f2
Remove more terminal from render layers and cache
2019-07-14 12:07:43 -07:00
Daniel Imms
a0e2c9b270
Fix naming issue with serviceBrand
2019-07-13 23:45:25 -07:00
Daniel Imms
88c88f1141
Adopt DI in browser services
2019-07-13 22:26:13 -07:00