eiac/xterm.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
9,024 Commits 45 Branches 121 Tags
abae7b62104b6834e65697d5aa280df24dd95763
Commit Graph
62 Commits
Author SHA1 Message Date
Daniel Imms 921da1a2ea Ignore no-unused-vars in .api, organize all remaining imports 2023-08-23 04:47:53 -07:00
Daniel Imms 530f758905 Restrict comments to 100 characters 
This is a rule I try enforce in PR but it's a bit of a hassle, this will
give a lint warning when it happens resulting in:

- Yellow underline in supported editors when eslint is installed
- Compilation will succeed since it's a warning not an error
- CI will fail as it does not allow lint warnings

Special case comments are ignored which includes @vt comments, table
comments and commented out code.
 2023-08-12 09:04:41 -07:00
Daniel Imms 0adbedf98d Request links after viewport resize 
This clears the underline when hovering the link but this is an edge
case that isn't so important. As it's difficult to do outside of the
demo.

Fixes #4357
 2022-12-27 06:41:58 -08:00
Daniel Imms 7b8ad8c0b4 Improve comment 2022-12-20 15:01:30 -08:00
Daniel Imms f28c21eb77 Fix link event listener leak 
The bug here is that _clearCurrentLink was being called only on the
line(s) that changed, but _askForLink was then being triggered
regardless. This caused more onRenderedViewportChange listeners to be
registered and for the thread blocking to get exponentially worse.

Fixes #4341
 2022-12-20 14:58:35 -08:00
Jörg Breitbart d65898ffed Merge branch 'master' into fix_weblinks 2022-12-19 14:19:43 +01:00
Jörg Breitbart 440da4a5ff reeval previous active link, fixes #4295 2022-12-09 16:37:56 +01:00
Jörg Breitbart e70138b63c revert temp changes in linkifier2 2022-12-08 17:46:45 +01:00
Jörg Breitbart 42bacc3283 disabled faulty code in linkifier2 2022-12-05 18:30:25 +01:00
Jörg Breitbart 46bd97247d disabled faulty code in linkifier2 2022-12-05 18:28:42 +01:00
Daniel Imms 5d8e4a0af4 Add lint rule to ensure _on prefix is only for event emitters 2022-10-08 11:05:52 -07:00
Daniel Imms ac659cb412 Prevent overriding of Disposable.dispose 
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
 2022-10-08 08:27:10 -07:00
Daniel Imms 4d97729010 Revert "Merge pull request #4166 from Tyriar/event_with_emitter" 
This reverts commit d22f7c9edd, reversing
changes made to 1f8e6f0952.
 2022-10-06 09:48:54 -07:00
Daniel Imms ed15a8e170 Create new event with emitter object to simplify code 2022-10-01 08:45:40 -07:00
Daniel Imms 1a22c44f2b Make all emitters readonly 2022-10-01 08:02:32 -07:00
Daniel Imms cf9949840b Use readonly over getter for exposing events 
Fixes #4164
 2022-10-01 07:52:26 -07:00
Svante Boberg 52dc6a456c Remove redundant disposal 2022-07-27 14:34:00 +02:00
Svante Boberg 9df996cb3d Dispose events 
https://github.com/microsoft/vscode/issues/155232

The events that is setup for needs to be disposed for js to be able
to garbage collect the terminals.
 2022-07-23 13:28:52 +02:00
Daniel Imms 8f97a5a786 Deflake registerLinkProvider tests 
The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.

Fixes #3821
 2022-05-19 15:30:12 -07:00
Megan Rogge a5f2ea336e update search results onBufferContentsChange (#3811) 2022-05-17 10:00:55 -07:00
Martin Sander 5185e5f894 Use linkifier2 to double click select links 
Also works with right click select.
Fixes #682.
 2021-03-16 16:42:38 +01:00
Daniel Imms 50fc84f7d7 Support ILink.dispose 
When displaying hovers/overlays using the link provider API currently
it's not possible to know when unused links are no longer cached in
xterm.js which can result in leaked event listeners.
 2020-09-04 21:57:51 -07:00
Daniel Imms 27af770068 Remove intersecting lower priority links 
Fixes #2848
 2020-05-06 06:16:36 -07:00
Daniel Imms f886698dc3 Workaround for hover firing multiple times 
Fixes #2911
 2020-05-06 04:53:25 -07:00
Daniel Imms 0707398a5b Remove logs 2020-05-05 18:27:11 -07:00
Daniel Imms 484883f442 Fix Linkifier2 tests 2020-05-05 18:24:45 -07:00
Daniel Imms d488b49fc4 Change link provider API to return all links for the line 
Fixes #2848
 2020-05-05 18:19:57 -07:00
Daniel Imms 06b8d36cf0 Fix other leaking listeners 2020-05-03 14:37:20 -07:00
Daniel Imms b75e42a56c Fix terminal object leaking 2020-05-03 12:46:37 -07:00
Daniel Imms bdb438972f Fix errors in Terminal and elsewhere 
This was mostly ! to compel TS, we should actually fix this down the road
but that can come later.
 2020-04-26 10:44:44 -07:00
Daniel Imms e3c81048af Use DI with Linkifier2 2020-04-25 07:29:07 -07:00
Daniel Imms 22aaf0471a Invalidate all links above when the terminal scrolls 
See microsoft/vscode#95556
 2020-04-25 06:41:25 -07:00
Daniel Imms d0519d6c25 Fix tests 2020-04-19 04:20:10 -07:00
Daniel Imms 2ce435f98d Allow embedders to customize link decorations independently 
See microsoft/vscode#95631
 2020-04-19 04:07:22 -07:00
Daniel Imms 1282c060fc Prevent hover callbacks firing if the mouse is outside the viewport 
Fixes #2849
 2020-04-18 18:02:51 -07:00
Daniel Imms 88ff19383b Allow embedders to designate link hover elements 2020-04-18 09:13:09 -07:00
Daniel Imms 832312e095 Change hideUnderline to hideDecorations 
Also track cursor style
 2020-04-18 06:23:46 -07:00
Daniel Imms f2ed01993d Track changes to hideUnderline 2020-04-18 06:18:01 -07:00
Daniel Imms ccf869e671 Merge pull request #2854 from Tyriar/hide_underline 
Allow hiding of link underlines
 2020-04-17 19:01:22 -07:00
Daniel Imms 48f579977e Allow hiding of link underlines 
See microsoft/vscode#95080
 2020-04-17 18:46:01 -07:00
Daniel Imms 0cd2b78425 Clear link when leaving xterm link 
Fixes #2851
 2020-04-17 17:30:53 -07:00
Daniel Imms 309bdf3d70 Rename onRender 2020-04-11 09:53:32 -07:00
Daniel Imms 55f9203f60 Only fire IRenderService.onRender when buffer changes occurred 
Fixes #2836
 2020-04-11 09:51:28 -07:00
Jon Bockhorst e817a7b6c6 Add Linkifier2 tests 2020-02-13 00:43:24 -06:00
Jon Bockhorst 901adb38ae Fix linkProvider end positions 2020-02-10 12:39:16 -06:00
Daniel Imms 54743eda16 Make link matcher API the default for web links addon 2020-02-08 10:52:36 -08:00
Daniel Imms 0103c689f7 Start registerLinkProvider tests 
Bugs fixed:

- Not breaking on first link match for multiple providers
- Hover event wasn't fired when on last character of link
 2020-02-07 11:16:41 -08:00
Daniel Imms f4a31251cb handle -> activate 2020-02-07 09:59:25 -08:00
Daniel Imms b18ded0e2d Rename tooltip to hover/leave 2020-02-07 09:55:06 -08:00
Daniel Imms c327116e7f url -> text 2020-02-07 09:39:26 -08:00