Commit Graph
47 Commits
Author SHA1 Message Date
Daniel Imms 66efb0388a Move prop to top 2022-09-24 11:57:12 -07:00
Daniel Imms 4ac5a91c95 Make DebouncedIdleTask helper 2022-09-24 11:56:46 -07:00
Daniel Imms 4e8e6b9788 Defer paused renderer resize to idle callback 2022-09-24 11:45:48 -07:00
Mihai Parparita a39a468f19 Make terminal rendering work in popout windows
Add support for the parent element (what is passed to Terminal.open)
being in a different (same origin) window. Accesses to DOM APIs such
as requestAnimationFrame and devicePixelRatio thus need to be scoped
to the corrent window, instead of assuming that it's the same as the
window/global scope where the code is running.

This is done by inferring a parent window at the creation time, and
then storing it in CoreBrowserService, which is already passed to most
places that need it.

To catch future regressions, an ESLint rule that checks for global
accesses is added (it uses AST selectors via the no-restricted-syntax
rule).

This should also be applicable when the parent element is an iframe.

Fixes #3758
2022-09-08 16:59:31 -07:00
Daniel Imms 4a6e7bee21 Fix lgtm recommendations 2022-08-30 14:09:39 -07:00
Megan Rogge a5f2ea336e update search results onBufferContentsChange (#3811) 2022-05-17 10:00:55 -07:00
Megan Rogge de5df69333 share animation frame with renderService (#3796) 2022-05-17 09:52:46 -07:00
Daniel Imms 900200b871 Merge remote-tracking branch 'upstream/master' into 3773 2022-05-13 08:46:05 -07:00
Daniel Imms 3d41f028e4 Layout dimension left/right after renderer dims change
Fixes #3773
2022-05-11 10:12:48 -07:00
Daniel Imms 324ea2ecb7 Clean up/resolve todos 2022-05-11 09:54:40 -07:00
Daniel Imms de574a27fc Full re-render when there are decoration changes 2022-05-10 05:44:00 -07:00
meganrogge 1f60a398b2 on render, fire when height has changed (was 0) 2022-03-22 15:04:22 -04:00
Daniel Imms fea1079b1e Force clear of the glyph renderer when switching
Fixes #3617
2022-02-03 08:33:22 -08:00
Daniel Imms 189ff56224 Add API to clear canvas renderer texture atlas
Fixes #3455
2021-09-22 06:38:47 -07:00
Samuel Sampson f1849cafaf Introduce IRenderDebouncer interface, unifying RenderDebouncer and TimeBasedDebouncer types 2021-08-17 20:50:47 +00:00
Daniel Imms 999116c536 Convert CharacterJoinerRegistry to a service
Part of #3094, #3283
2021-04-02 07:43:39 -07:00
jeanp413 350f6cfea1 Fixes https://github.com/microsoft/vscode/issues/102194 2021-02-05 11:15:39 -05:00
Tony Brix 3d9a33bb69 move measure before refreshRows 2020-10-25 10:59:30 -05:00
Daniel Imms 49d5608fa6 Define member bar in ctor 2020-09-11 05:29:24 -07:00
Tony Brix 9513c231c9 fix: rerender hidden terminal when visible 2020-09-11 00:42:18 -05:00
Andrew Schlackman 0abd121653 fix renderer pause again with handling of undefined 2020-07-12 10:07:47 -04:00
Daniel Imms 70e0c0385a Revert "fix renderer pausing inadvertently in some cases"
This reverts commit 5738f4545f.
2020-07-10 12:14:59 -07:00
Andrew Schlackman 5738f4545f fix renderer pausing inadvertently in some cases 2020-07-09 16:20:37 -04:00
Daniel Imms 6a0f7b0713 Fix exception when disposing Terminal twice
Fixes #2933
2020-05-15 10:58:09 -07:00
Daniel Imms 06b8d36cf0 Fix other leaking listeners 2020-05-03 14:37:20 -07:00
Daniel Imms bdb438972f Fix errors in Terminal and elsewhere
This was mostly ! to compel TS, we should actually fix this down the road
but that can come later.
2020-04-26 10:44:44 -07:00
Daniel Imms 6f9730c652 Merge branch 'master' into layers2 2020-04-26 08:14:47 -07:00
Daniel Imms 3a1a0d6590 Remove input handler Terminal.resize dep 2020-04-26 06:34:36 -07:00
Daniel Imms 9346eba2f2 Remove Terminal.showCursor dep from input handler 2020-04-25 16:18:43 -07:00
Daniel Imms 353a8c5388 Create CoreTerminal, fix createInstance in strict mode 2020-04-25 10:21:56 -07:00
Daniel Imms c185529ad5 Make sure selection gets redrawn when switching renderers
Fixes #2555
2020-04-25 07:11:43 -07:00
Daniel Imms 3a5def98e5 Correct selection types being optional 2020-04-25 06:56:00 -07:00
Daniel Imms 1472e7b051 Merge branch 'master' into 2824 2020-04-14 06:25:06 -07:00
Daniel Imms 9817754f92 Fix explicit access 2020-04-14 06:23:11 -07:00
Daniel Imms 04c1e4b57d Remove readonly from ctors 2020-04-14 06:03:31 -07:00
Daniel Imms 309bdf3d70 Rename onRender 2020-04-11 09:53:32 -07:00
Daniel Imms 55f9203f60 Only fire IRenderService.onRender when buffer changes occurred
Fixes #2836
2020-04-11 09:51:28 -07:00
Daniel Imms 22f4342194 Move options row refresh into render service 2019-11-09 10:07:24 -08:00
Daniel Imms 1e1038b2c7 Remove renderer circular dep on renderservice
Also fix super.dispose not being called correctly on RenderService
2019-11-07 18:09:40 -08:00
Daniel Imms dd42eccb91 Fix dom -> canvas renderer switch not drawing viewport
Fixes #2204
2019-08-10 17:51:17 -07:00
Daniel Imms cdefb3e7f2 Remove more terminal from render layers and cache 2019-07-14 12:07:43 -07:00
Daniel Imms a0e2c9b270 Fix naming issue with serviceBrand 2019-07-13 23:45:25 -07:00
Daniel Imms 88c88f1141 Adopt DI in browser services 2019-07-13 22:26:13 -07:00
Daniel Imms 29db1a2b2b Refresh viewport after setting renderer and set correct end refresh row 2019-06-15 14:44:05 -07:00
Daniel Imms e53cae8c69 Fix screen dpr change not refreshing canvas renderer 2019-06-14 20:37:58 -07:00
Daniel Imms 80ce33f9ef Rename EventEmitter2 to EventEmitter
Fixes #2029
2019-06-08 21:33:02 -07:00
Daniel Imms 54d7bb0b38 Move RenderService into browser 2019-06-08 19:26:31 -07:00