Daniel Imms
0b54c9a5d6
Add trace log level, traceCall decorator and use in webgl
...
- New 'trace' log level in the API, you should expect very spammy logs when
trace is on and filter them down. As opposed to 'debug' which should be more
readable.
- traceCall decorator logs the args and return value of the decorated method.
Wecan use this on key functions in various parts of the code to assist
debugging issues that are hard to reproduce such as #4665 .
- Decorated a few webgl render methods for #4665 .
- There's an early exit in traceCall when not on the trace log level so the
runtime impact when not in trace is negligable.
Part of #4665
2023-08-18 11:04:23 -07:00
Daniel Imms
c908eeed5c
Merge pull request #4667 from Dennnnny/fix-transparent-foreground-color
...
Fix transparent foreground color
2023-08-14 12:11:04 -07:00
dennnnny
855e911398
Fix transparent foreground color
2023-08-14 09:49:18 +08:00
Daniel Imms
1cef30cca0
Enforce half minimum contrast ratio for dim text
...
Provided MCR is not too high, this ensures dim text differs from normal
text and has a reasonable difference in contrast.
Fixes #4262
2023-08-13 11:27:57 -07:00
dennnnny
bef87403db
Fix force transparent foreground colors to be opaque
2023-08-13 17:52:49 +08:00
Daniel Imms
530f758905
Restrict comments to 100 characters
...
This is a rule I try enforce in PR but it's a bit of a hassle, this will
give a lint warning when it happens resulting in:
- Yellow underline in supported editors when eslint is installed
- Compilation will succeed since it's a warning not an error
- CI will fail as it does not allow lint warnings
Special case comments are ignored which includes @vt comments, table
comments and commented out code.
2023-08-12 09:04:41 -07:00
dennnnny
fb7349bc87
Fix transparent foreground color
2023-08-12 08:39:39 +08:00
Daniel Imms
07d187151e
Update src/browser/renderer/shared/TextureAtlas.ts
2023-08-11 09:50:22 -07:00
tisilent
f317b96262
Fix canvas underline is cut off.
2023-08-11 17:58:29 +08:00
tisilent
b8bf35be17
Add restrictToCellHeight,Restore abnormal format
2023-08-09 11:53:30 +08:00
tisilent
3ba579f680
fix double underline, upwards
2023-08-08 18:36:44 +08:00
Daniel Imms
cdec1e5b03
Merge pull request #4526 from Tyriar/4499_overline
...
Add support for SGR 53 overline and SGR 55 not overline
2023-05-20 14:21:22 -07:00
Daniel Imms
eb56356133
Don't dodge overline, simplify drawing
2023-05-20 10:04:14 -07:00
Daniel Imms
2bfd95fe54
Add support for SGR 53, 55 overline
...
Specced in ECMA-48
2023-05-20 09:56:56 -07:00
Daniel Imms
e9b0593298
Merge pull request #4525 from Tyriar/4161_dim
...
Don't apply dim to background color
2023-05-20 09:43:16 -07:00
Daniel Imms
539fed4daa
Don't apply dim to background color
...
Fixes #4161
2023-05-20 08:13:50 -07:00
Daniel Imms
8c9e44c219
Disallow glyphs to exceed atlas texture size
...
Fixes #4507
2023-05-09 07:35:41 -07:00
Daniel Imms
56734874ac
Include right part of wide char in underline gap
...
Fixes #4096
2022-12-24 07:30:26 -08:00
Daniel Imms
d17df65fad
Improve rendering of dotted underlines
...
Fixes #4060
2022-12-23 14:04:12 -08:00
Daniel Imms
1880399849
dirtyId -> version
2022-11-23 08:51:06 -08:00
Jean Pierre
d4ee0309d9
Fixes https://github.com/microsoft/vscode/issues/166158
2022-11-22 00:07:23 -05:00
Daniel Imms
97a0df260b
Remove unused event
2022-11-03 05:44:50 -07:00
Daniel Imms
d82da195f3
Remove atlas pages from demo when they're merged
2022-11-02 06:02:53 -07:00
Daniel Imms
c22e684904
Fix exception when last 4 smallest pages are merged
2022-11-02 05:40:13 -07:00
Daniel Imms
6406fd79c1
Enforce a maximum page merge amount
2022-11-02 05:28:47 -07:00
Daniel Imms
0271fdf49d
Merge 4 largest pages
2022-11-02 04:49:02 -07:00
Daniel Imms
805b41b80f
Keep merging default texture size pages
2022-11-01 10:26:48 -07:00
Daniel Imms
c9bacc80d7
Merge when max atlas pages is reached
2022-11-01 10:08:00 -07:00
Daniel Imms
54ee698ba6
Basic merging working
...
Part of #4243
2022-11-01 09:07:38 -07:00
Daniel Imms
4d05905736
Polish
2022-10-30 18:11:24 -07:00
Daniel Imms
e092ca70e1
Simplify page reuse/creation
2022-10-30 10:33:38 -07:00
Daniel Imms
0592837620
Fill pages to capacity
2022-10-30 10:21:17 -07:00
Daniel Imms
fc03a1698b
Share page creation code
2022-10-30 10:16:48 -07:00
Daniel Imms
c9ef4a8eb9
Increase texture size as it nears the maximum texture unit
...
#4243 would be a better, but more complicated, solution to this
2022-10-30 09:20:17 -07:00
Daniel Imms
846573bb01
Support up to maximum texture units (eg. 16 on my machine)
2022-10-30 03:16:29 -07:00
Daniel Imms
3f2ed42e73
Fix glyphs getting clipped on bottom row
2022-10-29 20:57:42 -07:00
Daniel Imms
2a3c2d9520
Make better use of atlas space
2022-10-29 20:33:27 -07:00
Daniel Imms
5e95475d6b
Use current row when filling in old atlas pages
2022-10-29 19:50:44 -07:00
Daniel Imms
57a65e0858
Continute filling atlas page after new pages are added
2022-10-29 19:44:12 -07:00
Daniel Imms
bfa9dd5060
Clean up
2022-10-29 18:09:18 -07:00
Daniel Imms
c257a7247e
Only upload textures that change
2022-10-29 13:27:33 -07:00
Daniel Imms
0a49a5dde1
Make texture atlas presentation nicer for multiple pages
2022-10-29 13:01:41 -07:00
Daniel Imms
713baeb64d
Base atlas page size on device pixel ratio
2022-10-29 12:45:20 -07:00
Daniel Imms
efba2c9040
Get pages working, add to demo
2022-10-28 19:30:42 -07:00
Daniel Imms
67ef455515
Get a second page kind of working
2022-10-28 19:20:26 -07:00
Daniel Imms
975d52fab9
Remove deprecated prop
2022-10-28 19:12:01 -07:00
Daniel Imms
6b37187b4d
Create AtlasPage
2022-10-28 19:08:33 -07:00
Daniel Imms
84ab6a49c4
Bring texturePage partially to atlas
2022-10-28 18:56:49 -07:00
Daniel Imms
67b3faef01
Use bbox padding and width consistently
2022-10-28 09:01:22 -07:00
Daniel Imms
8b545a3fe4
Fix bbox right scan start offset
...
This causes particularly wide glyphs like italic emoji to get clipped
even if they're within the allowed padding.
Fixes #4229
2022-10-28 08:57:41 -07:00
Daniel Imms
dennnnny
tisilent
Jean Pierre