Commit Graph
100 Commits
Author SHA1 Message Date
Daniel Imms 86ccd709bf Avoid setting uniforms every frame 2022-10-29 14:26:51 -07:00
Daniel Imms c257a7247e Only upload textures that change 2022-10-29 13:27:33 -07:00
Daniel Imms 0a49a5dde1 Make texture atlas presentation nicer for multiple pages 2022-10-29 13:01:41 -07:00
Daniel Imms c6e3cc007c Stop atlas flickering on demo 2022-10-29 12:49:11 -07:00
Daniel Imms 713baeb64d Base atlas page size on device pixel ratio 2022-10-29 12:45:20 -07:00
Daniel Imms efba2c9040 Get pages working, add to demo 2022-10-28 19:30:42 -07:00
Daniel Imms 67ef455515 Get a second page kind of working 2022-10-28 19:20:26 -07:00
Daniel Imms 975d52fab9 Remove deprecated prop 2022-10-28 19:12:01 -07:00
Daniel Imms 6b37187b4d Create AtlasPage 2022-10-28 19:08:33 -07:00
Daniel Imms 84ab6a49c4 Bring texturePage partially to atlas 2022-10-28 18:56:49 -07:00
Daniel Imms 4ebc75aae0 Merge remote-tracking branch 'upstream/master' into multi_page_atlas 2022-10-28 18:42:46 -07:00
Daniel Imms 54335ef54a Create texture page attribute 2022-10-28 18:16:55 -07:00
Daniel Imms 43d8db77f9 Merge pull request #4239 from Tyriar/4224_mcr_canvas_ydisp
Correctly offset mcr check on canvas renderer
2022-10-28 14:10:25 -07:00
Daniel Imms b0672aac09 Correctly offset mcr check on canvas renderer
Fixes #4224
2022-10-28 14:02:58 -07:00
Daniel Imms fcf378b172 Merge pull request #4237 from Tyriar/italic_bounds
Fix clipping of italic emoji
2022-10-28 09:12:07 -07:00
Daniel Imms 25551a4b98 Merge pull request #4236 from Tyriar/console_image
Add console.image helper
2022-10-28 09:04:37 -07:00
Daniel Imms 67b3faef01 Use bbox padding and width consistently 2022-10-28 09:01:22 -07:00
Daniel Imms 8b545a3fe4 Fix bbox right scan start offset
This causes particularly wide glyphs like italic emoji to get clipped
even if they're within the allowed padding.

Fixes #4229
2022-10-28 08:57:41 -07:00
Daniel Imms 4f4ce0146d Add console.image helper
This is useful for printing canvases that aren't attached to the DOM
2022-10-28 08:54:57 -07:00
Daniel Imms e7b347a2ef Merge pull request #4235 from Tyriar/opt_server_buffer
Avoid GC pressure from server data buffer
2022-10-27 22:41:07 -07:00
Daniel Imms 7908b7cf62 Avoid GC pressure from server data buffer 2022-10-27 22:30:46 -07:00
Daniel Imms 392f8e9c98 Merge pull request #4234 from Tyriar/slow_isFocused
Cache ICoreBrowserService.isFocused per task
2022-10-27 17:00:18 -07:00
Daniel Imms b5cd4f1492 Cache ICoreBrowserService.isFocused per task
This is called for every selected cell when rendering which ends up
consuming a bunch of CPU due to the DOM calls.
2022-10-27 16:50:45 -07:00
Daniel Imms 4edfc12cbf Merge pull request #4233 from Tyriar/4113_resize
Fix resize in demo
2022-10-27 14:03:17 -07:00
Daniel Imms 19c1ee56d3 Fix resize in demo
A double resize could happen due to the mismatch in canvas vs device
pixel widths

Fixes #4113
2022-10-27 13:55:24 -07:00
Daniel Imms a4f8b07a7f Merge pull request #4226 from Tyriar/dropped_frames
Fix dropped frame issue
2022-10-21 13:10:30 -07:00
Daniel Imms 8d4d5bd54b Fix dropped frame issue
This ensures decorations are refreshed in the same frame when called from
an animation frame callback

Fixes #4225
2022-10-21 13:02:24 -07:00
Daniel Imms d5710afcb3 Merge pull request #4219 from Tyriar/4218_safari_bitmap
Disable canvas ImageBitmap optimization on Safari
2022-10-19 10:58:43 -07:00
Daniel Imms 8bd8195e30 Disable canvas ImageBitmap optimization on Safari
Fixes #4218
2022-10-19 10:03:01 -07:00
Daniel Imms ffe066dfef Merge pull request #4217 from Nokel81/fix-dom-renderering-jsdom-v2
Change clearing innerText to using replaceChildren to fix testing using jsdom
2022-10-19 07:21:30 -07:00
Daniel Imms 376f0d9972 Merge pull request #4211 from hackermondev/patch-1
replit branding change
2022-10-17 07:45:06 -07:00
Daniel Imms 3f12d2925a Merge pull request #4208 from Tyriar/todo_attach_socket
Warn/throw on unexpected attach addon socket state
2022-10-17 03:48:31 -07:00
Daniel Imms 8e65ee8832 Merge pull request #4210 from Tyriar/todo_type_tabs
Fix a bunch of TODOs
2022-10-16 07:15:19 -07:00
Daniel Imms a7f0c3868c Merge pull request #4209 from Tyriar/todo_onData_event_test
Re-enable onData event test
2022-10-16 07:08:59 -07:00
Daniel Imms 96486c414b Acquire char size service better in webgl renderer 2022-10-16 07:04:34 -07:00
Daniel Imms b560d85553 Remove unneeded params as link provider is stable 2022-10-16 07:04:24 -07:00
Daniel Imms 7796b4101a Type Buffer.tabs 2022-10-16 06:58:20 -07:00
Daniel Imms a982484392 Re-enable onData event test 2022-10-16 06:55:04 -07:00
Daniel Imms e15c6b9f3e Warn/throw on unexpected attach addon socket state 2022-10-16 06:49:27 -07:00
Daniel Imms 807183bba6 Merge pull request #4207 from Tyriar/3925_dimensions
Improve names of IRenderDimensions interface members
2022-10-16 06:41:37 -07:00
Daniel Imms dc19628014 Fix width -> height 2022-10-16 06:34:12 -07:00
Daniel Imms ca68a5c59a Fix typo in test 2022-10-15 20:13:24 -07:00
Daniel Imms 22e8a2f8e7 Remove old dimension properties 2022-10-15 18:07:05 -07:00
Daniel Imms 171ba446bd Update other files 2022-10-15 15:32:02 -07:00
Daniel Imms 89e0b87eac Move to device/css in domrenderer 2022-10-15 14:22:04 -07:00
Daniel Imms 2c9e711cae Move all other refs in webgl over 2022-10-15 13:55:36 -07:00
Daniel Imms b0f1c38fd2 Move all other refs in canvas over 2022-10-15 13:44:52 -07:00
Daniel Imms b393008b54 Use new render dimensions in canvasrenderer 2022-10-15 13:19:04 -07:00
Daniel Imms 65f41a151e Use new render dimensions in webglrenderer 2022-10-15 13:15:12 -07:00
Daniel Imms ddc4e75583 Add new dimensions properties, helper creation function
Part of #3925
2022-10-15 10:31:43 -07:00
Daniel Imms 869ce3aa35 Merge pull request #4194 from silamon/fixmissingline
Capture data between terminal creation and connected to terminal in demo
2022-10-15 10:17:51 -07:00
Daniel Imms 16ea621a5f Merge pull request #4206 from Tyriar/eslint-jsdoc
Add eslint-plugin-jsdoc with minimal comment rules
2022-10-15 08:55:07 -07:00
Daniel Imms 5204374494 Add no-multi-asterisks rule 2022-10-15 08:43:06 -07:00
Daniel Imms 9f1a71485c Fix invalid jsdoc tags 2022-10-15 08:41:49 -07:00
Daniel Imms 49e0480f78 Add rule jsdoc/check-alignment 2022-10-15 08:39:32 -07:00
Daniel Imms 114924f3fa Add eslint-plugin-jsdoc and enable check-param-names 2022-10-15 08:38:14 -07:00
Daniel Imms aeba140c75 Merge pull request #4204 from silamon/proposedApiCheck
Remove check proposed api checks
2022-10-15 08:04:12 -07:00
Daniel Imms aea7680f76 Merge pull request #4205 from Tyriar/triangle_strip
Draw quads with triangle strip
2022-10-15 08:02:07 -07:00
Daniel Imms fb4a4e6127 Draw quads with triangle strip
This reduces the number of needed vertices from 6 to 4, it may not have a
noticeable performance impact but it's less data and simpler
2022-10-15 07:54:31 -07:00
Daniel Imms 1e6dfec4ae Merge pull request #4201 from Tyriar/4197_2
Remove clipImageData completely
2022-10-13 06:34:37 -07:00
Daniel Imms 5285b9ac45 Merge branch 'master' into 4197_2 2022-10-13 06:25:59 -07:00
Daniel Imms 50d1834871 Remove clipImageData completely
putImageData works a little differently to drawImage which confused me
for a bit, you need to offset the destination as putImageData draws the
'dirty' parts of the texture using the same source image dimensions

Fixes #4197
2022-10-13 06:25:13 -07:00
Daniel Imms b1f785879b Merge pull request #4200 from Tyriar/4197
Optimize _clipImageData
2022-10-12 10:24:28 -07:00
Daniel Imms 28fcffe46c Optimize _clipImageData
This makes clip image data around twice as fast, it's a little tricky to
measure it though. Changes:

- Work on Uint32Array instead of Uint8 so it's 1 assignment per pixel
  instead of 1 per channel.
- Perform the clipping in-place using the original image data to avoid
  allocation a new buffer.

Fixes #4197
2022-10-12 10:16:26 -07:00
Daniel Imms 1b13127f0b Merge pull request #4195 from Tyriar/4190
Create onSpecificOptionChange and onMultipleOptionChange helpers
2022-10-09 11:04:59 -07:00
Daniel Imms a37ea14d10 Use options service in renderers 2022-10-09 10:57:49 -07:00
Daniel Imms 8d7137417b Split renderer safe vs unsafe api on activate 2022-10-09 10:12:19 -07:00
Daniel Imms e47296c1b9 Use options service directly in renderers 2022-10-09 09:28:18 -07:00
Daniel Imms 96b26b2e4a Merge pull request #4193 from silamon/fixdemoagain
Fix demo again
2022-10-09 09:23:07 -07:00
Daniel Imms 8ac88bc6bf Move Terminal option updates into owning components 2022-10-09 09:07:01 -07:00
Daniel Imms 7eead44048 Add onMultipleOptionChange 2022-10-09 08:14:56 -07:00
Daniel Imms 49a0904857 Move onSpecificOptionChange adoption 2022-10-09 08:07:43 -07:00
Daniel Imms 415100e8b8 Adopt onSpecificOptionChange 2022-10-09 07:46:10 -07:00
Daniel Imms cad9c4164c onOptionChange/onSpecificOptionChange tests 2022-10-09 07:16:56 -07:00
Daniel Imms a87b6c3f2e Implement IOptionsService.onSpecificOptionChange
Part of #4190
2022-10-09 07:09:35 -07:00
Daniel Imms a2a855d747 Merge pull request #4192 from silamon/ubuntudeprecation
Switch to Ubuntu 20.04
2022-10-09 06:25:11 -07:00
Daniel Imms 0ba12301a6 Merge pull request #4188 from Tyriar/4184
Create theme service
2022-10-08 15:51:44 -07:00
Daniel Imms 97e084aa50 Remove document from test 2022-10-08 15:44:21 -07:00
Daniel Imms e0fb3b4d19 Remove ColorManager 2022-10-08 15:23:29 -07:00
Daniel Imms a1050d1a11 Merge ColorManager into ThemeService 2022-10-08 15:20:15 -07:00
Daniel Imms 7f9e3b1225 Remove resolved todo 2022-10-08 14:09:00 -07:00
Daniel Imms 48f15cb543 Remove remaining setColors methods 2022-10-08 14:07:28 -07:00
Daniel Imms 6e35bcd767 Use theme service in more places 2022-10-08 13:55:23 -07:00
Daniel Imms 80e474c6ad Viewport listen to theme service 2022-10-08 13:31:31 -07:00
Daniel Imms 4dee0c5d4b Build out theme service more 2022-10-08 12:15:21 -07:00
Daniel Imms a22ad76bd8 Merge pull request #4189 from Tyriar/ensure_canvas_changed
Ensure stale bitmap is not used when drawing new characters
2022-10-08 12:04:27 -07:00
Daniel Imms 4f5154fd21 Ensure stale bitmap is not used when drawing new characters
This would cause a problem where the first time a glyph is used it would
not be visible because it was using the old invalidated bitmap.
2022-10-08 11:56:29 -07:00
Daniel Imms cc6def57e4 Use readonly color set in canvas addon 2022-10-08 11:46:41 -07:00
Daniel Imms c4750eaf77 Create basic theme service
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms 8db2244f5d Merge pull request #4187 from Tyriar/4183_on_naming
Lint rule for on=event emitter and rename all methods with on prefix to handle
2022-10-08 11:14:15 -07:00
Daniel Imms 5d8e4a0af4 Add lint rule to ensure _on prefix is only for event emitters 2022-10-08 11:05:52 -07:00
Daniel Imms eecf52e949 Add lint rule to ensure on prefix is only for event emitters
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms d8c31d7ad0 Merge pull request #4185 from Tyriar/4167_register_emitter
Fix a bunch of memory retention problems
2022-10-08 10:35:04 -07:00
Daniel Imms d8cf3af555 Fix Marker.dispose 2022-10-08 10:23:19 -07:00
Daniel Imms d3976c05f1 Fix marker dispose unit tests 2022-10-08 09:27:58 -07:00
Daniel Imms 94c3d11239 Fix compile 2022-10-08 09:11:28 -07:00
Daniel Imms 00f6d3a88c Register all event emitters, make some services disposable 2022-10-08 09:00:14 -07:00
Daniel Imms f61d8c91a3 Properly register disposables in SearchAddon 2022-10-08 08:30:39 -07:00
Daniel Imms ac659cb412 Prevent overriding of Disposable.dispose
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms 34475f24c3 Release canvas texture atlas 2022-10-08 08:11:28 -07:00