Daniel Imms
0b54c9a5d6
Add trace log level, traceCall decorator and use in webgl
...
- New 'trace' log level in the API, you should expect very spammy logs when
trace is on and filter them down. As opposed to 'debug' which should be more
readable.
- traceCall decorator logs the args and return value of the decorated method.
Wecan use this on key functions in various parts of the code to assist
debugging issues that are hard to reproduce such as #4665 .
- Decorated a few webgl render methods for #4665 .
- There's an early exit in traceCall when not on the trace log level so the
runtime impact when not in trace is negligable.
Part of #4665
2023-08-18 11:04:23 -07:00
Daniel Imms
70f6fa2bc9
Fix SortedList.values iteration and general dec lifecycle fixes
...
Fixes #4652
2023-08-13 10:42:45 -07:00
Daniel Imms
530f758905
Restrict comments to 100 characters
...
This is a rule I try enforce in PR but it's a bit of a hassle, this will
give a lint warning when it happens resulting in:
- Yellow underline in supported editors when eslint is installed
- Compilation will succeed since it's a warning not an error
- CI will fail as it does not allow lint warnings
Special case comments are ignored which includes @vt comments, table
comments and commented out code.
2023-08-12 09:04:41 -07:00
tisilent
482dad3036
Add cursorInactiveStyle option
2023-08-10 16:11:04 +08:00
Daniel Imms
44ced27bee
Add ignoreBracketedPasteMode option
...
Fixes #4588
2023-08-01 13:58:52 -07:00
Daniel Imms
e8a925b6af
Merge pull request #4583 from jerch/fix_mouse_tracking
...
fix mouse tracking behavior
2023-08-01 05:50:20 -07:00
Daniel Imms
1067ec19a8
Implement smooth scroll for pages/top/bottom, add viewport request event
2023-08-01 05:31:30 -07:00
Jörg Breitbart
65568f502e
fix #4582
2023-07-05 13:56:41 +02:00
Daniel Imms
4d501b38b8
Improve safety of log service
2023-06-16 10:30:54 -07:00
Daniel Imms
64a62fb0c1
Bind logger calls
2023-06-16 09:19:23 -07:00
Daniel Imms
2c45989fea
Merge pull request #4563 from Tyriar/logger
...
Add logger delegate option
2023-06-16 08:34:13 -07:00
Daniel Imms
f779e4ddc0
Add logger delegate option
...
This allows embedders to route the logs whereever they want, when this
is set the xterm.js prefix is excluded.
2023-06-16 08:23:22 -07:00
Daniel Imms
ffadc0b31d
Fix NPEs on buffer line and windowsPty option
2023-06-09 08:47:17 -07:00
Daniel Imms
22140b5e94
Add more granular windowsPty option
...
See microsoft/vscode#134448
2023-05-29 09:40:00 -07:00
Daniel Imms
c546f7cc8a
Ensure Decoration.isDisposed can be true
...
Fixes #4410
2023-03-31 12:11:50 -07:00
Daniel Imms
046d4b8314
Improve createInstance types
2023-02-01 08:42:51 -08:00
Daniel Imms
4ee4a0f988
Merge branch 'master' into cleanup_coreservice
2022-12-11 07:36:01 -08:00
Daniel Imms
d6b8a21219
Avoid passing circular callback into CoreService ctor
2022-12-11 07:35:11 -08:00
Jason Lin
9e84895141
polish
2022-12-07 10:12:43 +11:00
Jason Lin
73d20c1d3b
Add option scrollOnKeypress
...
Note that we also change the existing behavior a bit:
CoreService.triggerDataEvent() will not scroll to the bottom unless
`wasUserInput` is also true. This actually seems to be the intended
behavior according to the doc just above
ICoreService.triggerDataEvent().
2022-12-06 14:29:18 +11:00
Megan Rogge
0b84d17b18
revert decoration dispose changes ( #4215 )
2022-10-18 21:32:22 +00:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
7eead44048
Add onMultipleOptionChange
2022-10-09 08:14:56 -07:00
Daniel Imms
49a0904857
Move onSpecificOptionChange adoption
2022-10-09 08:07:43 -07:00
Daniel Imms
415100e8b8
Adopt onSpecificOptionChange
2022-10-09 07:46:10 -07:00
Daniel Imms
cad9c4164c
onOptionChange/onSpecificOptionChange tests
2022-10-09 07:16:56 -07:00
Daniel Imms
a87b6c3f2e
Implement IOptionsService.onSpecificOptionChange
...
Part of #4190
2022-10-09 07:09:35 -07:00
Daniel Imms
94c3d11239
Fix compile
2022-10-08 09:11:28 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd , reversing
changes made to 1f8e6f0952 .
2022-10-06 09:48:54 -07:00
Daniel Imms
f6a61acc86
Merge branch 'master' into feature/lint-by-putout
2022-10-04 09:52:10 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
969db2bcf9
Merge pull request #4163 from Tyriar/4147
...
Inline dirty row service into input handler
2022-10-01 08:28:29 -07:00
Daniel Imms
8e378c07e9
Merge pull request #4165 from Tyriar/4164
...
Define all events and emitters consistently
2022-10-01 08:28:18 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Daniel Imms
3a90f7e7c0
Inline dirty row service into input handler
...
Fixes #4147
2022-10-01 07:39:02 -07:00
Daniel Imms
52ed65d7bd
Move w objects to $ prefix variables
...
Fixes #4138
2022-10-01 07:26:07 -07:00
coderaiser
bbff3e8396
Update src/common/services/InstantiationService.ts
2022-09-15 22:52:50 +03:00
coderaiser
25eb7d6472
chore: lint using 🐊 Putout
2022-09-15 17:19:34 +03:00
Daniel Imms
e8e2f16cff
Merge remote-tracking branch 'upstream/master' into pr/silamon/4004
2022-09-02 13:05:52 -07:00
Jörg Breitbart
06d6e08347
sgr_pixels mouse report
2022-09-01 00:50:11 +02:00
Daniel Imms
4a6e7bee21
Fix lgtm recommendations
2022-08-30 14:09:39 -07:00
Daniel Imms
3f3fc183f4
Merge branch 'master' into 1134_3
2022-08-30 05:53:36 -07:00
Daniel Imms
0727741ca1
Remove iterators from IDecorationService
...
They're too low performance for typical use cases
Fixes #4079
2022-08-27 20:50:16 -07:00
Daniel Imms
5e3f63e876
Avoid garbage collection in webgl decoration hot code
...
Part of #4079
2022-08-27 20:06:58 -07:00
Daniel Imms
2cfbee413f
Add some OscLinkService unit tests
2022-08-07 11:30:08 -07:00
Daniel Imms
8191483fbd
Evict links from maps when markers are disposed
2022-08-07 08:05:42 -07:00
Daniel Imms
d9b8c6a838
linkHandler option and default handler
2022-08-07 07:35:46 -07:00