Daniel Imms
70f6fa2bc9
Fix SortedList.values iteration and general dec lifecycle fixes
...
Fixes #4652
2023-08-13 10:42:45 -07:00
Daniel Imms
d8cf3af555
Fix Marker.dispose
2022-10-08 10:23:19 -07:00
Daniel Imms
d3976c05f1
Fix marker dispose unit tests
2022-10-08 09:27:58 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd , reversing
changes made to 1f8e6f0952 .
2022-10-06 09:48:54 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Jörg Breitbart
f5a4eed27c
add super.dispose, add oDispose to API
2020-09-27 15:59:11 +02:00
Daniel
67e5974eee
Set disposed marker line to -1
...
Another indicator that it's disposed/invalid
2019-10-25 04:04:17 -07:00
Daniel Imms
80ce33f9ef
Rename EventEmitter2 to EventEmitter
...
Fixes #2029
2019-06-08 21:33:02 -07:00
Daniel Imms
f8e7ff24d9
Merge core into common
...
Part of #1507
2019-06-08 16:09:27 -07:00