Daniel Imms
1b13127f0b
Merge pull request #4195 from Tyriar/4190
...
Create onSpecificOptionChange and onMultipleOptionChange helpers
2022-10-09 11:04:59 -07:00
Daniel Imms
a37ea14d10
Use options service in renderers
2022-10-09 10:57:49 -07:00
Daniel Imms
e47296c1b9
Use options service directly in renderers
2022-10-09 09:28:18 -07:00
Daniel Imms
8ac88bc6bf
Move Terminal option updates into owning components
2022-10-09 09:07:01 -07:00
Daniel Imms
7eead44048
Add onMultipleOptionChange
2022-10-09 08:14:56 -07:00
Daniel Imms
49a0904857
Move onSpecificOptionChange adoption
2022-10-09 08:07:43 -07:00
Simon Lamon
1c345bef48
Handle onWillFire if it fails, so it loads dom renderer
2022-10-09 15:01:15 +00:00
Daniel Imms
415100e8b8
Adopt onSpecificOptionChange
2022-10-09 07:46:10 -07:00
Daniel Imms
e0fb3b4d19
Remove ColorManager
2022-10-08 15:23:29 -07:00
Daniel Imms
a1050d1a11
Merge ColorManager into ThemeService
2022-10-08 15:20:15 -07:00
Daniel Imms
7f9e3b1225
Remove resolved todo
2022-10-08 14:09:00 -07:00
Daniel Imms
48f15cb543
Remove remaining setColors methods
2022-10-08 14:07:28 -07:00
Daniel Imms
6e35bcd767
Use theme service in more places
2022-10-08 13:55:23 -07:00
Daniel Imms
80e474c6ad
Viewport listen to theme service
2022-10-08 13:31:31 -07:00
Daniel Imms
4dee0c5d4b
Build out theme service more
2022-10-08 12:15:21 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
5d8e4a0af4
Add lint rule to ensure _on prefix is only for event emitters
2022-10-08 11:05:52 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
d3976c05f1
Fix marker dispose unit tests
2022-10-08 09:27:58 -07:00
Daniel Imms
94c3d11239
Fix compile
2022-10-08 09:11:28 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms and Megan Rogge
c4eef2f470
Fix race condition that could when clearing atlas on 2+ terminals
...
This is the proper fix for microsoft/vscode#162996 , after a bunch of
investigation we found that this is causing the problem:
VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.
Co-Authored-By: Megan Rogge <merogge@microsoft.com >
2022-10-07 16:17:11 -07:00
Daniel Imms
ffa4d921bb
Merge remote-tracking branch 'upstream/master' into renderer_before_open
2022-10-07 10:10:24 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd , reversing
changes made to 1f8e6f0952 .
2022-10-06 09:48:54 -07:00
Daniel Imms
e0324e32a8
Bring back ImageBitmap optimization in canvas renderer
...
It's more simple than it used to be, it will clear and debounce all
glyphs when any change is made.
2022-10-04 15:24:10 -07:00
Daniel Imms
622acaaad7
Remove old selection start/end values
2022-10-04 14:45:19 -07:00
Daniel Imms
0d7e18d236
Add CellColorResolver to share load color code
2022-10-04 14:41:27 -07:00
Daniel Imms
83c09c34db
Share selection render model code
2022-10-04 14:23:09 -07:00
Daniel Imms
03e3105c55
Fix fg/bg overrides in canvas
2022-10-04 14:10:27 -07:00
Daniel Imms
c5d015c908
Merge branch 'master' into shared_cache
2022-10-04 13:54:14 -07:00
Daniel Imms
f6a61acc86
Merge branch 'master' into feature/lint-by-putout
2022-10-04 09:52:10 -07:00
Daniel Imms
6316eee672
Comment out debug log
2022-10-02 21:32:24 -07:00
Daniel Imms
dbef850039
Hook up attributes to new texture atlas
2022-10-02 13:57:35 -07:00
Daniel Imms
590a8219e3
Merge remote-tracking branch 'upstream/master' into shared_cache
2022-10-02 13:42:44 -07:00
Daniel Imms
f38a49b4d5
Move remaining webgl atlas to shared
2022-10-02 08:48:55 -07:00
Daniel Imms
333b0e28ac
Add ITextureAtlas and use that instead of WebglCharAtlas
2022-10-02 07:48:43 -07:00
Daniel Imms
d669c6e9d6
Fix remaining references
2022-10-01 18:03:43 -07:00
Daniel Imms
c5f9eacbb1
Move other render parts to shared folder
2022-10-01 17:41:16 -07:00
Daniel Imms
6fcc496547
Move cache utils to core shared/ folder
...
Part of #4065
2022-10-01 17:36:16 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Daniel Imms
23328a394b
Fix trusted types in dom renderer
...
Fixes #4156
2022-09-27 13:01:36 -07:00
Daniel Imms
c548977a3e
Fix imports
2022-09-24 16:16:14 -07:00
Daniel Imms
2febe19222
Set renderer after screen element is attached to dom
2022-09-24 14:42:57 -07:00
Daniel Imms
693d09cbad
Allow setting renderer addon before open is called
2022-09-24 14:41:48 -07:00
Daniel Imms
66efb0388a
Move prop to top
2022-09-24 11:57:12 -07:00
Daniel Imms
4ac5a91c95
Make DebouncedIdleTask helper
2022-09-24 11:56:46 -07:00
Daniel Imms
4e8e6b9788
Defer paused renderer resize to idle callback
2022-09-24 11:45:48 -07:00