Daniel Imms
921da1a2ea
Ignore no-unused-vars in .api, organize all remaining imports
2023-08-23 04:47:53 -07:00
Daniel Imms
d03b5c9481
Track CursorBlinkStateManager in MutableDisposable
...
Fixes #4685
2023-08-18 14:26:56 -07:00
Daniel Imms
0b54c9a5d6
Add trace log level, traceCall decorator and use in webgl
...
- New 'trace' log level in the API, you should expect very spammy logs when
trace is on and filter them down. As opposed to 'debug' which should be more
readable.
- traceCall decorator logs the args and return value of the decorated method.
Wecan use this on key functions in various parts of the code to assist
debugging issues that are hard to reproduce such as #4665 .
- Decorated a few webgl render methods for #4665 .
- There's an early exit in traceCall when not on the trace log level so the
runtime impact when not in trace is negligable.
Part of #4665
2023-08-18 11:04:23 -07:00
Daniel Imms
dc390ab03a
Merge pull request #4657 from tisilent/add-cursorInactiveStyle-option
...
Add cursorInactiveStyle option
2023-08-11 13:16:51 -07:00
Daniel Imms
6f6cc6a686
Remove string mapping, improve types, standardize on 'outline'
2023-08-11 13:09:31 -07:00
tisilent
5c1e6dce99
Add block to cursorInactiveStyle,
...
change line to bar
2023-08-11 11:36:40 +08:00
Svante Boberg
3b3012353f
Use disposable registration
2023-08-10 19:04:20 +02:00
Svante Boberg
adad53d526
Dispose blink state manager
2023-08-10 18:47:04 +02:00
tisilent
482dad3036
Add cursorInactiveStyle option
2023-08-10 16:11:04 +08:00
Daniel Imms
41e97ec042
Always render cursor even if model didn't change
...
This ensures underline/bar cursors get rendered
2023-08-01 07:43:27 -07:00
Daniel Imms
f64cb1566d
Correctly apply cursor colors in new renderer
2023-08-01 06:31:58 -07:00
Daniel Imms
9b204c012a
Remove bad logs
2023-08-01 06:19:54 -07:00
Daniel Imms
6b33ac1e85
Share cursor blink state manager between canvas and webgl
...
This also focused the manager's creation on renderer start up, to ensure blink
works immediately.
2023-08-01 06:13:21 -07:00
Albert Safin
064fe0cfd9
Render the cursor in the WebGL canvas
2023-06-18 06:34:14 +00:00
Jörg Breitbart
f270127ce5
fix webgl part of #4480
2023-05-21 16:32:57 +02:00
Megan Rogge
8a1faed5cb
ensure line is defined via clamp ( #4403 )
2023-02-07 21:03:06 +00:00
Daniel Imms
9c815250b6
Handle glyph/rect renderer safer
...
See microsoft/vscode#172782
2023-01-31 11:14:33 -08:00
Daniel Imms
8b1c5c4ffb
Revert "Fix NPE in webgl renderer"
...
This reverts commit ea7571c2b9 .
2022-12-21 16:51:45 -08:00
Daniel Imms
0981ca8796
Merge pull request #4328 from Tyriar/vscode166909
...
Remove ! to improve safety
2022-12-16 11:16:17 -08:00
Daniel Imms
ffeaa2b976
Remove ! to improve safety
...
See microsoft/vscode#166909
This doesn't necessarily fix that, but it does remove the hacky ! which could
potentially let an error slip past TS.
2022-12-16 11:05:03 -08:00
Daniel Imms
ea7571c2b9
Fix NPE in webgl renderer
...
Theory is this can happen when a resize down happens as end will be too big
See microsoft/vscode#166878
2022-12-16 10:42:05 -08:00
Daniel Imms
02d3ef599a
Fix internal usages that needed Required<ITerminalOptions>
2022-12-11 11:42:14 -08:00
Daniel Imms
97a0df260b
Remove unused event
2022-11-03 05:44:50 -07:00
Daniel Imms
d82da195f3
Remove atlas pages from demo when they're merged
2022-11-02 06:02:53 -07:00
Daniel Imms
6406fd79c1
Enforce a maximum page merge amount
2022-11-02 05:28:47 -07:00
Daniel Imms
dda3f5f545
Properly dispose of atlas event
2022-10-30 15:00:27 -07:00
Daniel Imms
c9ef4a8eb9
Increase texture size as it nears the maximum texture unit
...
#4243 would be a better, but more complicated, solution to this
2022-10-30 09:20:17 -07:00
Daniel Imms
efba2c9040
Get pages working, add to demo
2022-10-28 19:30:42 -07:00
Daniel Imms
975d52fab9
Remove deprecated prop
2022-10-28 19:12:01 -07:00
Daniel Imms
96486c414b
Acquire char size service better in webgl renderer
2022-10-16 07:04:34 -07:00
Daniel Imms
dc19628014
Fix width -> height
2022-10-16 06:34:12 -07:00
Daniel Imms
22e8a2f8e7
Remove old dimension properties
2022-10-15 18:07:05 -07:00
Daniel Imms
2c9e711cae
Move all other refs in webgl over
2022-10-15 13:55:36 -07:00
Daniel Imms
65f41a151e
Use new render dimensions in webglrenderer
2022-10-15 13:15:12 -07:00
Daniel Imms
ddc4e75583
Add new dimensions properties, helper creation function
...
Part of #3925
2022-10-15 10:31:43 -07:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
a37ea14d10
Use options service in renderers
2022-10-09 10:57:49 -07:00
Daniel Imms
e47296c1b9
Use options service directly in renderers
2022-10-09 09:28:18 -07:00
Daniel Imms
48f15cb543
Remove remaining setColors methods
2022-10-08 14:07:28 -07:00
Daniel Imms
6e35bcd767
Use theme service in more places
2022-10-08 13:55:23 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
8116e035b4
Register webgl renderers
2022-10-08 08:06:43 -07:00
Daniel Imms
fc8043a25a
Ensure webgl texture atlas is released on dispose
2022-10-08 07:32:51 -07:00
Daniel Imms and Megan Rogge
c4eef2f470
Fix race condition that could when clearing atlas on 2+ terminals
...
This is the proper fix for microsoft/vscode#162996 , after a bunch of
investigation we found that this is causing the problem:
VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.
Co-Authored-By: Megan Rogge <merogge@microsoft.com >
2022-10-07 16:17:11 -07:00
Daniel Imms
e89c507d06
Fix clearTextureAtlas call as implemented on IRenderer
...
This is the root cause of microsoft/vscode#162996
2022-10-07 14:22:51 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd , reversing
changes made to 1f8e6f0952 .
2022-10-06 09:48:54 -07:00
Daniel Imms
0d7e18d236
Add CellColorResolver to share load color code
2022-10-04 14:41:27 -07:00
Daniel Imms
83c09c34db
Share selection render model code
2022-10-04 14:23:09 -07:00