Daniel Imms
8b1c5c4ffb
Revert "Fix NPE in webgl renderer"
...
This reverts commit ea7571c2b9 .
2022-12-21 16:51:45 -08:00
Daniel Imms
0981ca8796
Merge pull request #4328 from Tyriar/vscode166909
...
Remove ! to improve safety
2022-12-16 11:16:17 -08:00
Daniel Imms
ffeaa2b976
Remove ! to improve safety
...
See microsoft/vscode#166909
This doesn't necessarily fix that, but it does remove the hacky ! which could
potentially let an error slip past TS.
2022-12-16 11:05:03 -08:00
Daniel Imms
ea7571c2b9
Fix NPE in webgl renderer
...
Theory is this can happen when a resize down happens as end will be too big
See microsoft/vscode#166878
2022-12-16 10:42:05 -08:00
Daniel Imms
02d3ef599a
Fix internal usages that needed Required<ITerminalOptions>
2022-12-11 11:42:14 -08:00
Daniel Imms
97a0df260b
Remove unused event
2022-11-03 05:44:50 -07:00
Daniel Imms
d82da195f3
Remove atlas pages from demo when they're merged
2022-11-02 06:02:53 -07:00
Daniel Imms
6406fd79c1
Enforce a maximum page merge amount
2022-11-02 05:28:47 -07:00
Daniel Imms
dda3f5f545
Properly dispose of atlas event
2022-10-30 15:00:27 -07:00
Daniel Imms
c9ef4a8eb9
Increase texture size as it nears the maximum texture unit
...
#4243 would be a better, but more complicated, solution to this
2022-10-30 09:20:17 -07:00
Daniel Imms
efba2c9040
Get pages working, add to demo
2022-10-28 19:30:42 -07:00
Daniel Imms
975d52fab9
Remove deprecated prop
2022-10-28 19:12:01 -07:00
Daniel Imms
96486c414b
Acquire char size service better in webgl renderer
2022-10-16 07:04:34 -07:00
Daniel Imms
dc19628014
Fix width -> height
2022-10-16 06:34:12 -07:00
Daniel Imms
22e8a2f8e7
Remove old dimension properties
2022-10-15 18:07:05 -07:00
Daniel Imms
2c9e711cae
Move all other refs in webgl over
2022-10-15 13:55:36 -07:00
Daniel Imms
65f41a151e
Use new render dimensions in webglrenderer
2022-10-15 13:15:12 -07:00
Daniel Imms
ddc4e75583
Add new dimensions properties, helper creation function
...
Part of #3925
2022-10-15 10:31:43 -07:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
a37ea14d10
Use options service in renderers
2022-10-09 10:57:49 -07:00
Daniel Imms
e47296c1b9
Use options service directly in renderers
2022-10-09 09:28:18 -07:00
Daniel Imms
48f15cb543
Remove remaining setColors methods
2022-10-08 14:07:28 -07:00
Daniel Imms
6e35bcd767
Use theme service in more places
2022-10-08 13:55:23 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
8116e035b4
Register webgl renderers
2022-10-08 08:06:43 -07:00
Daniel Imms
fc8043a25a
Ensure webgl texture atlas is released on dispose
2022-10-08 07:32:51 -07:00
Daniel Imms and Megan Rogge
c4eef2f470
Fix race condition that could when clearing atlas on 2+ terminals
...
This is the proper fix for microsoft/vscode#162996 , after a bunch of
investigation we found that this is causing the problem:
VS Code clears the texture atlas on OS resume to fix an issue where the texture
could be corrupted. This calls clearTextureAtlas twice which should be fine, but
it's not because inside WebglRenderer.clear we're calling updateModel which is
meant to only ever be called in an animation frame. This calls potentially both
renderers to have stale views of the texture atlas for those rows and our perf
caching of cells (the main purpose of the model) doesn't know it's stale.
Co-Authored-By: Megan Rogge <merogge@microsoft.com >
2022-10-07 16:17:11 -07:00
Daniel Imms
e89c507d06
Fix clearTextureAtlas call as implemented on IRenderer
...
This is the root cause of microsoft/vscode#162996
2022-10-07 14:22:51 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd , reversing
changes made to 1f8e6f0952 .
2022-10-06 09:48:54 -07:00
Daniel Imms
0d7e18d236
Add CellColorResolver to share load color code
2022-10-04 14:41:27 -07:00
Daniel Imms
83c09c34db
Share selection render model code
2022-10-04 14:23:09 -07:00
Daniel Imms
03e3105c55
Fix fg/bg overrides in canvas
2022-10-04 14:10:27 -07:00
Daniel Imms
590a8219e3
Merge remote-tracking branch 'upstream/master' into shared_cache
2022-10-02 13:42:44 -07:00
Daniel Imms
0bc5ca8f80
Fix imports
2022-10-02 11:08:06 -07:00
Daniel Imms
f38a49b4d5
Move remaining webgl atlas to shared
2022-10-02 08:48:55 -07:00
Daniel Imms
333b0e28ac
Add ITextureAtlas and use that instead of WebglCharAtlas
2022-10-02 07:48:43 -07:00
Daniel Imms
c5f9eacbb1
Move other render parts to shared folder
2022-10-01 17:41:16 -07:00
Daniel Imms
2e8b793ba0
Format files
2022-10-01 08:56:56 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
8e378c07e9
Merge pull request #4165 from Tyriar/4164
...
Define all events and emitters consistently
2022-10-01 08:28:18 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Daniel Imms
52ed65d7bd
Move w objects to $ prefix variables
...
Fixes #4138
2022-10-01 07:26:07 -07:00
Mihai Parparita
a39a468f19
Make terminal rendering work in popout windows
...
Add support for the parent element (what is passed to Terminal.open)
being in a different (same origin) window. Accesses to DOM APIs such
as requestAnimationFrame and devicePixelRatio thus need to be scoped
to the corrent window, instead of assuming that it's the same as the
window/global scope where the code is running.
This is done by inferring a parent window at the creation time, and
then storing it in CoreBrowserService, which is already passed to most
places that need it.
To catch future regressions, an ESLint rule that checks for global
accesses is added (it uses AST selectors via the no-restricted-syntax
rule).
This should also be applicable when the parent element is an iframe.
Fixes #3758
2022-09-08 16:59:31 -07:00
Jason Lin
e5ad3ce9b9
Polish
2022-09-05 17:32:02 +10:00
Jason Lin
faf5f72c1f
Clear glyph render when the webgl model is cleared
2022-09-05 13:32:04 +10:00
Daniel Imms
e8e2f16cff
Merge remote-tracking branch 'upstream/master' into pr/silamon/4004
2022-09-02 13:05:52 -07:00
Daniel Imms
f309affff2
Tweak handling of _contextRestorationTimeout
2022-08-31 05:44:48 -07:00