Daniel Imms
5839accbf1
Use is prefix for boolean prop/getter
2023-02-02 06:12:04 -08:00
Megan Rogge
a9da61e605
accessibilityBuffer: textarea -> div & prevent mouse click from exiting ( #4389 )
2023-01-31 18:25:25 -06:00
Daniel Imms
41dc93a008
Prototype improved a11y buffer view ( #4340 )
2023-01-18 23:00:21 +00:00
Daniel Imms
880b726bcb
Merge pull request #4325 from Tyriar/4056
...
Fix canvas renderer selection not re-rendering sometimes
2022-12-16 09:39:28 -08:00
Daniel Imms
2bd9c4e839
Fix canvas renderer selection not re-rendering sometimes
...
Fixes #4056
2022-12-16 09:28:02 -08:00
Daniel Imms
0b5625581e
Merge pull request #4284 from JasonXJ/a11y-2
...
Fix a11y issues #4269
2022-12-16 08:57:55 -08:00
Jason Lin
9e84895141
polish
2022-12-07 10:12:43 +11:00
Jason Lin
73d20c1d3b
Add option scrollOnKeypress
...
Note that we also change the existing behavior a bit:
CoreService.triggerDataEvent() will not scroll to the bottom unless
`wasUserInput` is also true. This actually seems to be the intended
behavior according to the doc just above
ICoreService.triggerDataEvent().
2022-12-06 14:29:18 +11:00
Jason Lin
d177acccee
Fix a11y issues #4269
2022-12-02 18:35:09 +11:00
Daniel Imms
22e8a2f8e7
Remove old dimension properties
2022-10-15 18:07:05 -07:00
Daniel Imms
114924f3fa
Add eslint-plugin-jsdoc and enable check-param-names
2022-10-15 08:38:14 -07:00
Daniel Imms
1b13127f0b
Merge pull request #4195 from Tyriar/4190
...
Create onSpecificOptionChange and onMultipleOptionChange helpers
2022-10-09 11:04:59 -07:00
Daniel Imms
8ac88bc6bf
Move Terminal option updates into owning components
2022-10-09 09:07:01 -07:00
Daniel Imms
49a0904857
Move onSpecificOptionChange adoption
2022-10-09 08:07:43 -07:00
Simon Lamon
1c345bef48
Handle onWillFire if it fails, so it loads dom renderer
2022-10-09 15:01:15 +00:00
Daniel Imms
415100e8b8
Adopt onSpecificOptionChange
2022-10-09 07:46:10 -07:00
Daniel Imms
7f9e3b1225
Remove resolved todo
2022-10-08 14:09:00 -07:00
Daniel Imms
6e35bcd767
Use theme service in more places
2022-10-08 13:55:23 -07:00
Daniel Imms
80e474c6ad
Viewport listen to theme service
2022-10-08 13:31:31 -07:00
Daniel Imms
4dee0c5d4b
Build out theme service more
2022-10-08 12:15:21 -07:00
Daniel Imms
c4750eaf77
Create basic theme service
...
Part of #4184
2022-10-08 11:43:19 -07:00
Daniel Imms
5d8e4a0af4
Add lint rule to ensure _on prefix is only for event emitters
2022-10-08 11:05:52 -07:00
Daniel Imms
eecf52e949
Add lint rule to ensure on prefix is only for event emitters
...
Fixes #4183
2022-10-08 10:57:31 -07:00
Daniel Imms
00f6d3a88c
Register all event emitters, make some services disposable
2022-10-08 09:00:14 -07:00
Daniel Imms
ac659cb412
Prevent overriding of Disposable.dispose
...
A common mistake made was overriding dispose and not calling super.dispose,
so a TS trick is now used to move it to a readonly property instead of a
member method which prevents it being overridden.
2022-10-08 08:27:10 -07:00
Daniel Imms
ffa4d921bb
Merge remote-tracking branch 'upstream/master' into renderer_before_open
2022-10-07 10:10:24 -07:00
Daniel Imms
4d97729010
Revert "Merge pull request #4166 from Tyriar/event_with_emitter"
...
This reverts commit d22f7c9edd , reversing
changes made to 1f8e6f0952 .
2022-10-06 09:48:54 -07:00
Daniel Imms
590a8219e3
Merge remote-tracking branch 'upstream/master' into shared_cache
2022-10-02 13:42:44 -07:00
Daniel Imms
c5f9eacbb1
Move other render parts to shared folder
2022-10-01 17:41:16 -07:00
Daniel Imms
ed15a8e170
Create new event with emitter object to simplify code
2022-10-01 08:45:40 -07:00
Daniel Imms
1a22c44f2b
Make all emitters readonly
2022-10-01 08:02:32 -07:00
Daniel Imms
cf9949840b
Use readonly over getter for exposing events
...
Fixes #4164
2022-10-01 07:52:26 -07:00
Daniel Imms
2febe19222
Set renderer after screen element is attached to dom
2022-09-24 14:42:57 -07:00
Daniel Imms
693d09cbad
Allow setting renderer addon before open is called
2022-09-24 14:41:48 -07:00
Daniel Imms
6368cb4cff
Move canvas-based parsing to Color.ts lib
...
This removed the allowTransparency code, it didn't actually do much
before, just whether the 'advanced parsing' would allow transparency.
Since we already do the common formats, I'm not even sure what other
format it could be.
2022-09-24 10:37:40 -07:00
Mihai Parparita
a39a468f19
Make terminal rendering work in popout windows
...
Add support for the parent element (what is passed to Terminal.open)
being in a different (same origin) window. Accesses to DOM APIs such
as requestAnimationFrame and devicePixelRatio thus need to be scoped
to the corrent window, instead of assuming that it's the same as the
window/global scope where the code is running.
This is done by inferring a parent window at the creation time, and
then storing it in CoreBrowserService, which is already passed to most
places that need it.
To catch future regressions, an ESLint rule that checks for global
accesses is added (it uses AST selectors via the no-restricted-syntax
rule).
This should also be applicable when the parent element is an iframe.
Fixes #3758
2022-09-08 16:59:31 -07:00
Jörg Breitbart
ef1b773fd7
fix pixel to cell offsets
2022-09-01 12:35:44 +02:00
Jörg Breitbart
06d6e08347
sgr_pixels mouse report
2022-09-01 00:50:11 +02:00
Daniel Imms
4a6e7bee21
Fix lgtm recommendations
2022-08-30 14:09:39 -07:00
Daniel Imms
91d46dae50
OSC link progress
2022-08-07 05:08:13 -07:00
Daniel Imms
0910e58b15
Merge pull request #3924 from silamon/allowmarkersonaltbuffer
...
Allow markers on the alt buffer
2022-07-31 14:39:45 -07:00
Daniel Imms
055bcce18d
Remove instantiation service from canvas addon completely
2022-07-28 11:31:51 -07:00
Daniel Imms
848aceaa25
Merge branch 'master' into allowmarkersonaltbuffer
2022-07-28 11:05:24 -07:00
Daniel Imms
8b276c1a54
Merge remote-tracking branch 'upstream/master' into pr/SvanT/3919
2022-07-28 07:04:11 -07:00
Daniel Imms
2fffe9fc89
Merge branch 'master' into allowmarkersonaltbuffer
2022-07-28 06:50:17 -07:00
Daniel Imms
d1f53e2b02
Replace ISelectionPosition with IBufferRange
...
Fixes #2480
2022-07-28 05:58:15 -07:00
Daniel Imms
1c6ce99419
Move canvas renderer contents into addon
2022-07-27 10:26:02 -07:00
Daniel Imms
440ab765c4
Remove rendererType setting
2022-07-27 09:22:05 -07:00
Daniel Imms
7bd3801f58
Remove mouse zone manager
...
Part of #2703
2022-07-27 08:41:27 -07:00
Daniel Imms
7a17a26e18
Remove link matchers
...
Fixes #2703
2022-07-27 06:49:35 -07:00