Daniel Imms
4443ed69c7
Add noUnusedLocals tsconfig flag, fix issues
...
Two parts were commented out:
- _writeStopped: This is because _xoffSentToCatchUp references this variable
and the feature is sort of half implemented/disabled.
- _clearChar: This is because some comments still reference this, it's part
of the work needed to do better line redrawing.
2018-03-08 10:56:10 -08:00
Daniel Imms
7639131c12
Ensure underscore is used for private vars
...
Variables changed based on regex: "private [^(_|get)]"
2018-03-08 06:09:46 -08:00
Daniel Imms
404a285eaf
Merge pull request #1307 from bgw/split-char-atlas-files
...
Split CharAtlas types and utility functions off
2018-03-08 05:16:44 -08:00
Daniel Imms
b20fe80f9b
Merge pull request #1308 from bgw/rm-did-char-size-change
...
Remove didCharSizeChange logic from renderer
2018-03-08 05:10:53 -08:00
Benjamin Woodruff
ab69bfbb32
Move rest of atlas implementations to atlas dirs
...
Moves CharAtlas into src/renderer/atlas/ and CharAtlasGenerator into
src/shared/atlas/.
2018-03-07 22:23:19 -08:00
Benjamin Woodruff
70771430b5
Clean up char atlas constant imports/exports
...
- Ensures that everything is only defined in one place, and everything
imports from that place.
- Moves CHAR_ATLAS_CELL_SPACING into a subdirectory of shared/ so that
CharAtlasGenerator can pull from it.
This addresses the comments on
https://github.com/xtermjs/xterm.js/pull/1307/files/454fd4bfb1ab5c9ece
2018-03-07 22:13:41 -08:00
Bruno Ribeiro
34034b849f
Merge branch 'master' into allow-named-theme-colors-1195
2018-03-05 23:22:12 +00:00
Benjamin Woodruff
18fb134910
Remove didCharSizeChange logic from renderer
...
The only thing `didCharSizeChange` was used for was to figure out if we
need to refresh the character atlas or not. However, `acquireCharAtlas`
already inspects the atlas owned by this terminal, and if it matches, it
avoids generating a new atlas.
So if `didCharSizeChange` is true and it's not needed, it quickly bails
out as a no-op. But if `didCharSizeChange` is false, and it was needed
(possible given the complexity of testing all of these edge cases), it
could introduce a bug.
I think it makes sense to just get rid of `didCharSizeChange`, and just
always call `acquireCharAtlas`.
2018-03-04 20:55:42 -08:00
Benjamin Woodruff
454fd4bfb1
Split CharAtlas types and utility functions off
...
I'm starting to pull some changes off of my large WIP branch/commit that
adds an alternative dynamic character atlas. We're going to need to
support multiple CharAtlas implementations, and this should make that
easier.
2018-03-04 18:50:46 -08:00
Bruno Ribeito
1114977a21
Fix tests
2018-02-21 23:35:37 +00:00
Bruno Ribeito
a9d6686e14
Regex is not needed for color validation
2018-02-20 20:38:12 +00:00
Bruno Ribeito
99aa142cef
Fix test -> wrong Regex flag
2018-02-19 23:55:25 +00:00
Bruno Ribeito
f8f1355155
Validate colors
2018-02-19 22:54:09 +00:00
Daniel Griffen
183fd2fe79
fix terminal width calculation
2018-02-16 10:18:03 -08:00
Daniel Imms
f089b997c0
Merge branch 'master' into 731_screen_reader
2018-02-14 09:03:31 -08:00
Thomas Zilz
dc759a93bc
Support setting padding on the .xterm element ( #1208 )
...
* Support padding on the .xterm element
2018-02-06 12:31:17 +01:00
Daniel Imms
69ebb3e53e
Fix recent typo in comment
2018-01-29 07:42:59 -08:00
Daniel Imms
fc2af1d806
Fix lint, reduce duplication, don't scale ctx
...
Scaling ctx was breaking the scale when setOption was called, not sure
it was doing anything.
2018-01-28 14:13:25 -08:00
Daniel Imms
106704b5d8
Merge remote-tracking branch 'ups/master' into pr/1148
2018-01-28 13:39:07 -08:00
Daniel Imms
39abf8aecf
Change render layer id to a class
...
It's only used to identify them in DOM explorer currently
Fixes #1255
2018-01-27 22:26:00 -08:00
Daniel Imms
ec156f62e1
Only update a11y manager dimensions after a renderer resize
2018-01-27 18:38:28 -08:00
Daniel Imms
b9976c3d17
Merge remote-tracking branch 'origin/master' into 731_screen_reader
2018-01-26 10:24:09 -08:00
CHaBou
fe53e1a091
Change canvas transparency when option is updated
2018-01-25 23:20:20 +01:00
Daniel Imms
2e23dd34e0
Move xterm-internal types back into Types.ts files
2018-01-25 11:06:52 -08:00
Daniel Imms
8225b94d34
Types.d.ts -> .ts
2018-01-25 10:24:17 -08:00
Daniel Imms
177edfa66e
Merge interfaces and types files
2018-01-25 10:03:28 -08:00
Daniel Imms
7358890a31
Merge remote-tracking branch 'ups/master' into 1221_iterminal_typings
2018-01-25 09:45:13 -08:00
Daniel Imms
70747e84a1
Merge remote-tracking branch 'ups/master' into pr/1148
2018-01-25 08:15:42 -08:00
Daniel Imms
a22b5c0faa
Merge remote-tracking branch 'ups/master' into 955_worker_refactor
2018-01-25 07:16:00 -08:00
Daniel Imms
067acd8803
Merge branch 'master' into pr/1148
2018-01-23 08:33:55 -08:00
Daniel Imms
df02dacdc4
Add enableBold back
...
Part of #1117
2018-01-23 08:28:01 -08:00
Daniel Imms
b97cedcf5b
Merge remote-tracking branch 'origin/master' into 731_screen_reader
2018-01-19 14:01:37 -08:00
Daniel Imms
e4abd4dd8a
Move Shared interfaces into a new typings file
...
This will enable sharing the internal interface with addons (and catching
breakages early)
2018-01-19 09:48:33 -08:00
Daniel Imms
47df04976c
Base ITerminal on interface in .d.ts
...
Part of #1221
2018-01-19 09:48:33 -08:00
Bruno Ribeiro
b8f2832ed4
Merge branch 'master' into 1117
2018-01-18 21:10:09 +00:00
Daniel Imms
9c4ef2fd86
Merge remote-tracking branch 'origin/master' into fix_lint
2018-01-18 12:11:21 -08:00
Daniel Imms
b1beee3595
Fix cursor lagging behind when blink is on
...
Fixes #1216
2018-01-18 07:54:45 -08:00
Daniel Imms
4588d15738
Add more tslint rules, fix attach addon
2018-01-17 10:40:42 -08:00
Daniel Imms
53e1f83bb5
Update tslint, fix lint
2018-01-17 10:23:27 -08:00
Daniel Imms
1e9fb8696a
Merge remote-tracking branch 'origin/master' into 731_screen_reader
2018-01-16 09:56:19 -08:00
Daniel Imms
80f13792a3
Ensure renderer uses latest options at open
...
Fixes #1194
2018-01-16 06:34:22 -08:00
Daniel Imms
bbc9a010b9
Listen to dpr change in a11y manager
2018-01-11 09:27:37 -08:00
Daniel Imms
d0ef868215
Refactor char atlas to enable generation with worker
...
This doesn't actually add workers but it separates the code nicely
such that the minimal amount of relevant code can be pulled in by
worker code.
Part of #955
2018-01-06 13:43:34 -08:00
Daniel Imms
c46304c716
Merge remote-tracking branch 'origin/master' into 731_screen_reader
2018-01-05 14:28:08 -08:00
Daniel Imms
f6da87f3b4
Merge remote-tracking branch 'origin/master' into 1118_dpi_change
2018-01-05 14:19:21 -08:00
Daniel Imms
b3c8923709
Merge branch 'master' into 1117
2018-01-05 11:03:24 -08:00
Daniel Imms
b66578a4ca
Merge branch 'master' into 880_renderer_pause
2018-01-05 11:00:11 -08:00
Daniel Imms
b0b6c8d878
Merge branch 'master' into transparency
2018-01-05 10:58:59 -08:00
Daniel Imms
e20d2caa0e
Use consistent refresh/render method names
2018-01-05 08:19:30 -08:00
Daniel Imms
a846e8c08d
Pull render animation frame logic into a helper class
2018-01-05 08:15:21 -08:00