Commit Graph
131 Commits
Author SHA1 Message Date
Daniel Imms 78128762f9 Perform texture atlas warm up in an idle callback
Part of #4103
2022-09-22 13:06:08 -07:00
Mihai Parparita a39a468f19 Make terminal rendering work in popout windows
Add support for the parent element (what is passed to Terminal.open)
being in a different (same origin) window. Accesses to DOM APIs such
as requestAnimationFrame and devicePixelRatio thus need to be scoped
to the corrent window, instead of assuming that it's the same as the
window/global scope where the code is running.

This is done by inferring a parent window at the creation time, and
then storing it in CoreBrowserService, which is already passed to most
places that need it.

To catch future regressions, an ESLint rule that checks for global
accesses is added (it uses AST selectors via the no-restricted-syntax
rule).

This should also be applicable when the parent element is an iframe.

Fixes #3758
2022-09-08 16:59:31 -07:00
Daniel Imms e8e2f16cff Merge remote-tracking branch 'upstream/master' into pr/silamon/4004 2022-09-02 13:05:52 -07:00
Daniel Imms 4a6e7bee21 Fix lgtm recommendations 2022-08-30 14:09:39 -07:00
Daniel Imms 5c6d16ef0a Only remove padding from restricted powerline chars 2022-08-28 13:33:09 -07:00
Daniel Imms 1d945fdffc Create 2 and 4 key map objects, use in color and glyph caches 2022-08-28 08:34:51 -07:00
Daniel Imms 23ee719f6e Remove more garbage collection issues from cell render loop
Part of #4079
2022-08-28 08:02:35 -07:00
Daniel Imms 4ecc098de4 Get width of emoji/combined chars 2022-08-27 06:38:15 -07:00
Daniel Imms e76918eddc Take char width into account when drawing underlines/strokethrough
Fixes #4063
2022-08-27 06:34:38 -07:00
Daniel Imms 2526409ca5 Merge pull request #4074 from Tyriar/4059
Only draw character outline if it has a descent
2022-08-26 14:38:40 -07:00
Daniel Imms 7ffd9e1f7f Only draw character outline if it has a descent
Fixes #4059
2022-08-26 14:16:02 -07:00
Daniel Imms 8bbbc98ac8 Merge pull request #4073 from Tyriar/4072
Show entire glyph for extra powerline symbols
2022-08-26 08:33:53 -07:00
Daniel Imms f6860442fb Show entire glyph for extra powerline symbols
Fixes #4072
2022-08-26 08:12:00 -07:00
Daniel Imms 774ebe40e6 Improve glyph padding, especially in large font sizes
Fixes #4066
2022-08-26 07:26:36 -07:00
Daniel Imms 523de80162 Merge branch 'master' into vscode_158497 2022-08-24 15:36:44 -07:00
Daniel Imms e40cf0684e Properly clear underscore glyph's background
See microsoft/vscode#158497
2022-08-24 15:36:03 -07:00
Daniel Imms 0698afaf12 Only stroke glyph when font size >= 12 2022-08-19 13:24:39 -07:00
Daniel Imms 79d47893df Move webgl underline rendering down
See microsoft/vscode#158326
2022-08-19 13:19:08 -07:00
Simon Lamon a1385f589b Required options 2022-08-05 16:16:12 +00:00
Daniel Imms 39959c2861 Don't dim default bg in webgl
Fixes #3970
2022-07-31 15:39:34 -07:00
Daniel Imms 1ede106ab4 Fix powerlines not clipped when bg changes 2022-07-31 12:05:20 -07:00
Daniel Imms e7e71dbd3c Merge remote-tracking branch 'upstream/master' into 3969 2022-07-31 11:35:47 -07:00
Daniel Imms 266d795179 Fix line height and letter spacing for custom glyphs 2022-07-31 10:58:04 -07:00
Daniel Imms 889e3ad14b Merge pull request #3980 from Tyriar/3971
Fix underline color and polish width and positioning
2022-07-30 23:50:20 -07:00
Daniel Imms bbd03fb5fe Merge pull request #3976 from Tyriar/clip_underline
Clip outline drawing near underline
2022-07-30 23:43:42 -07:00
Daniel Imms f4618b229f Bring underlines closer to characters 2022-07-30 23:30:52 -07:00
Daniel Imms 686105942c Reduce line width of webgl underline 2022-07-30 23:25:18 -07:00
Daniel Imms ed492f7253 Implement improved texture packing strategy
Fixes #3977
2022-07-30 19:24:09 -07:00
Daniel Imms ce4a85d07d Clip outline drawing near underline
Fixes #3975
2022-07-30 17:52:00 -07:00
Daniel Imms 309487a020 Fix character offset to respect texture padding in webgl
Fixes #3974
2022-07-30 11:07:33 -07:00
Daniel Imms f0ddaf49ea Disable threshold check for glyphs with colored underlines
This causes some underlines to disappear which looks very bad for
colored underlines
2022-07-30 07:36:48 -07:00
Daniel Imms d0ec9f2591 Support letter spacing in webgl 2022-07-30 07:05:05 -07:00
Daniel Imms 941cc5100d Increase curly height when dpr <= 1 2022-07-30 06:56:32 -07:00
Daniel Imms e0d4384d3c Merge branch 'master' into underline 2022-07-30 06:40:41 -07:00
Daniel Imms ff33834eb2 Merge branch 'master' into inactiveSelection 2022-07-29 14:51:22 -07:00
Daniel Imms b0c29cac9a Merge pull request #3932 from Tyriar/tyriar/dim_bg
Fix inverse dim rendering on canvas+webgl
2022-07-29 14:50:47 -07:00
Daniel Imms 6493679b2e Inactive selection bg in dom renderer
Part of #3803
2022-07-29 11:00:36 -07:00
Daniel Imms 9cb25fbf06 Rename ITheme.selection to selectionBackground
This makes it consistent with selectionForeground and other theme keys and
as a result will make the API easier to work with, especially when inactive
selection is done (#3803)
2022-07-29 10:34:27 -07:00
Daniel Imms 48142eca23 Merge branch 'master' into tyriar/dim_bg 2022-07-29 10:20:22 -07:00
Daniel Imms 1fe0ec8d2c Merge branch 'master' into underline 2022-07-29 10:19:52 -07:00
Daniel Imms d2be5f992a Merge remote-tracking branch 'upstream/master' into underline 2022-07-28 07:01:41 -07:00
Daniel Imms 84b259dfa5 Merge remote-tracking branch 'upstream/master' into tyriar/dim_bg 2022-07-28 06:57:27 -07:00
Daniel Imms 1ef9f7c1d1 Merge branch 'master' into 3930 2022-07-28 06:50:26 -07:00
Daniel Imms ced5c304f1 Move CustomGlyphs.ts into core 2022-07-28 04:46:18 -07:00
Daniel Imms 1c6ce99419 Move canvas renderer contents into addon 2022-07-27 10:26:02 -07:00
Daniel Imms ee2e54487d Fix inverse dim for webgl
Fixes #3534
2022-07-24 13:13:26 -07:00
Daniel Imms a39c7fb636 Never clear color when allowTransparency is on
It's redundant and wasn't working as expected anyway.

Fixes #3930
2022-07-24 08:31:12 -07:00
Daniel Imms 4087284822 Fix ext caching issues 2022-07-23 15:19:17 -07:00
Daniel Imms 759a5928a2 Continuous curly underline 2022-07-23 14:48:26 -07:00
Daniel Imms fd8fc18302 Clear stroke around text in underline 2022-07-23 14:28:15 -07:00