Commit Graph
24 Commits
Author SHA1 Message Date
Benjamin Woodruff b66b0aae18 Block transparent colors without allowTransparency
Fixes xterm/xterm.js#1357.
2018-03-29 22:04:24 -07:00
Benjamin Woodruff 0cb6138cd0 Allow theming with arbitrary CSS color strings
This mostly worked before, but clearColor made the assumption that the
colors were always in #RRBBGG format. See the discussion here:
https://github.com/xtermjs/xterm.js/pull/1327#issuecomment-374812842

This changes the internal representation of a color so that we hold onto
into an object containing the original css string along with an RGBA
value encoded as a 32-bit uint. clearColor can then use that RGBA
representation.

Additionally, this deduplicates some code between ColorManager and
Terminal. Terminal was generating the 256 ansi colors the same way
ColorManager was, so this just makes Terminal use the same constant.
2018-03-26 09:47:25 -07:00
Bruno Ribeito 1114977a21 Fix tests 2018-02-21 23:35:37 +00:00
Bruno Ribeito a9d6686e14 Regex is not needed for color validation 2018-02-20 20:38:12 +00:00
Bruno Ribeito 99aa142cef Fix test -> wrong Regex flag 2018-02-19 23:55:25 +00:00
Bruno Ribeito f8f1355155 Validate colors 2018-02-19 22:54:09 +00:00
Daniel Imms 106704b5d8 Merge remote-tracking branch 'ups/master' into pr/1148 2018-01-28 13:39:07 -08:00
Daniel Imms 2e23dd34e0 Move xterm-internal types back into Types.ts files 2018-01-25 11:06:52 -08:00
Daniel Imms e4abd4dd8a Move Shared interfaces into a new typings file
This will enable sharing the internal interface with addons (and catching
breakages early)
2018-01-19 09:48:33 -08:00
CHaBou 9f85790ad1 Add allowTransparency option
Fixes #1004
2017-12-14 22:55:01 +01:00
Daniel Imms 2fc723b3ac Fix exception when setting theme
Fixes #1079
2017-10-25 21:24:44 -07:00
Daniel Imms 06b9f1db87 Always draw entire line and allow overlapping
State/diffing code is kept in comments as it may be reinstated soon.

Fixes #1035
Fixes #1036
Fixes #1032
Fixes #1037
2017-10-05 23:25:03 -07:00
Daniel Imms b9872c9a67 Merge remote-tracking branch 'ups/v3' into 963_cursor_accent 2017-09-14 09:02:32 -07:00
Daniel Imms aca7ab63e8 Set background color on Renderer immediately
Prevents black flash on init
2017-09-14 00:22:57 -07:00
Daniel Imms 6c06d83525 Support theming cursor accent color
Fixes #963
2017-09-10 08:01:16 -07:00
Daniel Imms 75b91c618e Update license text 2017-09-08 10:16:42 -07:00
Daniel Imms 7b199ac17f Some more documentation 2017-09-04 19:40:49 -07:00
Daniel Imms 6f6f17f5dc Add tests for ColorManager 2017-09-04 09:52:35 -07:00
Daniel Imms ff31f34551 Add selection to ITheme 2017-09-04 08:14:40 -07:00
Daniel Imms 0bfdff0b39 Theme unfocused cursor using cursor color 2017-09-04 08:09:43 -07:00
Daniel Imms e77f1a9287 Use default colors if not defined in a theme
Previous behavior didn't touch them, meaning partial themes could be
inconsistent
2017-09-03 21:52:52 -07:00
Daniel Imms 9cabb93b8b Organize temporary color handling code 2017-09-02 11:08:43 -07:00
Daniel Imms 4919c40b57 Add cursor to ITheme 2017-09-01 22:53:21 -07:00
Daniel Imms 62fea4d3ed Add theme support 2017-09-01 15:50:18 -07:00