Commit Graph
772 Commits
Author SHA1 Message Date
Daniel Imms 1801403ce2 Move off deprecated keyCode -> key 2022-06-26 09:22:39 -07:00
Daniel Imms 4c7d89e67d Merge branch 'master' into fix-caps-lock-ime 2022-06-26 09:09:43 -07:00
Daniel Imms 5d3a9e864d Merge pull request #3726 from Eugeny/fix-macos-alt-n
Fix Alt-N/E/U handling in macOS, handle Alt-Shift-Letter
2022-06-26 09:04:33 -07:00
Sebastian Pfitzner 783722c2f3 Add missing semicolons 2022-06-22 11:58:32 +02:00
Sebastian Pfitzner 44e4b56ced Only send wheel mouse event when scrolling a line or more 2022-06-22 11:52:00 +02:00
Megan Rogge 52044e9aad clear all markers (#3868) 2022-06-21 18:26:02 +00:00
Daniel Imms efb939d171 Fix column selection issues
The following parts were not respecting the column selection edge case where the
start column was greater than the end column while the start row was less than the
end row:

- Webgl renderer
- DOM renderer
- Selection service (ie. getSelection(), I don't think this was a
  regression)

Fixes #3855
2022-06-14 06:51:54 -07:00
Daniel Imms d28819de41 Add horizontal padding to powerline outline chars 2022-06-14 06:12:05 -07:00
Daniel Imms f8e9f1813a Custom common powerline glyph rendering
Fixes #3827
2022-06-11 16:15:04 -07:00
Megan RoggeandDaniel Imms bc9c9dd6fd fix #3846 (#3849)
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2022-06-02 18:02:36 +00:00
Megan Rogge 6b16732192 exclude box and block glyphs from contrast ratio demands (#3844) 2022-06-01 17:05:27 -07:00
Daniel Imms 7a652c4169 Allow up to double the size for overview ruler decorations
Fixes #3840
2022-05-27 11:56:54 -07:00
Daniel Imms 98c40e3f8e Add opaque selection dom renderer tests 2022-05-27 10:46:23 -07:00
Daniel Imms 6ced3014cf Support opaque selections in DOM renderer
Brings the DOM renderer closer to the webgl renderer which draws the text
on top of the selection. This is done by leveraging the override system
similar to in webgl and as well as forcing the element above the selection.
This also improves contrast color caching for the DOM renderer.

This should result in a slight performance hit but only when a selection
is being made. The improved contrast seems worth it.

Fixes #3838
2022-05-27 10:38:32 -07:00
SerKo 6ad553483d Merge branch 'master' into fix-caps-lock-ime 2022-05-24 22:49:52 +08:00
Daniel Imms ca083f257c Pass window in to fix tests 2022-05-23 07:23:15 -07:00
Daniel Imms 8b53b8c255 Take padding into account when converting mouse coord to cell
Part of microsoft/vscode#148061
2022-05-23 06:49:52 -07:00
Daniel Imms 41fdb96b68 Merge pull request #3822 from Tyriar/3821
Deflake registerLinkProvider tests
2022-05-19 15:51:58 -07:00
Daniel Imms 8f97a5a786 Deflake registerLinkProvider tests
The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.

Fixes #3821
2022-05-19 15:30:12 -07:00
Daniel Imms bcb71e854f Fix decoration positioning
In _createElement the element wasn't set on the decoration yet.

Fixes 3818
2022-05-19 09:32:57 -07:00
Daniel Imms d1a87facfd Fix selectionForeground column select mode on dom/canvas 2022-05-17 12:10:52 -07:00
Daniel Imms 18a2751471 Fix selectionForeground handling in test 2022-05-17 11:55:14 -07:00
Daniel Imms 59e1bddb6e Merge branch 'master' into 3810 2022-05-17 11:43:06 -07:00
Daniel Imms d6ad4a4fc3 Remove unneeded dep 2022-05-17 11:41:13 -07:00
Daniel Imms ec26820ea6 Fix circular dependency mouseservice <-> renderservice 2022-05-17 11:23:33 -07:00
Daniel Imms d7fdf17eab Ensure color mode is set for selection foreground overrides 2022-05-17 11:20:20 -07:00
Megan Rogge a5f2ea336e update search results onBufferContentsChange (#3811) 2022-05-17 10:00:55 -07:00
Megan Rogge de5df69333 share animation frame with renderService (#3796) 2022-05-17 09:52:46 -07:00
Daniel Imms f2b90d690f Selection foreground for canvas (circular dep issue) 2022-05-16 15:17:03 -07:00
Daniel Imms eec53261e0 Merge pull request #3779 from Tyriar/3773
Layout dimension left/right after renderer dims change
2022-05-16 14:29:16 -07:00
Daniel Imms eb96187801 Support selectionForeground in dom
Part of #3810
2022-05-16 10:08:51 -07:00
Daniel Imms c502272373 Support selection foreground in webgl
Part of #3810
2022-05-16 09:40:07 -07:00
Daniel Imms a38e97f1ec Merge pull request #3805 from Tyriar/3804
Fire onSelectionChange when Terminal.select is called
2022-05-13 09:51:28 -07:00
Daniel Imms 5d98304249 Fire onSelectionChange when Terminal.select is called
Fixes #3804
2022-05-13 09:42:39 -07:00
Daniel ImmsandMegan Rogge a458bae36d Update src/browser/renderer/dom/DomRendererRowFactory.ts
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
2022-05-13 08:46:40 -07:00
Daniel Imms 900200b871 Merge remote-tracking branch 'upstream/master' into 3773 2022-05-13 08:46:05 -07:00
Daniel Imms 1a50cfabe0 Dom renderer: top decorations above selection
Fixes #3799
2022-05-13 07:56:45 -07:00
Daniel Imms 5a9f2635d3 Merge branch 'master' into scrollbar-impro 2022-05-13 05:29:57 -07:00
SerKo d24c473172 Merge branch 'master' into fix-caps-lock-ime 2022-05-13 15:38:02 +08:00
Daniel Imms da93a35671 Merge pull request #3785 from Tyriar/layers
Support setting the layer of a decoration
2022-05-12 13:36:40 -07:00
Daniel Imms 748d0cc74f Fix missed decorations casing 2022-05-12 11:49:57 -07:00
Daniel Imms cd01157e55 Rename decorations2 -> decorations to fix casing 2022-05-12 11:19:07 -07:00
Daniel Imms 4cc4b2cd42 Rename Decorations -> decoration2 to fix casing 2022-05-12 11:18:49 -07:00
Daniel Imms f18528d2bb Clear _dimensionsChanged variable 2022-05-12 10:58:50 -07:00
Daniel Imms 7b4423819e Support setting the layer of a decoration
Fixes #3778
2022-05-12 10:51:11 -07:00
Daniel Imms 372c2970e6 Merge pull request #3782 from Tyriar/3774
Correct positioning of decoration elements
2022-05-12 10:16:06 -07:00
Daniel Imms 0976b15709 Fix lint 2022-05-11 11:57:13 -07:00
Daniel Imms 09aed4d339 Correct positioning of decoration elements
Fixes #3774
2022-05-11 10:27:35 -07:00
Daniel Imms aeb4fa0fe9 Fix compile after bad merge 2022-05-11 10:15:18 -07:00
Daniel Imms 0ae5aedcf9 Merge branch 'master' into 3773 2022-05-11 10:13:57 -07:00