Commit Graph
4 Commits
Author SHA1 Message Date
Mihai Parparita a39a468f19 Make terminal rendering work in popout windows
Add support for the parent element (what is passed to Terminal.open)
being in a different (same origin) window. Accesses to DOM APIs such
as requestAnimationFrame and devicePixelRatio thus need to be scoped
to the corrent window, instead of assuming that it's the same as the
window/global scope where the code is running.

This is done by inferring a parent window at the creation time, and
then storing it in CoreBrowserService, which is already passed to most
places that need it.

To catch future regressions, an ESLint rule that checks for global
accesses is added (it uses AST selectors via the no-restricted-syntax
rule).

This should also be applicable when the parent element is an iframe.

Fixes #3758
2022-09-08 16:59:31 -07:00
Jean Pierre 3953db0d68 Fixes https://github.com/microsoft/vscode/issues/160070 2022-09-07 11:56:52 -05:00
Daniel Imms 81a62306af Ensure canvas device dims are > 0x0 when firing callback
See microsoft/vscode#157444
2022-08-10 05:59:29 -07:00
Daniel Imms 47b1fdd147 Refactor to share observeDevicePixelDimensions 2022-07-24 04:09:34 -07:00