Commit Graph
233 Commits
Author SHA1 Message Date
Daniel Imms 09a5da5d33 Fix width of upper 1/8 block char
See microsoft/vscode#161323
2022-09-23 10:11:28 -07:00
Mihai Parparita a39a468f19 Make terminal rendering work in popout windows
Add support for the parent element (what is passed to Terminal.open)
being in a different (same origin) window. Accesses to DOM APIs such
as requestAnimationFrame and devicePixelRatio thus need to be scoped
to the corrent window, instead of assuming that it's the same as the
window/global scope where the code is running.

This is done by inferring a parent window at the creation time, and
then storing it in CoreBrowserService, which is already passed to most
places that need it.

To catch future regressions, an ESLint rule that checks for global
accesses is added (it uses AST selectors via the no-restricted-syntax
rule).

This should also be applicable when the parent element is an iframe.

Fixes #3758
2022-09-08 16:59:31 -07:00
Jean Pierre 3953db0d68 Fixes https://github.com/microsoft/vscode/issues/160070 2022-09-07 11:56:52 -05:00
Daniel Imms 4a6e7bee21 Fix lgtm recommendations 2022-08-30 14:09:39 -07:00
Daniel Imms 0727741ca1 Remove iterators from IDecorationService
They're too low performance for typical use cases

Fixes #4079
2022-08-27 20:50:16 -07:00
Daniel Imms 8bbbc98ac8 Merge pull request #4073 from Tyriar/4072
Show entire glyph for extra powerline symbols
2022-08-26 08:33:53 -07:00
Daniel Imms f6860442fb Show entire glyph for extra powerline symbols
Fixes #4072
2022-08-26 08:12:00 -07:00
Daniel Imms 774ebe40e6 Improve glyph padding, especially in large font sizes
Fixes #4066
2022-08-26 07:26:36 -07:00
Daniel Imms 81a62306af Ensure canvas device dims are > 0x0 when firing callback
See microsoft/vscode#157444
2022-08-10 05:59:29 -07:00
Daniel Imms 8f6bde9641 Polish powerline rendering
Fixes #3986
2022-07-31 14:27:07 -07:00
Daniel Imms bff529e1e2 Simplify dom tests and fix assertion 2022-07-30 23:41:08 -07:00
Daniel Imms e0d4384d3c Merge branch 'master' into underline 2022-07-30 06:40:41 -07:00
Daniel Imms ff33834eb2 Merge branch 'master' into inactiveSelection 2022-07-29 14:51:22 -07:00
Daniel Imms b0c29cac9a Merge pull request #3932 from Tyriar/tyriar/dim_bg
Fix inverse dim rendering on canvas+webgl
2022-07-29 14:50:47 -07:00
Daniel Imms 6493679b2e Inactive selection bg in dom renderer
Part of #3803
2022-07-29 11:00:36 -07:00
Daniel Imms 9cb25fbf06 Rename ITheme.selection to selectionBackground
This makes it consistent with selectionForeground and other theme keys and
as a result will make the API easier to work with, especially when inactive
selection is done (#3803)
2022-07-29 10:34:27 -07:00
Daniel Imms 48142eca23 Merge branch 'master' into tyriar/dim_bg 2022-07-29 10:20:22 -07:00
Daniel Imms 1fe0ec8d2c Merge branch 'master' into underline 2022-07-29 10:19:52 -07:00
Daniel Imms d2be5f992a Merge remote-tracking branch 'upstream/master' into underline 2022-07-28 07:01:41 -07:00
Daniel Imms 437c8aac5c Merge remote-tracking branch 'upstream/master' into rounding 2022-07-28 07:00:13 -07:00
Daniel Imms 84b259dfa5 Merge remote-tracking branch 'upstream/master' into tyriar/dim_bg 2022-07-28 06:57:27 -07:00
Daniel Imms ced5c304f1 Move CustomGlyphs.ts into core 2022-07-28 04:46:18 -07:00
Daniel Imms 1c6ce99419 Move canvas renderer contents into addon 2022-07-27 10:26:02 -07:00
Daniel Imms 7a17a26e18 Remove link matchers
Fixes #2703
2022-07-27 06:49:35 -07:00
Daniel Imms 2ceec34809 Remove log 2022-07-24 17:20:41 -07:00
Daniel Imms a4f7e2d8e9 Fix inverse dim on canvas renderer 2022-07-24 13:20:04 -07:00
Daniel Imms f4ffb13ece Render dim bg in all renderers
Fixes #3534
2022-07-24 10:59:24 -07:00
Daniel Imms 0165c3612d Fix canvas device pixel dimension setting 2022-07-24 07:11:56 -07:00
Daniel Imms 47b1fdd147 Refactor to share observeDevicePixelDimensions 2022-07-24 04:09:34 -07:00
Daniel Imms e25471361f Fix device pixel value in canvas renderer 2022-07-24 03:41:25 -07:00
Daniel Imms 19fb806214 Fix tests 2022-07-23 13:44:12 -07:00
Daniel Imms 1f89223c2a DOM renderer underline color 2022-07-23 10:26:20 -07:00
Daniel Imms 8287e783a2 Underline color canvas 2022-07-23 10:24:51 -07:00
Daniel Imms 8184e0824b Add tests for dom underline styles 2022-07-23 10:13:26 -07:00
Daniel Imms 72d18f7d5e DOM renderer underline style 2022-07-23 09:20:53 -07:00
Daniel Imms 1d9b4d4778 Canvas renderer underline style 2022-07-23 08:58:10 -07:00
Daniel Imms baa8a1e6ec Stub out canvas renderer underline style 2022-07-23 08:27:15 -07:00
Daniel Imms a8405b86de Fix \u259B rendering
Fixes #3902
2022-07-13 02:59:56 -07:00
Daniel Imms 6b447951f1 Merge pull request #3897 from Tyriar/3892
Clear glyph pixels when all channels differ below a threshold
2022-07-11 12:06:33 -07:00
Daniel Imms 89b320a5e2 Clear glyph pixels when all channels differ < 35
Fixes #3892
Also helps with #3877
2022-07-10 07:22:33 -07:00
Daniel Imms 4cbfd86db0 Make corder box chars more round
Fixes #3894
2022-07-10 05:44:44 -07:00
Daniel Imms 8959d6ae1d Fix indentation 2022-07-06 18:52:24 -07:00
Megan Rogge 17b1eed0d2 Update src/browser/renderer/CustomGlyphs.ts 2022-07-06 21:50:09 -04:00
Megan Rogge 72eb7e245d Update src/browser/renderer/CustomGlyphs.ts 2022-07-06 21:49:38 -04:00
Daniel Imms 83551eaf60 Remove horizontal padding for semi-circles 2022-07-06 18:39:31 -07:00
SteVen Batten 56a1a7613c add powerline semi circle glyphs 2022-07-06 17:13:47 -07:00
Daniel Imms efb939d171 Fix column selection issues
The following parts were not respecting the column selection edge case where the
start column was greater than the end column while the start row was less than the
end row:

- Webgl renderer
- DOM renderer
- Selection service (ie. getSelection(), I don't think this was a
  regression)

Fixes #3855
2022-06-14 06:51:54 -07:00
Daniel Imms d28819de41 Add horizontal padding to powerline outline chars 2022-06-14 06:12:05 -07:00
Daniel Imms f8e9f1813a Custom common powerline glyph rendering
Fixes #3827
2022-06-11 16:15:04 -07:00
Megan RoggeandDaniel Imms bc9c9dd6fd fix #3846 (#3849)
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2022-06-02 18:02:36 +00:00