Commit Graph
21 Commits
Author SHA1 Message Date
Daniel Imms 59264f1f5b Merge pull request #5974 from xtermjs/cursor/parser-validation-fixes-89d6
fix(parser): Params error grammar and ESC prefix precedence
2026-06-01 09:05:28 -07:00
Daniel ImmsandCursor 8854430df4 docs(parser): fix sub-parameter limit name in Params JSDoc
addSubParam documents a cap on stored sub parameters; the limit is
enforced via maxSubParamsLength, not subParamsLength (the current count).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-01 15:28:36 +00:00
Daniel ImmsandCursor 1a01e9634f fix(parser): use correct grammar in Params validation errors
Replace "values lesser than -1" with "values less than -1" in
addParam and addSubParam throw messages. "Lesser" is not standard
English for numeric comparisons; tests assert the exact message.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-01 15:28:04 +00:00
Daniel ImmsandCursor 17ad33dc3d Remove TypeScript path mappings in favor of relative imports
Fixes https://github.com/xtermjs/xterm.js/issues/5896

TypeScript path mappings for common/*, browser/*, and headless/*
were not rewritten in emitted JavaScript, which forced webpack resolve
aliases and NODE_PATH workarounds so runtime could resolve modules.
That added build complexity and broke tooling such as ESLint import/no-cycle.

Changes:
- Convert ~750 imports across src/, addons/, and test/ to relative paths
- Remove common/browser/headless paths and src catch-all mappings from tsconfigs
  (keep @xterm/addon-* demo and addon typings paths)
- Remove webpack resolve.alias for common, browser, headless, and vs
- Drop NODE_PATH from unit tests, benchmarks, and VS Code launch config
- Fix addon-image IIPImageStorage to import ./Types after removing catch-all *

Verified: npm run build, esbuild, package, package-headless
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-31 09:16:10 -07:00
Daniel Imms 80debafa11 Convert a lot of top level consts to const enums 2026-05-02 06:44:25 -07:00
Ismail Pelaseyed eaebe2ab15 refactor: add Params.resetZdm() to collapse reset+addParam(0) into single call
Replaces 10 separate reset()+addParam(0) pairs across the parser with
a single resetZdm() method that inlines both operations, avoiding two
calls to a foreign object per sequence reset.
2026-04-23 16:55:46 +02:00
coderaiser 01b35ae4eb Update src/common/parser/Params.ts 2021-11-05 21:37:50 +02:00
coderaiser 82f8e06ff6 chore: lint using putout 2021-11-05 21:34:37 +02:00
Jörg Breitbart 87eb942d32 remove comment 2019-08-23 20:21:58 +02:00
Jörg Breitbart a7e64ad537 fix bugs 2019-08-23 15:32:05 +02:00
Jörg Breitbart 5f8d07ac62 cleanup Types.ts, docs for ZDM 2019-07-04 13:50:03 +02:00
Jörg Breitbart 7bd0325128 remove example snippet from docs 2019-07-04 12:42:43 +02:00
Jörg Breitbart 6bcd8e3bfd ParamsArray to Types.ts 2019-07-04 12:12:11 +02:00
Jörg Breitbart 65b757bc19 fix typos in docs 2019-07-02 22:04:12 +02:00
Jörg Breitbart 357faa71df value range restrictions: clamp max, reject < -1 2019-07-02 18:27:13 +02:00
Jörg Breitbart 5827b4b0d1 change to int32_t 2019-07-02 15:18:39 +02:00
Jörg Breitbart c80ff1e1d1 cleanup interface 2019-06-18 15:37:53 +02:00
Jörg Breitbart fc778c76c2 add usage example for action handler 2019-06-18 15:23:36 +02:00
Jörg Breitbart cec1aa3f33 interfaces, add test for clone 2019-06-17 21:17:56 +02:00
Jörg Breitbart 24c39f664d remove unused import 2019-06-17 20:55:29 +02:00
Jörg Breitbart 383849b36f Params type implementation 2019-06-17 20:49:12 +02:00