eiac/xterm.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

better interfaces, cleanup

Browse Source
This commit is contained in:
Jörg Breitbart
2019-08-11 16:45:35 +02:00
parent e58a84df6a
commit f677516e95
11 changed files with 94 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/parser/OscParser.test.ts
+18 -18
View File
@@ -37,7 +37,7 @@ describe('OscParser', () => {
beforeEach(() => {
reports = [];
parser = new OscParser();
parser.setOscHandlerFallback((id, action, data) => {
parser.setHandlerFallback((id, action, data) => {
reports.push([id, action, data]);
});
});
@@ -78,7 +78,7 @@ describe('OscParser', () => {
});
describe('handler registration', () => {
it('setOscHandler', () => {
parser.setOscHandler(1234, new TestHandler(1234, reports, 'th'));
parser.setHandler(1234, new TestHandler(1234, reports, 'th'));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -94,8 +94,8 @@ describe('OscParser', () => {
]);
});
it('clearOscHandler', () => {
parser.setOscHandler(1234, new TestHandler(1234, reports, 'th'));
parser.clearOscHandler(1234);
parser.setHandler(1234, new TestHandler(1234, reports, 'th'));
parser.clearHandler(1234);
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -111,8 +111,8 @@ describe('OscParser', () => {
]);
});
it('addOscHandler', () => {
parser.setOscHandler(1234, new TestHandler(1234, reports, 'th1'));
parser.addOscHandler(1234, new TestHandler(1234, reports, 'th2'));
parser.setHandler(1234, new TestHandler(1234, reports, 'th1'));
parser.addHandler(1234, new TestHandler(1234, reports, 'th2'));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -131,8 +131,8 @@ describe('OscParser', () => {
]);
});
it('addOscHandler with return false', () => {
parser.setOscHandler(1234, new TestHandler(1234, reports, 'th1'));
parser.addOscHandler(1234, new TestHandler(1234, reports, 'th2', true));
parser.setHandler(1234, new TestHandler(1234, reports, 'th1'));
parser.addHandler(1234, new TestHandler(1234, reports, 'th2', true));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -151,8 +151,8 @@ describe('OscParser', () => {
]);
});
it('dispose handlers', () => {
parser.setOscHandler(1234, new TestHandler(1234, reports, 'th1'));
const dispo = parser.addOscHandler(1234, new TestHandler(1234, reports, 'th2', true));
parser.setHandler(1234, new TestHandler(1234, reports, 'th1'));
const dispo = parser.addHandler(1234, new TestHandler(1234, reports, 'th2', true));
dispo.dispose();
parser.start();
let data = toUtf32('1234;Here comes');
@@ -170,7 +170,7 @@ describe('OscParser', () => {
});
describe('OscHandlerFactory', () => {
it('should be called once on end(true)', () => {
parser.setOscHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.setHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -180,7 +180,7 @@ describe('OscParser', () => {
assert.deepEqual(reports, [[1234, 'Here comes the mouse!']]);
});
it('should not be called on end(false)', () => {
parser.setOscHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.setHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -190,8 +190,8 @@ describe('OscParser', () => {
assert.deepEqual(reports, []);
});
it('should be disposable', () => {
parser.setOscHandler(1234, new OscHandler(data => reports.push(['one', data])));
const dispo = parser.addOscHandler(1234, new OscHandler(data => reports.push(['two', data])));
parser.setHandler(1234, new OscHandler(data => reports.push(['one', data])));
const dispo = parser.addHandler(1234, new OscHandler(data => reports.push(['two', data])));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -209,8 +209,8 @@ describe('OscParser', () => {
assert.deepEqual(reports, [['two', 'Here comes the mouse!'], ['one', 'some other data']]);
});
it('should respect return false', () => {
parser.setOscHandler(1234, new OscHandler(data => reports.push(['one', data])));
parser.addOscHandler(1234, new OscHandler(data => { reports.push(['two', data]); return false; }));
parser.setHandler(1234, new OscHandler(data => reports.push(['one', data])));
parser.addHandler(1234, new OscHandler(data => { reports.push(['two', data]); return false; }));
parser.start();
let data = toUtf32('1234;Here comes');
parser.put(data, 0, data.length);
@@ -221,7 +221,7 @@ describe('OscParser', () => {
});
it('should work up to payload limit', function(): void {
this.timeout(10000);
parser.setOscHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.setHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.start();
let data = toUtf32('1234;');
parser.put(data, 0, data.length);
@@ -234,7 +234,7 @@ describe('OscParser', () => {
});
it('should abort for payload limit +1', function(): void {
this.timeout(10000);
parser.setOscHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.setHandler(1234, new OscHandler(data => reports.push([1234, data])));
parser.start();
let data = toUtf32('1234;');
parser.put(data, 0, data.length);