add tests

This commit is contained in:
meganrogge
2022-02-09 11:51:25 -06:00
parent 3e204584d9
commit e2a402d80e
3 changed files with 40 additions and 11 deletions
+4 -1
View File
@@ -530,5 +530,8 @@ function loadTest() {
function addDecoration() { function addDecoration() {
const marker = term.addMarker(1); const marker = term.addMarker(1);
const decoration = term.registerDecoration({ marker }); const decoration = term.registerDecoration({ marker });
decoration.element.style.backgroundColor = 'red'; term.write('');
decoration.onRender(() => {
decoration.element.style.backgroundColor = 'red';
});
} }
+3 -4
View File
@@ -57,8 +57,7 @@ export class DecorationService extends Disposable implements IDecorationService
} }
} }
} }
export class Decoration extends Disposable implements IDecoration {
class Decoration extends Disposable implements IDecoration {
private static _nextId = 1; private static _nextId = 1;
private readonly _marker: IMarker; private readonly _marker: IMarker;
private _element: HTMLElement | undefined; private _element: HTMLElement | undefined;
@@ -103,8 +102,8 @@ class Decoration extends Disposable implements IDecoration {
} }
private _createElement(bufferService: IBufferService, renderService: IRenderService, recreate?: boolean): void { private _createElement(bufferService: IBufferService, renderService: IRenderService, recreate?: boolean): void {
if (recreate) { if (recreate && this._element) {
this._container.removeChild(this._element!); this._container.removeChild(this._element);
} }
this._element = document.createElement('div'); this._element = document.createElement('div');
this._element.classList.add('xterm-decoration'); this._element.classList.add('xterm-decoration');
+33 -6
View File
@@ -731,22 +731,50 @@ describe('API Integration Tests', function(): void {
await pollFor(page, `window.term._core._renderService.dimensions.actualCellWidth > 0`, true); await pollFor(page, `window.term._core._renderService.dimensions.actualCellWidth > 0`, true);
}); });
describe.only('registerDecoration', () => { describe('registerDecoration', () => {
it('should register a decoration', async () => { it('should register a decoration but not add the element until the first refresh call', async () => {
await openTerminal(page); await openTerminal(page);
await writeSync(page, '\\n\\n\\n\\n');
await writeSync(page, '\\n\\n\\n\\n');
await page.evaluate(`window.marker = window.term.addMarker(1)`); await page.evaluate(`window.marker = window.term.addMarker(1)`);
await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker });`); await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker });
assert.notEqual(await page.evaluate(`document.querySelector('.xterm-screen .xterm-decoration')`), undefined); window.decoration.onRender(() => {
window.rendered = true;
});`);
assert.equal(await page.evaluate(`window.rendered`), undefined);
});
it('should register a decoration and render it', async () => {
await openTerminal(page);
await writeSync(page, '\\n\\n\\n\\n');
await writeSync(page, '\\n\\n\\n\\n');
await page.evaluate(`window.marker = window.term.addMarker(1)`);
await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker });
window.decoration.onRender(() => {
window.rendered = true;
});`);
assert.equal(await page.evaluate(`window.rendered`), true);
});
it('on resize should dispose of the old decoration and create a new one', async () => {
await openTerminal(page);
await writeSync(page, '\\n\\n\\n\\n');
await writeSync(page, '\\n\\n\\n\\n');
await page.evaluate(`window.marker = window.term.addMarker(1)`);
await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker })`);
await page.evaluate(`window.term.resize(10, 5)`);
assert.equal(await page.evaluate(`document.querySelectorAll('.xterm-screen .xterm-decoration').length`), 1);
}); });
it('should return undefined when the marker has already been disposed of', async () => { it('should return undefined when the marker has already been disposed of', async () => {
await openTerminal(page); await openTerminal(page);
await writeSync(page, '\\n\\n\\n\\n');
await writeSync(page, '\\n\\n\\n\\n');
await page.evaluate(`window.marker = window.term.addMarker(1)`); await page.evaluate(`window.marker = window.term.addMarker(1)`);
await page.evaluate(`window.marker.dispose()`); await page.evaluate(`window.marker.dispose()`);
assert.equal(await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker });`), undefined); assert.equal(await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker });`), undefined);
assert.equal(await page.evaluate(`document.querySelector('.xterm-screen .xterm-decoration')`), undefined);
}); });
it('should throw when a negative x offset is provided', async () => { it('should throw when a negative x offset is provided', async () => {
await openTerminal(page); await openTerminal(page);
await writeSync(page, '\\n\\n\\n\\n');
await writeSync(page, '\\n\\n\\n\\n');
await page.evaluate(`window.marker = window.term.addMarker(1)`); await page.evaluate(`window.marker = window.term.addMarker(1)`);
await page.evaluate(` await page.evaluate(`
try { try {
@@ -756,7 +784,6 @@ describe('API Integration Tests', function(): void {
} }
`); `);
await pollFor(page, 'window.throwMessage', 'This API only accepts positive integers'); await pollFor(page, 'window.throwMessage', 'This API only accepts positive integers');
assert.equal(await page.evaluate(`document.querySelector('.xterm-screen .xterm-decoration-container .xterm-decoration')`), undefined);
}); });
}); });