eiac/xterm.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Ensure all viewport scroll events are handled by buffer

Browse Source 
Some scroll events were never making it to the buffer service when using
a trackpad.

See microsoft/vscode#121017
Fixes #3311
This commit is contained in:
Daniel Imms
2021-04-28 12:51:40 -07:00
parent 376b29673b
commit d616aaa4f8
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/Terminal.ts
+2 -4
View File
@@ -476,7 +476,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
this._instantiationService.setService(IMouseService, this._mouseService); this._instantiationService.setService(IMouseService, this._mouseService);
this.viewport = this._instantiationService.createInstance(Viewport, this.viewport = this._instantiationService.createInstance(Viewport,
(amount: number) => this.scrollLines(amount, false, ScrollSource.VIEWPORT), (amount: number) => this.scrollLines(amount, true, ScrollSource.VIEWPORT),
this._viewportElement, this._viewportElement,
this._viewportScrollArea this._viewportScrollArea
); );
@@ -511,9 +511,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
this.textarea!.select(); this.textarea!.select();
})); }));
this.register(this._onScroll.event(ev => { this.register(this._onScroll.event(ev => {
if (ev.source !== ScrollSource.VIEWPORT) { this.viewport!.syncScrollArea();
this.viewport!.syncScrollArea();
}
this._selectionService!.refresh(); this._selectionService!.refresh();
})); }));
this.register(addDisposableDomListener(this._viewportElement, 'scroll', () => this._selectionService!.refresh())); this.register(addDisposableDomListener(this._viewportElement, 'scroll', () => this._selectionService!.refresh()));