1. Removed logic to blend selection with background with 0.3 opacity from ColorManager to a function in color namespace.

2. Changed the DomRenderer and CanvasRenderer where the function defined in color namespace is called.
This commit is contained in:
Puneethnaik
2020-06-03 19:48:34 +05:30
parent 6daa3f4499
commit d5bc65ec0e
4 changed files with 15 additions and 14 deletions
+2 -2
View File
@@ -15,6 +15,7 @@ import { ICharSizeService, ICoreBrowserService } from 'browser/services/Services
import { IBufferService, IOptionsService, ICoreService } from 'common/services/Services';
import { removeTerminalFromCache } from 'browser/renderer/atlas/CharAtlasCache';
import { EventEmitter, IEvent } from 'common/EventEmitter';
import { color } from 'browser/Color';
let nextRendererId = 1;
@@ -44,7 +45,7 @@ export class Renderer extends Disposable implements IRenderer {
super();
const allowTransparency = this._optionsService.options.allowTransparency;
this._characterJoinerRegistry = new CharacterJoinerRegistry(this._bufferService);
color.blendSelectionWithBgWithOpacity(this._colors);
this._renderLayers = [
new TextRenderLayer(this._screenElement, 0, this._colors, this._characterJoinerRegistry, allowTransparency, this._id, this._bufferService, _optionsService),
new SelectionRenderLayer(this._screenElement, 1, this._colors, this._id, this._bufferService, _optionsService),
@@ -87,7 +88,6 @@ export class Renderer extends Disposable implements IRenderer {
public setColors(colors: IColorSet): void {
this._colors = colors;
// Clear layers and force a full render
this._renderLayers.forEach(l => {
l.setColors(this._colors);
+1 -1
View File
@@ -53,7 +53,7 @@ export class DomRenderer extends Disposable implements IRenderer {
@IBufferService private readonly _bufferService: IBufferService
) {
super();
color.blendSelectionWithBgWithOpacity(this._colors);
this._rowContainer = document.createElement('div');
this._rowContainer.classList.add(ROW_CONTAINER_CLASS);
this._rowContainer.style.lineHeight = 'normal';