Colocate buffer types in buffer/Types.ts

The import/no-cycle refactor had moved IBuffer, IBufferSet, and related
cell/line types into src/common/Types.ts, with buffer/Types.ts only
re-exporting them. That inverted the natural module boundary and made
buffer code depend on the top-level types hub.

Define buffer-owned types in buffer/Types.ts instead:
- CharData, IExtendedAttrs, IAttributeData, ICellData, IBufferLine
- IMarker, IBuffer, IBufferSet, BufferIndex

Restore UnderlineStyle to buffer/Constants.ts (used by IExtendedAttrs)
and remove those definitions from Types.ts.

buffer/Types.ts imports only what it needs from outside the buffer layer:
ICircularList and ICharset from Types, IDisposable from Lifecycle,
IEvent from Event, and UnderlineStyle from Constants. Types.ts does not
import buffer/Types.ts, so the previous Types <-> buffer cycle stays broken.

Update imports across common, browser, headless, addons, and tests to use
common/buffer/Types for buffer types rather than common/Types.

Co-authored-by: Cursor <cursoragent@cursor.com>

This commit is contained in:

Daniel Imms

2026-05-31 14:35:08 -07:00

co-authored by

Cursor

parent 56a7195487

commit cd3dcc52b2

37 changed files with 253 additions and 247 deletions

									
										src/common/buffer/BufferReflow.ts
									
		+1
		-1
	
												View File
												
				@@ -5,7 +5,7 @@

				import { BufferLine } from './BufferLine';

				import { CircularList } from '../CircularList';

				import { IBufferLine, ICellData } from '../Types';

				import { IBufferLine, ICellData } from './Types';

				export interface INewLayoutResult {

				  layout: number[];