eiac/xterm.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix decoration positioning

Browse Source 
In _createElement the element wasn't set on the decoration yet.

Fixes 3818
This commit is contained in:
Daniel Imms
2022-05-19 09:32:57 -07:00
parent 51ef27894e
commit bcb71e854f
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/decorations/BufferDecorationRenderer.ts
+5 -5
View File
@@ -84,7 +84,7 @@ export class BufferDecorationRenderer extends Disposable {
// exceeded the container width, so hide // exceeded the container width, so hide
element.style.display = 'none'; element.style.display = 'none';
} }
this._refreshXPosition(decoration); this._refreshXPosition(decoration, element);
return element; return element;
} }
@@ -112,15 +112,15 @@ export class BufferDecorationRenderer extends Disposable {
} }
} }
private _refreshXPosition(decoration: IInternalDecoration): void { private _refreshXPosition(decoration: IInternalDecoration, element: HTMLElement | undefined = decoration.element): void {
if (!decoration.element) { if (!element) {
return; return;
} }
const x = decoration.options.x ?? 0; const x = decoration.options.x ?? 0;
if ((decoration.options.anchor || 'left') === 'right') { if ((decoration.options.anchor || 'left') === 'right') {
decoration.element.style.right = x ? `${x * this._renderService.dimensions.actualCellWidth}px` : ''; element.style.right = x ? `${x * this._renderService.dimensions.actualCellWidth}px` : '';
} else { } else {
decoration.element.style.left = x ? `${x * this._renderService.dimensions.actualCellWidth}px` : ''; element.style.left = x ? `${x * this._renderService.dimensions.actualCellWidth}px` : '';
} }
} }