eiac/xterm.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #3976 from Tyriar/clip_underline

Browse Source 
Clip outline drawing near underline
This commit is contained in:
Daniel Imms
2022-07-30 23:43:42 -07:00
committed by GitHub
parent 04a14a748e ce4a85d07d
commit bbd03fb5fe
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/xterm-addon-webgl/src/atlas/WebglCharAtlas.ts
+8
View File
@@ -532,9 +532,17 @@ export class WebglCharAtlas implements IDisposable {
// text // text
if (!this._config.allowTransparency && chars !== ' ') { if (!this._config.allowTransparency && chars !== ' ') {
// This translates to 1/2 the line width in either direction // This translates to 1/2 the line width in either direction
this._tmpCtx.save();
// Clip the region to only draw in valid pixels near the underline to avoid a slight
// outline around the whole glyph, as well as additional pixels in the glyph at the top
// which would increase GPU memory demands
const clipRegion = new Path2D();
clipRegion.rect(xLeft, yTop - Math.ceil(lineWidth / 2), this._config.scaledCellWidth, yBot - yTop + Math.ceil(lineWidth / 2));
this._tmpCtx.clip(clipRegion);
this._tmpCtx.lineWidth = window.devicePixelRatio * 3; this._tmpCtx.lineWidth = window.devicePixelRatio * 3;
this._tmpCtx.strokeStyle = backgroundColor.css; this._tmpCtx.strokeStyle = backgroundColor.css;
this._tmpCtx.strokeText(chars, padding, padding + this._config.scaledCharHeight); this._tmpCtx.strokeText(chars, padding, padding + this._config.scaledCharHeight);
this._tmpCtx.restore();
} }
} }
} }