Fix tsconfigs, IDisposable, and add comments

This commit is contained in:
Ayman Bagabas
2023-09-21 10:26:46 -04:00
parent db5bfc7525
commit b22762b472
9 changed files with 26 additions and 34 deletions
+6 -5
View File
@@ -883,12 +883,13 @@ export class Terminal extends CoreTerminal implements ITerminal {
return this.linkifier2.registerLinkProvider(linkProvider);
}
public registerClipboardProvider(provider: IClipboardProvider): void {
public registerClipboardProvider(provider: IClipboardProvider): IDisposable {
this._clipboardProvider = provider;
}
public deregisterClipboardProvider(): void {
this._clipboardProvider = undefined;
return {
dispose: () => {
this._clipboardProvider = undefined;
}
};
}
public registerCharacterJoiner(handler: CharacterJoinerHandler): number {
+1 -4
View File
@@ -104,10 +104,7 @@ export class MockTerminal implements ITerminal {
public registerDecoration(decorationOptions: IDecorationOptions): IDecoration | undefined {
throw new Error('Method not implemented.');
}
public registerClipboardProvider(provider: IClipboardProvider): void {
throw new Error('Method not implemented.');
}
public deregisterClipboardProvider(): void {
public registerClipboardProvider(provider: IClipboardProvider): IDisposable {
throw new Error('Method not implemented.');
}
public hasSelection(): boolean {
+2 -5
View File
@@ -168,11 +168,8 @@ export class Terminal extends Disposable implements ITerminalApi {
this._verifyPositiveIntegers(decorationOptions.x ?? 0, decorationOptions.width ?? 0, decorationOptions.height ?? 0);
return this._core.registerDecoration(decorationOptions);
}
public registerClipboardProvider(provider: IClipboardProvider): void {
this._core.registerClipboardProvider(provider);
}
public deregisterClipboardProvider(): void {
this._core.deregisterClipboardProvider();
public registerClipboardProvider(provider: IClipboardProvider): IDisposable {
return this._core.registerClipboardProvider(provider);
}
public hasSelection(): boolean {
return this._core.hasSelection();